[{"id":1770545,"web_url":"http://patchwork.ozlabs.org/comment/1770545/","msgid":"<484784df-69d0-5349-4416-03a03884d323@amsat.org>","list_archive_url":null,"date":"2017-09-18T22:04:35","subject":"Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2\n\tSoC","submitter":{"id":70924,"url":"http://patchwork.ozlabs.org/api/people/70924/","name":"Philippe Mathieu-Daudé","email":"f4bug@amsat.org"},"content":"On 09/18/2017 04:23 PM, Subbaraya Sundeep wrote:\n> Smartfusion2 SoC has hardened Microcontroller subsystem\n> and flash based FPGA fabric. This patch adds support for\n> Microcontroller subsystem in the SoC.\n> \n> Signed-off-by: Subbaraya Sundeep \n> Reviewed-by: Alistair Francis \n> Reviewed-by: Philippe Mathieu-Daudé \n> Tested-by: Philippe Mathieu-Daudé \n> ---\n> default-configs/arm-softmmu.mak | 1 +\n> hw/arm/Makefile.objs | 1 +\n> hw/arm/msf2-soc.c | 232 ++++++++++++++++++++++++++++++++++++++++\n> include/hw/arm/msf2-soc.h | 66 ++++++++++++\n> 4 files changed, 300 insertions(+)\n> create mode 100644 hw/arm/msf2-soc.c\n> create mode 100644 include/hw/arm/msf2-soc.h\n> \n> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak\n> index bbdd3c1..5059d13 100644\n> --- a/default-configs/arm-softmmu.mak\n> +++ b/default-configs/arm-softmmu.mak\n> @@ -129,3 +129,4 @@ CONFIG_ACPI=y\n> CONFIG_SMBIOS=y\n> CONFIG_ASPEED_SOC=y\n> CONFIG_GPIO_KEY=y\n> +CONFIG_MSF2=y\n> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs\n> index 5ee6f7d..a6cf24f 100644\n> --- a/hw/arm/Makefile.objs\n> +++ b/hw/arm/Makefile.objs\n> @@ -19,3 +19,4 @@ obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o\n> obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o\n> obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o\n> obj-$(CONFIG_MPS2) += mps2.o\n> +obj-$(CONFIG_MSF2) += msf2-soc.o\n> diff --git a/hw/arm/msf2-soc.c b/hw/arm/msf2-soc.c\n> new file mode 100644\n> index 0000000..313da5d\n> --- /dev/null\n> +++ b/hw/arm/msf2-soc.c\n> @@ -0,0 +1,232 @@\n> +/*\n> + * SmartFusion2 SoC emulation.\n> + *\n> + * Copyright (c) 2017 Subbaraya Sundeep \n> + *\n> + * Permission is hereby granted, free of charge, to any person obtaining a copy\n> + * of this software and associated documentation files (the \"Software\"), to deal\n> + * in the Software without restriction, including without limitation the rights\n> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n> + * copies of the Software, and to permit persons to whom the Software is\n> + * furnished to do so, subject to the following conditions:\n> + *\n> + * The above copyright notice and this permission notice shall be included in\n> + * all copies or substantial portions of the Software.\n> + *\n> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n> + * THE SOFTWARE.\n> + */\n> +\n> +#include \"qemu/osdep.h\"\n> +#include \"qapi/error.h\"\n> +#include \"qemu-common.h\"\n> +#include \"hw/arm/arm.h\"\n> +#include \"exec/address-spaces.h\"\n> +#include \"hw/char/serial.h\"\n> +#include \"hw/boards.h\"\n> +#include \"sysemu/block-backend.h\"\n> +#include \"qemu/cutils.h\"\n> +#include \"hw/arm/msf2-soc.h\"\n> +#include \"hw/misc/unimp.h\"\n> +\n> +#define MSF2_TIMER_BASE 0x40004000\n> +#define MSF2_SYSREG_BASE 0x40038000\n> +\n> +#define ENVM_BASE_ADDRESS 0x60000000\n> +\n> +#define SRAM_BASE_ADDRESS 0x20000000\n> +\n> +#define MSF2_ENVM_MAX_SIZE (512 * K_BYTE)\n> +\n> +/*\n> + * eSRAM max size is 80k without SECDED(Single error correction and\n> + * dual error detection) feature and 64k with SECDED.\n> + * We do not support SECDED now.\n> + */\n> +#define MSF2_ESRAM_MAX_SIZE (80 * K_BYTE)\n> +\n> +static const uint32_t spi_addr[MSF2_NUM_SPIS] = { 0x40001000 , 0x40011000 };\n> +static const uint32_t uart_addr[MSF2_NUM_UARTS] = { 0x40000000 , 0x40010000 };\n> +\n> +static const int spi_irq[MSF2_NUM_SPIS] = { 2, 3 };\n> +static const int uart_irq[MSF2_NUM_UARTS] = { 10, 11 };\n> +static const int timer_irq[MSF2_NUM_TIMERS] = { 14, 15 };\n> +\n> +static void m2sxxx_soc_initfn(Object *obj)\n> +{\n> + MSF2State *s = MSF2_SOC(obj);\n> + int i;\n> +\n> + object_initialize(&s->armv7m, sizeof(s->armv7m), TYPE_ARMV7M);\n> + qdev_set_parent_bus(DEVICE(&s->armv7m), sysbus_get_default());\n> +\n> + object_initialize(&s->sysreg, sizeof(s->sysreg), TYPE_MSF2_SYSREG);\n> + qdev_set_parent_bus(DEVICE(&s->sysreg), sysbus_get_default());\n> +\n> + object_initialize(&s->timer, sizeof(s->timer), TYPE_MSS_TIMER);\n> + qdev_set_parent_bus(DEVICE(&s->timer), sysbus_get_default());\n> +\n> + for (i = 0; i < MSF2_NUM_SPIS; i++) {\n> + object_initialize(&s->spi[i], sizeof(s->spi[i]),\n> + TYPE_MSS_SPI);\n> + qdev_set_parent_bus(DEVICE(&s->spi[i]), sysbus_get_default());\n> + }\n> +}\n> +\n> +static void m2sxxx_soc_realize(DeviceState *dev_soc, Error **errp)\n> +{\n> + MSF2State *s = MSF2_SOC(dev_soc);\n> + DeviceState *dev, *armv7m;\n> + SysBusDevice *busdev;\n> + Error *err = NULL;\n> + int i;\n> +\n> + MemoryRegion *system_memory = get_system_memory();\n> + MemoryRegion *nvm = g_new(MemoryRegion, 1);\n> + MemoryRegion *nvm_alias = g_new(MemoryRegion, 1);\n> + MemoryRegion *sram = g_new(MemoryRegion, 1);\n> +\n> + memory_region_init_rom(nvm, NULL, \"MSF2.eNVM\", s->envm_size,\n> + &error_fatal);\n> + /*\n> + * On power-on, the eNVM region 0x60000000 is automatically\n> + * remapped to the Cortex-M3 processor executable region\n> + * start address (0x0). We do not support remapping other eNVM,\n> + * eSRAM and DDR regions by guest(via Sysreg) currently.\n> + */\n> + memory_region_init_alias(nvm_alias, NULL, \"MSF2.eNVM\",\n> + nvm, 0, s->envm_size);\n> +\n> + memory_region_add_subregion(system_memory, ENVM_BASE_ADDRESS, nvm);\n> + memory_region_add_subregion(system_memory, 0, nvm_alias);\n> +\n> + memory_region_init_ram(sram, NULL, \"MSF2.eSRAM\", s->esram_size,\n> + &error_fatal);\n> + memory_region_add_subregion(system_memory, SRAM_BASE_ADDRESS, sram);\n> +\n> + armv7m = DEVICE(&s->armv7m);\n> + qdev_prop_set_uint32(armv7m, \"num-irq\", 81);\n> + qdev_prop_set_string(armv7m, \"cpu-model\", \"cortex-m3\");\n> + object_property_set_link(OBJECT(&s->armv7m), OBJECT(get_system_memory()),\n> + \"memory\", &error_abort);\n> + object_property_set_bool(OBJECT(&s->armv7m), true, \"realized\", &err);\n> + if (err != NULL) {\n> + error_propagate(errp, err);\n> + return;\n> + }\n> +\n\nHere we missed:\n\n if (!s->m3clk) {\n error_setg(errp, \"Invalid m3clk value\");\n error_append_hint(errp, \"m3clk can not be zero\\n\");\n return;\n }\n\nExcept this fix, this series looks ready to get applied.\nMaybe Peter can add this piece of code directly.\n\n> + system_clock_scale = NANOSECONDS_PER_SECOND / s->m3clk;\n> +\n> + for (i = 0; i < MSF2_NUM_UARTS; i++) {\n> + if (serial_hds[i]) {\n> + serial_mm_init(get_system_memory(), uart_addr[i], 2,\n> + qdev_get_gpio_in(armv7m, uart_irq[i]),\n> + 115200, serial_hds[i], DEVICE_NATIVE_ENDIAN);\n> + }\n> + }\n> +\n> + dev = DEVICE(&s->timer);\n> + /* APB0 clock is the timer input clock */\n> + qdev_prop_set_uint32(dev, \"clock-frequency\", s->m3clk / s->apb0div);\n> + object_property_set_bool(OBJECT(&s->timer), true, \"realized\", &err);\n> + if (err != NULL) {\n> + error_propagate(errp, err);\n> + return;\n> + }\n> + busdev = SYS_BUS_DEVICE(dev);\n> + sysbus_mmio_map(busdev, 0, MSF2_TIMER_BASE);\n> + sysbus_connect_irq(busdev, 0,\n> + qdev_get_gpio_in(armv7m, timer_irq[0]));\n> + sysbus_connect_irq(busdev, 1,\n> + qdev_get_gpio_in(armv7m, timer_irq[1]));\n> +\n> + dev = DEVICE(&s->sysreg);\n> + qdev_prop_set_uint32(dev, \"apb0divisor\", s->apb0div);\n> + qdev_prop_set_uint32(dev, \"apb1divisor\", s->apb1div);\n> + object_property_set_bool(OBJECT(&s->sysreg), true, \"realized\", &err);\n> + if (err != NULL) {\n> + error_propagate(errp, err);\n> + return;\n> + }\n> + busdev = SYS_BUS_DEVICE(dev);\n> + sysbus_mmio_map(busdev, 0, MSF2_SYSREG_BASE);\n> +\n> + for (i = 0; i < MSF2_NUM_SPIS; i++) {\n> + gchar *bus_name;\n> +\n> + object_property_set_bool(OBJECT(&s->spi[i]), true, \"realized\", &err);\n> + if (err != NULL) {\n> + error_propagate(errp, err);\n> + return;\n> + }\n> +\n> + sysbus_mmio_map(SYS_BUS_DEVICE(&s->spi[i]), 0, spi_addr[i]);\n> + sysbus_connect_irq(SYS_BUS_DEVICE(&s->spi[i]), 0,\n> + qdev_get_gpio_in(armv7m, spi_irq[i]));\n> +\n> + /* Alias controller SPI bus to the SoC itself */\n> + bus_name = g_strdup_printf(\"spi%d\", i);\n> + object_property_add_alias(OBJECT(s), bus_name,\n> + OBJECT(&s->spi[i]), \"spi\",\n> + &error_abort);\n> + g_free(bus_name);\n> + }\n> +\n> + /* Below devices are not modelled yet. */\n> + create_unimplemented_device(\"i2c_0\", 0x40002000, 0x1000);\n> + create_unimplemented_device(\"dma\", 0x40003000, 0x1000);\n> + create_unimplemented_device(\"watchdog\", 0x40005000, 0x1000);\n> + create_unimplemented_device(\"i2c_1\", 0x40012000, 0x1000);\n> + create_unimplemented_device(\"gpio\", 0x40013000, 0x1000);\n> + create_unimplemented_device(\"hs-dma\", 0x40014000, 0x1000);\n> + create_unimplemented_device(\"can\", 0x40015000, 0x1000);\n> + create_unimplemented_device(\"rtc\", 0x40017000, 0x1000);\n> + create_unimplemented_device(\"apb_config\", 0x40020000, 0x10000);\n> + create_unimplemented_device(\"emac\", 0x40041000, 0x1000);\n> + create_unimplemented_device(\"usb\", 0x40043000, 0x1000);\n> +}\n> +\n> +static Property m2sxxx_soc_properties[] = {\n> + /*\n> + * part name specifies the type of SmartFusion2 device variant(this\n> + * property is for information purpose only.\n> + */\n> + DEFINE_PROP_STRING(\"part-name\", MSF2State, part_name),\n> + DEFINE_PROP_UINT64(\"eNVM-size\", MSF2State, envm_size, MSF2_ENVM_MAX_SIZE),\n> + DEFINE_PROP_UINT64(\"eSRAM-size\", MSF2State, esram_size,\n> + MSF2_ESRAM_MAX_SIZE),\n> + /* Libero GUI shows 100Mhz as default for clocks */\n> + DEFINE_PROP_UINT32(\"m3clk\", MSF2State, m3clk, 100 * 1000000),\n> + /* default divisors in Libero GUI */\n> + DEFINE_PROP_UINT8(\"apb0div\", MSF2State, apb0div, 2),\n> + DEFINE_PROP_UINT8(\"apb1div\", MSF2State, apb1div, 2),\n> + DEFINE_PROP_END_OF_LIST(),\n> +};\n> +\n> +static void m2sxxx_soc_class_init(ObjectClass *klass, void *data)\n> +{\n> + DeviceClass *dc = DEVICE_CLASS(klass);\n> +\n> + dc->realize = m2sxxx_soc_realize;\n> + dc->props = m2sxxx_soc_properties;\n> +}\n> +\n> +static const TypeInfo m2sxxx_soc_info = {\n> + .name = TYPE_MSF2_SOC,\n> + .parent = TYPE_SYS_BUS_DEVICE,\n> + .instance_size = sizeof(MSF2State),\n> + .instance_init = m2sxxx_soc_initfn,\n> + .class_init = m2sxxx_soc_class_init,\n> +};\n> +\n> +static void m2sxxx_soc_types(void)\n> +{\n> + type_register_static(&m2sxxx_soc_info);\n> +}\n> +\n> +type_init(m2sxxx_soc_types)\n> diff --git a/include/hw/arm/msf2-soc.h b/include/hw/arm/msf2-soc.h\n> new file mode 100644\n> index 0000000..afea23d\n> --- /dev/null\n> +++ b/include/hw/arm/msf2-soc.h\n> @@ -0,0 +1,66 @@\n> +/*\n> + * Microsemi Smartfusion2 SoC\n> + *\n> + * Copyright (c) 2017 Subbaraya Sundeep \n> + *\n> + * Permission is hereby granted, free of charge, to any person obtaining a copy\n> + * of this software and associated documentation files (the \"Software\"), to deal\n> + * in the Software without restriction, including without limitation the rights\n> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n> + * copies of the Software, and to permit persons to whom the Software is\n> + * furnished to do so, subject to the following conditions:\n> + *\n> + * The above copyright notice and this permission notice shall be included in\n> + * all copies or substantial portions of the Software.\n> + *\n> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL\n> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n> + * THE SOFTWARE.\n> + */\n> +\n> +#ifndef HW_ARM_MSF2_SOC_H\n> +#define HW_ARM_MSF2_SOC_H\n> +\n> +#include \"hw/arm/armv7m.h\"\n> +#include \"hw/timer/mss-timer.h\"\n> +#include \"hw/misc/msf2-sysreg.h\"\n> +#include \"hw/ssi/mss-spi.h\"\n> +\n> +#define TYPE_MSF2_SOC \"msf2-soc\"\n> +#define MSF2_SOC(obj) OBJECT_CHECK(MSF2State, (obj), TYPE_MSF2_SOC)\n> +\n> +#define MSF2_NUM_SPIS 2\n> +#define MSF2_NUM_UARTS 2\n> +\n> +/*\n> + * System timer consists of two programmable 32-bit\n> + * decrementing counters that generate individual interrupts to\n> + * the Cortex-M3 processor\n> + */\n> +#define MSF2_NUM_TIMERS 2\n> +\n> +typedef struct MSF2State {\n> + /*< private >*/\n> + SysBusDevice parent_obj;\n> + /*< public >*/\n> +\n> + ARMv7MState armv7m;\n> +\n> + char *part_name;\n> + uint64_t envm_size;\n> + uint64_t esram_size;\n> +\n> + uint32_t m3clk;\n> + uint8_t apb0div;\n> + uint8_t apb1div;\n> +\n> + MSF2SysregState sysreg;\n> + MSSTimerState timer;\n> + MSSSpiState spi[MSF2_NUM_SPIS];\n> +} MSF2State;\n> +\n> +#endif\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UDXozkif\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx0S04HQWz9s7G\n\tfor ;\n\tTue, 19 Sep 2017 08:05:20 +1000 (AEST)","from localhost ([::1]:39110 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du4AI-0005KQ-PN\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 18:05:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56712)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1du49o-0005Hl-UD\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 18:04:51 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1du49m-0002ni-T9\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 18:04:48 -0400","from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:35560)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1du49h-0002ii-10; Mon, 18 Sep 2017 18:04:41 -0400","by mail-qt0-x243.google.com with SMTP id l25so1248482qtf.2;\n\tMon, 18 Sep 2017 15:04:40 -0700 (PDT)","from [192.168.1.10] ([181.93.89.178])\n\tby smtp.gmail.com with ESMTPSA id\n\tx4sm5278395qkl.74.2017.09.18.15.04.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 15:04:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=6XCHNdh+RINuKcIPnD6VdAVJnfJcewfdwz7rd6lfDek=;\n\tb=UDXozkifNV/zVIn6pFzX/P7ZzJ/q0FHwYs+UI+FPdcLEpXOaNtRCqcBVY4N5U1H1tj\n\tSZnVun+bfl0wKc/y58SaKnhlapDq03tuvIji7Wsn+BG9ZiXtKYZCKwUBoSS5beZGm3+k\n\tTofk3V9asJdw1fy5CF8/sgQsevbpfb17R59Gbf7v2CofGSPDYNhhVv/EAeC90bSGMddC\n\tv0KtrcTsbzCy8ATlu4EuQTcDJP+PYKuZLlUfMMaaXpaYYNFU7+ENWWBAEdm0Qg/rBaqg\n\t3ifw2lvdmD/NM3oRt/YQ5GGPGOB/SBj5UQqQZlAebVIiDFROyFxX2e+f1G9utaf7N8/v\n\tThLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:subject:to:cc:references:from:message-id\n\t:date:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=6XCHNdh+RINuKcIPnD6VdAVJnfJcewfdwz7rd6lfDek=;\n\tb=lBEFK43Yee9HwXddVuxEx7cZx9mk+66/+qjJm+Z1sBtINW5XQmcu359iZTeTaSubKS\n\tjY5r55VW5TRwi9nuvowVwXmfAWUC3OeqGZQKhtOsyFJJqeYJzLeKXQkgk6+fTXp+bW4D\n\tf6js/FwwzRJVt6CKCRqWP5/HudLxcfTr4nkoHs0EsgV30doFcOY32n22pg/b9Ax7IwrI\n\t2dX20Xu1tLlKodCDRcmoehHyrshUg4p0lKvI3giXjJmaZw/x4hN4GrtzAtxCbk2RwDs1\n\tsC5r1bu6B039TR3DGeA4GBjHGeuLEKjis6rGAMl2RtiN3IdBAUzZM/bryENnT0KTd3p1\n\t15fg==","X-Gm-Message-State":"AHPjjUidKOkZyiUsvB2HxjKcrpo0F1xieF9w9dLzKXeUOAJ3tUkBm+Pp\n\to/5nmA4TONEMku92yTxM4Q==","X-Google-Smtp-Source":"AOwi7QCKaqT/qXm1cGQsm/blcZ3DP1KrCbvG7t0j2l2Ms/hRpz5NQdDYX4n0D71eU6FOck4klqioHw==","X-Received":"by 10.237.39.7 with SMTP id n7mr50722221qtd.124.1505772280302;\n\tMon, 18 Sep 2017 15:04:40 -0700 (PDT)","To":"Subbaraya Sundeep , peter.maydell@linaro.org","References":"<1505762601-27143-1-git-send-email-sundeep.lkml@gmail.com>\n\t<1505762601-27143-5-git-send-email-sundeep.lkml@gmail.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Message-ID":"<484784df-69d0-5349-4416-03a03884d323@amsat.org>","Date":"Mon, 18 Sep 2017 19:04:35 -0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505762601-27143-5-git-send-email-sundeep.lkml@gmail.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400d:c0d::243","Subject":"Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2\n\tSoC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"alistair23@gmail.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org,\n\tcrosthwaite.peter@gmail.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770763,"web_url":"http://patchwork.ozlabs.org/comment/1770763/","msgid":"","list_archive_url":null,"date":"2017-09-19T08:59:49","subject":"Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2\n\tSoC","submitter":{"id":64324,"url":"http://patchwork.ozlabs.org/api/people/64324/","name":"sundeep subbaraya","email":"sundeep.lkml@gmail.com"},"content":"Hi Philippe and Peter,\n\nOn Tue, Sep 19, 2017 at 3:34 AM, Philippe Mathieu-Daudé \nwrote:\n\n> On 09/18/2017 04:23 PM, Subbaraya Sundeep wrote:\n>\n>> Smartfusion2 SoC has hardened Microcontroller subsystem\n>> and flash based FPGA fabric. This patch adds support for\n>> Microcontroller subsystem in the SoC.\n>>\n>> Signed-off-by: Subbaraya Sundeep \n>> Reviewed-by: Alistair Francis \n>> Reviewed-by: Philippe Mathieu-Daudé \n>> Tested-by: Philippe Mathieu-Daudé \n>> ---\n>> default-configs/arm-softmmu.mak | 1 +\n>> hw/arm/Makefile.objs | 1 +\n>> hw/arm/msf2-soc.c | 232 ++++++++++++++++++++++++++++++\n>> ++++++++++\n>> include/hw/arm/msf2-soc.h | 66 ++++++++++++\n>> 4 files changed, 300 insertions(+)\n>> create mode 100644 hw/arm/msf2-soc.c\n>> create mode 100644 include/hw/arm/msf2-soc.h\n>>\n>> diff --git a/default-configs/arm-softmmu.mak\n>> b/default-configs/arm-softmmu.mak\n>> index bbdd3c1..5059d13 100644\n>> --- a/default-configs/arm-softmmu.mak\n>> +++ b/default-configs/arm-softmmu.mak\n>> @@ -129,3 +129,4 @@ CONFIG_ACPI=y\n>> CONFIG_SMBIOS=y\n>> CONFIG_ASPEED_SOC=y\n>> CONFIG_GPIO_KEY=y\n>> +CONFIG_MSF2=y\n>> diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs\n>> index 5ee6f7d..a6cf24f 100644\n>> --- a/hw/arm/Makefile.objs\n>> +++ b/hw/arm/Makefile.objs\n>> @@ -19,3 +19,4 @@ obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o\n>> obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o\n>> obj-$(CONFIG_ASPEED_SOC) += aspeed_soc.o aspeed.o\n>> obj-$(CONFIG_MPS2) += mps2.o\n>> +obj-$(CONFIG_MSF2) += msf2-soc.o\n>> diff --git a/hw/arm/msf2-soc.c b/hw/arm/msf2-soc.c\n>> new file mode 100644\n>> index 0000000..313da5d\n>> --- /dev/null\n>> +++ b/hw/arm/msf2-soc.c\n>> @@ -0,0 +1,232 @@\n>> +/*\n>> + * SmartFusion2 SoC emulation.\n>> + *\n>> + * Copyright (c) 2017 Subbaraya Sundeep \n>> + *\n>> + * Permission is hereby granted, free of charge, to any person obtaining\n>> a copy\n>> + * of this software and associated documentation files (the \"Software\"),\n>> to deal\n>> + * in the Software without restriction, including without limitation the\n>> rights\n>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or\n>> sell\n>> + * copies of the Software, and to permit persons to whom the Software is\n>> + * furnished to do so, subject to the following conditions:\n>> + *\n>> + * The above copyright notice and this permission notice shall be\n>> included in\n>> + * all copies or substantial portions of the Software.\n>> + *\n>> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n>> EXPRESS OR\n>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n>> MERCHANTABILITY,\n>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT\n>> SHALL\n>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n>> OTHER\n>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n>> ARISING FROM,\n>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER\n>> DEALINGS IN\n>> + * THE SOFTWARE.\n>> + */\n>> +\n>> +#include \"qemu/osdep.h\"\n>> +#include \"qapi/error.h\"\n>> +#include \"qemu-common.h\"\n>> +#include \"hw/arm/arm.h\"\n>> +#include \"exec/address-spaces.h\"\n>> +#include \"hw/char/serial.h\"\n>> +#include \"hw/boards.h\"\n>> +#include \"sysemu/block-backend.h\"\n>> +#include \"qemu/cutils.h\"\n>> +#include \"hw/arm/msf2-soc.h\"\n>> +#include \"hw/misc/unimp.h\"\n>> +\n>> +#define MSF2_TIMER_BASE 0x40004000\n>> +#define MSF2_SYSREG_BASE 0x40038000\n>> +\n>> +#define ENVM_BASE_ADDRESS 0x60000000\n>> +\n>> +#define SRAM_BASE_ADDRESS 0x20000000\n>> +\n>> +#define MSF2_ENVM_MAX_SIZE (512 * K_BYTE)\n>> +\n>> +/*\n>> + * eSRAM max size is 80k without SECDED(Single error correction and\n>> + * dual error detection) feature and 64k with SECDED.\n>> + * We do not support SECDED now.\n>> + */\n>> +#define MSF2_ESRAM_MAX_SIZE (80 * K_BYTE)\n>> +\n>> +static const uint32_t spi_addr[MSF2_NUM_SPIS] = { 0x40001000 ,\n>> 0x40011000 };\n>> +static const uint32_t uart_addr[MSF2_NUM_UARTS] = { 0x40000000 ,\n>> 0x40010000 };\n>> +\n>> +static const int spi_irq[MSF2_NUM_SPIS] = { 2, 3 };\n>> +static const int uart_irq[MSF2_NUM_UARTS] = { 10, 11 };\n>> +static const int timer_irq[MSF2_NUM_TIMERS] = { 14, 15 };\n>> +\n>> +static void m2sxxx_soc_initfn(Object *obj)\n>> +{\n>> + MSF2State *s = MSF2_SOC(obj);\n>> + int i;\n>> +\n>> + object_initialize(&s->armv7m, sizeof(s->armv7m), TYPE_ARMV7M);\n>> + qdev_set_parent_bus(DEVICE(&s->armv7m), sysbus_get_default());\n>> +\n>> + object_initialize(&s->sysreg, sizeof(s->sysreg), TYPE_MSF2_SYSREG);\n>> + qdev_set_parent_bus(DEVICE(&s->sysreg), sysbus_get_default());\n>> +\n>> + object_initialize(&s->timer, sizeof(s->timer), TYPE_MSS_TIMER);\n>> + qdev_set_parent_bus(DEVICE(&s->timer), sysbus_get_default());\n>> +\n>> + for (i = 0; i < MSF2_NUM_SPIS; i++) {\n>> + object_initialize(&s->spi[i], sizeof(s->spi[i]),\n>> + TYPE_MSS_SPI);\n>> + qdev_set_parent_bus(DEVICE(&s->spi[i]), sysbus_get_default());\n>> + }\n>> +}\n>> +\n>> +static void m2sxxx_soc_realize(DeviceState *dev_soc, Error **errp)\n>> +{\n>> + MSF2State *s = MSF2_SOC(dev_soc);\n>> + DeviceState *dev, *armv7m;\n>> + SysBusDevice *busdev;\n>> + Error *err = NULL;\n>> + int i;\n>> +\n>> + MemoryRegion *system_memory = get_system_memory();\n>> + MemoryRegion *nvm = g_new(MemoryRegion, 1);\n>> + MemoryRegion *nvm_alias = g_new(MemoryRegion, 1);\n>> + MemoryRegion *sram = g_new(MemoryRegion, 1);\n>> +\n>> + memory_region_init_rom(nvm, NULL, \"MSF2.eNVM\", s->envm_size,\n>> + &error_fatal);\n>> + /*\n>> + * On power-on, the eNVM region 0x60000000 is automatically\n>> + * remapped to the Cortex-M3 processor executable region\n>> + * start address (0x0). We do not support remapping other eNVM,\n>> + * eSRAM and DDR regions by guest(via Sysreg) currently.\n>> + */\n>> + memory_region_init_alias(nvm_alias, NULL, \"MSF2.eNVM\",\n>> + nvm, 0, s->envm_size);\n>> +\n>> + memory_region_add_subregion(system_memory, ENVM_BASE_ADDRESS, nvm);\n>> + memory_region_add_subregion(system_memory, 0, nvm_alias);\n>> +\n>> + memory_region_init_ram(sram, NULL, \"MSF2.eSRAM\", s->esram_size,\n>> + &error_fatal);\n>> + memory_region_add_subregion(system_memory, SRAM_BASE_ADDRESS, sram);\n>> +\n>> + armv7m = DEVICE(&s->armv7m);\n>> + qdev_prop_set_uint32(armv7m, \"num-irq\", 81);\n>> + qdev_prop_set_string(armv7m, \"cpu-model\", \"cortex-m3\");\n>> + object_property_set_link(OBJECT(&s->armv7m),\n>> OBJECT(get_system_memory()),\n>> + \"memory\", &error_abort);\n>> + object_property_set_bool(OBJECT(&s->armv7m), true, \"realized\",\n>> &err);\n>> + if (err != NULL) {\n>> + error_propagate(errp, err);\n>> + return;\n>> + }\n>> +\n>>\n>\n> Here we missed:\n>\n> if (!s->m3clk) {\n> error_setg(errp, \"Invalid m3clk value\");\n> error_append_hint(errp, \"m3clk can not be zero\\n\");\n> return;\n> }\n>\n> Yeah we missed this. Thanks for pointing out.\n\n\n> Except this fix, this series looks ready to get applied.\n> Maybe Peter can add this piece of code directly.\n>\n> Peter? I will do it within a day if you want.\n\nThanks,\nSundeep\n\n>\n> + system_clock_scale = NANOSECONDS_PER_SECOND / s->m3clk;\n>> +\n>> + for (i = 0; i < MSF2_NUM_UARTS; i++) {\n>> + if (serial_hds[i]) {\n>> + serial_mm_init(get_system_memory(), uart_addr[i], 2,\n>> + qdev_get_gpio_in(armv7m, uart_irq[i]),\n>> + 115200, serial_hds[i], DEVICE_NATIVE_ENDIAN);\n>> + }\n>> + }\n>> +\n>> + dev = DEVICE(&s->timer);\n>> + /* APB0 clock is the timer input clock */\n>> + qdev_prop_set_uint32(dev, \"clock-frequency\", s->m3clk / s->apb0div);\n>> + object_property_set_bool(OBJECT(&s->timer), true, \"realized\", &err);\n>> + if (err != NULL) {\n>> + error_propagate(errp, err);\n>> + return;\n>> + }\n>> + busdev = SYS_BUS_DEVICE(dev);\n>> + sysbus_mmio_map(busdev, 0, MSF2_TIMER_BASE);\n>> + sysbus_connect_irq(busdev, 0,\n>> + qdev_get_gpio_in(armv7m, timer_irq[0]));\n>> + sysbus_connect_irq(busdev, 1,\n>> + qdev_get_gpio_in(armv7m, timer_irq[1]));\n>> +\n>> + dev = DEVICE(&s->sysreg);\n>> + qdev_prop_set_uint32(dev, \"apb0divisor\", s->apb0div);\n>> + qdev_prop_set_uint32(dev, \"apb1divisor\", s->apb1div);\n>> + object_property_set_bool(OBJECT(&s->sysreg), true, \"realized\",\n>> &err);\n>> + if (err != NULL) {\n>> + error_propagate(errp, err);\n>> + return;\n>> + }\n>> + busdev = SYS_BUS_DEVICE(dev);\n>> + sysbus_mmio_map(busdev, 0, MSF2_SYSREG_BASE);\n>> +\n>> + for (i = 0; i < MSF2_NUM_SPIS; i++) {\n>> + gchar *bus_name;\n>> +\n>> + object_property_set_bool(OBJECT(&s->spi[i]), true, \"realized\",\n>> &err);\n>> + if (err != NULL) {\n>> + error_propagate(errp, err);\n>> + return;\n>> + }\n>> +\n>> + sysbus_mmio_map(SYS_BUS_DEVICE(&s->spi[i]), 0, spi_addr[i]);\n>> + sysbus_connect_irq(SYS_BUS_DEVICE(&s->spi[i]), 0,\n>> + qdev_get_gpio_in(armv7m, spi_irq[i]));\n>> +\n>> + /* Alias controller SPI bus to the SoC itself */\n>> + bus_name = g_strdup_printf(\"spi%d\", i);\n>> + object_property_add_alias(OBJECT(s), bus_name,\n>> + OBJECT(&s->spi[i]), \"spi\",\n>> + &error_abort);\n>> + g_free(bus_name);\n>> + }\n>> +\n>> + /* Below devices are not modelled yet. */\n>> + create_unimplemented_device(\"i2c_0\", 0x40002000, 0x1000);\n>> + create_unimplemented_device(\"dma\", 0x40003000, 0x1000);\n>> + create_unimplemented_device(\"watchdog\", 0x40005000, 0x1000);\n>> + create_unimplemented_device(\"i2c_1\", 0x40012000, 0x1000);\n>> + create_unimplemented_device(\"gpio\", 0x40013000, 0x1000);\n>> + create_unimplemented_device(\"hs-dma\", 0x40014000, 0x1000);\n>> + create_unimplemented_device(\"can\", 0x40015000, 0x1000);\n>> + create_unimplemented_device(\"rtc\", 0x40017000, 0x1000);\n>> + create_unimplemented_device(\"apb_config\", 0x40020000, 0x10000);\n>> + create_unimplemented_device(\"emac\", 0x40041000, 0x1000);\n>> + create_unimplemented_device(\"usb\", 0x40043000, 0x1000);\n>> +}\n>> +\n>> +static Property m2sxxx_soc_properties[] = {\n>> + /*\n>> + * part name specifies the type of SmartFusion2 device variant(this\n>> + * property is for information purpose only.\n>> + */\n>> + DEFINE_PROP_STRING(\"part-name\", MSF2State, part_name),\n>> + DEFINE_PROP_UINT64(\"eNVM-size\", MSF2State, envm_size,\n>> MSF2_ENVM_MAX_SIZE),\n>> + DEFINE_PROP_UINT64(\"eSRAM-size\", MSF2State, esram_size,\n>> + MSF2_ESRAM_MAX_SIZE),\n>> + /* Libero GUI shows 100Mhz as default for clocks */\n>> + DEFINE_PROP_UINT32(\"m3clk\", MSF2State, m3clk, 100 * 1000000),\n>> + /* default divisors in Libero GUI */\n>> + DEFINE_PROP_UINT8(\"apb0div\", MSF2State, apb0div, 2),\n>> + DEFINE_PROP_UINT8(\"apb1div\", MSF2State, apb1div, 2),\n>> + DEFINE_PROP_END_OF_LIST(),\n>> +};\n>> +\n>> +static void m2sxxx_soc_class_init(ObjectClass *klass, void *data)\n>> +{\n>> + DeviceClass *dc = DEVICE_CLASS(klass);\n>> +\n>> + dc->realize = m2sxxx_soc_realize;\n>> + dc->props = m2sxxx_soc_properties;\n>> +}\n>> +\n>> +static const TypeInfo m2sxxx_soc_info = {\n>> + .name = TYPE_MSF2_SOC,\n>> + .parent = TYPE_SYS_BUS_DEVICE,\n>> + .instance_size = sizeof(MSF2State),\n>> + .instance_init = m2sxxx_soc_initfn,\n>> + .class_init = m2sxxx_soc_class_init,\n>> +};\n>> +\n>> +static void m2sxxx_soc_types(void)\n>> +{\n>> + type_register_static(&m2sxxx_soc_info);\n>> +}\n>> +\n>> +type_init(m2sxxx_soc_types)\n>> diff --git a/include/hw/arm/msf2-soc.h b/include/hw/arm/msf2-soc.h\n>> new file mode 100644\n>> index 0000000..afea23d\n>> --- /dev/null\n>> +++ b/include/hw/arm/msf2-soc.h\n>> @@ -0,0 +1,66 @@\n>> +/*\n>> + * Microsemi Smartfusion2 SoC\n>> + *\n>> + * Copyright (c) 2017 Subbaraya Sundeep \n>> + *\n>> + * Permission is hereby granted, free of charge, to any person obtaining\n>> a copy\n>> + * of this software and associated documentation files (the \"Software\"),\n>> to deal\n>> + * in the Software without restriction, including without limitation the\n>> rights\n>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or\n>> sell\n>> + * copies of the Software, and to permit persons to whom the Software is\n>> + * furnished to do so, subject to the following conditions:\n>> + *\n>> + * The above copyright notice and this permission notice shall be\n>> included in\n>> + * all copies or substantial portions of the Software.\n>> + *\n>> + * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,\n>> EXPRESS OR\n>> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF\n>> MERCHANTABILITY,\n>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT\n>> SHALL\n>> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR\n>> OTHER\n>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,\n>> ARISING FROM,\n>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER\n>> DEALINGS IN\n>> + * THE SOFTWARE.\n>> + */\n>> +\n>> +#ifndef HW_ARM_MSF2_SOC_H\n>> +#define HW_ARM_MSF2_SOC_H\n>> +\n>> +#include \"hw/arm/armv7m.h\"\n>> +#include \"hw/timer/mss-timer.h\"\n>> +#include \"hw/misc/msf2-sysreg.h\"\n>> +#include \"hw/ssi/mss-spi.h\"\n>> +\n>> +#define TYPE_MSF2_SOC \"msf2-soc\"\n>> +#define MSF2_SOC(obj) OBJECT_CHECK(MSF2State, (obj), TYPE_MSF2_SOC)\n>> +\n>> +#define MSF2_NUM_SPIS 2\n>> +#define MSF2_NUM_UARTS 2\n>> +\n>> +/*\n>> + * System timer consists of two programmable 32-bit\n>> + * decrementing counters that generate individual interrupts to\n>> + * the Cortex-M3 processor\n>> + */\n>> +#define MSF2_NUM_TIMERS 2\n>> +\n>> +typedef struct MSF2State {\n>> + /*< private >*/\n>> + SysBusDevice parent_obj;\n>> + /*< public >*/\n>> +\n>> + ARMv7MState armv7m;\n>> +\n>> + char *part_name;\n>> + uint64_t envm_size;\n>> + uint64_t esram_size;\n>> +\n>> + uint32_t m3clk;\n>> + uint8_t apb0div;\n>> + uint8_t apb1div;\n>> +\n>> + MSF2SysregState sysreg;\n>> + MSSTimerState timer;\n>> + MSSSpiState spi[MSF2_NUM_SPIS];\n>> +} MSF2State;\n>> +\n>> +#endif\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"cCuUlh/k\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxH063DRLz9s7g\n\tfor ;\n\tTue, 19 Sep 2017 19:00:38 +1000 (AEST)","from localhost ([::1]:40864 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duEOS-0003Ez-Jg\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 05:00:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43582)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duENq-00039c-IC\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 05:00:06 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duENj-0001fC-Uz\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 04:59:58 -0400","from mail-vk0-x241.google.com ([2607:f8b0:400c:c05::241]:37806)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duENj-0001ds-NM; Tue, 19 Sep 2017 04:59:51 -0400","by mail-vk0-x241.google.com with SMTP id 184so815832vkn.4;\n\tTue, 19 Sep 2017 01:59:50 -0700 (PDT)","by 10.176.66.68 with HTTP; Tue, 19 Sep 2017 01:59:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=1/U2/hb+njjxIMJ3kyKRKAiGLsTbQkz/ZgLIq2XsYeU=;\n\tb=cCuUlh/kZWwESw3je8QEuN0Had20OMzPkj0/AQRXa2mErrOqErlFQbb/PZv7IBA1eE\n\tkXwLvZbZRVadWDknr4x/NRqFaVpZXm+Gyk4zt9WySENBMw9GtGNgxeyYFQDyO/8wfcBz\n\tSP7DPmrORwsO91b7ILW/HgvPX7NZFndB2JO/3t6VwuDnAMuVkLrii77E/Yz0MuY227Gb\n\t+5yxtmh3EkHVbzIFdL1BCvw9wmN/qhPlMM6IDzA4oNl+w2udW70MHe+kB3R9gBQb1FWg\n\tpgAtKRcURJA8DRlFrQ/jqZ8u5lpJRYfb20vSafPm4O7VqDhwwWPg0+FTUWQ9e0dsDvH+\n\tJJZA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=1/U2/hb+njjxIMJ3kyKRKAiGLsTbQkz/ZgLIq2XsYeU=;\n\tb=M0iOaMLJRuU2jQz/+kmmjqJdV+oZlHXac/r8MN+Qk3ACXbQSBtAW2Ir3OzBahkTUEz\n\tz91hZUtyQ+Tzl49RX0ditPqqoQuvhlTzJy/T5Tp/0kbgX5Q3QDjH8CyJVrOLO4GKqPMl\n\t3rmfbVIt+DSQTghBu8DPiyki/+jW3ZuQA8TRkyH2+yGD4nBwoYHQSM7y3OqM8gpCYYGu\n\tcrVwMVewBGHvEbDNJ1GD1oWCpY2G73SqWeslNAqPbtv7kY/e44iXIEtkAG/OwP2TyPyM\n\togPnS+Hhub5kIXIxjugJFfxRhhLC7DbsBUAh49t3/jArs/cR9//ue6jUAV2YcxV5y3Td\n\tN5gg==","X-Gm-Message-State":"AHPjjUhtcAeg2dDuOiIjzX48DJRO7kbnSXegPbXqmVVK1L+Y4f51Ig1g\n\tLuiwx9ICU9udyLtwrZImqdVQCHgS4q+Odjlbu/A=","X-Google-Smtp-Source":"AOwi7QDs985aIhi+ofubXovXL3gCnOnwjuZAvLDXZj6+G2FSENMvfq3sbZUaw7tUNYTutYegv1tT8ChfvOOA9IDFDdU=","X-Received":"by 10.31.181.200 with SMTP id e191mr432398vkf.55.1505811589635; \n\tTue, 19 Sep 2017 01:59:49 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<484784df-69d0-5349-4416-03a03884d323@amsat.org>","References":"<1505762601-27143-1-git-send-email-sundeep.lkml@gmail.com>\n\t<1505762601-27143-5-git-send-email-sundeep.lkml@gmail.com>\n\t<484784df-69d0-5349-4416-03a03884d323@amsat.org>","From":"sundeep subbaraya ","Date":"Tue, 19 Sep 2017 14:29:49 +0530","Message-ID":"","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400c:c05::241","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [Qemu devel v10 PATCH 4/5] msf2: Add Smartfusion2\n\tSoC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-arm ,\n\tQEMU Developers ,\n\tAlistair Francis ,\n\tPeter Crosthwaite ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]