[{"id":1770756,"web_url":"http://patchwork.ozlabs.org/comment/1770756/","msgid":"<20170919084525.vdbjrqx5qvhhxmor@flea.lan>","list_archive_url":null,"date":"2017-09-19T08:45:25","subject":"Re: [PATCH v2] net: stmmac: dwmac-sun8i: Use reset exclusive","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Mon, Sep 18, 2017 at 08:30:43PM +0200, Corentin Labbe wrote:\n> The current dwmac_sun8i module cannot be rmmod/modprobe due to that\n> the reset controller was not released when removed.\n> \n> This patch remove ambiguity, by using of_reset_control_get_exclusive and\n> add the missing reset_control_put().\n> \n> Note that we cannot use devm_reset_control_get, since the reset is not\n> in the device node.\n> \n> Signed-off-by: Corentin Labbe \n> ---\n> Changes since v1:\n> - added a note about devm_reset_control_get in commit message\n\nThat comment would be better if it was in the code.\n\n> \n> drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n> index 57bb6dd7b401..1736d7cb0d96 100644\n> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c\n> @@ -854,6 +854,7 @@ static int sun8i_dwmac_unpower_internal_phy(struct sunxi_priv_data *gmac)\n> \n> \tclk_disable_unprepare(gmac->ephy_clk);\n> \treset_control_assert(gmac->rst_ephy);\n> +\treset_control_put(gmac->rst_ephy);\n\nPutting it here is weird.\n\nWhat would happen if power_phy / unpower_phy is called several times?\n\nCan't we just make it symetric and undo in remove what we do in probe?\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxGfs4zx0z9s7M\n\tfor ;\n\tTue, 19 Sep 2017 18:45:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751237AbdISIp1 (ORCPT );\n\tTue, 19 Sep 2017 04:45:27 -0400","from mail.free-electrons.com ([62.4.15.54]:58009 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750747AbdISIp0 (ORCPT\n\t); Tue, 19 Sep 2017 04:45:26 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 37D9620A24; Tue, 19 Sep 2017 10:45:25 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 0A335209F6;\n\tTue, 19 Sep 2017 10:45:25 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 19 Sep 2017 10:45:25 +0200","From":"Maxime Ripard ","To":"Corentin Labbe ","Cc":"peppe.cavallaro@st.com, alexandre.torgue@st.com, wens@csie.org,\n\tnetdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2] net: stmmac: dwmac-sun8i: Use reset exclusive","Message-ID":"<20170919084525.vdbjrqx5qvhhxmor@flea.lan>","References":"<20170918183043.8028-1-clabbe.montjoie@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"7mqomjgivpyllpcv\"","Content-Disposition":"inline","In-Reply-To":"<20170918183043.8028-1-clabbe.montjoie@gmail.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]