[{"id":1770437,"web_url":"http://patchwork.ozlabs.org/comment/1770437/","msgid":"<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>","list_archive_url":null,"date":"2017-09-18T19:20:25","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":66696,"url":"http://patchwork.ozlabs.org/api/people/66696/","name":"Martin Sebor","email":"msebor@gmail.com"},"content":"On 09/18/2017 12:26 PM, Steve Ellcey wrote:\n> This patch is for PR target/79868, where some aarch64 diagnostics are\n> said to be not translatable due to how they are implemented. See the\n> bug report for more details on why the current setup of passing\n> the string 'pragma' or 'attribute' doesn't work.\n>\n> This patch fixes it, unfortunately by increasing the number of calls we\n> have to 'error' (16 calls become 32 calls), but that seems to be the\n> most straight forward way to get translatable strings.\n\nI haven't looked at all of them but from the few I have seen it\nseems that rephrasing the messages along the following lines would\nbe a way to get around the translation issue and without increasing\nthe number of calls (though not without the conditional):\n\n error (is_pragma\n ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n : G_(\"missing name in % attribute\"),\n \"arch\");\n\nThe additional benefit of this approach is that it would also make\nthe quoting consistent with what seems to be the prevailing style\nof these sorts of messages. (It would be nice to eventually\nconverge on the same style/quoting and phrasing across all back\nand front ends.)\n\nMartin\n\n>\n> This patch is an update to the one I originally attached to the bug\n> report and I have fixed the issue that Frederic Marchal found in my\n> original patch.\n>\n> OK to checkin?\n>\n> Steve Ellcey\n> sellcey@cavium.com\n>\n>\n>\n> 2017-09-18 Steve Ellcey \n>\n> \tPR target/79868\n> \t* config/aarch64/aarch64-c.c (aarch64_pragma_target_parse):\n> \tChange argument type on aarch64_process_target_attr call.\n> \t* config/aarch64/aarch64-protos.h (aarch64_process_target_attr):\n> \tChange argument type.\n> \t* config/aarch64/aarch64.c (aarch64_attribute_info): Change\n> \tfield type.\n> \t(aarch64_handle_attr_arch): Change argument type, use boolean\n> \targument to make different error calls.\n> \t(aarch64_handle_attr_cpu): Ditto.\n> \t(aarch64_handle_attr_tune): Ditto.\n> \t(aarch64_handle_attr_isa_flags): Ditto.\n> \t(aarch64_process_one_target_attr): Ditto.\n> \t(aarch64_process_target_attr): Ditto.\n> \t(aarch64_option_valid_attribute_p): Change argument type on\n> \taarch64_process_target_attr call.\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462432-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"cPxCuoQ5\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwwp0534Wz9s7p\n\tfor ;\n\tTue, 19 Sep 2017 05:20:39 +1000 (AEST)","(qmail 103172 invoked by alias); 18 Sep 2017 19:20:32 -0000","(qmail 102791 invoked by uid 89); 18 Sep 2017 19:20:31 -0000","from mail-io0-f174.google.com (HELO mail-io0-f174.google.com)\n\t(209.85.223.174) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 18 Sep 2017 19:20:30 +0000","by mail-io0-f174.google.com with SMTP id m103so4677217iod.13 for\n\t; Mon, 18 Sep 2017 12:20:29 -0700 (PDT)","from localhost.localdomain (174-16-109-244.hlrn.qwest.net.\n\t[174.16.109.244]) by smtp.gmail.com with ESMTPSA id\n\to206sm1156044oif.26.2017.09.18.12.20.26 (version=TLS1_2\n\tcipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 12:20:26 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=qH7M343RhDAAH+J/Xt14mDgtsMstSSBDBxdXwOa+ikuUmMaMbGvwh\n\thMyXweLQ/ULAV1rkctHd+thNDDX7xes+BXFpcF5MVH1FCB8+wBDFVIgt0VHglW4R\n\tW3OLtW01cMhOYV3sZs2dxuRwKlH/Se/tk1RqeVSKJlDccJhgq9kn+w=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=E1SgJ95oQSZECFuvC/H4xUSBwuA=; b=cPxCuoQ5Uk65dtTAxQ35Rc7g8/8X\n\tChxePtF5MTfYXwvLjaeJnpkBhFXvczRR3FHHuy0p8G8lGDpORi1FV/gs6NlPT+6N\n\tt0kr67s/gtI1yhfoQ9oO2oeK355V9/x0ZncVXHTsQrqx+C0irmR/BL1n4Vm77uKb\n\tfzA1MVkTmcHTAGM=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=prevailing","X-HELO":"mail-io0-f174.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=ZZU55QctVyOT98Mt5EXYM3rWk2nQjykb5zgF+F/8vIY=;\n\tb=oX3F/anLY7A2Gw7pBCIEy9L4YSS0iEyvAEY/QHjqBIqeqVyWqR25mFCbRNm+L7/wC7\n\tPtQDtGQCZV11DdtbxVtg+WBtjWcBPVbtIPl7poHR3djwXR0AYyaAPFLcF59pf+CiASuN\n\tcL9kDFUINh75oav+qA+oUbD8zDPzK7Hs1D2jBbrow1ZtlfT7TSLP2IG1MQqEqYvOazE/\n\tc0EoGlPBrvtZPm38fDA3xM6mjzfWTj2O3j5y3cgT1ExIEywINHJ/4tcxQeY2PCWfXYj5\n\tT9wXuTPdEJkFTVQ4lv7oN84cBCkzXkPrCw+neDFfr/w6eve2cqR7oUyq5qVxj98WT7AI\n\tLtmQ==","X-Gm-Message-State":"AHPjjUio1feZrzyNiUH7ndq6YrxH1noOATJg6NdiHzNuV7b4oEZ6TW3D\t7aNjbH++6fiBpw==","X-Google-Smtp-Source":"AOwi7QArYRsRX85/m2XgSGP+m3KMIibWq9E/FQL4x5yQ9ZIixMQcawpwrCoLbHSUVilRHje/LR6QyQ==","X-Received":"by 10.202.243.194 with SMTP id r185mr990144oih.218.1505762428348;\n\tMon, 18 Sep 2017 12:20:28 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","To":"sellcey@cavium.com, gcc-patches ,\n\troland.illig@gmx.de, fmarchal@perso.be","References":"<1505759191.2286.72.camel@cavium.com>","From":"Martin Sebor ","Message-ID":"<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>","Date":"Mon, 18 Sep 2017 13:20:25 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:45.0) Gecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1505759191.2286.72.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-IsSubscribed":"yes"}},{"id":1770713,"web_url":"http://patchwork.ozlabs.org/comment/1770713/","msgid":"<2870639.NQtlXYLpcP@development>","list_archive_url":null,"date":"2017-09-19T07:50:54","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":72388,"url":"http://patchwork.ozlabs.org/api/people/72388/","name":"Frédéric Marchal","email":"fmarchal@perso.be"},"content":"On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote:\n> On 09/18/2017 12:26 PM, Steve Ellcey wrote:\n> > This patch is for PR target/79868, where some aarch64 diagnostics are\n> > said to be not translatable due to how they are implemented. See the\n> > bug report for more details on why the current setup of passing\n> > the string 'pragma' or 'attribute' doesn't work.\n> > \n> > This patch fixes it, unfortunately by increasing the number of calls we\n> > have to 'error' (16 calls become 32 calls), but that seems to be the\n> > most straight forward way to get translatable strings.\n> \n> I haven't looked at all of them but from the few I have seen it\n> seems that rephrasing the messages along the following lines would\n> be a way to get around the translation issue and without increasing\n> the number of calls (though not without the conditional):\n> \n> error (is_pragma\n> ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n> : G_(\"missing name in % attribute\"),\n> \"arch\");\n> \n> The additional benefit of this approach is that it would also make\n> the quoting consistent with what seems to be the prevailing style\n> of these sorts of messages. (It would be nice to eventually\n> converge on the same style/quoting and phrasing across all back\n> and front ends.)\n\nIndeed! That's even better as the message uses words the user sees in the \nsource code whatever his/her locale language is.\n\nWith your proposal, I know I must not translate \"target\" because it clearly is \npart of the programming language. With the former message, I would have \ntranslated \"target\" as part of the human language message. Your approach is \nclearly better.\n\nFrederic","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462459-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"amKobJ22\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxFS46MFHz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 17:51:16 +1000 (AEST)","(qmail 67178 invoked by alias); 19 Sep 2017 07:51:04 -0000","(qmail 66011 invoked by uid 89); 19 Sep 2017 07:51:02 -0000","from relay-1.mailobj.net (HELO relay-1.mailobj.net) (213.182.54.6)\n\tby sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with\n\tESMTP; Tue, 19 Sep 2017 07:50:59 +0000","from v-1c (unknown [192.168.90.161])\tby relay-1.mailobj.net\n\t(Postfix) with SMTP id 5C1C41097;\n\tTue, 19 Sep 2017 09:50:57 +0200 (CEST)","by mail-1.net-c.com [213.182.54.15] with ESMTP\tTue,\n\t19 Sep 2017 09:50:57 +0200 (CEST)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; q=dns; s=\n\tdefault; b=hyMm7+zSPJznWig3aG6dm2QnlN0U07xJqrmJ+4Z3qaWZfOP1FOQ+R\n\tLoROdlWVgVy7QZJ8+8IzIqKW7fowg30VQwlqkSCYKkD9W1QzmtdVd8N1/gvzqsq4\n\tqD1jxE6qvGmb/rUHitM4fKCAcHleo5Q1TRNa3goj5A3FrbJDT6ED2I=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender:from\n\t:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding:content-type; s=default;\n\tbh=QgdHupO7xQJ2D1HfrdMvBsFnsIw=; b=amKobJ227Oi3Rrkm3y1uRZnP+Cm3\n\tcoTFrFK8Gd+dC++43JSipFJRhOLwkZXV5mLGRhTj97XbfQSl4JuuUKzz68oqsqjJ\n\tBdQSnnV2wjU3Wb/OE43LCjPONQqXv3QjOnZryLqaUHLK0IxzLLkfQHiI73guTInt\n\tEmaz1mKhlJpIJzA=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-0.9 required=5.0 tests=BAYES_00,\n\tKAM_LAZY_DOMAIN_SECURITY,\n\tRCVD_IN_DNSWL_NONE autolearn=no version=3.3.2\n\tspammy=H*Ad:D*cavium.com, her, his","X-HELO":"relay-1.mailobj.net","X-EA-Auth":"xNSGgBRbQjUsgKPb98kY0GDpEO4LN5/8E/nZtKh3wxcE1BE9Hh6yrA5ifN14k7iTrcV3skejF9zPGQ1idGZfc+60bRgjTSvM","From":"=?iso-8859-1?q?Fr=E9d=E9ric?= Marchal ","To":"Martin Sebor ","Cc":"sellcey@cavium.com, gcc-patches ,\n\troland.illig@gmx.de","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","Date":"Tue, 19 Sep 2017 09:50:54 +0200","Message-ID":"<2870639.NQtlXYLpcP@development>","User-Agent":"KMail/5.2.3 (Linux/4.9.0-3-amd64; KDE/5.28.0; x86_64; ; )","In-Reply-To":"<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>","References":"<1505759191.2286.72.camel@cavium.com>\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\""}},{"id":1771171,"web_url":"http://patchwork.ozlabs.org/comment/1771171/","msgid":"<1505836441.2286.93.camel@cavium.com>","list_archive_url":null,"date":"2017-09-19T15:54:01","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote:\n> On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote:\n> > \n> > I haven't looked at all of them but from the few I have seen it\n> > seems that rephrasing the messages along the following lines would\n> > be a way to get around the translation issue and without increasing\n> > the number of calls (though not without the conditional):\n> > \n> >    error (is_pragma\n> >           ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n> >           : G_(\"missing name in % attribute\"),\n> >           \"arch\");\n> > \n> > The additional benefit of this approach is that it would also make\n> > the quoting consistent with what seems to be the prevailing style\n> > of these sorts of messages.  (It would be nice to eventually\n> > converge on the same style/quoting and phrasing across all back\n> > and front ends.)\n> Indeed! That's even better as the message uses words the user sees in the \n> source code whatever his/her locale language is.\n> \n> With your proposal, I know I must not translate \"target\" because it clearly is \n> part of the programming language. With the former message, I would have \n> translated \"target\" as part of the human language message. Your approach is \n> clearly better.\n> \n> Frederic\n\nAre '%<...%>' described somewhere?  These aren't normal printf options\nare they?  I don't think I have ever used them before.  I am also not\nsure why you have '%s=' means vs. '%s'.  Is it even worth breaking the\nword 'arch' out of the string vs. having something like:\n\n\terror (is_pragma\n\t\t? G_(\"missing name in %<#pragma target \\\"arch\\\"%>)\n\t\t: G_(\"missing name in % attribute\"));\n\nSteve Ellcey\nsellcey@cavium.com","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462511-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"dyZDXEwK\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxS9Y5mmPz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 01:54:25 +1000 (AEST)","(qmail 26015 invoked by alias); 19 Sep 2017 15:54:15 -0000","(qmail 25750 invoked by uid 89); 19 Sep 2017 15:54:15 -0000","from mail-sn1nam02on0043.outbound.protection.outlook.com (HELO\n\tNAM02-SN1-obe.outbound.protection.outlook.com) (104.47.36.43)\n\tby sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with\n\tESMTP; Tue, 19 Sep 2017 15:54:14 +0000","from sellcey-dt.caveonetworks.com (50.233.148.156) by\n\tBN6PR07MB3537.namprd07.prod.outlook.com (10.161.153.139) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.11; Tue, 19 Sep 2017 15:54:10 +0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version:content-transfer-encoding;\n\tq=dns; s=default; b=TdJLlebYODlgXWk/+x3A1HyCDV7gtPTRNjjIc/5Ga39\n\te8xpqgdZqb77MI0bGusPm5PH0Dyn16VuT7jNbTVnV70IFC6Z54z6jWvtz/AIeMyE\n\trZU+mBU5YBnYPF/0QmZtE9jD2cnvIsou5Dj35TMw7PSkTCaA3KD7cUAPTILtXFlk\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version:content-transfer-encoding;\n\ts=default; bh=59yxXFwajPsI1+/1EttOPAvjwuA=; b=dyZDXEwK0PHMpdNRe\n\t3L+mycNeKQ8Z+1TWagBz+Mfdvi+qnKPcxFmwitBVHSyN1Vs5FRzf3HvVOJfD2Ah/\n\tlumURWz6FF4SUY99giWidzGY/o5zbyNPnTM4nq87ZQ52kscULYTo4XlzPJe+kvH3\n\t5Y+bk2iN9d6yhohwKCcZc5FaG8=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.8 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=her","X-HELO":"NAM02-SN1-obe.outbound.protection.outlook.com","Message-ID":"<1505836441.2286.93.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","From":"Steve Ellcey ","Reply-To":"sellcey@cavium.com","To":"=?iso-8859-1?q?Fr=E9d=E9ric?= Marchal ,\n\tMartin Sebor\t ","Cc":"gcc-patches , roland.illig@gmx.de","Date":"Tue, 19 Sep 2017 08:54:01 -0700","In-Reply-To":"<2870639.NQtlXYLpcP@development>","References":"<1505759191.2286.72.camel@cavium.com>\t\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\t\n\t<2870639.NQtlXYLpcP@development>","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"MWHPR1201CA0014.namprd12.prod.outlook.com (10.174.253.24)\n\tTo BN6PR07MB3537.namprd07.prod.outlook.com (10.161.153.139)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"388caa31-f313-4d6a-1979-08d4ff76ab55","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:BN6PR07MB3537; ","X-Microsoft-Exchange-Diagnostics":["1; BN6PR07MB3537;\n\t3:twarKlaEiPD/Hxy1A5euHh9RhlW+Sdl6Wq/mIRdbeatJ81PBbt5jNKxvnuLHOqR9+eioql+w42ndgdOaohxVrTk5pgIxeKMz8X27AcajPfRAZrRgRFNM+AWyrRyTtv3qToAE5/MBCaV0Ey70wVGSkduXjTZCH8FSpK4TtFM9cmtZdPKDRO6DEkxkhVbH/mErq9lqNPWhpjYEoW/QP/0UhhTvICFVB/EKB2S3ugGLIvojR1d6J9Oj9chPDqYBnCbJ;\n\t25:TQJBQW+AiKRyB1HsKjGGRrFQgrxjTAs7HeZnezPZAv+nGHN0y0jDG8EQjqWKrepWdYjr2bPLDc5YRV4GlOpx1w7PefoujkOZFdEvHZrkNADe9QKyMmIpCrD4JTv70OVMqnR5wzDrH8oEZqtHSQdwr4yaTqEIF6RJZdX4vYt85IfWaR9vi3mEcu3Po6QslD+f8P6cKSE1LCnxF0IauhrrXAIX2jSdOo37ryc3dFWzmflcx/0zfYguhaukKBuOeZYmi9xFtRs+pfOCEz+TPE4EIQqsVf2X8RmSRvezR9x28+4CJwTNQkqDfJBjoN/j6McKtwrh1CUyoPLPCnfOYBH49A==;\n\t31:ekLVIPAcB07TCf2PMEcTLphO70Lq8VZ2eYlQPtbGxOszrEpZgMDES5GoZ1JTyySmcshzA9B8phOAm04W8YOKnfZ186Z1WhIXiVcEDuJ4UesmrzHW46TpZvTcuuOW2NOR5HXxyRxHMNtV+05nU//024I8wQWqmp+98fIyP9/aJ7cL67DbX+BQ+O1EZD7iwzvj7WKmZGl44iQdhjKRKTJT6B7ViQ9zT1v01ReToH1FRmk=","1; BN6PR07MB3537;\n\t20:d+PJtt+740bx5AOGYtwDzU+TLYv5t7UXeAuCFpJqrNOqphJ5nrUijhBKj1qwRADQGNEq6uFxg9GVXlMA/QQmphpl8YDRDf8VhVhQNOvJ0ETbK6SXE4pDdgwlM74GPCJ5X5zPF3TypXRpyxrs++W19I4SOWgUH7gH/bD1ye01kBpkB8CVSJ76k3cCW4t6P7fF9+BpztCQ/7H2GkxzJRsACp56RgXQABRRSJUQYJuhHHZ0BLcLHCpeBrAXOp+tC96Ve8PyFmsnxnNbmDCe8BQwq81VpJl3VAx7FQoOssaWNG4YUNBeD/ZsdNL0dwx3s27j4VXjQRzJp9p/mAZcoKWPREPC9eYnF8SrooQhxEUsVkyIOUrFp4b+CSvytriyh+VItQXNNX/GI6pP3Bq4ByvROrYbu07IunyMnHRo2NMfEjiAJ2JO0WAlL1YP9T/lVxtDRP3dQnXg4dWq0gDMXKBENSm1qYoMjlkr6w5Q4D+HeaxYA02NsPJuqhtVJ5krVdDs;\n\t4:wkHvxdKEqNVRzDRrWp6AkdBUOu7KFZNXGUzbIrLVEqSyRICLZuDZDJLVRZmRVP1M/Dl/7+oSxwjGTIMRKiEZLklPbgsB5cnYopFNQAYXi6cE2H8bPrUwBNs5ga64B6t48be//mMGuOv40e/Aw42VRkrgAubfQWXyp45N76JhhWZNFN76J2jOUtm2BNMWCzfEI3cnk25N2MgYgJCtp0luei05chmGZFxIrZVuSKaekANAWQc+lkPopTfsW8mX0xPB","=?utf-8?q?1=3BBN6PR07MB3537=3B23=3Af57r?=\n\t=?utf-8?q?UP7HwwO+TJsUWaAW/m4wRhKZZL4AMDCURzrD777KI6wNnenDpXTE/Pju?=\n\t=?utf-8?q?yy9B9I7TLgIYRwdfS544c0RmtlTw9nD7dPXJBSPo9G4D5NH0luiOlVAt?=\n\t=?utf-8?q?COS/FvizCoKv3aO7nsFwk6lsmp22w3uJ4VBZEfxQO2Br5e6zReiNvvVS?=\n\t=?utf-8?q?qdlhWmyb/4nJu2ZDiYh/H/HXVrXyLWZXf5by/FFKQ9JUYy1A6m+tEY1A?=\n\t=?utf-8?q?sltbdsW86VoAZPdIuP4b3rrADa6ymYftn+vv+KLNwixwNTcoQNRLxX8Q?=\n\t=?utf-8?q?mlw0sp+vZF+oq07slh45A2dMZ1SMpgrc1aBKepcDYD9pGrBX6Xz3HU7t?=\n\t=?utf-8?q?v2SaozpkwgRzNoCzwgFqki22HOqbSCSAvao5SSHSs11+NSmve56uva4A?=\n\t=?utf-8?q?f67HZkfoMg+hd8hVsHiogUFT/fPdPk3XPfrzh/x88XlVbW/1tgujgj6P?=\n\t=?utf-8?q?l+Z0mRYrgN/Xob4T5IxU/vEYItuwgVeUhXUyrLq/dYnQsvCE6OFzCNCW?=\n\t=?utf-8?q?eElYGak7ErGHcQ3cumWDU4DojHXYD0rE2vKUYlGGiKA04NAZz4aXZ/nh?=\n\t=?utf-8?q?fdcJNoYNCqhmjIphWQJfbAfbXI0bbB2hUzhCgEQQ7IPyaGd6Qh2kIxif?=\n\t=?utf-8?q?zpn2AJ07EveCY1P1YIpSclb9arW2MtCOv3/Rgz471rLNRthaN6S0NY9Y?=\n\t=?utf-8?q?Cz0FhmZTnUrqvZ/q3v9EoTTteTeef7NsJl3MnaavWjET1F5F28q0GEZV?=\n\t=?utf-8?q?UsXJPR4HQiptyA/CGCVCqWQF3WUldyDlEbzy48DzWHYLYBNGYefi13O1?=\n\t=?utf-8?q?EqLHQGkMdhKe3DDFShDyec1NkFVsBVbc+yVdpLVRoygRF3JBzSWkvWgG?=\n\t=?utf-8?q?ebIF81YXdWn8Xc//VvKmUDmrxA8EIE7kil9vmPSVQhMcKpR9m8Jw4xZB?=\n\t=?utf-8?q?/hxTOfylDclp4OpKtHsgVnJ/n150iujx91nSUBN/Jg1mqnjf5XjsYEHz?=\n\t=?utf-8?q?V+GzjKFjsw5bsq/KL8U6g2ibs3nKy7D0i94SCO7F7MRHyKzTq65Gd71P?=\n\t=?utf-8?q?C6p/19W3iR4Xt2M12SLAyx/NTSfAUbzs++e8TnTzSgofNJK6aukBN2yu?=\n\t=?utf-8?q?ca6XYPAogBHwi/nosBfF2GkZG/Y61mT2eAGewbVm4QYl4Wk3PxJGzuab?=\n\t=?utf-8?q?Z4HtzkiSZ9Kl7xe52wFw7S9Ss+BAJFzAWEIRR0XLpRPqwNuyUrlWfisd?=\n\t=?utf-8?q?Vs8KlgBTNVdyOH2yCJgawi/L2j/WqcaBBTbvpx+o1yJ7lDR7sbrUpAkf?=\n\t=?utf-8?q?zelmZECg1dkrK/GaT0eBXNKnWQxdgKu1Ya834XvykaxrjwwoLHUVQXFx?=\n\t=?utf-8?q?BEvxb8QVzlUp3T4tZv192auAmKdscfgh0WBlM0S6c78Cg4eXa93uh2lq?=\n\t=?utf-8?q?CKZHQ60rjzccfHuTazELEfDWlAxsg7q6Teq5llFD+om+a0muEMRGYUpb?=\n\t=?utf-8?q?L/CyhVARNj/fyCPDEeMP9vKACHIQlubPGEHbRiP/HpbG+jw=3D?=","1; BN6PR07MB3537;\n\t6:MOKvSLegRTaPn4sqAFIU60g0e283ZGdqFsBp3yxKXepxBWfY3Zb5vNz+phx/gL3ITfsdH0gK14xuSooK7yEpBys394ySHb/ZARtCTPzkKwsRvWHGAbx49Br0ez8ENLOWvNuRALmotVxkj+lp7tYgRP0/TcPKSaCDZVliqprzEkZwN8jnRtUhivL8AKBUOUrL7rUedVNn/NiBvb2ExUSeH2xtowO563vnkdG20C4idJVZdDa7R7vdC5IxhikNb5rltthhbRDH71Sy3KhJbralZeFTHPe6e08lFmJWDeJFN6LTRWOfse5FLResJoQ2dRm+cM8PRFoysvwDRBtDVcFnnQ==;\n\t5:usUOj7GWnWNYxiJuczw9m1tGN+u3kSPdwG2QxfAzq2N6pgT64g/lYKfkYdIaHWW5L8KUhBHDoCZ+bWvuytPbizWh7H4wjGCndfCa11wht0UrY9ORNifpRzSzcn+zJ3D98F7yZUQHMraSFjP5Kr5UQQ==;\n\t24:+f4hRVFgYkTyLRbfHXsckvSQLSlQjFeO75FUuCJUgwKJVsjJ1wDpGuB36hrQy0FJCt5dueILUCNbYeu9adGGhEeFijr11Un9uJGzk/2UCbE=;\n\t7:rydE0dl1HnZy1bX/++Yx7WgtO2FL9uHS8ft7Lv9odNGTY5G1EzefrXfHiwc0kq4hEj5Dd5ht/p2bVojx22/pjqQQpZ26tpDrKO8eKfup3EAXjgeuFiLXqBl7mUXdPhLJYtO4a66DPhWnIYzu4egnCA9C7/j/sffR9DTTBIFS9cvEWhYokcZPL+jD1n5Vs2r69Lbi+z/lQemH0WTDobl/Kq/hWGjRDgYchRs2KhZE71w="],"X-MS-TrafficTypeDiagnostic":"BN6PR07MB3537:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6041248)(20161123555025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:BN6PR07MB3537; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:BN6PR07MB3537; ","X-Forefront-PRVS":"04359FAD81","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(979002)(6009001)(376002)(346002)(199003)(24454002)(189002)(377424004)(6512007)(53936002)(36756003)(101416001)(103116003)(8666007)(53416004)(229853002)(6116002)(69596002)(106356001)(43066003)(110136005)(3846002)(561944003)(97736004)(105586002)(189998001)(5820100001)(478600001)(6666003)(6506006)(25786009)(50986999)(81166006)(50466002)(8676002)(316002)(76176999)(5660300001)(39060400002)(2906002)(6486002)(81156014)(4326008)(66066001)(2870700001)(6246003)(50226002)(8936002)(23676002)(68736007)(305945005)(33646002)(2950100002)(47776003)(7736002)(3450700001)(72206003)(16526017)(99106002)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3537;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"19 Sep 2017 15:54:10.5537\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BN6PR07MB3537"}},{"id":1771211,"web_url":"http://patchwork.ozlabs.org/comment/1771211/","msgid":"","list_archive_url":null,"date":"2017-09-19T16:49:55","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":66696,"url":"http://patchwork.ozlabs.org/api/people/66696/","name":"Martin Sebor","email":"msebor@gmail.com"},"content":"On 09/19/2017 09:54 AM, Steve Ellcey wrote:\n> On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote:\n>> On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote:\n>>>\n>>> I haven't looked at all of them but from the few I have seen it\n>>> seems that rephrasing the messages along the following lines would\n>>> be a way to get around the translation issue and without increasing\n>>> the number of calls (though not without the conditional):\n>>>\n>>> error (is_pragma\n>>> ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n>>> : G_(\"missing name in % attribute\"),\n>>> \"arch\");\n>>>\n>>> The additional benefit of this approach is that it would also make\n>>> the quoting consistent with what seems to be the prevailing style\n>>> of these sorts of messages. (It would be nice to eventually\n>>> converge on the same style/quoting and phrasing across all back\n>>> and front ends.)\n>> Indeed! That's even better as the message uses words the user sees in the\n>> source code whatever his/her locale language is.\n>>\n>> With your proposal, I know I must not translate \"target\" because it clearly is\n>> part of the programming language. With the former message, I would have\n>> translated \"target\" as part of the human language message. Your approach is\n>> clearly better.\n>>\n>> Frederic\n>\n> Are '%<...%>' described somewhere? These aren't normal printf options\n> are they? I don't think I have ever used them before. I am also not\n> sure why you have '%s=' means vs. '%s'. Is it even worth breaking the\n> word 'arch' out of the string vs. having something like:\n>\n> \terror (is_pragma\n> \t\t? G_(\"missing name in %<#pragma target \\\"arch\\\"%>)\n> \t\t: G_(\"missing name in % attribute\"));\n\n%< and %> are (briefly) mentioned in pretty-print.c, just above\npp_format. They should be used in preference to the apostrophe\nto introduce quoting and color highlighting in diagnostics.\n(There's also logic in the pretty printer to help detect\nmismatches between these and other related directives, but none\nfor the apostrophe.)\n\nI used %s= because it appears with some consistency in other\nsimilar messages in gcc.pot, e.g.:\n\n % CPU can be used only for % attribute\"\n\n(I ran 'grep target gcc.pot | grep attr' to find them, along with\nsome of the inconsistencies among them.)\n\nIt doesn't look to me like parameterizing the message on the name\nof the target attribute reduces the number of messages that need\nto be translated so it doesn't gain much (if anything) here. It\ndoes have help in a few other places where I've been working\nrecently that deal with attributes and I used mostly out of habit.\n\nMartin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462515-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"b8B7XA9B\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxTQ70yKnz9sPm\n\tfor ;\n\tWed, 20 Sep 2017 02:50:22 +1000 (AEST)","(qmail 74596 invoked by alias); 19 Sep 2017 16:50:01 -0000","(qmail 74417 invoked by uid 89); 19 Sep 2017 16:50:01 -0000","from mail-io0-f169.google.com (HELO mail-io0-f169.google.com)\n\t(209.85.223.169) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tTue, 19 Sep 2017 16:49:59 +0000","by mail-io0-f169.google.com with SMTP id l15so504286iol.8 for\n\t; Tue, 19 Sep 2017 09:49:59 -0700 (PDT)","from localhost.localdomain (174-16-109-244.hlrn.qwest.net.\n\t[174.16.109.244]) by smtp.gmail.com with ESMTPSA id\n\t36sm490396oth.0.2017.09.19.09.49.55 (version=TLS1_2\n\tcipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 19 Sep 2017 09:49:56 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=D9hKEWQX8QGG3hvfMjVBhrSryL44ay3nyolpUDcJn2+o7kRf3ZlJy\n\t9wAuReOf0bs78kiqKFuELqJzdabEQvostQn5RyXNpVU0LOk4CmTiUXb8MOUMKHMj\n\twWIbWkB8AZ8zzPboXdUicvm3IMNyLGq06dq4KyRt/UczzAq1AQ9pfI=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=lI+vVZsnP8BbQD/8glRxUxjs36I=; b=b8B7XA9Bljcay9KV+e/DQAEaj+D4\n\tp80XkjSnNRJegISVvbFJ0Tln72nvSaTCJe1M4Ux9Z/TcZOLXtftLM+byiGwA5F0d\n\tc29ZLDK8fGY4xpJP4ouz1NvHOE9E8o6prBqeograOsEH6LNf5pgemjHbkjNpnZxn\n\tlehVAjvg9DNPj2o=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.8 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2731,\n\thabit, her","X-HELO":"mail-io0-f169.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=SLAQ3fFjC9XTE5N7HJuXKvkGyChchNcSkX8yijA9cFc=;\n\tb=sD0+FpZEYB4X7eBCz//SAzgM3tnGuZWiJvhcrLKYubpaGwhUjWRsIA/INGdaa0OYg3\n\t035GqjmBEgcFQ424bJUFFnnIT14/fG3QTNjqHteOu5+DAtTc268mZ48JOlnS1Jg9TeQh\n\tcweLBYupl4IKmMHmKwMinpVAAk0PNojkiLjPtZ33tmm1GhlPNAcNgRNsXnMedARwvjAO\n\tjrZbgYtYD/dLQ1hrp+suMuFZR6AgsPXlpQG0DFCGzD0EdX+ycf4QcK0TFhKid8OpT9F8\n\tF40HpodAZLQOyXHJvpKzjwjQFRkeYhaJUD246GFbt6j3r8rrEdkunakOhPjaVLbtwUK4\n\tepcA==","X-Gm-Message-State":"AHPjjUjaZEuzAHU1ntJokdoZVjAzhQB4jlCIJ+JD/H7i0m30+hKOovi8\tqwKVo27UKC8ykpMIZ9DuxBF6tA==","X-Google-Smtp-Source":"AOwi7QBwws9TWAGXdkXQmnM72X0SyX9nvkg59r8nnZJh+U0AbW88oUq5/EXITE4RyhjshU1UapnJVw==","X-Received":"by 10.202.49.11 with SMTP id x11mr2082510oix.43.1505839797361;\n\tTue, 19 Sep 2017 09:49:57 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","To":"sellcey@cavium.com, =?utf-8?b?RnLDqWTDqXJpYyBNYXJjaGFs?=\n\t","References":"<1505759191.2286.72.camel@cavium.com>\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\n\t<2870639.NQtlXYLpcP@development>\n\t<1505836441.2286.93.camel@cavium.com>","Cc":"gcc-patches , roland.illig@gmx.de","From":"Martin Sebor ","Message-ID":"","Date":"Tue, 19 Sep 2017 10:49:55 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:45.0) Gecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1505836441.2286.93.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","X-IsSubscribed":"yes"}},{"id":1772316,"web_url":"http://patchwork.ozlabs.org/comment/1772316/","msgid":"<1505950604.2286.127.camel@cavium.com>","list_archive_url":null,"date":"2017-09-20T23:36:44","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote:\n> On 09/19/2017 09:54 AM, Steve Ellcey wrote:\n> > On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote:\n> > > \n> > > > \n> > > >    error (is_pragma\n> > > >           ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n> > > >           : G_(\"missing name in %\n> > > > attribute\"),\n> > > >           \"arch\");\n> > > > \n> > > > The additional benefit of this approach is that it would also make\n> > > > the quoting consistent with what seems to be the prevailing style\n> > > > of these sorts of messages.  (It would be nice to eventually\n> > > > converge on the same style/quoting and phrasing across all back\n> > > > and front ends.)\n> > > Indeed! That's even better as the message uses words the user sees in the\n> > > source code whatever his/her locale language is.\n\n\nSo I am looking at redoing the error messages and I am trying to decide\nbetween two forms.\n\nMake pragma/attribute part of the non-translatable string by showing the\npragma and/or attribute syntax ast it would be in the C/C++ code (what about\nFortran or Ada?).\n\nerror (is_pragma\n  ? G_(\"missing architecture name in %<#pragma GCC target (\\\"arch=string\\\")%>\")\n  : G_(\"missing architecture name in %<__attribute__ ((target(\\\"arch=string\\\")))\n%>\"));\n\nOr include them in the part that does get translated and include less of\nwhat is actually in the text of the file being compiled.\n\nerror (is_pragma\n  ? G_(\"missing architecture name in % pragma\")\n  : G_(\"missing architecture name in % attribute\"));\n\nOpinions?\n\nSteve Ellcey\nsellcey@cavium.com","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462660-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"o6TILCSz\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyGNv5dgvz9s78\n\tfor ;\n\tThu, 21 Sep 2017 09:37:01 +1000 (AEST)","(qmail 88138 invoked by alias); 20 Sep 2017 23:36:52 -0000","(qmail 87389 invoked by uid 89); 20 Sep 2017 23:36:51 -0000","from mail-sn1nam01on0072.outbound.protection.outlook.com (HELO\n\tNAM01-SN1-obe.outbound.protection.outlook.com) (104.47.32.72)\n\tby sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with\n\tESMTP; Wed, 20 Sep 2017 23:36:50 +0000","from sellcey-dt.caveonetworks.com (50.233.148.156) by\n\tMWHPR07MB3549.namprd07.prod.outlook.com (10.164.192.138) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.56.11; Wed, 20 Sep 2017 23:36:46 +0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version:content-transfer-encoding;\n\tq=dns; s=default; b=qEI/xlle34KhOrlYoNApcsqKU8gUnnojvLdOzv+gC6A\n\t008l50qO3Jnk6Ze4OhXYki+KOkSRecSefCMtpSZziApVZvGrOAHif0T9LAEHIt7C\n\tLrQVSjjnGuv86HCsiwX91qnIEEW3jpOi9+C0ha1eDcIdFHebkbJ8X4CdiX8OJF0s\n\t=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version:content-transfer-encoding;\n\ts=default; bh=HQPqvckA0OslHTWxwovZSUIPGS4=; b=o6TILCSz3uDDUkOBf\n\tQ1BoQIISDWVhpydpsfPbkpgbNi9DKkzSYMnCZ35GQ//MlPiLTOwVZzkB+cPP8LIC\n\tIpmz7znnsNPgk0HrQqozMOAPa3U2t4VUW2ZOK407/TPt6RlG1uFjLpH5GtXAHYnr\n\tOUacJFHRQDepgYiV/JPiznSRmk=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.8 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:127, her","X-HELO":"NAM01-SN1-obe.outbound.protection.outlook.com","Message-ID":"<1505950604.2286.127.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","From":"Steve Ellcey ","Reply-To":"sellcey@cavium.com","To":"Martin Sebor , =?iso-8859-1?q?Fr=E9d=E9ric?=\n\tMarchal\t ","Cc":"gcc-patches , roland.illig@gmx.de","Date":"Wed, 20 Sep 2017 16:36:44 -0700","In-Reply-To":"","References":"<1505759191.2286.72.camel@cavium.com>\t\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\t\n\t<2870639.NQtlXYLpcP@development>\n\t<1505836441.2286.93.camel@cavium.com>\t\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","X-ClientProxiedBy":"MWHPR08CA0016.namprd08.prod.outlook.com (10.174.103.157)\n\tTo MWHPR07MB3549.namprd07.prod.outlook.com (10.164.192.138)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"0f77875c-bdfb-49ec-93cd-08d5008075ad","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:MWHPR07MB3549; ","X-Microsoft-Exchange-Diagnostics":["1; MWHPR07MB3549;\n\t3:myHFv/fnqANRy6mYHqWXQFMcRdmkzh0Gc6DqPg/IhAlUJOI/wnAF1L0VS2xDCIvWajz+50pM+eTJAysJYXgx61Or3Smx3+bP5c00P8GKbob0hIP5IDyjvlHs1jpUwLHOJMWWup/278vOcg40ra+fewoofHcrL7vvcJZOWfkzPtogfyxSVxMajqYLual13YM9kyZYa7oMSWn6X1iFep9qEkxg6xkAyJYM56qsfFEI1zJwZVl7XagnaLVZ0nankxYO;\n\t25:+03HIqI1DqfmCdh6+9N8c4Yj988YA70MrgKq+mM32WIw1UhenPeBES+a92YkMoNf7gzPfjeLH/2HcO8oXK3XLBuK1kqbRP+pSCscMhSynUdvmswllaHDpE57CU8FnHmys1BGWhV7o+naap/W8SJk63bSDworJ9vXCv1q2Jxrx2oQPN3b1wXN9lNMgempq/AX4gKs8io+t4jlj+udV4a8bWPtSbGANmiaPmm9/cedJuo5fXvxoYQn1VoO0YZlkWJuRoJeiU6HOsU7uGJE44di6EffBm0A4diM92rh1txvTNcPFApGttQy6zwJVZJ9ZpdHRjgC+c7d/DNKndam7BhqXA==;\n\t31:K2kxB0bqrUHytwd71IrpklTn9+pVSKXKXFBfdnSxmbFW5eMRzI6otBfqkgPhYEKwWEdvh5LgNGOIPv6bPoxM73NHnne5yQlnGym9JrNnR4vmCxx/TSVjuiPXUtaioAW6tVkcmc8bZn/uiogro3K/qnoHnr4knKVfbkjfr5nqyZ6jxOe8mVVLmCzsYvtbownfl4azDdg1q+pz0dFkh0y7tULaywFYp2ubZu6iDQmH3d0=","1; MWHPR07MB3549;\n\t20:vCiqB5ijzdcY0Y5QCYmXQ37UU9V7sb10Rl3/jnmWvgMdxIlysgwCuD7ZgElvtX9/gCACuuNqO2gTa3izFh/yUQMSzgCW1sbnVSgBTpnTmR2YZdqfy6W11QIw0fSzkJTJnKCTJJFn0I3kIUKZWohR7hggmWN1xZ0stsUTY4ofbaGA8gLm7JbqSG2PL/WfRiB6RYeuwVeb2XaWCbWtZjBltpHrV+E+qjFp0gdBVnE6gir7aQI1MSe+yO+uy7e2H4EvO8+L4POzfGay50RexYczPSn1K+xMMr6utS5D5U8Wm7tup1+1rjtw+2TquoNA1sMHy0P+3Vk5SGNdM1hzZCfClIAqR8fSEKAgRKY4ne5KoYeSoqyUeTpbo1VAoc8bU790M5H7D/IaKFcC1BDMv+0NrS9J+RvPXrkSKqUAQiWKK1XAkYGPhq0JnSBmtHqLaBpyaw7bgiT7G/F8O/tKBFOaq3e2zlqDEFUjmleWw6uSbc/W1yooGqh4HPmHQKaNob+Z;\n\t4:xj25PkTSb6OqumcRUmenPBv2/jwLKMJMqvTaLKTU/gwLyK0ssiC5c6BsgQTlGLhnj44Ws9Ryur5xhYOSTGhPyT3bAomasekh3gW195pUK8Ahw77HN7gWk9QSsRhhlRFdIAkktd1KBsfLkwfKxQKUP+aHcruzFaxaeb03y8k6pY3sjvywAkIHhpY+S6PJEjxoDJvwORB8AOZSqWJapvEpg6V+y3TwTnKZV1oskxicATNcbE0vpeb/Cj+tupVdCdl+","=?utf-8?q?1=3BMWHPR07MB3549=3B23=3AQ1lF?=\n\t=?utf-8?q?I+mOEDPuKbxw09BudPe006YJcqnmzK48djBl9iiS6CNULNQA1yY2FgpV?=\n\t=?utf-8?q?60pXiqh8ZpM1IfslMrXn6C4YZPv1TBsmMRqSm2f4qlVtnv8Ta4Azc/6k?=\n\t=?utf-8?q?aEAPj/YVFjfNBTknKB6wkfU75vHa5QQTZQigsl1paKWXSe9yxQWdQFSr?=\n\t=?utf-8?q?Cd6hK3dqzEqIt60wFlhIooHmMKJ6h9clI1vgLJA/6lckOuh7T3EXmNLY?=\n\t=?utf-8?q?hs4jc/3EHrbnWSVOK0mMriLDhkiiHOIXRM1SBEOC0eKEB9BOxr2WEC6F?=\n\t=?utf-8?q?gOM+xjjYEKh+qgTejXXLxD+Fnskz4zq8k7CDKDnhsCD8OFlXaEkBmGue?=\n\t=?utf-8?q?hh2a8SRGVvPRf2uteJb4whqDPQEtEauFr7xmBGlubG5UQPX7j9dHqCSb?=\n\t=?utf-8?q?myudny6r/RoqNcdETmy+023Hz0765uRgYBAjhBsVpsUWIarVlEgFL0ek?=\n\t=?utf-8?q?vpO4g3JkEbBCnrPLWk8/LO43JaUTMzU7/1rAULSCuk3Xz+fS2FTp/Sm4?=\n\t=?utf-8?q?qeFCmwAlk886DmGGg8sC1+yc0WdX2XsTd8SrstPFo7Z1REbKtr/QmwFv?=\n\t=?utf-8?q?Ix0WEWf7Fton5dlYNeWOMZurjLR9bo16wlPdxhTVoLf6kl46t7Iluspy?=\n\t=?utf-8?q?j3KgEoCWKGzLWYs4BAKbe85r0TI18r9deef021fkfPP/OLGGV8tcf6H3?=\n\t=?utf-8?q?rof/IATAN1OIR61Yyo7R3m4NMJSg6FI9QBudMh8y5+PxxtJrpiF1Wssa?=\n\t=?utf-8?q?e4xhEnwfLL1ACABEA6qXdMspfARBfdEE/RJwuggM6ZzGU7pOcnNz8lvH?=\n\t=?utf-8?q?/VK+kR4nNnr8UXWz1Bt+pnJIbyI86UdPLzu7Y2HYF9DeQZo8RVMhUj7W?=\n\t=?utf-8?q?C6jIk24neTcbl0AYDBqdbIUnj1Ua5JW+pCJDf3Naz9iJQbNhWaibT3rm?=\n\t=?utf-8?q?XPn5hhMT1P9vse1GNyzgDdLbYXssgZPkcBsQD/8KJLbsT8LCdoZaGWuf?=\n\t=?utf-8?q?quy5OkuRR+MdZ3maAhJQCdkbIPOlPcoHAdVX0gCYsWW0AdVsrDJYBtyb?=\n\t=?utf-8?q?q2U0vFA94T24/4ia7Y32Vv6k5QAgrd3QhXPxbyZ/HtTvZlzBqAB3E89Q?=\n\t=?utf-8?q?3GkvQlbZPo7A4mYtARqO8dw1K/XzklMbSJv6ynMGpeZ8g8wMqIcipyjq?=\n\t=?utf-8?q?3RW71FI3zQ+ZaRDasxJmTTzIBqkvwgH5Ip09HUhPiLqs4+ICbh8+qdpL?=\n\t=?utf-8?q?WIglLk0aADi6m7BiVtCVEHZSsszng0jupZDYP2Z3SK8jO3oX/aeO8+S1?=\n\t=?utf-8?q?P6d+Nn+iEBqi5pMP7LObx0WH1nmAF3mhF9Iq5ST4TTQbLB3mWJ8muXCx?=\n\t=?utf-8?q?GeCdW7JRbs6CQ39kK2FOIp75jAThvbcXBGu5AzZCs6HmI5U80jkt+Ywx?=\n\t=?utf-8?q?JbKcvK1E2cPL33zAnIjo0D3l010pkKrwHol8pIk=3D?=","1; MWHPR07MB3549;\n\t6:Ycf5d0LeuBf9Wtk147s6XLhkIUSVLQk0limln6KuTy/tFMwvC/BTag0c0yIvgNWgmxW0ID8nq0AexeBvYZxRkzjZrzW5gB2MB9kHF45wJnoHr8oe4E6hEn0+0XpEmXFB1yKgJPblM7c+Ydh7ZGpRjqOlFMk0jU3zunEKuocYRXBDEnoDmayeN/tsK9WXCsyCu2RfC1jHz+cLybGakCvoGYW3l1hNlZbnBkf1T8VLd1G24pKjPfpHPPIdbvbUBSQUU1GhF2u/oVX6BbELieJkwzOWN6vOw7cH16gib4gctMj3eABlTX43QGXoBfQILsNl8GxcsGnEVAmzfMxRskdX3w==;\n\t5:6B1ot/IMR21SlkA75+I9KqodBTv5bbfvrkIRKs/rJ9hmadJ/xI4G4w5RB2mN/0Fnks9EZdbGGt4vn69nlQC7Zdom/zB3ubw93Km4yMD91HUhofuKFieU6b5oMkHWvn4Nd2x1eXqft2fvwXI7Ap/YhQ==;\n\t24:pFiFgU46zwGLu6iPhVgy/F/8BBOd6raPoj6S7/T/0TgwVxhIMFSAvAx+qHFj8+6TRPDqX+RB1ka0U5IyY3Mm6ZwXkKg9ehbaPVVqy1P+9Ck=;\n\t7:VnG1b2Bhn6CQPdQjrayZ7HSh+9kwHuNS19INUz+aKTOMNv7mAneYVSO28LIeRpfctZD8nHBhCuJHDSrn7E6B/virSx83aDQRWTA4fkm+hA+EjNmcclsFpeJWM0O7vOihC/TaK7UWomF5IHiVLfBog7xlyaa+os3SY2Hg3HgD1Bj1/NuAR5yUbdM6kS3ZJ2YfMz6qsQqc13MQHrAOvGxDud5ISwgzufM48EOUcHbslfo="],"X-MS-TrafficTypeDiagnostic":"MWHPR07MB3549:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:MWHPR07MB3549; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:MWHPR07MB3549; ","X-Forefront-PRVS":"04362AC73B","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(377454003)(24454002)(189002)(199003)(377424004)(6246003)(81156014)(4326008)(478600001)(105586002)(305945005)(3846002)(72206003)(43066003)(7736002)(6512007)(5660300001)(33646002)(47776003)(316002)(66066001)(6116002)(53936002)(53416004)(39060400002)(8666007)(189998001)(106356001)(110136005)(16526017)(93886005)(50466002)(2950100002)(68736007)(2906002)(25786009)(103116003)(50226002)(8936002)(3450700001)(76176999)(50986999)(2870700001)(101416001)(97736004)(229853002)(6506006)(81166006)(5820100001)(36756003)(53546010)(6486002)(69596002)(23676002)(8676002)(99106002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3549;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"20 Sep 2017 23:36:46.8698\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MWHPR07MB3549"}},{"id":1772823,"web_url":"http://patchwork.ozlabs.org/comment/1772823/","msgid":"","list_archive_url":null,"date":"2017-09-21T14:07:47","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":66696,"url":"http://patchwork.ozlabs.org/api/people/66696/","name":"Martin Sebor","email":"msebor@gmail.com"},"content":"On 09/20/2017 05:36 PM, Steve Ellcey wrote:\n> On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote:\n>> On 09/19/2017 09:54 AM, Steve Ellcey wrote:\n>>> On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote:\n>>>>\n>>>>>\n>>>>> error (is_pragma\n>>>>> ? G_(\"missing name in %<#pragma target\\(\\\"%s=\\\")%>\")\n>>>>> : G_(\"missing name in %\n>>>>> attribute\"),\n>>>>> \"arch\");\n>>>>>\n>>>>> The additional benefit of this approach is that it would also make\n>>>>> the quoting consistent with what seems to be the prevailing style\n>>>>> of these sorts of messages. (It would be nice to eventually\n>>>>> converge on the same style/quoting and phrasing across all back\n>>>>> and front ends.)\n>>>> Indeed! That's even better as the message uses words the user sees in the\n>>>> source code whatever his/her locale language is.\n>\n>\n> So I am looking at redoing the error messages and I am trying to decide\n> between two forms.\n>\n> Make pragma/attribute part of the non-translatable string by showing the\n> pragma and/or attribute syntax ast it would be in the C/C++ code (what about\n> Fortran or Ada?).\n>\n> error (is_pragma\n> ? G_(\"missing architecture name in %<#pragma GCC target (\\\"arch=string\\\")%>\")\n> : G_(\"missing architecture name in %<__attribute__ ((target(\\\"arch=string\\\")))\n> %>\"));\n>\n> Or include them in the part that does get translated and include less of\n> what is actually in the text of the file being compiled.\n>\n> error (is_pragma\n> ? G_(\"missing architecture name in % pragma\")\n> : G_(\"missing architecture name in % attribute\"));\n>\n> Opinions?\n\nThere are two distinctly different spellings of the target (and\nevery other) attribute: besides the one above, the C+++ standard\nrecommended syntax is [[gnu::target(\"arch=...\")]], so I think\nhardcoding one into the message wouldn't be optimal. (The C\nstandard hasn't adopted the C++ syntax but a proposal to do so\nis being considered. There are some questions about the exact\nspelling, and some people have proposed adding _Attribute()\ninstead, analogous to _Pragma, or possibly in addition to the\nC++ syntax.)\n\nThere are, of course, also two ways to spell a pragma: #pragma\nand _Pragma, so the same argument against hardcoding either one\ncould be made there.\n\nIn my view, the ideal message would use the same form as in\nthe source code. But I suspect that's not easy to determine at\nall sites where the message is being formatted, so the next best\nthing is to avoid using the keyword and fall back on the general\nterm.\n\nMartin\n\nPS If possible, I would also suggest adopting a style that is\nalready in use elsewhere, for consistency. (That would suggest\nusing % with no spaces and no \"string\" after\narch=.)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462707-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"Rzgw93P5\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xydjr2fv1z9t3v\n\tfor ;\n\tFri, 22 Sep 2017 00:08:00 +1000 (AEST)","(qmail 96357 invoked by alias); 21 Sep 2017 14:07:53 -0000","(qmail 96342 invoked by uid 89); 21 Sep 2017 14:07:52 -0000","from mail-io0-f182.google.com (HELO mail-io0-f182.google.com)\n\t(209.85.223.182) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tThu, 21 Sep 2017 14:07:50 +0000","by mail-io0-f182.google.com with SMTP id q11so11006712ioe.10 for\n\t; Thu, 21 Sep 2017 07:07:50 -0700 (PDT)","from localhost.localdomain (174-16-109-244.hlrn.qwest.net.\n\t[174.16.109.244]) by smtp.gmail.com with ESMTPSA id\n\tj134sm1526866oih.28.2017.09.21.07.07.48 (version=TLS1_2\n\tcipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 21 Sep 2017 07:07:48 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=b6ABDMYPvV+EX+buqHrNbYLiOEbZRCiMBmvi7jOSpZdj4EhkIyQdX\n\tH+dGopfectnhLFDhk/cPg51/EV8Un/ZXXyv/URricZgJAkLA6xFgZYIoX4Blz3rY\n\tLOKVReEiKDLXIpEGWS31uQQUyUhaDWoiIrCIa37zTgRScg8AgWrhQA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=qTs7pHDFlU5bTv1b+B4Q7OXN574=; b=Rzgw93P5WpAixJxXTOYynJFsZlD6\n\t7Ij7RaFZ4PGDvrce+EtGsJoq5OPtTB7w6ST37gvUf2xk7RFC6Br5hR1Rx9T1V/Zg\n\t/feswMHWvDHcI/px2Y8PqxkVe08PPYVjGBz1MG2EZjvVNPNnU6BYkjrC0WJSlm1i\n\tVr3KLXfpQmm0/Gw=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-6.7 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_FROM, GIT_PATCH_3, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=her, his","X-HELO":"mail-io0-f182.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=R+pEAlOrQA6qSa4yHM4StkuQmT2GIkDlWTveoVLDffI=;\n\tb=sloC2TJa6cT89IbwdYEw+AH4zyf0w4583zh+v7AsFocbz8afvYFEtPV3Sfb/gPrtTk\n\tc1Srlr/yb6wBaBNkjTg/QJiIcfoxG0O+uXO93DnnO5u7RlAYmphmxCt2ISs4kD805Tq1\n\ty+NqYh68HhGn6/57v53yT5WxJ2aq3Yk5cEfBz5oLoKkkKl4l1fV/rQzajW0BDiF2VztM\n\tA9aiGdXKJHXcQDavpuRU61/JS9JL+16/bPBqEnLmJhdD3K2gcfZQlIl/Yrdhsz31tV5r\n\t70Epd5ZQrpvfdCg/ZpsEeRwRe+9aFuLud0/KwsXY5swFBqCCpB2JWq6cl/LD8HgVN9Ys\n\tKXfw==","X-Gm-Message-State":"AHPjjUjUL5EznSyfTWVoGDNUpbfjUHhXSCyQTB1RadmNXL6RekH3fEia\tsVqN+gYEyHORY2G0HFPrQqg=","X-Google-Smtp-Source":"AOwi7QA6DJWaOFJ2yL7nUDDKBtUfDRlVj2ReaPcJ/oh+7JD4qsbEh07isRItAR7I6DDjb9JjjI8e+A==","X-Received":"by 10.202.105.16 with SMTP id e16mr2748129oic.104.1506002869051;\n\tThu, 21 Sep 2017 07:07:49 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","To":"sellcey@cavium.com, =?utf-8?b?RnLDqWTDqXJpYyBNYXJjaGFs?=\n\t","References":"<1505759191.2286.72.camel@cavium.com>\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\n\t<2870639.NQtlXYLpcP@development>\n\t<1505836441.2286.93.camel@cavium.com>\n\t\n\t<1505950604.2286.127.camel@cavium.com>","Cc":"gcc-patches , roland.illig@gmx.de","From":"Martin Sebor ","Message-ID":"","Date":"Thu, 21 Sep 2017 08:07:47 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:45.0) Gecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1505950604.2286.127.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","X-IsSubscribed":"yes"}},{"id":1773796,"web_url":"http://patchwork.ozlabs.org/comment/1773796/","msgid":"<1506102864.2286.168.camel@cavium.com>","list_archive_url":null,"date":"2017-09-22T17:54:24","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":70332,"url":"http://patchwork.ozlabs.org/api/people/70332/","name":"Steve Ellcey","email":"sellcey@cavium.com"},"content":"> In my view, the ideal message would use the same form as in\n> the source code.  But I suspect that's not easy to determine at\n> all sites where the message is being formatted, so the next best\n> thing is to avoid using the keyword and fall back on the general\n> term.\n> \n> Martin\n> \n> PS If possible, I would also suggest adopting a style that is\n> already in use elsewhere, for consistency.  (That would suggest\n> using % with no spaces and no \"string\" after\n> arch=.)\n\nHere is a new version of my patch.  I think it addresses these issues\nand is consistent.  It does cause some regressions in tests that check\nfor certain error messages, specifically:\n\ngcc.target/aarch64/spellcheck_1.c\ngcc.target/aarch64/spellcheck_2.c\ngcc.target/aarch64/spellcheck_3.c\ngcc.target/aarch64/target_attr_11.c\ngcc.target/aarch64/target_attr_12.c\ngcc.target/aarch64/target_attr_17.c\n\nBut I thought we should try and get some agreement on the format of the\nmessages before updating the tests.  If we think these changes look\ngood I can submit a final patch that includes the testsuite changes.\n\nSteve Ellcey\nsellcey@cavium.com\n\n2017-09-22  Steve Ellcey  \n\n\tPR target/79868\n\t* config/aarch64/aarch64-c.c (aarch64_pragma_target_parse):\n\tChange argument type on aarch64_process_target_attr call.\n\t* config/aarch64/aarch64-protos.h (aarch64_process_target_attr):\n\tChange argument type.\n\t* config/aarch64/aarch64.c (aarch64_attribute_info): Change\n\tfield type.\n\t(aarch64_handle_attr_arch): Change argument type, use boolean\n\targument to use different strings in error calls.\n\t(aarch64_handle_attr_cpu): Ditto.\n\t(aarch64_handle_attr_tune): Ditto.\n\t(aarch64_handle_attr_isa_flags): Ditto.\n\t(aarch64_process_one_target_attr): Ditto.\n\t(aarch64_process_target_attr): Ditto.\n\t(aarch64_option_valid_attribute_p): Change argument type on\n\taarch64_process_target_attr call.\ndiff --git a/gcc/config/aarch64/aarch64-c.c b/gcc/config/aarch64/aarch64-c.c\nindex 177e638..c9945db 100644\n--- a/gcc/config/aarch64/aarch64-c.c\n+++ b/gcc/config/aarch64/aarch64-c.c\n@@ -165,7 +165,7 @@ aarch64_pragma_target_parse (tree args, tree pop_target)\n information that it specifies. */\n if (args)\n {\n- if (!aarch64_process_target_attr (args, \"pragma\"))\n+ if (!aarch64_process_target_attr (args, true))\n \treturn false;\n \n aarch64_override_options_internal (&global_options);\ndiff --git a/gcc/config/aarch64/aarch64-protos.h b/gcc/config/aarch64/aarch64-protos.h\nindex e67c2ed..4323e9e 100644\n--- a/gcc/config/aarch64/aarch64-protos.h\n+++ b/gcc/config/aarch64/aarch64-protos.h\n@@ -445,7 +445,7 @@ bool aarch64_gen_adjusted_ldpstp (rtx *, bool, scalar_mode, RTX_CODE);\n \n void aarch64_init_builtins (void);\n \n-bool aarch64_process_target_attr (tree, const char*);\n+bool aarch64_process_target_attr (tree, bool);\n void aarch64_override_options_internal (struct gcc_options *);\n \n rtx aarch64_expand_builtin (tree exp,\ndiff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c\nindex 1c14008..3bf91b3 100644\n--- a/gcc/config/aarch64/aarch64.c\n+++ b/gcc/config/aarch64/aarch64.c\n@@ -67,6 +67,7 @@\n #include \"common/common-target.h\"\n #include \"selftest.h\"\n #include \"selftest-rtl.h\"\n+#include \"intl.h\"\n \n /* This file should be included last. */\n #include \"target-def.h\"\n@@ -9554,15 +9555,15 @@ struct aarch64_attribute_info\n const char *name;\n enum aarch64_attr_opt_type attr_type;\n bool allow_neg;\n- bool (*handler) (const char *, const char *);\n+ bool (*handler) (const char *, bool);\n enum opt_code opt_num;\n };\n \n /* Handle the ARCH_STR argument to the arch= target attribute.\n- PRAGMA_OR_ATTR is used in potential error messages. */\n+ IS_PRAGMA is used in potential error messages. */\n \n static bool\n-aarch64_handle_attr_arch (const char *str, const char *pragma_or_attr)\n+aarch64_handle_attr_arch (const char *str, bool is_pragma)\n {\n const struct processor *tmp_arch = NULL;\n enum aarch64_parse_opt_result parse_res\n@@ -9579,15 +9580,22 @@ aarch64_handle_attr_arch (const char *str, const char *pragma_or_attr)\n switch (parse_res)\n {\n case AARCH64_PARSE_MISSING_ARG:\n-\terror (\"missing architecture name in 'arch' target %s\", pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"missing name in % pragma\")\n+\t : G_(\"missing name in % attribute\"));\n \tbreak;\n case AARCH64_PARSE_INVALID_ARG:\n-\terror (\"unknown value %qs for 'arch' target %s\", str, pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"invalid name (%qs) in % pragma\")\n+\t : G_(\"invalid name (%qs) in % attribute\"),\n+\t str);\n \taarch64_print_hint_for_arch (str);\n \tbreak;\n case AARCH64_PARSE_INVALID_FEATURE:\n-\terror (\"invalid feature modifier %qs for 'arch' target %s\",\n-\t str, pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"invalid value (%qs) in % pragma\")\n+\t : G_(\"invalid value (%qs) in % attribute\"),\n+\t str);\n \tbreak;\n default:\n \tgcc_unreachable ();\n@@ -9597,10 +9605,10 @@ aarch64_handle_attr_arch (const char *str, const char *pragma_or_attr)\n }\n \n /* Handle the argument CPU_STR to the cpu= target attribute.\n- PRAGMA_OR_ATTR is used in potential error messages. */\n+ IS_PRAGMA is used in potential error messages. */\n \n static bool\n-aarch64_handle_attr_cpu (const char *str, const char *pragma_or_attr)\n+aarch64_handle_attr_cpu (const char *str, bool is_pragma)\n {\n const struct processor *tmp_cpu = NULL;\n enum aarch64_parse_opt_result parse_res\n@@ -9620,15 +9628,22 @@ aarch64_handle_attr_cpu (const char *str, const char *pragma_or_attr)\n switch (parse_res)\n {\n case AARCH64_PARSE_MISSING_ARG:\n-\terror (\"missing cpu name in 'cpu' target %s\", pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"missing name in % pragma\")\n+\t : G_(\"missing name in % attribute\"));\n \tbreak;\n case AARCH64_PARSE_INVALID_ARG:\n-\terror (\"unknown value %qs for 'cpu' target %s\", str, pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"invalid name (%qs) in % pragma\")\n+\t : G_(\"invalid name (%qs) in % attribute\"),\n+\t str);\n \taarch64_print_hint_for_core (str);\n \tbreak;\n case AARCH64_PARSE_INVALID_FEATURE:\n-\terror (\"invalid feature modifier %qs for 'cpu' target %s\",\n-\t str, pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"invalid value (%qs) in % pragma\")\n+\t : G_(\"invalid value (%qs) in % attribute\"),\n+\t str);\n \tbreak;\n default:\n \tgcc_unreachable ();\n@@ -9638,10 +9653,10 @@ aarch64_handle_attr_cpu (const char *str, const char *pragma_or_attr)\n }\n \n /* Handle the argument STR to the tune= target attribute.\n- PRAGMA_OR_ATTR is used in potential error messages. */\n+ IS_PRAGMA is used in potential error messages. */\n \n static bool\n-aarch64_handle_attr_tune (const char *str, const char *pragma_or_attr)\n+aarch64_handle_attr_tune (const char *str, bool is_pragma)\n {\n const struct processor *tmp_tune = NULL;\n enum aarch64_parse_opt_result parse_res\n@@ -9658,7 +9673,10 @@ aarch64_handle_attr_tune (const char *str, const char *pragma_or_attr)\n switch (parse_res)\n {\n case AARCH64_PARSE_INVALID_ARG:\n-\terror (\"unknown value %qs for 'tune' target %s\", str, pragma_or_attr);\n+\terror (is_pragma\n+\t ? G_(\"invalid name (%qs) in % pragma\")\n+\t : G_(\"invalid name (%qs) in % attribute\"),\n+\t str);\n \taarch64_print_hint_for_core (str);\n \tbreak;\n default:\n@@ -9672,10 +9690,10 @@ aarch64_handle_attr_tune (const char *str, const char *pragma_or_attr)\n For example \"+fp+nosimd\". Show any errors if needed. Return TRUE\n if successful. Update aarch64_isa_flags to reflect the ISA features\n modified.\n- PRAGMA_OR_ATTR is used in potential error messages. */\n+ IS_PRAGMA is used in potential error messages. */\n \n static bool\n-aarch64_handle_attr_isa_flags (char *str, const char *pragma_or_attr)\n+aarch64_handle_attr_isa_flags (char *str, bool is_pragma)\n {\n enum aarch64_parse_opt_result parse_res;\n unsigned long isa_flags = aarch64_isa_flags;\n@@ -9699,13 +9717,16 @@ aarch64_handle_attr_isa_flags (char *str, const char *pragma_or_attr)\n switch (parse_res)\n {\n case AARCH64_PARSE_MISSING_ARG:\n-\terror (\"missing feature modifier in target %s %qs\",\n-\t pragma_or_attr, str);\n+\terror (is_pragma\n+\t ? G_(\"missing value in % pragma\")\n+\t : G_(\"missing value in % attribute\"));\n \tbreak;\n \n case AARCH64_PARSE_INVALID_FEATURE:\n-\terror (\"invalid feature modifier in target %s %qs\",\n-\t pragma_or_attr, str);\n+\terror (is_pragma\n+\t ? G_(\"invalid value (%qs) in % pragma\")\n+\t : G_(\"invalid value (%qs) in % attribute\"),\n+\t str);\n \tbreak;\n \n default:\n@@ -9744,11 +9765,11 @@ static const struct aarch64_attribute_info aarch64_attributes[] =\n \n /* Parse ARG_STR which contains the definition of one target attribute.\n Show appropriate errors if any or return true if the attribute is valid.\n- PRAGMA_OR_ATTR holds the string to use in error messages about whether\n+ IS_PRAGMA holds the boolean to tell error messages about whether\n we're processing a target attribute or pragma. */\n \n static bool\n-aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n+aarch64_process_one_target_attr (char *arg_str, bool is_pragma)\n {\n bool invert = false;\n \n@@ -9756,7 +9777,9 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n \n if (len == 0)\n {\n- error (\"malformed target %s\", pragma_or_attr);\n+ error (is_pragma\n+\t ? G_(\"malformed % pragma\")\n+\t : G_(\"malformed % attribute\"));\n return false;\n }\n \n@@ -9772,7 +9795,7 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n through the machinery for the rest of the target attributes in this\n function. */\n if (*str_to_check == '+')\n- return aarch64_handle_attr_isa_flags (str_to_check, pragma_or_attr);\n+ return aarch64_handle_attr_isa_flags (str_to_check, is_pragma);\n \n if (len > 3 && strncmp (str_to_check, \"no-\", 3) == 0)\n {\n@@ -9804,8 +9827,10 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n \n if (attr_need_arg_p ^ (arg != NULL))\n \t{\n-\t error (\"target %s %qs does not accept an argument\",\n-\t\t pragma_or_attr, str_to_check);\n+\t error (is_pragma\n+\t\t ? G_(\"pragma % does not accept an argument\")\n+\t\t : G_(\"attribute % does not accept an argument\"),\n+\t\t str_to_check);\n \t return false;\n \t}\n \n@@ -9813,8 +9838,10 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n \t then we can't match. */\n if (invert && !p_attr->allow_neg)\n \t{\n-\t error (\"target %s %qs does not allow a negated form\",\n-\t\t pragma_or_attr, str_to_check);\n+\t error (is_pragma\n+\t\t ? G_(\"pragma % does not allow a negated form\")\n+\t\t : G_(\"attribute % does not allow a negated form\"),\n+\t\t str_to_check);\n \t return false;\n \t}\n \n@@ -9824,7 +9851,7 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n \t For example, cpu=, arch=, tune=. */\n \t case aarch64_attr_custom:\n \t gcc_assert (p_attr->handler);\n-\t if (!p_attr->handler (arg, pragma_or_attr))\n+\t if (!p_attr->handler (arg, is_pragma))\n \t return false;\n \t break;\n \n@@ -9868,8 +9895,10 @@ aarch64_process_one_target_attr (char *arg_str, const char* pragma_or_attr)\n \t\t}\n \t else\n \t\t{\n-\t\t error (\"target %s %s=%s is not valid\",\n-\t\t\t pragma_or_attr, str_to_check, arg);\n+\t\t error (is_pragma\n+\t\t\t ? G_(\"pragma % is not valid\")\n+\t\t\t : G_(\"attribute % is not valid\"),\n+\t\t\t str_to_check, arg);\n \t\t}\n \t break;\n \t }\n@@ -9903,12 +9932,12 @@ num_occurences_in_str (char c, char *str)\n }\n \n /* Parse the tree in ARGS that contains the target attribute information\n- and update the global target options space. PRAGMA_OR_ATTR is a string\n- to be used in error messages, specifying whether this is processing\n+ and update the global target options space. IS_PRAGMA is a boolean\n+ to be used by error messages, specifying whether this is processing\n a target attribute or a target pragma. */\n \n bool\n-aarch64_process_target_attr (tree args, const char* pragma_or_attr)\n+aarch64_process_target_attr (tree args, bool is_pragma)\n {\n if (TREE_CODE (args) == TREE_LIST)\n {\n@@ -9917,7 +9946,7 @@ aarch64_process_target_attr (tree args, const char* pragma_or_attr)\n \t tree head = TREE_VALUE (args);\n \t if (head)\n \t {\n-\t if (!aarch64_process_target_attr (head, pragma_or_attr))\n+\t if (!aarch64_process_target_attr (head, is_pragma))\n \t\treturn false;\n \t }\n \t args = TREE_CHAIN (args);\n@@ -9938,7 +9967,9 @@ aarch64_process_target_attr (tree args, const char* pragma_or_attr)\n \n if (len == 0)\n {\n- error (\"malformed target %s value\", pragma_or_attr);\n+ error (is_pragma\n+\t ? G_(\"malformed % pragma\")\n+\t : G_(\"malformed % attribute\"));\n return false;\n }\n \n@@ -9953,9 +9984,12 @@ aarch64_process_target_attr (tree args, const char* pragma_or_attr)\n while (token)\n {\n num_attrs++;\n- if (!aarch64_process_one_target_attr (token, pragma_or_attr))\n+ if (!aarch64_process_one_target_attr (token, is_pragma))\n \t{\n-\t error (\"target %s %qs is invalid\", pragma_or_attr, token);\n+\t error (is_pragma\n+\t\t ? G_(\"pragma % is not valid\")\n+\t\t : G_(\"attribute % is not valid\"),\n+\t\t token);\n \t return false;\n \t}\n \n@@ -9964,8 +9998,10 @@ aarch64_process_target_attr (tree args, const char* pragma_or_attr)\n \n if (num_attrs != num_commas + 1)\n {\n- error (\"malformed target %s list %qs\",\n-\t pragma_or_attr, TREE_STRING_POINTER (args));\n+ error (is_pragma\n+\t? G_(\"malformed % pragma\")\n+\t: G_(\"malformed % attribute\"),\n+\tTREE_STRING_POINTER (args));\n return false;\n }\n \n@@ -10025,7 +10061,7 @@ aarch64_option_valid_attribute_p (tree fndecl, tree, tree args, int)\n \t\t\tTREE_TARGET_OPTION (target_option_current_node));\n \n \n- ret = aarch64_process_target_attr (args, \"attribute\");\n+ ret = aarch64_process_target_attr (args, false);\n \n /* Set up any additional state. */\n if (ret)","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462799-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"N77b98jC\"; dkim-atps=neutral","sourceware.org; auth=none","spf=none (sender IP is )\n\tsmtp.mailfrom=Steve.Ellcey@cavium.com; "],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzLjF64Ydz9sPm\n\tfor ;\n\tSat, 23 Sep 2017 03:54:45 +1000 (AEST)","(qmail 100045 invoked by alias); 22 Sep 2017 17:54:34 -0000","(qmail 99725 invoked by uid 89); 22 Sep 2017 17:54:34 -0000","from mail-by2nam03on0069.outbound.protection.outlook.com (HELO\n\tNAM03-BY2-obe.outbound.protection.outlook.com) (104.47.42.69)\n\tby sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with\n\tESMTP; Fri, 22 Sep 2017 17:54:30 +0000","from sellcey-dt.caveonetworks.com (50.233.148.156) by\n\tCY4PR07MB3541.namprd07.prod.outlook.com (10.171.252.162) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.7; Fri, 22 Sep 2017 17:54:27 +0000"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version; q=dns; s=default; b=UQ/aT\n\tvJk0BtyRjfBSDDvmqZ8ViCWmzXKI6OLPRuLcNofHyxwGSBIpXHMfLkgEJOcBw4+v\n\txhxiWOgVlOKwd3K14NZSsZeCu3UUeUakZdwVXw9w291//k+CxocOUymjB0PSil7H\n\tU34AZMan+k9gSxGzvhDSUU2o0Zx39KzZmFn1Ms=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:message-id:subject:from:reply-to:to:cc:date:in-reply-to\n\t:references:content-type:mime-version; s=default; bh=CiS361JQuD3\n\tBtvN4lHNItziRsJE=; b=N77b98jC83YJhUePnqUUq2jTXMTMeXrMEGm9yNF4p8B\n\tdYtQX3vVd8WCGOygZBlHIVracj0BmA/JerXj9EqJoHf+bTSFMIxa3d2aBFa+GEXX\n\tUgv+fWTGapeiG3iZm+sZ54wSXXAnaKJTMv1VocQgUVfBQLUaXyO+G1vsSPFFPGTw\n\t=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-25.2 required=5.0 tests=AWL, BAYES_00,\n\tGIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3,\n\tRCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:168,\n\t99539","X-HELO":"NAM03-BY2-obe.outbound.protection.outlook.com","Message-ID":"<1506102864.2286.168.camel@cavium.com>","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","From":"Steve Ellcey ","Reply-To":"sellcey@cavium.com","To":"Martin Sebor , =?iso-8859-1?q?Fr=E9d=E9ric?=\n\tMarchal\t ","Cc":"gcc-patches , roland.illig@gmx.de","Date":"Fri, 22 Sep 2017 10:54:24 -0700","In-Reply-To":"","References":"<1505759191.2286.72.camel@cavium.com>\t\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\t\n\t<2870639.NQtlXYLpcP@development>\n\t<1505836441.2286.93.camel@cavium.com>\t\n\t\t\n\t<1505950604.2286.127.camel@cavium.com>\t\n\t","Content-Type":"multipart/mixed; boundary=\"=-Mj9KyhiFhLCr4ta4OrBB\"","Mime-Version":"1.0","X-ClientProxiedBy":"MWHPR22CA0064.namprd22.prod.outlook.com (10.171.142.26)\n\tTo CY4PR07MB3541.namprd07.prod.outlook.com (10.171.252.162)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"91e0d090-1fd9-461f-f2f8-08d501e2f7d8","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(2017030254152)(300000503095)(300135400095)(2017052603199)(49563074)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:CY4PR07MB3541; ","X-Microsoft-Exchange-Diagnostics":["1; CY4PR07MB3541;\n\t3:gLoTh87/rA1KM/pEtc82lECSXqlfyDwqRzm8P7fPJPw2q9NGjfFEmS7ZhJQ5gvBwsx01u3V2NWKCaZBqZOprlVwbhILmYMwBZg1dVOqB63tQ0nMHJnj09hpHyl/4A7IwBxa60kxX2+VG3PYWyLTulZMtbwe0lgN5uGUHfZ8iIc12UyKEtjdhs16/MoM4RyxC2n4ExSPTCt4z9/E7aWRDFh6m9jPskuwSLUPuH4/421jmLKgL6f+WU2zpuxl+yhM6;\n\t25:m8X2882w0NRbot1zd5L3/8ZpL/EKbH3Hrcs0Q3XEo54lWFbxV4nwI8k1CPlC6gkWsJH3CHHWQtDJF4/REMQS5BPt45t0qvYZhjF2Y8MugForqqLQ4DH+fEjV44fxX7+J9zLDNpL+nXl8SqePJoeBtKuGN5CqzVcFkab54Iz9JnAFLFkRa//o2ebHXpMUFdq1uSX8Es4DF87e5QofGNcHacebSuUlsheCPGHcySSuOaIs2QfWDXDfyU1pk0H4ORK2Mcy671Bl3oOO9pmxApQk106mUU/XEtSKFmfK7zKDBce/5MXkizLWKXaJeYdDCNhuEWm3roGBAagV+Aozz6qhKg==;\n\t31:krfZPqp0VCjq9pRBdcPOCIbCHAZx/EcPZoFi7gQne0WaxOsF5Q7CWO938YeAsU9VpSDnuqIoju5ihjTbK0dJtNqlKw9iYwOi9Cw/py8/oRqD/XiJvQ4aeDQA//PqZ7VJkYaDgfhB9pGd28uwe/fE65uiO+iC1W8Rjag85LayKeV0EJJFniG6vBdo0Waz0JdfTuRG87+zUlxlzU2UOD9Wc7JRDqtSd08sqKdMpISJXXY=","1; CY4PR07MB3541;\n\t20:8Xp7Rpek7rEWLznylxJAcqmHiD5Yst5xQRXerdQ+dabdHtdqPdLfr12erL/goSYNlDFYTo0j9L/sp4ksUPur/FEl2wzd70V8R2eW0BSV53IRJ39Yl/8N2ThHl8zxRg/8jqxBGwE/9yIE37ybgJJ6mQX5EEMJtxEVnsciBBDdV5tHK1CgyVoTYK6W34upf7CPI5KhW96MN/o2aDi3Yh/ehQMvEJ9h4u2AWkUF7jozsbjP9BrpvGSA73bpl5AY3qQa4X/5uzhIq/aNjVPI8ofmPpbyJwx9ftse9iWoO79Bxti8HF92OL1Jz7ah5bx/mTD5WrpLIJhcqQGztyaytZGM1HtnNZlULChEtvv2/cHbgGOuJr1LieGQCGDA0Meikv8g6E/5SuEcqkgFPVeFp2qncy2e0sPtCY/xQerD5xm+4YmsuLWxtaV224YuAJMtihfTb6M9oQtx+zxf+i4pYTgpxZxdh4D0fooK2KwvpHaPLdSAjThMvMy+R4CRVZGmdZVk;\n\t4:QLjEkJkp3gxU4X55GW8kKNvWqdV29dj5pJVYpJ7uvHm77Lzw2BFmfkVJ/oi8zCtgOtnCkDZjfC0NHcc1nw8qKWVhD47r+wkkE35Ce3NskWJwge+Yubg6ezGyDBg/X4bEmbIO6+gzqqHcx7o0eqOGN32ji0pWPht83uRp9aDB9abIV8TaZIWqbWIdCiKOCoDuatWrRcjuLlyEza+e37HnzmkmlB6YMtHV/PjtpzVtzoP8IUy2O0IUfiiw2Mi06eob","1; CY4PR07MB3541;\n\t23:K/XDo8Zjaiq1G7qUeqkum0kqlVl8Ont54yjtFcFjVUKiJy16uLRbnroRkC6wvRWr8mfoZ2uWbR82paHj0HtuJW/Wi1PUiOOqHfoGLLzNZrjLoMQsX22nH6dcumxc18JFQB0Av5w1ddDKq64cb8WcvojHfg2N4Sfxo4Isq+eG2Adjy+sQDeeGnJkjiCHU/vNHCLl+lwJSqtwIXjRb8GG7sPmMXFwIDzYZGRmEgXs5axN9uS2Gk5Q1KIAE7ZzgaaPp5F3FCMMe4wZX5jRiBUghAjI0/OaVFH8YAiOX3FaRWnXj/Lkyk+yiOcF151/4GvN84EE3dJWnLrd+V9j3Z6agBO7Cdi+LrQ4QvFxE2zmqwT33mNN51aMY1OqLv0TlO4JIN9XhdB9pPtxvI+hJuc9IdlmbjIg86WUYS573ZxsD1sBMymOOihAHEAkg/qGUTJdOI63mdmuvUJV76dkoBMSHk5m+jKJ55PZU3/LTkmZL3D11i+bxn82c38XC88m2R/JnazcmazRMnFO+ZFn6mQo031Ose649t6T0DVm/0Efh4lD9Mw/d9IC/1I7WSyB0MfmT+LN53TuJanqxPzcLXExyGvI43Zf6f66SEsWnEMnVx4v+4Ac6U4s1q47NNCgowjnl1Li105SdqrEIVMsYTxxP6hUsvDtHH5hUdaMYWTp/xWRNPyfeeSKX6YvlaE5Q47TE8qPTQbEgf7So4LP9XsUdTu3AazP6dfLz2Jr/RBJ5CUlMdGE/QEwWlugm94Xxm30d5mUKGIKZC6xMOZ0YUPeVtpqEZ0GcacVQdTrE4E2msqfqBwxwmT0RohHJEAdNE9IMl3y5vO0Ed2zfXILsOzpA3/UWTYN1YUjf47BbBtQSyk5U4D7V8SC6AOjX0xS7tItynKPwKRpTMfpyN0J2jaX1BgCoxStpCjQkB5rMd6p1AOWre1F+zzkQReMTCudE8rl9/Ti4j4137S1SVE/QjRY9y+FiH3BJeCK/tlPNAwvxdmfqRx0fnKnTTInTvqLAzVTPHIqtFea2G0Wwsbyf5exsJ7335/CMwR4fOnoSPFVUaT0ssrwSVnYQDzxjjW7Dq0O9VUrXGrraHr7XS9DBsJUTjD409ZpHKYU/sJJca0pcVjiZSnPfwBIotBvHbCCcHd4Lhb+fMnbxan5zkvVDlnOqf3Vl2FCw3ctiN3lEtZZ5W1glj5vXFQ0kVuxxHwOW+vMJaaiiHmLI8HZD5VWXiHGTfKUzYJ05cfLGsYd2n+V0+uXoCHkTQOGxHaHN0OIGTEQP4v90gO6mL2djr8r9a6GgyeUjAENHS3xegpjjsCAy8WVMKw0RJOX5RHs4AViR0Bf83FojsZxRDZeLzUUi5a4T4qUmTbu3eB8/6HVdR8nC65o=","1; CY4PR07MB3541;\n\t6:Bhqp1tPhbFD9XRJSj42Cb27ggvS1NR7gUxSRBG1ZR09SaMFgWVL7LsOqhHkZ5sELdZeT30rkVkBNAdmBCOs584+v3v+BN8mwvYWfwdtXR+XMjrjoU+uLP4gw6rgalOHoMCfanMy8uRiuc/0egH1KThYjWG2/jZ5ArjWsR+a5sE5x5BYZBkWWTAEy7+zw5esFwIS0AWv9OEEInCm1WM3liwjusI9fNHshz6l/SJFuGtlKGW1HtOXrq5tKdfbZdgy99a54od7WDX2KOb0PjDiDlzsKpa5IcquUpKigIoKnQvLKAZGPxZC61daTOQXUEZdGi7jiZaUGwwSzIGUOt+DwPw==;\n\t5:3fdpt+PZKtoN/4xffA/883vZcuIYoj2W0W4+e7ypzRDS1cm3M08y306IHZkO8X97yJSbW5ZwG3WSkZlToI2wB6oDWiqmFORp1XnR2IORLzVk1tI6YtFxWLrolEQ3m3M72FOVaS5FJovV+xkfWGBFHQ==;\n\t24:YwJw5G+432DWn/XTHvb/1SDzDkqF3iSPtrsSP9bb0f5zMIta7GofhALVqj4jSaotKVSKY1An03bbxabyJHwyQVQe9pjLtANsfSDSoq91kU4=;\n\t7:hg1VAsWkVJyyfxznkTLjgY+s7T8SRmoZo7dKvadWx6i/cZNrP3JiIExW4dNJYns3yTB69ozj7y5PNcmRAebc7IxnqxavpqbIlAwgXzwC37qR3pTBD5AHGxzCqW/W0/08ihUmYNyc+Nhgn6Q2QZXBPB2YiSeDYRC7UiuvBk5Bf5+TB5ubMjFsanMA5CQ0IyWrEaHrKnqIMnpqGvp2wTdTLQhsA5vmHgKd2ubYTHyK50k="],"X-MS-TrafficTypeDiagnostic":"CY4PR07MB3541:","X-Exchange-Antispam-Report-Test":"UriScan:;","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:CY4PR07MB3541; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:CY4PR07MB3541; ","X-Forefront-PRVS":"0438F90F17","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(346002)(376002)(377424004)(199003)(189002)(6506006)(316002)(16586007)(50226002)(53416004)(6116002)(2476003)(3846002)(33646002)(4326008)(110136005)(6486002)(2906002)(105586002)(6246003)(25786009)(106356001)(93886005)(84326002)(16526017)(5660300001)(7736002)(72206003)(305945005)(66066001)(76176999)(4610100001)(512874002)(101416001)(5890100001)(8936002)(189998001)(69596002)(8666007)(97736004)(3450700001)(36756003)(6512007)(81166006)(2950100002)(81156014)(568964002)(39060400002)(229853002)(68736007)(8676002)(103116003)(6666003)(478600001)(53936002)(50986999)(43066003)(99106002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR07MB3541;\n\tH:sellcey-dt.caveonetworks.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"cavium.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"22 Sep 2017 17:54:27.1470\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"711e4ccf-2e9b-4bcf-a551-4094005b6194","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY4PR07MB3541"}},{"id":1773839,"web_url":"http://patchwork.ozlabs.org/comment/1773839/","msgid":"<966ef0a9-38c4-a046-aaef-98b81db0aac4@gmail.com>","list_archive_url":null,"date":"2017-09-22T19:34:30","subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","submitter":{"id":66696,"url":"http://patchwork.ozlabs.org/api/people/66696/","name":"Martin Sebor","email":"msebor@gmail.com"},"content":"On 09/22/2017 11:54 AM, Steve Ellcey wrote:\n>\n>> In my view, the ideal message would use the same form as in\n>> the source code. But I suspect that's not easy to determine at\n>> all sites where the message is being formatted, so the next best\n>> thing is to avoid using the keyword and fall back on the general\n>> term.\n>>\n>> Martin\n>>\n>> PS If possible, I would also suggest adopting a style that is\n>> already in use elsewhere, for consistency. (That would suggest\n>> using % with no spaces and no \"string\" after\n>> arch=.)\n>\n> Here is a new version of my patch. I think it addresses these issues\n> and is consistent. It does cause some regressions in tests that check\n> for certain error messages, specifically:\n>\n> gcc.target/aarch64/spellcheck_1.c\n> gcc.target/aarch64/spellcheck_2.c\n> gcc.target/aarch64/spellcheck_3.c\n> gcc.target/aarch64/target_attr_11.c\n> gcc.target/aarch64/target_attr_12.c\n> gcc.target/aarch64/target_attr_17.c\n>\n> But I thought we should try and get some agreement on the format of the\n> messages before updating the tests. If we think these changes look\n> good I can submit a final patch that includes the testsuite changes.\n\nThank you for taking my suggestions! The changes look good to me.\nJust one minor nit. The following won't produce the kind of output\nwe'd like it to:\n\n error (is_pragma\n ? G_(\"pragma % does not accept an argument\")\n : G_(\"attribute % does not accept an argument\"),\n str_to_check);\n\nIt will end up printing:\n\n error: pragma ‘target(‘...’)’ does not accept an argument\n\n(note the single quotes around the ... where the syntax otherwise\ncalls for a string). The %s directive should not use the 'q' flag\nwhen nested between %< and %>. -Wformat normally warns about this\nbut in this case it doesn't see the format string because of the\nconditional (I think -Wformat can be extended to handle this case).\n\n warning: 'q' flag used within a quoted sequence [-Wformat=]\n\nTo get the right output I think the format string should like\nsomething like this:\n\n \"pragma % does not accept an argument\"\n\nMartin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462807-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"JU7o1dUp\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzNwM5H57z9sNr\n\tfor ;\n\tSat, 23 Sep 2017 05:34:43 +1000 (AEST)","(qmail 59131 invoked by alias); 22 Sep 2017 19:34:36 -0000","(qmail 59121 invoked by uid 89); 22 Sep 2017 19:34:35 -0000","from mail-io0-f195.google.com (HELO mail-io0-f195.google.com)\n\t(209.85.223.195) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tFri, 22 Sep 2017 19:34:34 +0000","by mail-io0-f195.google.com with SMTP id 93so235343iol.4 for\n\t; Fri, 22 Sep 2017 12:34:33 -0700 (PDT)","from localhost.localdomain (75-166-115-132.hlrn.qwest.net.\n\t[75.166.115.132]) by smtp.gmail.com with ESMTPSA id\n\tr5sm978628oia.16.2017.09.22.12.34.31 (version=TLS1_2\n\tcipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 12:34:32 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=ae9TdEO635U43FFMtZAamSSs1Jr0zYy/8Np8npOsjlsx9N5mfxflZ\n\t2mh11WxeBd13OHTiPrR771ntiOjFeCjjDJsupHhC92I7Q/wZiu2vbAslhXMujNOI\n\t9Wz/AZuXvvfAuv5Biq0SlAiuRyZdqg/snynI9osL04Bp9vY8zz747E=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:cc:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=Ck5T9hqo9L2UVPMU2bQGmnYjfko=; b=JU7o1dUpeXzfP66BtJx3E9kNncds\n\tm98gLMDzo0mEoXtaphc2UiVBakUNfjXaoyd8vBOExEYgrEyK201rV2w67O+ibICj\n\tHgjCe9dt8NXBl6uLvhruJ74R/iMxU4myWMsWJ2UgDpF3QNyKsdUXvAewl+xDw8AC\n\t5wwKkRJ/Usk49BE=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.4 required=5.0 tests=BAYES_00,\n\tFREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=(unknown)","X-HELO":"mail-io0-f195.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=M4armNW5ZGe55y6fD3Op8LLYJmoWEQ3wjw0Djw06N90=;\n\tb=n1Dhh1/4Ea7CfUi6ieHq1Tnrm5LU+yyz5yo4hphPF7nXy+9zZwkHmksFuA25oIVSoM\n\tL9TQVdc2PBoQS+xD0M94Ercr4grWTvkjh8gLfsdMkVRpBTQVD+DVMvlAej9IQPZcaUbE\n\tIhiq6pjDlXzS24Epa0c/dPUWXWaCm/fBqzS7nkP3/S8sSFQlVAk8O0sygUixPryHeQGj\n\tMHh1pfvTHFomjIoY+0o8cCxX+fdSoktTMIPJAmJ2t6J7AxUjHkCUi1Np9ZJsLLezxRur\n\tqfrolnJ0ZwIV7N1+zFpjJ1Vc2L2sRdosb0z3jeVXB971I/BotnTbyZCdZYuZsXaGQugN\n\tn9aA==","X-Gm-Message-State":"AHPjjUggqpOhtLa0FEdfiiqxXeTG0BOn5HqZochvu2rzM5rq1AFEPxoc\toA3p+7KrdUsTUs6wuR5BuOs=","X-Google-Smtp-Source":"AOwi7QDTQzaGvHPm0yYgaC2vkoVtMcS5jmnFFnTZiEndfk86n8+y9KKsVrLa2aFnoRNPjPNBuzdKQQ==","X-Received":"by 10.202.57.195 with SMTP id g186mr289600oia.320.1506108872541;\n\tFri, 22 Sep 2017 12:34:32 -0700 (PDT)","Subject":"Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be\n\ttranlated","To":"sellcey@cavium.com, =?utf-8?b?RnLDqWTDqXJpYyBNYXJjaGFs?=\n\t","References":"<1505759191.2286.72.camel@cavium.com>\n\t<8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com>\n\t<2870639.NQtlXYLpcP@development>\n\t<1505836441.2286.93.camel@cavium.com>\n\t\n\t<1505950604.2286.127.camel@cavium.com>\n\t\n\t<1506102864.2286.168.camel@cavium.com>","Cc":"gcc-patches , roland.illig@gmx.de","From":"Martin Sebor ","Message-ID":"<966ef0a9-38c4-a046-aaef-98b81db0aac4@gmail.com>","Date":"Fri, 22 Sep 2017 13:34:30 -0600","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:45.0) Gecko/20100101 Thunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<1506102864.2286.168.camel@cavium.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"8bit","X-IsSubscribed":"yes"}}]