[{"id":1774368,"web_url":"http://patchwork.ozlabs.org/comment/1774368/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:12:51","subject":"Re: [U-Boot] [PATCH v2 4/5] rockchip: back-to-bootrom: allow\n\tpassing a cmd to the bootrom","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 18 September 2017 at 12:18, Philipp Tomsich\n wrote:\n> The BROM supports forcing it to enter download-mode, if an appropriate\n> result/cmd-word is returned to it. There already is a series to\n> support this in review, so this prepares the (newly C-version) of the\n> back-to-bootrom code to accept a cmd to passed on to the BROM.\n>\n> All the existing call-sites are adjusted to match the changed function\n> signature.\n>\n> Signed-off-by: Philipp Tomsich \n>\n> ---\n>\n> Changes in v2:\n> - adapt the RK3188 spl support file (that I had originally missed)\n>\n> arch/arm/include/asm/arch-rockchip/bootrom.h | 5 ++++-\n> arch/arm/mach-rockchip/bootrom.c | 4 ++--\n> arch/arm/mach-rockchip/rk3036-board-spl.c | 2 +-\n> arch/arm/mach-rockchip/rk3188-board-spl.c | 4 ++--\n> arch/arm/mach-rockchip/rk3188-board-tpl.c | 4 ++--\n> arch/arm/mach-rockchip/rk322x-board-spl.c | 2 +-\n> arch/arm/mach-rockchip/rk3288-board-spl.c | 4 ++--\n> arch/arm/mach-rockchip/rk3368-board-tpl.c | 2 +-\n> arch/arm/mach-rockchip/rk3399-board-spl.c | 2 +-\n> 9 files changed, 16 insertions(+), 13 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"eshQw8Pk\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"CNUFJ3hZ\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0pH33PnYz9t30\n\tfor ;\n\tMon, 25 Sep 2017 12:40:47 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 499B1C221D3; Mon, 25 Sep 2017 02:33:08 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C2CDCC221BB;\n\tMon, 25 Sep 2017 02:30:12 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 992A7C221D1; Mon, 25 Sep 2017 02:13:16 +0000 (UTC)","from mail-qt0-f174.google.com (mail-qt0-f174.google.com\n\t[209.85.216.174])\n\tby lists.denx.de (Postfix) with ESMTPS id DE91FC21C4F\n\tfor ; Mon, 25 Sep 2017 02:13:12 +0000 (UTC)","by mail-qt0-f174.google.com with SMTP id i50so5553212qtf.0\n\tfor ; Sun, 24 Sep 2017 19:13:12 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:12:51 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=WmcXx02Qpn7lNEii3DGzvBMSJS7A/xxqqfMwCqQiD5k=;\n\tb=eshQw8Pk4pkIZLL0L/6+jzHFuewN1iZPDzbLEVwZ9rvqkHafx/ZGX6S8jYvI4ftJ0O\n\tmzFbhfX58hbn6Z/FN+VNnzlY634g6tfWpla6FJxJrEVuK0nAqIYo8od3bBEQEwmoMBRQ\n\tzIasjYcxIS883tP8w5HciJgtKEJwqADpCLgJgz+tOkhRHKn87+lIogqSDFO1A6EWgrs0\n\tQ1feT/ATkebogsbPxwCWkiTOSrNNqUUYPtyUJFdXtwUA8cgpRXd7YdkXsxacZGnzzpDD\n\tg8ZleXdAs8cW6JNrIwOu0itzapx6Fl2I+vWvbM9rjsUpGKUftlgaRG8qBQF0jyUZIqAS\n\t1PeA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=WmcXx02Qpn7lNEii3DGzvBMSJS7A/xxqqfMwCqQiD5k=;\n\tb=CNUFJ3hZkLdu9wVlM2jm2/LmR5kyiHUCDsIoWn94FSCCgxEjqY/Z9PcNxJ1mX598aC\n\tMiN93+bosdqGfaNTwTN9PYobPA43c6CxVDrhp7Jo1pkHy1XKTh+oLXXilb9udDggdfWQ\n\tfb1L5+jtVF/Gcf2QqHdp2ePvOWTn7cEp7OsbI="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=WmcXx02Qpn7lNEii3DGzvBMSJS7A/xxqqfMwCqQiD5k=;\n\tb=l+ayDm1xFPaEHufq/Qnn3mhNgnZtpw2FYZJ/Ju1tlWTcKjrhW9p8V+JhSqOYuWyHi9\n\tdP408BHDyITqW/c9yh6leDoTT1NPz55oGp0Fb9wJ8O5VBmy56A15vPLgWeSkj1SixHRS\n\tAM5YvtzrQZHLq4pTIqZN2ET2eNJ6F5In7xcajT0nU++0edNTEYKyOOF4ACK+EG8tkL6M\n\tYZlazk8RZ1EjjIC4LXgAEaB5QR/F5R8Qx6kEZM3mAVobr4K/jmTiCie0bi8gxk92RBh3\n\tw+2W4NrYqtpC5v4NfIQw+SkZoNUedRRa0RpjQo2M13wIsGwqzHzQ+sNcKe0ExjV8ty85\n\tdDYA==","X-Gm-Message-State":"AHPjjUjuaBJcU0U+2bOZHfhs2agCFlfxzS9FTCGlORBAzTgM3JZ5xs14\n\tb/8moaTgZ3559M3Rrz2y27N3DgPyaRsvv8kdq132BQ==","X-Google-Smtp-Source":"AOwi7QA0ieaMjT6MDMatTn4x8UOakRa+wx5qoaft/0INaTJT4au+FEUp3++EQl3qEoQxO2NKeWyp3TmDKJP8MhsOQfE=","X-Received":"by 10.200.63.154 with SMTP id d26mr9263841qtk.212.1506305591636; \n\tSun, 24 Sep 2017 19:13:11 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505758708-29213-5-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1505758708-29213-1-git-send-email-philipp.tomsich@theobroma-systems.com>\n\t<1505758708-29213-5-git-send-email-philipp.tomsich@theobroma-systems.com>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:12:51 -0400","X-Google-Sender-Auth":"tDyw_rsxqn45-QW4OMETyX_zoFY","Message-ID":"","To":"Philipp Tomsich ","Cc":"U-Boot Mailing List ,\n\tKlaus Goger ,\n\tAndy Yan ","Subject":"Re: [U-Boot] [PATCH v2 4/5] rockchip: back-to-bootrom: allow\n\tpassing a cmd to the bootrom","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]