[{"id":1774367,"web_url":"http://patchwork.ozlabs.org/comment/1774367/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:12:46","subject":"Re: [U-Boot] [PATCH v2 3/5] rockchip: back-to-bootrom: rk3188:\n\tchain from SPL via TPL to the BROM","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 18 September 2017 at 12:18, Philipp Tomsich\n wrote:\n> The RK3188 implementation previously passed the address of the stack\n> frame created during save_boot_params via pmu->os_reg[2]. This was not\n> strictly necessary, as the save_boot_params() function was called\n> twice (first: for TPL, saving the context for the BROM; next: for SPL,\n> saving the context for the TPL) and a back-to-bootrom from the SPL\n> would thus return to TPL.\n>\n> To simplify things, we now assume that the state of the TPL is not\n> corrupted during SPL (the binaries are non-overlapping) and that the\n> SPL can safely return to TPL using the back-to-bootrom mechanism.\n> Consequently, the TPL should expect the SPL to return control and then\n> further return to the actual bootrom by performing another\n> back-to-bootrom transition.\n>\n> Signed-off-by: Philipp Tomsich \n> ---\n>\n> Changes in v2:\n> - [added in v2] chain back_to_bootrom calls for SPL, first returning\n> to the TPL (using the same mechanism) and the to the BROM from the\n> TPL\n>\n> arch/arm/mach-rockchip/rk3188-board-spl.c | 10 ----------\n> arch/arm/mach-rockchip/rk3188-board-tpl.c | 17 ++++++++++-------\n> 2 files changed, 10 insertions(+), 17 deletions(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"ChVh2vPm\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bsKGQHjf\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0pGW6Z9Nz9t30\n\tfor ;\n\tMon, 25 Sep 2017 12:40:19 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B0B62C22195; Mon, 25 Sep 2017 02:26:20 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 130D9C221A0;\n\tMon, 25 Sep 2017 02:26:15 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 08EF9C22192; Mon, 25 Sep 2017 02:13:11 +0000 (UTC)","from mail-qk0-f174.google.com (mail-qk0-f174.google.com\n\t[209.85.220.174])\n\tby lists.denx.de (Postfix) with ESMTPS id 53F10C21C45\n\tfor ; Mon, 25 Sep 2017 02:13:08 +0000 (UTC)","by mail-qk0-f174.google.com with SMTP id a128so5379063qkc.5\n\tfor ; Sun, 24 Sep 2017 19:13:08 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:12:46 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=t8YjGHUw/NT7RiO9SDmh5NTX+3z5R2wNJDsf9LH4FNI=;\n\tb=ChVh2vPmNJqqU9e4+Ucfth4e/3369zR5myYXdcNFg9+NDn+n7d96O3FC/OMECIyFn4\n\t5irMBDyod90a03ZdoEOgNHcj2esIuV8AO1f0Qwd4pITy1evUMhsZR8VQTDet4b0x7On6\n\tbjVF/641w1qOOG2D6Hxv0RCT/CwE/BCzsI/3ZV6Bz1ce+ndr91DQeEO59BhBFH1w5Int\n\ts7a86Qja9kc9NxdwU/o8jOrcDzkFQqe8XwkKAmStOAmsI7lF047loHdubX/jZbI0x5hL\n\thnwouYca+o6xrny9jSI/UlobckHicpO97pViYhzqlAL7ezTlWRygcmt5WFKbTTTazMa9\n\tua9A==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=t8YjGHUw/NT7RiO9SDmh5NTX+3z5R2wNJDsf9LH4FNI=;\n\tb=bsKGQHjfW4OB5zg3NL+QCVD4yTMwHY11gMVrtjWGtb35ad1sqV9yRUY8xhXgHSmyJQ\n\t/nTDD0UYf/TiW5zksv99zRaVY6PuWgfZ9bKvyBIUoUTmCrUdwdU1PWED0Kay/eHsdRs0\n\txTazGKe85Ap+E4CucvmE70YOT2RiLRmoe4rHE="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=t8YjGHUw/NT7RiO9SDmh5NTX+3z5R2wNJDsf9LH4FNI=;\n\tb=M+0gdG4AScocIRsVAi+YdzU1y2GI+QOeGNWPXFtTKS7FKIBbZR87TveJ6X6gU+tZzB\n\tt2J0vDvBSKdm5jlTt5sVOw+Cvu212KVTAN8G1tvutJUOPUM9t5kUQBcR7iIn7ph+jef+\n\tT9pQG4o1bib973bkFMagD6TFH+Xxud9ivs3SUFSiqP4OjAVndX+FgzzyrcSjTUkORQel\n\tg1X7stySJpRycBzlvA3spYZiiqxsLSQZ4wQuQZt5bO2xt2DQIIrn7EYeoiGoRg1NnJo0\n\tbM2umuGDQcFQKt60abX/aknGZoFIaUEno355F99WvwjraDXXLRitz/omFo+GvR9kPbx0\n\tlx7Q==","X-Gm-Message-State":"AHPjjUgS3OCEHB4Ud8/IbntlCg6pxX6I/XzMXlLTWOle+LbI617jzW9m\n\tCcKjazB3IuQoeIObt5F+Rp7fpWHGQKepWuTQa+StLw==","X-Google-Smtp-Source":"AOwi7QArutKsRzCPN7GvQTmTWZT5ePo4OTWspTeA5rLpqoKcG4lu4iphAvHGA5hzwTjwcjWrOPOex/S8/jdQT16bkzo=","X-Received":"by 10.55.122.130 with SMTP id v124mr8758196qkc.209.1506305587090;\n\tSun, 24 Sep 2017 19:13:07 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505758708-29213-4-git-send-email-philipp.tomsich@theobroma-systems.com>","References":"<1505758708-29213-1-git-send-email-philipp.tomsich@theobroma-systems.com>\n\t<1505758708-29213-4-git-send-email-philipp.tomsich@theobroma-systems.com>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:12:46 -0400","X-Google-Sender-Auth":"xIc4a-Coh6HAzNa676qe2ifXO24","Message-ID":"","To":"Philipp Tomsich ","Cc":"U-Boot Mailing List ,\n\tKlaus Goger ,\n\tAndy Yan ","Subject":"Re: [U-Boot] [PATCH v2 3/5] rockchip: back-to-bootrom: rk3188:\n\tchain from SPL via TPL to the BROM","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]