[{"id":1770399,"web_url":"http://patchwork.ozlabs.org/comment/1770399/","msgid":"<CAF6AEGu_2MQVdQ51pLj+208drZ-zJNQyegbNtKbrDVC9vKkutw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-18T18:27:10","subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","submitter":{"id":18760,"url":"http://patchwork.ozlabs.org/api/people/18760/","name":"Rob Clark","email":"robdclark@gmail.com"},"content":"On Mon, Sep 18, 2017 at 1:47 PM, Rob Clark <robdclark@gmail.com> wrote:\n> This is needed to run 'bootefi' from sandbox.  I suspect StartImage()\n> must have been broken too on x86.\n>\n> Signed-off-by: Rob Clark <robdclark@gmail.com>\n> ---\n>  cmd/bootefi.c                 | 2 +-\n>  include/efi.h                 | 2 +-\n>  lib/efi_loader/efi_boottime.c | 2 +-\n>  3 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/cmd/bootefi.c b/cmd/bootefi.c\n> index fb8ba9be6a..3c9a466e20 100644\n> --- a/cmd/bootefi.c\n> +++ b/cmd/bootefi.c\n> @@ -96,7 +96,7 @@ static void *copy_fdt(void *fdt)\n>\n>  static ulong efi_do_enter(void *image_handle,\n>                           struct efi_system_table *st,\n> -                         asmlinkage ulong (*entry)(void *image_handle,\n> +                         EFIAPI ulong (*entry)(void *image_handle,\n>                                 struct efi_system_table *st))\n>  {\n>         efi_status_t ret = EFI_LOAD_ERROR;\n> diff --git a/include/efi.h b/include/efi.h\n> index 04e83220b4..47c2c8f398 100644\n> --- a/include/efi.h\n> +++ b/include/efi.h\n> @@ -19,7 +19,7 @@\n>  #include <linux/string.h>\n>  #include <linux/types.h>\n>\n> -#ifdef CONFIG_EFI_STUB_64BIT\n> +#if defined(CONFIG_EFI_STUB_64BIT) || defined(CONFIG_SANDBOX)\n\nbtw, maybe we should have CONFIG_SANDBOX_$arch somehow so we don't\nhave to assume SANDBOX==X86 (but I guess at least just having\nefi_loader work in sandbox on x86 is a nice first step)\n\nBR,\n-R\n\n>  /* EFI uses the Microsoft ABI which is not the default for GCC */\n>  #define EFIAPI __attribute__((ms_abi))\n>  #else\n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 22bb95d738..3e10e6f6b5 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -950,7 +950,7 @@ static efi_status_t EFIAPI efi_start_image(efi_handle_t image_handle,\n>                                            unsigned long *exit_data_size,\n>                                            s16 **exit_data)\n>  {\n> -       ulong (*entry)(void *image_handle, struct efi_system_table *st);\n> +       EFIAPI ulong (*entry)(void *image_handle, struct efi_system_table *st);\n>         struct efi_loaded_image *info = image_handle;\n>\n>         EFI_ENTRY(\"%p, %p, %p\", image_handle, exit_data_size, exit_data);\n> --\n> 2.13.5\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"tCtuNL+B\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwvcZ4fM3z9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 04:27:26 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1307EC21D76; Mon, 18 Sep 2017 18:27:16 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 7B923C21C4C;\n\tMon, 18 Sep 2017 18:27:13 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 10307C21C4C; Mon, 18 Sep 2017 18:27:12 +0000 (UTC)","from mail-lf0-f66.google.com (mail-lf0-f66.google.com\n\t[209.85.215.66])\n\tby lists.denx.de (Postfix) with ESMTPS id AA6FDC21C2B\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 18:27:11 +0000 (UTC)","by mail-lf0-f66.google.com with SMTP id m199so741250lfe.5\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 11:27:11 -0700 (PDT)","by 10.46.41.75 with HTTP; Mon, 18 Sep 2017 11:27:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=6YyrBE+q6N7V/A7owv9T4q2XGwDNK64bOWE4H3n7NAo=;\n\tb=tCtuNL+BwQ3WxiEC9UaXPjDaBJnqW65cDxfMmqlGkriu98xplX0CLl0B82glaQQTdr\n\t7nuHpSvnk0ZbYYOkzJl1j/p7DdTWd+C6Pnheh7iPVqcV8eKMaDgjzNaCpNE/cf08M8Gr\n\tWBTbYwS/yNx8hXeQprD31LBan1PfGT0w/YpDd31n+JBqt5G/XOOe+eneMmwScdAvyuWz\n\tNcKO4YO4ehlhYGjoXp2agIExNhMDxNxdYbwfY6JJKYp3s5V5vCT81tw+0LEoeyIFqWJe\n\tWxH6yqzBVSpplckvauBvI6PxXlj/Iuaqw3sZhSSE3dX2LmtM++e4Y7+oRoVOQMGz5iPf\n\twnLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=6YyrBE+q6N7V/A7owv9T4q2XGwDNK64bOWE4H3n7NAo=;\n\tb=WGCjCCpQxETnoLGawBvXSj+XindtcSKtmA1DBocMT6F09EpPWK/hkz1c9iGgNOvegO\n\tHopcRpL82W6FQ/oP87DhLH7Cb68JQT0ywhwIVcfIEASk7N6xK1x3DJ691RIxkrsO4Hxx\n\t8XU0qJxxOKeJcge2wICi43E3fdN2FDqi1n5446e6hu0K98LUt+lT73M76cqGaZ77dJTI\n\tovPse2VuPqCOd016ykpDdsTyOyKnnj4QFCgPFTohubv52H5QaKTNRHcgEA3neh1J0PUE\n\tOBXGW1F83uvlGQYM37FFIjzPKKMKzZbn6Vb25gdAT2joUdFaLdplk0A532Wut7F6WBU+\n\tOg5Q==","X-Gm-Message-State":"AHPjjUh/CO+y3jdkGqd8aedX78kLhbeDWI/vjffaRWD2A+t5tCLtkdvS\n\t2f6ohRdECckrH6aWgeCsjVX2U45O6B4VasHiJ2GSdQ==","X-Google-Smtp-Source":"AOwi7QDACQqu6uqDhb5KtsuGxegyIFrxxxm9f7h1TSzt+FI1pSUx6IlQnLRswN0RtR4x89OGry3Bf+ljixayRn29JxE=","X-Received":"by 10.25.23.105 with SMTP id n102mr3677827lfi.252.1505759230908; \n\tMon, 18 Sep 2017 11:27:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918174801.31792-1-robdclark@gmail.com>","References":"<20170918174801.31792-1-robdclark@gmail.com>","From":"Rob Clark <robdclark@gmail.com>","Date":"Mon, 18 Sep 2017 14:27:10 -0400","Message-ID":"<CAF6AEGu_2MQVdQ51pLj+208drZ-zJNQyegbNtKbrDVC9vKkutw@mail.gmail.com>","To":"U-Boot Mailing List <u-boot@lists.denx.de>","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1770489,"web_url":"http://patchwork.ozlabs.org/comment/1770489/","msgid":"<b4afb661-607c-07cd-cd78-e42e464b9f44@suse.de>","list_archive_url":null,"date":"2017-09-18T20:58:29","subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 18.09.17 19:47, Rob Clark wrote:\n> This is needed to run 'bootefi' from sandbox.  I suspect StartImage()\n> must have been broken too on x86.\n> \n> Signed-off-by: Rob Clark <robdclark@gmail.com>\n> ---\n>   cmd/bootefi.c                 | 2 +-\n>   include/efi.h                 | 2 +-\n>   lib/efi_loader/efi_boottime.c | 2 +-\n>   3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/cmd/bootefi.c b/cmd/bootefi.c\n> index fb8ba9be6a..3c9a466e20 100644\n> --- a/cmd/bootefi.c\n> +++ b/cmd/bootefi.c\n> @@ -96,7 +96,7 @@ static void *copy_fdt(void *fdt)\n>   \n>   static ulong efi_do_enter(void *image_handle,\n>   \t\t\t  struct efi_system_table *st,\n> -\t\t\t  asmlinkage ulong (*entry)(void *image_handle,\n> +\t\t\t  EFIAPI ulong (*entry)(void *image_handle,\n>   \t\t\t\tstruct efi_system_table *st))\n>   {\n>   \tefi_status_t ret = EFI_LOAD_ERROR;\n> diff --git a/include/efi.h b/include/efi.h\n> index 04e83220b4..47c2c8f398 100644\n> --- a/include/efi.h\n> +++ b/include/efi.h\n> @@ -19,7 +19,7 @@\n>   #include <linux/string.h>\n>   #include <linux/types.h>\n>   \n> -#ifdef CONFIG_EFI_STUB_64BIT\n> +#if defined(CONFIG_EFI_STUB_64BIT) || defined(CONFIG_SANDBOX)\n\nThis is incorrect for sandbox on non-x86_64 hosts. We should rather fix \nit in Kconfig I guess.\n\n\nAlex\n\n>   /* EFI uses the Microsoft ABI which is not the default for GCC */\n>   #define EFIAPI __attribute__((ms_abi))\n>   #else\n> diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c\n> index 22bb95d738..3e10e6f6b5 100644\n> --- a/lib/efi_loader/efi_boottime.c\n> +++ b/lib/efi_loader/efi_boottime.c\n> @@ -950,7 +950,7 @@ static efi_status_t EFIAPI efi_start_image(efi_handle_t image_handle,\n>   \t\t\t\t\t   unsigned long *exit_data_size,\n>   \t\t\t\t\t   s16 **exit_data)\n>   {\n> -\tulong (*entry)(void *image_handle, struct efi_system_table *st);\n> +\tEFIAPI ulong (*entry)(void *image_handle, struct efi_system_table *st);\n>   \tstruct efi_loaded_image *info = image_handle;\n>   \n>   \tEFI_ENTRY(\"%p, %p, %p\", image_handle, exit_data_size, exit_data);\n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwyz81C7Zz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 06:58:42 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 32F6FC21D92; Mon, 18 Sep 2017 20:58:38 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C0566C21C34;\n\tMon, 18 Sep 2017 20:58:35 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 25C73C21C34; Mon, 18 Sep 2017 20:58:33 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id EE1D8C21C2B\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 20:58:32 +0000 (UTC)","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 2E014ABB4;\n\tMon, 18 Sep 2017 20:58:32 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Rob Clark <robdclark@gmail.com>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>","References":"<20170918174801.31792-1-robdclark@gmail.com>","From":"Alexander Graf <agraf@suse.de>","Message-ID":"<b4afb661-607c-07cd-cd78-e42e464b9f44@suse.de>","Date":"Mon, 18 Sep 2017 22:58:29 +0200","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918174801.31792-1-robdclark@gmail.com>","Content-Language":"en-US","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1770492,"web_url":"http://patchwork.ozlabs.org/comment/1770492/","msgid":"<a12294c4-2c60-24c2-c894-7a6de70d523f@suse.de>","list_archive_url":null,"date":"2017-09-18T20:59:29","subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","submitter":{"id":1212,"url":"http://patchwork.ozlabs.org/api/people/1212/","name":"Alexander Graf","email":"agraf@suse.de"},"content":"On 18.09.17 20:27, Rob Clark wrote:\n> On Mon, Sep 18, 2017 at 1:47 PM, Rob Clark <robdclark@gmail.com> wrote:\n>> This is needed to run 'bootefi' from sandbox.  I suspect StartImage()\n>> must have been broken too on x86.\n>>\n>> Signed-off-by: Rob Clark <robdclark@gmail.com>\n>> ---\n>>   cmd/bootefi.c                 | 2 +-\n>>   include/efi.h                 | 2 +-\n>>   lib/efi_loader/efi_boottime.c | 2 +-\n>>   3 files changed, 3 insertions(+), 3 deletions(-)\n>>\n>> diff --git a/cmd/bootefi.c b/cmd/bootefi.c\n>> index fb8ba9be6a..3c9a466e20 100644\n>> --- a/cmd/bootefi.c\n>> +++ b/cmd/bootefi.c\n>> @@ -96,7 +96,7 @@ static void *copy_fdt(void *fdt)\n>>\n>>   static ulong efi_do_enter(void *image_handle,\n>>                            struct efi_system_table *st,\n>> -                         asmlinkage ulong (*entry)(void *image_handle,\n>> +                         EFIAPI ulong (*entry)(void *image_handle,\n>>                                  struct efi_system_table *st))\n>>   {\n>>          efi_status_t ret = EFI_LOAD_ERROR;\n>> diff --git a/include/efi.h b/include/efi.h\n>> index 04e83220b4..47c2c8f398 100644\n>> --- a/include/efi.h\n>> +++ b/include/efi.h\n>> @@ -19,7 +19,7 @@\n>>   #include <linux/string.h>\n>>   #include <linux/types.h>\n>>\n>> -#ifdef CONFIG_EFI_STUB_64BIT\n>> +#if defined(CONFIG_EFI_STUB_64BIT) || defined(CONFIG_SANDBOX)\n> \n> btw, maybe we should have CONFIG_SANDBOX_$arch somehow so we don't\n> have to assume SANDBOX==X86 (but I guess at least just having\n> efi_loader work in sandbox on x86 is a nice first step)\n\nAh, sorry, read that too late. I use aarch64 systems productively these \ndays, so I would certainly prefer if we could not block ourselves in on \nany x86_64 host dependency - even if it's just for make test :)\n\nAlex","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwz0Q1gLyz9s7m\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 19 Sep 2017 06:59:50 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D18CAC21D7E; Mon, 18 Sep 2017 20:59:37 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id BAEF0C21C34;\n\tMon, 18 Sep 2017 20:59:34 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 30C47C21C34; Mon, 18 Sep 2017 20:59:33 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby lists.denx.de (Postfix) with ESMTPS id E3E88C21C2B\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 20:59:32 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id AEC2AABB4;\n\tMon, 18 Sep 2017 20:59:32 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","To":"Rob Clark <robdclark@gmail.com>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>","References":"<20170918174801.31792-1-robdclark@gmail.com>\n\t<CAF6AEGu_2MQVdQ51pLj+208drZ-zJNQyegbNtKbrDVC9vKkutw@mail.gmail.com>","From":"Alexander Graf <agraf@suse.de>","Message-ID":"<a12294c4-2c60-24c2-c894-7a6de70d523f@suse.de>","Date":"Mon, 18 Sep 2017 22:59:29 +0200","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<CAF6AEGu_2MQVdQ51pLj+208drZ-zJNQyegbNtKbrDVC9vKkutw@mail.gmail.com>","Content-Language":"en-US","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1774363,"web_url":"http://patchwork.ozlabs.org/comment/1774363/","msgid":"<CAPnjgZ2af-udQvjxqWhGvFvarcbz4PMyHEJO_quvync8GdxiCg@mail.gmail.com>","list_archive_url":null,"date":"2017-09-25T02:12:55","subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 18 September 2017 at 11:47, Rob Clark <robdclark@gmail.com> wrote:\n> This is needed to run 'bootefi' from sandbox.  I suspect StartImage()\n> must have been broken too on x86.\n>\n> Signed-off-by: Rob Clark <robdclark@gmail.com>\n> ---\n>  cmd/bootefi.c                 | 2 +-\n>  include/efi.h                 | 2 +-\n>  lib/efi_loader/efi_boottime.c | 2 +-\n>  3 files changed, 3 insertions(+), 3 deletions(-)\n\nReviewed-by: Simon Glass <sjg@chromium.org>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"p9/Rkmin\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"S0SUv/Eh\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0p9s2MXvz9t30\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 12:36:17 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 2321CC22187; Mon, 25 Sep 2017 02:20:55 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id C94FDC22170;\n\tMon, 25 Sep 2017 02:20:53 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 23449C221A2; Mon, 25 Sep 2017 02:13:21 +0000 (UTC)","from mail-qt0-f182.google.com (mail-qt0-f182.google.com\n\t[209.85.216.182])\n\tby lists.denx.de (Postfix) with ESMTPS id B2D9BC21C45\n\tfor <u-boot@lists.denx.de>; Mon, 25 Sep 2017 02:13:17 +0000 (UTC)","by mail-qt0-f182.google.com with SMTP id x54so5528578qth.12\n\tfor <u-boot@lists.denx.de>; Sun, 24 Sep 2017 19:13:17 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:12:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Y7pKpa28LjGF0f1/mPKSrbHe0D7+r4dc4F8J65NaGLY=;\n\tb=p9/RkminqIagMInETKwSLO0n4F0+FZE4dXdK/PthhNpypOBR5RbfEe5HaP9nDoFYVE\n\tJvKcDTxcMXst4kl1NEdjMPYrzXfTXYe9FxD+XtfSjixmIUBov7btTBE7QtM+Oregtnni\n\tG6cHJjWM3VPErcKXctGjzUJxZH8UlS+vQNTj2AtEskneoclI3PzaOo7L1H4czKo9mBr4\n\tL3qqOPdZ8pCEMMGci/kBHALl08tc0G2i9NXHegB2u8q0hEAKcRIUn+k3RLgl1xHS7EdL\n\tvBKOsc3hJpKA1MT7bFyeTxE5OQyHqjkCPRft6voAR0yXybew/dh19R4tPVMFR5BINiax\n\tTRtQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=Y7pKpa28LjGF0f1/mPKSrbHe0D7+r4dc4F8J65NaGLY=;\n\tb=S0SUv/EhYgMO1cXdpU1yOO07Dkm3MSnl0ft/bXQgIb2WCrfcPs0PJtKhCbqhv5/Sz+\n\tDUBCfYGl0mBAAXejkWkrYjfuz2zq4RWen6UBzYB7JVuYT0ruzX+tpWBDfsn/EQxLWhBk\n\t2VQ6WUAupYMqrFU/f521UnizRDse0Jd+90UYY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Y7pKpa28LjGF0f1/mPKSrbHe0D7+r4dc4F8J65NaGLY=;\n\tb=JlBpXjgwKKUD6hJ5Bg7NiPgKslvmCETDsuK8Cg5nPNHRxm1nSy0PM64KuzopQZCxsK\n\t1+EPGiKlxYBoSbNbCpUgX8viQtQLF2revjgTmMplieherSCAV2hdXPDtT7nYoYMFGU/N\n\tUdwideNL8GgJn4UfgBeflYVDYzdNigi/ROUBwc2xIK5AfhL3ZaIU8/Nwn483MOkS6CLs\n\tRwAQwDGqU4ZvpOFF7XSJdSXfpUkRcrnJH91ohl5tpa1+faqZa97vZuCQWKMgePwiy+wg\n\tyW5meHQWqvhzDyP4iXfq5nNGZP771rQdkoJtBhdxh2ZI2o8/8DXPOY7Fwk3p1GciVOLB\n\tZ8Kg==","X-Gm-Message-State":"AHPjjUjoE8sznd6mbIG6W2i3Ni4EvipweXmWZ3K4T44L3VWJIqljKMdm\n\tN1mn03h8dGgC+1es5WSfnJDvsnxFsG2AZ+2APMOShQ==","X-Google-Smtp-Source":"AOwi7QDO+1w/5EobvNEqsPlE1FMwxD9qo0UjB0wup74hGLeay3+GI6kl9G7E/0bqD/vD+b6yG2gV18T2pdydKJdvptY=","X-Received":"by 10.200.52.241 with SMTP id x46mr9271238qtb.38.1506305596496; \n\tSun, 24 Sep 2017 19:13:16 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918174801.31792-1-robdclark@gmail.com>","References":"<20170918174801.31792-1-robdclark@gmail.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Sun, 24 Sep 2017 22:12:55 -0400","X-Google-Sender-Auth":"MA_N3fJehN6n430nAu_nPpGQgKI","Message-ID":"<CAPnjgZ2af-udQvjxqWhGvFvarcbz4PMyHEJO_quvync8GdxiCg@mail.gmail.com>","To":"Rob Clark <robdclark@gmail.com>","Cc":"U-Boot Mailing List <u-boot@lists.denx.de>,\n\tHeinrich Schuchardt <xypron.glpk@gmx.de>","Subject":"Re: [U-Boot] [PATCH] efi_loader: EFI entry point should be EFIAPI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]