[{"id":1770441,"web_url":"http://patchwork.ozlabs.org/comment/1770441/","msgid":"<17bc270e-9cc1-485a-d6bb-0ebfa143e65e@cogentembedded.com>","list_archive_url":null,"date":"2017-09-18T19:29:51","subject":"Re: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","submitter":{"id":22564,"url":"http://patchwork.ozlabs.org/api/people/22564/","name":"Sergei Shtylyov","email":"sergei.shtylyov@cogentembedded.com"},"content":"Hello!\n\nOn 09/19/2017 01:02 AM, Nisar Sayed wrote:\n\n> Allow EEPROM write for less than MAX_EEPROM_SIZE\n> \n> Fixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet device driver\")\n> Signed-off-by: Nisar Sayed \n> ---\n> drivers/net/usb/lan78xx.c | 9 ++++-----\n> 1 file changed, 4 insertions(+), 5 deletions(-)\n> \n> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\n> index fcf85ae37435..3292f56ffe02 100644\n> --- a/drivers/net/usb/lan78xx.c\n> +++ b/drivers/net/usb/lan78xx.c\n> @@ -1290,11 +1290,10 @@ static int lan78xx_ethtool_set_eeprom(struct net_device *netdev,\n> \tif (ret)\n> \t\treturn ret;\n> \n> -\t/* Allow entire eeprom update only */\n> -\tif ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\n> -\t (ee->offset == 0) &&\n> -\t (ee->len == 512) &&\n> -\t (data[0] == EEPROM_INDICATOR))\n> +\t/* Invalid EEPROM_INDICATOR at offset zero will result in fail to\n\n s/fail/a failure/.\n\n> +\t * load data from EEPROM\n> +\t */\n> +\tif (ee->magic == LAN78XX_EEPROM_MAGIC)\n> \t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len, data);\n> \telse if ((ee->magic == LAN78XX_OTP_MAGIC) &&\n> \t\t (ee->offset == 0) &&\n> \n\nMBR, Sergei","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=cogentembedded-com.20150623.gappssmtp.com\n\theader.i=@cogentembedded-com.20150623.gappssmtp.com\n\theader.b=\"WQm0waGo\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwx0n2BVmz9s83\n\tfor ;\n\tTue, 19 Sep 2017 05:30:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751578AbdIRT37 (ORCPT );\n\tMon, 18 Sep 2017 15:29:59 -0400","from mail-lf0-f42.google.com ([209.85.215.42]:54467 \"EHLO\n\tmail-lf0-f42.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750872AbdIRT3z (ORCPT\n\t); Mon, 18 Sep 2017 15:29:55 -0400","by mail-lf0-f42.google.com with SMTP id k23so1582610lfi.11\n\tfor ; Mon, 18 Sep 2017 12:29:54 -0700 (PDT)","from wasted.cogentembedded.com ([31.173.81.185])\n\tby smtp.gmail.com with ESMTPSA id\n\t63sm1574839lfz.92.2017.09.18.12.29.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 12:29:52 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cogentembedded-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:organization:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=3qv0W1SZVDddVK5RAN4iqwsF07prL7HFUvzM9mGsHnM=;\n\tb=WQm0waGoXrpNgKMQlUOKd/O+PAhYspjjwZQa4eG7ZTa0dE0mFAPOQaksMjFVPSlRLZ\n\tPBC4oSdaBEk9wnygXkNCNvsnM2SLiPa2JtTf2X4Q94ZxRxMRSVH8rxDtowMtfHr1XLB7\n\t42cz+YKBYaEFDmXOPXQuwwd7rmxzxn6sqjDg0nvDYPyafDj0QPLQlrULMTukBxOhNjeo\n\t3wDRmUJckEe/FwSF76l32QNw3nhM0pl9VgYyB208ex2LuwwSMbxgRRXJGpNJW3j68pI4\n\tbnisiO+b+ARzBkPyk7/76xyGCWEiRlwyz/aIHd8m9IflXY7gYkvO+Nt8Jsyr4oj/m6/F\n\tNfTg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=3qv0W1SZVDddVK5RAN4iqwsF07prL7HFUvzM9mGsHnM=;\n\tb=f3geEyJbkr19xOeaThkJIlTzBX0BY6o4NHznoTaGs5Tv39Oez/lJJb+nNAMBml8wa3\n\tCATOjtHNJ7JqLDt5x6Vkadb0ckrZpQxfYeSn63Yhupy5DynpwUSN3KR6m/zFSPbBh97W\n\tJXM2SAY2OX9doN4ZqjB8ploAo9yUrmC2CNRFAmsmfp0OkGrTXsmMDfVT/GfrT4CEKhZO\n\t/CZ+7CrcOE1kwbdv2EfMK+3d/XQDRsqotuSUlrAKHTQc75DHkkDu5gcH18dUhe3gVqvj\n\tgynamPr35NdGBWTknI5jIc3v6WLmhfX6TK1KVDK8WbmTbdMoXAbrV2iRuMyGvICEy292\n\tX1SA==","X-Gm-Message-State":"AHPjjUjoFC0a0MJy4Ix6b9/YVVst5cH76uulCIPQRayztMT0IhCAONFT\n\tqhk4ZvPwjCLU6cZlhruKow==","X-Google-Smtp-Source":"AOwi7QC//CMy6RxHcVzkMvfECcMh4tx9lcEhDPGt0AnxETRgHi+faYVKbu3J/6QJP+laysT5DF/s+A==","X-Received":"by 10.46.34.194 with SMTP id i185mr6998189lji.45.1505762993675; \n\tMon, 18 Sep 2017 12:29:53 -0700 (PDT)","Subject":"Re: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","To":"Nisar Sayed , davem@davemloft.net","Cc":"UNGLinuxDriver@microchip.com, netdev@vger.kernel.org","References":"<20170918220225.3767-1-Nisar.Sayed@microchip.com>\n\t<20170918220225.3767-3-Nisar.Sayed@microchip.com>","From":"Sergei Shtylyov ","Organization":"Cogent Embedded","Message-ID":"<17bc270e-9cc1-485a-d6bb-0ebfa143e65e@cogentembedded.com>","Date":"Mon, 18 Sep 2017 22:29:51 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170918220225.3767-3-Nisar.Sayed@microchip.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-MW","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1771983,"web_url":"http://patchwork.ozlabs.org/comment/1771983/","msgid":"","list_archive_url":null,"date":"2017-09-20T15:27:14","subject":"RE: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","submitter":{"id":71648,"url":"http://patchwork.ozlabs.org/api/people/71648/","name":"Nisar Sayed","email":"Nisar.Sayed@microchip.com"},"content":"Thanks Sergei, I will update it and submit next version.\r\n\r\n- Nisar\r\n\r\n > Hello!\r\n> \r\n> On 09/19/2017 01:02 AM, Nisar Sayed wrote:\r\n> \r\n> > Allow EEPROM write for less than MAX_EEPROM_SIZE\r\n> >\r\n> > Fixes: 55d7de9de6c3 (\"Microchip's LAN7800 family USB 2/3 to\r\n> > 10/100/1000 Ethernet device driver\")\r\n> > Signed-off-by: Nisar Sayed \r\n> > ---\r\n> > drivers/net/usb/lan78xx.c | 9 ++++-----\r\n> > 1 file changed, 4 insertions(+), 5 deletions(-)\r\n> >\r\n> > diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c\r\n> > index fcf85ae37435..3292f56ffe02 100644\r\n> > --- a/drivers/net/usb/lan78xx.c\r\n> > +++ b/drivers/net/usb/lan78xx.c\r\n> > @@ -1290,11 +1290,10 @@ static int lan78xx_ethtool_set_eeprom(struct\r\n> net_device *netdev,\r\n> > \tif (ret)\r\n> > \t\treturn ret;\r\n> >\r\n> > -\t/* Allow entire eeprom update only */\r\n> > -\tif ((ee->magic == LAN78XX_EEPROM_MAGIC) &&\r\n> > -\t (ee->offset == 0) &&\r\n> > -\t (ee->len == 512) &&\r\n> > -\t (data[0] == EEPROM_INDICATOR))\r\n> > +\t/* Invalid EEPROM_INDICATOR at offset zero will result in fail to\r\n> \r\n> s/fail/a failure/.\r\n> \r\n> > +\t * load data from EEPROM\r\n> > +\t */\r\n> > +\tif (ee->magic == LAN78XX_EEPROM_MAGIC)\r\n> > \t\tret = lan78xx_write_raw_eeprom(dev, ee->offset, ee->len,\r\n> data);\r\n> > \telse if ((ee->magic == LAN78XX_OTP_MAGIC) &&\r\n> > \t\t (ee->offset == 0) &&\r\n> >\r\n> \r\n> MBR, Sergei","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xy3Wq4nzCz9s8J\n\tfor ;\n\tThu, 21 Sep 2017 01:27:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751636AbdITP1R (ORCPT );\n\tWed, 20 Sep 2017 11:27:17 -0400","from esa2.microchip.iphmx.com ([68.232.149.84]:15989 \"EHLO\n\tesa2.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751408AbdITP1Q (ORCPT\n\t); Wed, 20 Sep 2017 11:27:16 -0400","from exsmtp02.microchip.com (HELO email.microchip.com)\n\t([198.175.253.38])\n\tby esa2.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t20 Sep 2017 08:27:15 -0700","from CHN-SV-EXMX03.mchp-main.com ([fe80::58f5:b949:4b1:3df4]) by\n\tCHN-SV-EXCH02.mchp-main.com ([::1]) with mapi id 14.03.0352.000;\n\tWed, 20 Sep 2017 08:27:15 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,421,1500966000\"; d=\"scan'208\";a=\"7151127\"","From":"","To":", ","CC":", ","Subject":"RE: [PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Topic":"[PATCH v4 net 2/3] lan78xx: Allow EEPROM write for less than\n\tMAX_EEPROM_SIZE","Thread-Index":"AQHTMJzBvn1lpxxXWEqNJwwc+cq2nKK7fR2AgAJrOLA=","Date":"Wed, 20 Sep 2017 15:27:14 +0000","Message-ID":"","References":"<20170918220225.3767-1-Nisar.Sayed@microchip.com>\n\t<20170918220225.3767-3-Nisar.Sayed@microchip.com>\n\t<17bc270e-9cc1-485a-d6bb-0ebfa143e65e@cogentembedded.com>","In-Reply-To":"<17bc270e-9cc1-485a-d6bb-0ebfa143e65e@cogentembedded.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.215.90]","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]