[{"id":1770463,"web_url":"http://patchwork.ozlabs.org/comment/1770463/","msgid":"<651594b8-0d18-fd61-f0e9-287ad098306d@redhat.com>","list_archive_url":null,"date":"2017-09-18T20:00:48","subject":"Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and\n\tRESET interrupts for TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"> static void cpu_inject_io(S390CPU *cpu, uint16_t subchannel_id,\n> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c\n> index ce8fda9d01..521dcc75f3 100644\n> --- a/target/s390x/sigp.c\n> +++ b/target/s390x/sigp.c\n> @@ -498,6 +498,7 @@ void do_stop_interrupt(CPUS390XState *env)\n> s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);\n> }\n> env->sigp_order = 0;\n> + env->pending_int &= ~INTERRUPT_STOP;\n\nThe *awesome* kvm-unit-tests (yes, the single sigp_stop() we do when\nshutting down) just found a missing cpu_loop_exit()\n\ndiff --git a/target/s390x/sigp.c b/target/s390x/sigp.c\nindex ce8fda9d01..9aadc3ffdd 100644\n--- a/target/s390x/sigp.c\n+++ b/target/s390x/sigp.c\n@@ -498,6 +498,11 @@ void do_stop_interrupt(CPUS390XState *env)\n s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);\n }\n env->sigp_order = 0;\n+ env->pending_int &= ~INTERRUPT_STOP;\n+#ifdef CONFIG_TCG\n+ /* the CPU has been stopped, we must immediately go out of the loop */\n+ cpu_loop_exit(CPU(s390_env_get_cpu(env)));\n+#endif\n }\n\n\n> }\n> \n> void s390_init_sigp(void)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwxsS5PCNz9s7v\n\tfor ;\n\tTue, 19 Sep 2017 06:08:43 +1000 (AEST)","from localhost ([::1]:38713 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du2LQ-0003sL-SK\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 16:08:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42644)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du2Dw-0006mA-Cf\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:00:57 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du2Dt-0003u8-8r\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:00:56 -0400","from mx1.redhat.com ([209.132.183.28]:44464)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du2Dt-0003tV-2E\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:00:53 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C6E4F806D6;\n\tMon, 18 Sep 2017 20:00:51 +0000 (UTC)","from [10.36.116.100] (ovpn-116-100.ams2.redhat.com [10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5FCA95D97B;\n\tMon, 18 Sep 2017 20:00:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C6E4F806D6","To":"qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-24-david@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<651594b8-0d18-fd61-f0e9-287ad098306d@redhat.com>","Date":"Mon, 18 Sep 2017 22:00:48 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-24-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 18 Sep 2017 20:00:52 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and\n\tRESET interrupts for TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770470,"web_url":"http://patchwork.ozlabs.org/comment/1770470/","msgid":"<17cdabba-97ac-50b0-678d-e48ff903553e@redhat.com>","list_archive_url":null,"date":"2017-09-18T20:21:41","subject":"Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and\n\tRESET interrupts for TCG","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 18.09.2017 22:00, David Hildenbrand wrote:\n> \n>> static void cpu_inject_io(S390CPU *cpu, uint16_t subchannel_id,\n>> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c\n>> index ce8fda9d01..521dcc75f3 100644\n>> --- a/target/s390x/sigp.c\n>> +++ b/target/s390x/sigp.c\n>> @@ -498,6 +498,7 @@ void do_stop_interrupt(CPUS390XState *env)\n>> s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);\n>> }\n>> env->sigp_order = 0;\n>> + env->pending_int &= ~INTERRUPT_STOP;\n> \n> The *awesome* kvm-unit-tests (yes, the single sigp_stop() we do when\n> shutting down) just found a missing cpu_loop_exit()\n> \n> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c\n> index ce8fda9d01..9aadc3ffdd 100644\n> --- a/target/s390x/sigp.c\n> +++ b/target/s390x/sigp.c\n> @@ -498,6 +498,11 @@ void do_stop_interrupt(CPUS390XState *env)\n> s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);\n> }\n> env->sigp_order = 0;\n> + env->pending_int &= ~INTERRUPT_STOP;\n> +#ifdef CONFIG_TCG\n> + /* the CPU has been stopped, we must immediately go out of the loop */\n> + cpu_loop_exit(CPU(s390_env_get_cpu(env)));\n> +#endif\n> }\n> \n\nif (tcg_enabled()) of course ...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwy995QR2z9s78\n\tfor ;\n\tTue, 19 Sep 2017 06:22:20 +1000 (AEST)","from localhost ([::1]:38765 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du2Yc-0007gI-0W\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 16:22:18 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50567)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du2YE-0007fz-7c\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:21:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du2Y5-0004OK-Lt\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:21:49 -0400","from mx1.redhat.com ([209.132.183.28]:49592)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du2Y5-0004Mj-Fa\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 16:21:45 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4A1D461498;\n\tMon, 18 Sep 2017 20:21:44 +0000 (UTC)","from [10.36.116.100] (ovpn-116-100.ams2.redhat.com [10.36.116.100])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 29BC45D972;\n\tMon, 18 Sep 2017 20:21:41 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4A1D461498","From":"David Hildenbrand ","To":"qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-24-david@redhat.com>\n\t<651594b8-0d18-fd61-f0e9-287ad098306d@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<17cdabba-97ac-50b0-678d-e48ff903553e@redhat.com>","Date":"Mon, 18 Sep 2017 22:21:41 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<651594b8-0d18-fd61-f0e9-287ad098306d@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tMon, 18 Sep 2017 20:21:44 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 23/27] s390x/tcg: implement STOP and\n\tRESET interrupts for TCG","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]