[{"id":1774630,"web_url":"http://patchwork.ozlabs.org/comment/1774630/","msgid":"<d1e53b94-8545-5db0-d4e9-58b5ce5fef1f@redhat.com>","list_archive_url":null,"date":"2017-09-25T10:22:56","subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 18.09.2017 17:59, David Hildenbrand wrote:\n> This will now also detect crashes under TCG. We can directly use\n> cpu->env.psw.addr instead of kvm_run, as we do a\n> cpu_synchronize_state().\n> \n> Signed-off-by: David Hildenbrand <david@redhat.com>\n> ---\n>  target/s390x/helper.c   | 28 ++++++++++++++++++++++------\n>  target/s390x/internal.h |  1 +\n>  target/s390x/kvm.c      | 15 +--------------\n>  3 files changed, 24 insertions(+), 20 deletions(-)\n> \n> diff --git a/target/s390x/helper.c b/target/s390x/helper.c\n> index e22b93258b..75ceb0bf2b 100644\n> --- a/target/s390x/helper.c\n> +++ b/target/s390x/helper.c\n> @@ -26,6 +26,7 @@\n>  #include \"qemu/timer.h\"\n>  #include \"exec/exec-all.h\"\n>  #include \"hw/s390x/ioinst.h\"\n> +#include \"sysemu/hw_accel.h\"\n>  #ifndef CONFIG_USER_ONLY\n>  #include \"sysemu/sysemu.h\"\n>  #endif\n> @@ -113,6 +114,26 @@ hwaddr s390_cpu_get_phys_addr_debug(CPUState *cs, vaddr vaddr)\n>      return phys_addr;\n>  }\n>  \n> +static inline bool is_special_wait_psw(uint64_t psw_addr)\n> +{\n> +    /* signal quiesce */\n> +    return psw_addr == 0xfffUL;\n> +}\n> +\n> +void handle_wait(S390CPU *cpu)\n\n\"handle_wait\" is a very generic name ... could you maybe at least name\nthis \"s390x_handle_wait\" or so?\n\n> +{\n> +    cpu_synchronize_state(CPU(cpu));\n> +    if (s390_cpu_halt(cpu) == 0) {\n> +#ifndef CONFIG_USER_ONLY\n> +        if (is_special_wait_psw(cpu->env.psw.addr)) {\n> +            qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);\n> +        } else {\n> +            qemu_system_guest_panicked(NULL);\n> +        }\n> +#endif\n> +    }\n> +}\n> +\n>  void load_psw(CPUS390XState *env, uint64_t mask, uint64_t addr)\n>  {\n>      uint64_t old_mask = env->psw.mask;\n> @@ -128,12 +149,7 @@ void load_psw(CPUS390XState *env, uint64_t mask, uint64_t addr)\n>      }\n>  \n>      if (mask & PSW_MASK_WAIT) {\n> -        S390CPU *cpu = s390_env_get_cpu(env);\n> -        if (s390_cpu_halt(cpu) == 0) {\n> -#ifndef CONFIG_USER_ONLY\n> -            qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);\n> -#endif\n> -        }\n> +        handle_wait(s390_env_get_cpu(env));\n>      }\n>  }\n>  \n> diff --git a/target/s390x/internal.h b/target/s390x/internal.h\n> index 15743ec40f..cb331f35ea 100644\n> --- a/target/s390x/internal.h\n> +++ b/target/s390x/internal.h\n> @@ -280,6 +280,7 @@ const char *cc_name(enum cc_op cc_op);\n>  void load_psw(CPUS390XState *env, uint64_t mask, uint64_t addr);\n>  uint32_t calc_cc(CPUS390XState *env, uint32_t cc_op, uint64_t src, uint64_t dst,\n>                   uint64_t vr);\n> +void handle_wait(S390CPU *cpu);\n>  \n>  \n>  /* cpu.c */\n> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\n> index 3f9983154f..14f864697d 100644\n> --- a/target/s390x/kvm.c\n> +++ b/target/s390x/kvm.c\n> @@ -1936,12 +1936,6 @@ static int handle_instruction(S390CPU *cpu, struct kvm_run *run)\n>      return r;\n>  }\n>  \n> -static bool is_special_wait_psw(CPUState *cs)\n> -{\n> -    /* signal quiesce */\n> -    return cs->kvm_run->psw_addr == 0xfffUL;\n> -}\n> -\n>  static void unmanageable_intercept(S390CPU *cpu, const char *str, int pswoffset)\n>  {\n>      CPUState *cs = CPU(cpu);\n> @@ -2012,14 +2006,7 @@ static int handle_intercept(S390CPU *cpu)\n>              break;\n>          case ICPT_WAITPSW:\n>              /* disabled wait, since enabled wait is handled in kernel */\n> -            cpu_synchronize_state(cs);\n\nMaybe we should rather keep the cpu_synchronize_state() here instead of\nputting it in helper.c? No other function in helper.c seems to call that\non its own yet...\n\n> -            if (s390_cpu_halt(cpu) == 0) {\n> -                if (is_special_wait_psw(cs)) {\n> -                    qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);\n> -                } else {\n> -                    qemu_system_guest_panicked(NULL);\n> -                }\n> -            }\n> +            handle_wait(cpu);\n>              r = EXCP_HALTED;\n>              break;\n>          case ICPT_CPU_STOP:\n> \n\n Thomas","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y10YH282kz9tX3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 25 Sep 2017 20:23:42 +1000 (AEST)","from localhost ([::1]:41614 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwQY7-0004rG-8n\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:23:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46203)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1dwQXc-0004qx-PN\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:23:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1dwQXZ-0003Qg-5R\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:23:08 -0400","from mx1.redhat.com ([209.132.183.28]:38916)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1dwQXY-0003QS-SM\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:23:05 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9152561475;\n\tMon, 25 Sep 2017 10:23:03 +0000 (UTC)","from [10.36.117.66] (ovpn-117-66.ams2.redhat.com [10.36.117.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id F2E48709E0;\n\tMon, 25 Sep 2017 10:22:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9152561475","To":"David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-10-david@redhat.com>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<d1e53b94-8545-5db0-d4e9-58b5ce5fef1f@redhat.com>","Date":"Mon, 25 Sep 2017 12:22:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-10-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tMon, 25 Sep 2017 10:23:03 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, cohuck@redhat.com, Richard\n\tHenderson <richard.henderson@linaro.org>, \n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com, Igor Mammedov\n\t<imammedo@redhat.com>, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t<alex.bennee@linaro.org>, \tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775031,"web_url":"http://patchwork.ozlabs.org/comment/1775031/","msgid":"<1ca3bf22-aa0d-edc4-296c-6bb827791e95@linaro.org>","list_archive_url":null,"date":"2017-09-25T23:23:06","subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n> This will now also detect crashes under TCG. We can directly use\n> cpu->env.psw.addr instead of kvm_run, as we do a\n> cpu_synchronize_state().\n> \n> Signed-off-by: David Hildenbrand <david@redhat.com>\n> ---\n>  target/s390x/helper.c   | 28 ++++++++++++++++++++++------\n>  target/s390x/internal.h |  1 +\n>  target/s390x/kvm.c      | 15 +--------------\n>  3 files changed, 24 insertions(+), 20 deletions(-)\n\nReviewed-by: Richard Henderson <richard.henderson@linaro.org>\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"U5XvZdQF\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1KzT0mZXz9t3Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 09:29:09 +1000 (AEST)","from localhost ([::1]:44754 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwcoF-0005Sg-8n\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:29:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44913)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwciX-0001pf-Vj\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:23:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwciU-0003Ek-1Y\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:23:13 -0400","from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235]:43770)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dwciT-0003EZ-SK\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:23:09 -0400","by mail-pg0-x235.google.com with SMTP id u18so4892940pgo.0\n\tfor <qemu-devel@nongnu.org>; Mon, 25 Sep 2017 16:23:09 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tb75sm16229936pfc.29.2017.09.25.16.23.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:23:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=xPfujimhlxf5nbb57h0Wk4ro0GWTsABzPnKq3g4T4EI=;\n\tb=U5XvZdQFB46i0GDKB5irkJbd+03u8PYc9QWDtJ8HvJWIYQi/CMCMd0WpEk7V+mhCrd\n\tZ1XvidG1sxOZTXGKDO7M7/2yHAdu7V7dfurLgenF6ydrn4f3XlqQl7w6pUO2AmSwU4ER\n\ttq0eg2UT+oAJCNyT8dKv2rHFG4tJdrSfPsrm4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=xPfujimhlxf5nbb57h0Wk4ro0GWTsABzPnKq3g4T4EI=;\n\tb=Qsmf1bjR3yZdM/58VQRtlphqyXoa6B3lvTelWdVsmFUynvZcTPLOXfz2be+L8nLFIz\n\tfOz8oA4P7a5woyOJfOndthMI37idd/LaQa0BuY2qW60HRmKnvA0sMQO13HAtGud9zQ6/\n\tlIR9DQTLAYvYQ73QfIiJOohmQKkzHhacbRHRBg6b1OSg5AINJqNaDJUjYqNR8l3UMl0H\n\tjSX3Qirgxz64lR4yfL6+i2dsz9awYLOUDbUN1WYUhiQurvflcODrYVPDLhmdZu/pYvnQ\n\teLan6dmPaMYIADZDC7EJF28Spi2p+QQy6MATPmYfNvpxUG2/4vGu4MyOprGfoE9WOXuH\n\tjxyg==","X-Gm-Message-State":"AHPjjUgMLgGpMA3MneI53YuYxxjuCgjr1dlIlPfy3SsNmOBvjCYgJG54\n\tio4K2J7QIptZgptA/2MJxFld9Q==","X-Google-Smtp-Source":"AOwi7QAlbkhwTf+xWdmP46Pvmnld8h/+Vi55MzE8NZIewRQsgXGxop1keRn2WdNvPkZjHDDuA9icTg==","X-Received":"by 10.99.126.84 with SMTP id o20mr9191204pgn.139.1506381789069; \n\tMon, 25 Sep 2017 16:23:09 -0700 (PDT)","To":"David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-10-david@redhat.com>","From":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<1ca3bf22-aa0d-edc4-296c-6bb827791e95@linaro.org>","Date":"Mon, 25 Sep 2017 16:23:06 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-10-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::235","Subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf <agraf@suse.de>, \n\tborntraeger@de.ibm.com, Igor Mammedov <imammedo@redhat.com>, \n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775463,"web_url":"http://patchwork.ozlabs.org/comment/1775463/","msgid":"<f1006d03-c175-f057-49ae-122d1fd1480c@redhat.com>","list_archive_url":null,"date":"2017-09-26T13:04:23","subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":">> +\n>> +void handle_wait(S390CPU *cpu)\n> \n> \"handle_wait\" is a very generic name ... could you maybe at least name\n> this \"s390x_handle_wait\" or so?\n\nsure, will do, thanks!\n\n> \n>> +{\n>> +    cpu_synchronize_state(CPU(cpu));\n>> +    if (s390_cpu_halt(cpu) == 0) {\n>> +#ifndef CONFIG_USER_ONLY\n>> +        if (is_special_wait_psw(cpu->env.psw.addr)) {\n>> +            qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);\n>> +        } else {\n>> +            qemu_system_guest_panicked(NULL);\n>> +        }\n>> +#endif\n>> +    }\n>> +}\n[...]\n\n>> -            cpu_synchronize_state(cs);\n> \n> Maybe we should rather keep the cpu_synchronize_state() here instead of\n> putting it in helper.c? No other function in helper.c seems to call that\n> on its own yet...\n\nDon't have a strong opinion on this, as long as it works :)\n\n> \n>> -            if (s390_cpu_halt(cpu) == 0) {\n>> -                if (is_special_wait_psw(cs)) {\n>> -                    qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);\n>> -                } else {\n>> -                    qemu_system_guest_panicked(NULL);\n>> -                }\n>> -            }\n>> +            handle_wait(cpu);\n>>              r = EXCP_HALTED;\n>>              break;\n>>          case ICPT_CPU_STOP:\n>>\n> \n>  Thomas\n>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1h5J1CrQz9tXj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 23:05:24 +1000 (AEST)","from localhost ([::1]:47486 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwpYA-0003Z4-82\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 09:05:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38974)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwpXN-0003UX-1H\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:39 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwpXI-0006W8-30\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:33 -0400","from mx1.redhat.com ([209.132.183.28]:35492)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dwpXH-0006Vm-U3\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 09:04:28 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C5019D7159;\n\tTue, 26 Sep 2017 13:04:26 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6C6AF6C422;\n\tTue, 26 Sep 2017 13:04:24 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C5019D7159","To":"Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-10-david@redhat.com>\n\t<d1e53b94-8545-5db0-d4e9-58b5ce5fef1f@redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<f1006d03-c175-f057-49ae-122d1fd1480c@redhat.com>","Date":"Tue, 26 Sep 2017 15:04:23 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<d1e53b94-8545-5db0-d4e9-58b5ce5fef1f@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 26 Sep 2017 13:04:26 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 09/27] target/s390x: factor out handling\n\tof WAIT PSW into handle_wait()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, cohuck@redhat.com, Richard\n\tHenderson <richard.henderson@linaro.org>, \n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com, Igor Mammedov\n\t<imammedo@redhat.com>, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t<alex.bennee@linaro.org>, \tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]