[{"id":1774632,"web_url":"http://patchwork.ozlabs.org/comment/1774632/","msgid":"<05125361-7f19-20c5-0a83-c4b2ff1f12fe@redhat.com>","list_archive_url":null,"date":"2017-09-25T10:27:33","subject":"Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into\n\thandle_sigp()","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 18.09.2017 17:59, David Hildenbrand wrote:\n> No need to pass kvm_run.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/kvm.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c\n> index 14f864697d..da3f7e9895 100644\n> --- a/target/s390x/kvm.c\n> +++ b/target/s390x/kvm.c\n> @@ -1852,7 +1852,7 @@ static int sigp_set_architecture(S390CPU *cpu, uint32_t param,\n> return SIGP_CC_STATUS_STORED;\n> }\n> \n> -static int handle_sigp(S390CPU *cpu, struct kvm_run *run, uint8_t ipa1)\n> +static int handle_sigp(S390CPU *cpu, uint32_t ipb, uint8_t ipa1)\n\nMaybe order the parameters alphabetically now? I.e. first ipa, then ipb?\n\nAnyway, feel free to add my:\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y10fM0fh9z9tX3\n\tfor ;\n\tMon, 25 Sep 2017 20:28:11 +1000 (AEST)","from localhost ([::1]:41641 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwQcT-0008Cx-80\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:28:09 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47432)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwQc3-00088g-Bs\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:27:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwQc0-0005eT-IV\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:27:43 -0400","from mx1.redhat.com ([209.132.183.28]:41072)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwQc0-0005cf-CV\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:27:40 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 53AEAC047B7B;\n\tMon, 25 Sep 2017 10:27:39 +0000 (UTC)","from [10.36.117.66] (ovpn-117-66.ams2.redhat.com [10.36.117.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 0CC006BC37;\n\tMon, 25 Sep 2017 10:27:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 53AEAC047B7B","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-11-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<05125361-7f19-20c5-0a83-c4b2ff1f12fe@redhat.com>","Date":"Mon, 25 Sep 2017 12:27:33 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-11-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 25 Sep 2017 10:27:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into\n\thandle_sigp()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , cohuck@redhat.com, Richard\n\tHenderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775029,"web_url":"http://patchwork.ozlabs.org/comment/1775029/","msgid":"<2625fc95-3120-d564-92a3-b3e9e9cdfa95@linaro.org>","list_archive_url":null,"date":"2017-09-25T23:24:42","subject":"Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into\n\thandle_sigp()","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n> No need to pass kvm_run.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/kvm.c | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Y2ITNadS\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Kwv0Wdlz9t3Z\n\tfor ;\n\tTue, 26 Sep 2017 09:26:55 +1000 (AEST)","from localhost ([::1]:44743 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwcm5-0003tK-6B\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:26:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45445)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwck6-0002qF-T9\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:24:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwck2-00042s-V0\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:24:50 -0400","from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:50946)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwck2-00042X-OR\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:24:46 -0400","by mail-pf0-x22d.google.com with SMTP id m63so4601770pfk.7\n\tfor ; Mon, 25 Sep 2017 16:24:46 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\ty72sm9469944pfa.129.2017.09.25.16.24.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:24:44 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=sNbtpJUKQk14wY3Il6+AQaOTeirjOgr4jt6i9AcoCMA=;\n\tb=Y2ITNadSVHu10fV/NUMCZs8taps08e0STLvlik9WFnKVz+ot/hBsW2diGapAGX8h12\n\t/bG4uG6SlAHYYi8kAvIEMO1PUgPd40Ao+RFeatT8zFq+j8ZvssvdZjwgt1pGdk3gHKck\n\tURDzV3VAI961CKxRUzm9SJpKVZNElyAu0bnv0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=sNbtpJUKQk14wY3Il6+AQaOTeirjOgr4jt6i9AcoCMA=;\n\tb=oOlUt6qSDO8zW3cSZ1xz+mhUcF4erYNUSeDVNqs7LDUHBcrsYjP/EUvNviG0zhgCEb\n\tSJABIGa0+jBVI7hA2H+RmSNVFSpYVqLfR29NKu33bH160BEWKlSloj0jF3bDjbB4zaZV\n\ts2D1XFJwVUIRgwh1mFEgJp516A25AXfzSpZZxcvSdyWkarFnhxUwZ5Gq2UAFSeDj0Ugd\n\tV5FqvMt71x8IS06wJt9j5cCO7V9+kDxDqMdTaos64//DJ7haR7PK+5V/UfPFKSZt4lXy\n\t086ujL/bviYf5iQaJI2VQUZRDakb8IdWPAj7PgmaQZm/b8CZCfyRAICh41eyPZOT0C/N\n\tr+iA==","X-Gm-Message-State":"AHPjjUiRx/3i4phi6nfFk8/SrMd6AwRtmj8AIRkmvMhGwLllaN0ZY0a0\n\tNIVsIDh8VyrGcny24PxCtYOrUw==","X-Google-Smtp-Source":"AOwi7QDMpT7dr/qKsQsLokFdJjoOToAuF54RqIbLG1VTW+HUM8z7No9s5krzgApl8/3nssgHB6ywiA==","X-Received":"by 10.101.69.136 with SMTP id o8mr9180714pgq.127.1506381885825; \n\tMon, 25 Sep 2017 16:24:45 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-11-david@redhat.com>","From":"Richard Henderson ","Message-ID":"<2625fc95-3120-d564-92a3-b3e9e9cdfa95@linaro.org>","Date":"Mon, 25 Sep 2017 16:24:42 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-11-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::22d","Subject":"Re: [Qemu-devel] [PATCH v1 10/27] s390x/kvm: pass ipb directly into\n\thandle_sigp()","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf , \n\tborntraeger@de.ibm.com, Igor Mammedov , \n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]