[{"id":1774726,"web_url":"http://patchwork.ozlabs.org/comment/1774726/","msgid":"<1551a7b0-de0b-ab57-0ac7-1d0cb9eed6af@redhat.com>","list_archive_url":null,"date":"2017-09-25T13:16:31","subject":"Re: [Qemu-devel] [PATCH v1 06/27] s390x/tcg: injection of emergency\n\tsignals and extarnal calls","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"> @@ -248,6 +249,19 @@ static void do_ext_interrupt(CPUS390XState *env)\n> lowcore->ext_int_code = cpu_to_be16(EXT_CPU_TIMER);\n> lowcore->cpu_addr = 0;\n> env->pending_int &= ~INTERRUPT_EXT_CPU_TIMER;\n> + } else if (env->pending_int & INTERRUPT_EMERGENCY_SIGNAL) {\n> + lowcore->ext_int_code = cpu_to_be16(EXT_EMERGENCY);\n> + cpu_addr = find_first_bit(env->emergency_signals, S390_MAX_CPUS);\n> + g_assert(cpu_addr < S390_MAX_CPUS);\n> + lowcore->cpu_addr = cpu_to_be16(cpu_addr);\n> + clear_bit(cpu_addr, env->emergency_signals);\n> + if (bitmap_empty(env->emergency_signals, max_cpus)) {\n> + env->pending_int &= ~INTERRUPT_EMERGENCY_SIGNAL;\n> + }\n> + } else if (env->pending_int & INTERRUPT_EXTERNAL_CALL) {\n> + lowcore->ext_int_code = cpu_to_be16(EXT_EXTERNAL_CALL);\n> + lowcore->cpu_addr = cpu_to_be16(env->external_call_addr);\n> + env->pending_int &= ~INTERRUPT_EXTERNAL_CALL;\n\nThe priority of the interrupts is still wrong and we don't check for the\nsubclass-mask bits. Will fix this.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y14PV3L0Sz9t3F\n\tfor ;\n\tMon, 25 Sep 2017 23:17:17 +1000 (AEST)","from localhost ([::1]:42418 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwTG6-0004nf-Kn\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 09:17:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57863)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwTFa-0004df-4e\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:16:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwTFV-0001re-3k\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:16:42 -0400","from mx1.redhat.com ([209.132.183.28]:42432)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwTFU-0001rG-TE\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 09:16:37 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9529B81E06;\n\tMon, 25 Sep 2017 13:16:35 +0000 (UTC)","from [10.36.117.28] (ovpn-117-28.ams2.redhat.com [10.36.117.28])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 28D376C431;\n\tMon, 25 Sep 2017 13:16:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9529B81E06","To":"qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-7-david@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<1551a7b0-de0b-ab57-0ac7-1d0cb9eed6af@redhat.com>","Date":"Mon, 25 Sep 2017 15:16:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-7-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 25 Sep 2017 13:16:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 06/27] s390x/tcg: injection of emergency\n\tsignals and extarnal calls","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]