[{"id":1774463,"web_url":"http://patchwork.ozlabs.org/comment/1774463/","msgid":"<54d45b80-4b24-7c27-9640-0bb50d77f14d@de.ibm.com>","list_archive_url":null,"date":"2017-09-25T07:18:10","subject":"Re: [Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq\n\tafter really hotplugged","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"On 09/18/2017 05:59 PM, David Hildenbrand wrote:\n> Let's move it into the machine, so we trigger the IRQ after setting\n> ms->possible_cpus (which SCLP uses to construct the list of\n> online CPUs).\n> \n> Signed-off-by: David Hildenbrand \n\nMakes sense\nReviewed-by: Christian Borntraeger \n\n> ---\n> hw/s390x/s390-virtio-ccw.c | 4 ++++\n> target/s390x/cpu.c | 8 --------\n> 2 files changed, 4 insertions(+), 8 deletions(-)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index 0471407187..d5a12a2472 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -327,6 +327,10 @@ static void s390_cpu_plug(HotplugHandler *hotplug_dev,\n> \n> g_assert(!ms->possible_cpus->cpus[cpu->env.core_id].cpu);\n> ms->possible_cpus->cpus[cpu->env.core_id].cpu = OBJECT(dev);\n> +\n> + if (dev->hotplugged) {\n> + raise_irq_cpu_hotplug();\n> + }\n> }\n> \n> static void s390_machine_reset(void)\n> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c\n> index 34538c3ab9..4920da3625 100644\n> --- a/target/s390x/cpu.c\n> +++ b/target/s390x/cpu.c\n> @@ -41,7 +41,6 @@\n> #include \"hw/hw.h\"\n> #include \"sysemu/arch_init.h\"\n> #include \"sysemu/sysemu.h\"\n> -#include \"hw/s390x/sclp.h\"\n> #endif\n> \n> #define CR0_RESET 0xE0UL\n> @@ -227,13 +226,6 @@ static void s390_cpu_realizefn(DeviceState *dev, Error **errp)\n> #endif\n> \n> scc->parent_realize(dev, &err);\n> -\n> -#if !defined(CONFIG_USER_ONLY)\n> - if (dev->hotplugged) {\n> - raise_irq_cpu_hotplug();\n> - }\n> -#endif\n> -\n> out:\n> error_propagate(errp, err);\n> }\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0wSF3yYdz9tXG\n\tfor ;\n\tMon, 25 Sep 2017 17:19:09 +1000 (AEST)","from localhost ([::1]:40990 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwNfX-00086f-Lv\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 03:19:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60474)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwNfB-00086O-Im\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 03:18:46 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwNf8-00009H-AT\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 03:18:45 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46348)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwNf7-0008Gs-L9\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 03:18:42 -0400","from pps.filterd (m0098404.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8P7EaYw051781\n\tfor ; Mon, 25 Sep 2017 03:18:18 -0400","from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d6sv61r5q-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 25 Sep 2017 03:18:18 -0400","from localhost\n\tby e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 25 Sep 2017 08:18:15 +0100","from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195)\n\tby e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 25 Sep 2017 08:18:12 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8P7IBkn29098164; Mon, 25 Sep 2017 07:18:11 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 26F7C42041;\n\tMon, 25 Sep 2017 08:14:16 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B907542045;\n\tMon, 25 Sep 2017 08:14:15 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 25 Sep 2017 08:14:15 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-2-david@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 25 Sep 2017 09:18:10 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-2-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092507-0040-0000-0000-000003DCC212","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092507-0041-0000-0000-000025DE06AF","Message-Id":"<54d45b80-4b24-7c27-9640-0bb50d77f14d@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-25_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250112","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq\n\tafter really hotplugged","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , Igor Mammedov , \n\t=?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775017,"web_url":"http://patchwork.ozlabs.org/comment/1775017/","msgid":"<17f707d2-9fd7-470d-72ce-b706971bc46b@linaro.org>","list_archive_url":null,"date":"2017-09-25T23:10:32","subject":"Re: [Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq\n\tafter really hotplugged","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n> Let's move it into the machine, so we trigger the IRQ after setting\n> ms->possible_cpus (which SCLP uses to construct the list of\n> online CPUs).\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 4 ++++\n> target/s390x/cpu.c | 8 --------\n> 2 files changed, 4 insertions(+), 8 deletions(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"I22WjxfE\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1KZX3QN7z9t3F\n\tfor ;\n\tTue, 26 Sep 2017 09:11:00 +1000 (AEST)","from localhost ([::1]:44694 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwcWg-0003oC-JH\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:10:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41447)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwcWP-0003l6-T4\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:10:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwcWK-00079J-UI\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:10:41 -0400","from mail-pg0-x230.google.com ([2607:f8b0:400e:c05::230]:54508)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwcWK-00078V-Nd\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:10:36 -0400","by mail-pg0-x230.google.com with SMTP id c137so4865424pga.11\n\tfor ; Mon, 25 Sep 2017 16:10:36 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tb5sm12634969pgc.50.2017.09.25.16.10.33\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:10:34 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=LjkF9tqt58sKnqg0sQnynHGp2TN9BtjxnG3I2DqfJWU=;\n\tb=I22WjxfEe0irjb89nuDD1jF/QkUNqPIbQxh4C/YrIv4rqGvkhoj0uDJpJY/ydbSniG\n\ty9a1qaor2vPx3U6ryFWP6+g6G0Mx4jap93q3ATjdAsMrtKsF0UUe9Pujxof8rKyw40Xy\n\t0EJWJWM6BQmGzDv+stD9nnYnEAhVw05L0gUcI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=LjkF9tqt58sKnqg0sQnynHGp2TN9BtjxnG3I2DqfJWU=;\n\tb=QntNIi0sgo4Zgv0cytY7qaH0nKL1F3yIFEBGvfzsBPShK2+D+O9+M0gLWnDEaXc+rS\n\t3j+VoXB2MmNy+8bYFPOhIIbeSRWv3Eav0bMzBhva5wnft5w4nnaOdLgV6oK9BWcVg+H/\n\tdDsCI4frX33sUSthcjlbq6TFpuy7jHhHkw1aE2P/p4ArRLojLaVjD6Ygz9hM8YGTjS/A\n\t+zDoPObQlHPnt9ZPW7rSdoFrewJsSckp1cDMrYVJ58/SbXx3BRfls/6li6IQtkkavL75\n\t1ayUx/mN1Gy4+gg3QSCLuOuCtK7yBFi9oar2/kcWHoG50/LB55uIrTG6I5x5XIyubc1d\n\tISng==","X-Gm-Message-State":"AHPjjUifT4WSRuSMh4iFskMMOr3HmrC2BBefO8QbvNQeK12+bf5sKJJg\n\tGNI7ARcf6wyqqobOLZCMLzbFhQ==","X-Google-Smtp-Source":"AOwi7QDdtB65ZWyK8M+Ichrtpe2s2GGKnieHXQ1tW09albVRl/vhkaHMVusG+cTHMI9G1NmtDrxLbw==","X-Received":"by 10.84.194.3 with SMTP id g3mr9191872pld.246.1506381035580;\n\tMon, 25 Sep 2017 16:10:35 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-2-david@redhat.com>","From":"Richard Henderson ","Message-ID":"<17f707d2-9fd7-470d-72ce-b706971bc46b@linaro.org>","Date":"Mon, 25 Sep 2017 16:10:32 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-2-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::230","Subject":"Re: [Qemu-devel] [PATCH v1 01/27] s390x: raise CPU hotplug irq\n\tafter really hotplugged","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf , \n\tborntraeger@de.ibm.com, Igor Mammedov , \n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]