[{"id":1774609,"web_url":"http://patchwork.ozlabs.org/comment/1774609/","msgid":"","list_archive_url":null,"date":"2017-09-25T10:08:34","subject":"Re: [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use\n\tS390_MAX_CPUS","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 18.09.2017 17:59, David Hildenbrand wrote:\n> Will be handy in the next patches.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 2 +-\n> target/s390x/cpu.h | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c\n> index d5a12a2472..a57d435cbf 100644\n> --- a/hw/s390x/s390-virtio-ccw.c\n> +++ b/hw/s390x/s390-virtio-ccw.c\n> @@ -443,7 +443,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)\n> mc->no_parallel = 1;\n> mc->no_sdcard = 1;\n> mc->use_sclp = 1;\n> - mc->max_cpus = 248;\n> + mc->max_cpus = S390_MAX_CPUS;\n> mc->has_hotpluggable_cpus = true;\n> mc->get_hotplug_handler = s390_get_hotplug_handler;\n> mc->cpu_index_to_instance_props = s390_cpu_index_to_props;\n> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h\n> index f13aea3dd8..5f539b1057 100644\n> --- a/target/s390x/cpu.h\n> +++ b/target/s390x/cpu.h\n> @@ -59,6 +59,8 @@\n> #define PSW_MCHK_MASK 0x0004000000000000\n> #define PSW_IO_MASK 0x0200000000000000\n> \n> +#define S390_MAX_CPUS 248\n> +\n> typedef struct PSW {\n> uint64_t mask;\n> uint64_t addr;\n> \n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y10DW4Pcmz9tXF\n\tfor ;\n\tMon, 25 Sep 2017 20:09:15 +1000 (AEST)","from localhost ([::1]:41577 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwQK8-0000QJ-SG\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 06:09:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43985)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwQJg-0000NS-BV\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:08:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwQJb-0005C2-Vx\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:08:44 -0400","from mx1.redhat.com ([209.132.183.28]:60586)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwQJb-0005Bc-Ow\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 06:08:39 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C60D9C04D2B3;\n\tMon, 25 Sep 2017 10:08:38 +0000 (UTC)","from [10.36.117.66] (ovpn-117-66.ams2.redhat.com [10.36.117.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 741EE675A1;\n\tMon, 25 Sep 2017 10:08:36 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C60D9C04D2B3","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-5-david@redhat.com>","From":"Thomas Huth ","Message-ID":"","Date":"Mon, 25 Sep 2017 12:08:34 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-5-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 25 Sep 2017 10:08:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use\n\tS390_MAX_CPUS","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , cohuck@redhat.com, Richard\n\tHenderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775021,"web_url":"http://patchwork.ozlabs.org/comment/1775021/","msgid":"<19d5240f-5243-cd9d-8d69-cd4edb6ce259@linaro.org>","list_archive_url":null,"date":"2017-09-25T23:14:39","subject":"Re: [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use\n\tS390_MAX_CPUS","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n> Will be handy in the next patches.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> hw/s390x/s390-virtio-ccw.c | 2 +-\n> target/s390x/cpu.h | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n\nReviewed-by: Richard Henderson \n\n\nr~","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"jGXhKESU\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1KgV0llgz9t3Z\n\tfor ;\n\tTue, 26 Sep 2017 09:15:18 +1000 (AEST)","from localhost ([::1]:44698 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwcaq-0005Ch-4R\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:15:16 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42811)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwcaO-0005Au-0l\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwcaJ-0000Fl-Ml\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:47 -0400","from mail-pg0-x232.google.com ([2607:f8b0:400e:c05::232]:52469)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwcaJ-0000FQ-HB\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:43 -0400","by mail-pg0-x232.google.com with SMTP id i195so4873766pgd.9\n\tfor ; Mon, 25 Sep 2017 16:14:43 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tu27sm13731759pfl.76.2017.09.25.16.14.41\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:14:41 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=q3BYsYyi/5JmwceYz3H+6DeDp7JZUh+XRWdRxvzNpJc=;\n\tb=jGXhKESUshkKrFcjTajSsqgjROigxyjLTq2xnb7UXa3vJORBDIsriCpUcPmiUDXf1t\n\tSeqmgAPjARdXwfetYtZPVIwMW+xtwgPk2UmvhFmoE8DSV79+jrMk25ALjyhnaS1IXjWz\n\t6YoGxeQPfGDTA5TEsRJPTSzuhJAv/n6mHfXoE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=q3BYsYyi/5JmwceYz3H+6DeDp7JZUh+XRWdRxvzNpJc=;\n\tb=Eh4hVFm2ECOOvxPzo1Raoi+DJV6vDdwxCTQ6tHLcxfooK1x37YHkWf9zwPSJ9JIhiu\n\to2xurGX3nTvfk8ElUZ9bEP86dY326vvU66sI4Uc4O0bEeWNfbMryhb8POYNUoDG6nAu1\n\tClvnO4RJcCAG23haVI85khhgylvbqUkkNV2SlSv67JPKhUC3AkMG1QxtkL/I44javv9w\n\tK6OH5LOtzROoJD+TxnkMQjo2t6YbV/ZgGixftjL41L1SdttFAPl8BFrUd7y0R3hqGjDD\n\tsaB9fAGfc366yeUn0POrol8pMVzkQJp5L2y62BYN4nOSKwTzzfwb860SDcBM8seSc1l8\n\t3Wfw==","X-Gm-Message-State":"AHPjjUi2wkEJRLaezAu2o7uWge3xZdYw6o3G6JGJI0dY6Cr8Sqxmx6r2\n\tXTlT8qsSklXIvaKKDUKr+rNMCw==","X-Google-Smtp-Source":"AOwi7QArWdpPUMNGuWm/tI6ViJK88rFS5v2FvNArsulITcRSAYol1V+CVL/brE8Vq0bTvSqF7UA3Pg==","X-Received":"by 10.98.17.216 with SMTP id 85mr9008918pfr.206.1506381282637;\n\tMon, 25 Sep 2017 16:14:42 -0700 (PDT)","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-5-david@redhat.com>","From":"Richard Henderson ","Message-ID":"<19d5240f-5243-cd9d-8d69-cd4edb6ce259@linaro.org>","Date":"Mon, 25 Sep 2017 16:14:39 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-5-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::232","Subject":"Re: [Qemu-devel] [PATCH v1 04/27] s390x: introduce and use\n\tS390_MAX_CPUS","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf , \n\tborntraeger@de.ibm.com, Igor Mammedov , \n\t=?utf-8?q?Alex_Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]