[{"id":1774500,"web_url":"http://patchwork.ozlabs.org/comment/1774500/","msgid":"<0ca38937-6b03-1929-9157-91cb043a9236@de.ibm.com>","list_archive_url":null,"date":"2017-09-25T08:14:12","subject":"Re: [Qemu-devel] [PATCH v1 02/27] s390x/cpumodel: fix max STFL(E)\n\tbit number","submitter":{"id":590,"url":"http://patchwork.ozlabs.org/api/people/590/","name":"Christian Borntraeger","email":"borntraeger@de.ibm.com"},"content":"Makes sense. I asked myself if there is code outside that does not zero out 2048-16k so\nI looked into the kernel source and it looks like we always did the right thing\n(and zeroed out the response buffer), so this should not uncover any bugs.\n\nReviewed-by: Christian Borntraeger \n\nOn 09/18/2017 05:59 PM, David Hildenbrand wrote:\n> Not that it would matter in the near future, but it is actually 2048\n> bytes, therefore 16384 possible bits.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/cpu_features.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c\n> index 1d3a036393..31a4676f05 100644\n> --- a/target/s390x/cpu_features.c\n> +++ b/target/s390x/cpu_features.c\n> @@ -381,7 +381,7 @@ void s390_add_from_feat_block(S390FeatBitmap features, S390FeatType type,\n> \n> switch (type) {\n> case S390_FEAT_TYPE_STFL:\n> - nr_bits = 2048;\n> + nr_bits = 16384;\n> break;\n> case S390_FEAT_TYPE_PLO:\n> nr_bits = 256;\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0xjP1m8pz9t5c\n\tfor ;\n\tMon, 25 Sep 2017 18:15:37 +1000 (AEST)","from localhost ([::1]:41220 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwOYB-0002O6-B0\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 04:15:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43953)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwOXc-0002Mb-M1\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 04:15:01 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwOXa-0001ym-0o\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 04:15:00 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:52362)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dwOXZ-0001yB-OR\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 04:14:57 -0400","from pps.filterd (m0098396.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8P8ErXv123161\n\tfor ; Mon, 25 Sep 2017 04:14:53 -0400","from e06smtp11.uk.ibm.com (e06smtp11.uk.ibm.com [195.75.94.107])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d6p5xwepq-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 25 Sep 2017 04:14:52 -0400","from localhost\n\tby e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 25 Sep 2017 09:14:17 +0100","from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196)\n\tby e06smtp11.uk.ibm.com (192.168.101.141) with IBM ESMTP SMTP\n\tGateway: Authorized Use Only! Violators will be prosecuted; \n\tMon, 25 Sep 2017 09:14:13 +0100","from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60])\n\tby b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8P8EDB620185240; Mon, 25 Sep 2017 08:14:13 GMT","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A81AE42041;\n\tMon, 25 Sep 2017 09:10:17 +0100 (BST)","from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 4964B4203F;\n\tMon, 25 Sep 2017 09:10:17 +0100 (BST)","from oc7330422307.ibm.com (unknown [9.152.224.56])\n\tby d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP;\n\tMon, 25 Sep 2017 09:10:17 +0100 (BST)"],"To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-3-david@redhat.com>","From":"Christian Borntraeger ","Date":"Mon, 25 Sep 2017 10:14:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-3-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17092508-0040-0000-0000-000003FCC1F9","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17092508-0041-0000-0000-0000209E0767","Message-Id":"<0ca38937-6b03-1929-9157-91cb043a9236@de.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-25_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709250129","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH v1 02/27] s390x/cpumodel: fix max STFL(E)\n\tbit number","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson , \n\tAlexander Graf , Igor Mammedov , \n\t=?utf-8?q?Alex_?= =?utf-8?q?Benn=C3=A9e?= ,\n\tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774560,"web_url":"http://patchwork.ozlabs.org/comment/1774560/","msgid":"<67fd3a3b-cdb2-093d-6235-0dd363e73932@redhat.com>","list_archive_url":null,"date":"2017-09-25T09:18:51","subject":"Re: [Qemu-devel] [PATCH v1 02/27] s390x/cpumodel: fix max STFL(E)\n\tbit number","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 18.09.2017 17:59, David Hildenbrand wrote:\n> Not that it would matter in the near future, but it is actually 2048\n> bytes, therefore 16384 possible bits.\n> \n> Signed-off-by: David Hildenbrand \n> ---\n> target/s390x/cpu_features.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/target/s390x/cpu_features.c b/target/s390x/cpu_features.c\n> index 1d3a036393..31a4676f05 100644\n> --- a/target/s390x/cpu_features.c\n> +++ b/target/s390x/cpu_features.c\n> @@ -381,7 +381,7 @@ void s390_add_from_feat_block(S390FeatBitmap features, S390FeatType type,\n> \n> switch (type) {\n> case S390_FEAT_TYPE_STFL:\n> - nr_bits = 2048;\n> + nr_bits = 16384;\n> break;\n> case S390_FEAT_TYPE_PLO:\n> nr_bits = 256;\n\nReviewed-by: Thomas Huth ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0z7F2vDlz9s7F\n\tfor ;\n\tMon, 25 Sep 2017 19:19:35 +1000 (AEST)","from localhost ([::1]:41428 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwPY3-0008Ix-G5\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 05:19:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60145)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwPXc-0008Im-He\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 05:19:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwPXY-0005zN-B5\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 05:19:04 -0400","from mx1.redhat.com ([209.132.183.28]:34616)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwPXY-0005ys-4o\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 05:19:00 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id F38544E028;\n\tMon, 25 Sep 2017 09:18:58 +0000 (UTC)","from [10.36.117.66] (ovpn-117-66.ams2.redhat.com [10.36.117.66])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 26FC56EC89;\n\tMon, 25 Sep 2017 09:18:52 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com F38544E028","To":"David Hildenbrand , qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-3-david@redhat.com>","From":"Thomas Huth ","Message-ID":"<67fd3a3b-cdb2-093d-6235-0dd363e73932@redhat.com>","Date":"Mon, 25 Sep 2017 11:18:51 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-3-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 25 Sep 2017 09:18:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 02/27] s390x/cpumodel: fix max STFL(E)\n\tbit number","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , cohuck@redhat.com, Richard\n\tHenderson , \n\tAlexander Graf , borntraeger@de.ibm.com, Igor Mammedov\n\t, =?utf-8?q?Alex_Benn=C3=A9e?=\n\t, \tAurelien Jarno ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]