[{"id":1772797,"web_url":"http://patchwork.ozlabs.org/comment/1772797/","msgid":"<20170921152829.3ae552f5@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-21T13:28:29","subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 18 Sep 2017 17:59:48 +0200\nDavid Hildenbrand <david@redhat.com> wrote:\n\n> core_id is not needed by linux-user, as the core_id a.k.a. CPU address\n> is only accessible from kernel space.\n> \n> Therefore, drop next_core_id and make cpu_index get autoassigned again\n> for linux-user.\n> \n> While at it, shield core_id and cpuid completely from linux-user. cpuid\n> can also only be queried from kernel space.\n> \n> Suggested-by: Igor Mammedov <imammedo@redhat.com>\n> Signed-off-by: David Hildenbrand <david@redhat.com>\nReviewed-by: Igor Mammedov <imammedo@redhat.com>\n\n[...]","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xycry608sz9t43\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 21 Sep 2017 23:29:06 +1000 (AEST)","from localhost ([::1]:53702 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dv1XN-0001Nm-0Q\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 09:29:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58854)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dv1X0-0001NT-4U\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:28:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dv1Wu-0000h1-L5\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:28:42 -0400","from mx1.redhat.com ([209.132.183.28]:43326)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <imammedo@redhat.com>) id 1dv1Wu-0000gZ-F0\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 09:28:36 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 58E54806C0;\n\tThu, 21 Sep 2017 13:28:35 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 44F6560178;\n\tThu, 21 Sep 2017 13:28:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 58E54806C0","Date":"Thu, 21 Sep 2017 15:28:29 +0200","From":"Igor Mammedov <imammedo@redhat.com>","To":"David Hildenbrand <david@redhat.com>","Message-ID":"<20170921152829.3ae552f5@nial.brq.redhat.com>","In-Reply-To":"<20170918160012.4317-4-david@redhat.com>","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-4-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tThu, 21 Sep 2017 13:28:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tcohuck@redhat.com, Richard Henderson <richard.henderson@linaro.org>, \n\tqemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, \n\tborntraeger@de.ibm.com, Alex =?utf-8?q?Benn=C3=A9e?=\n\t<alex.bennee@linaro.org>, \tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775020,"web_url":"http://patchwork.ozlabs.org/comment/1775020/","msgid":"<f5df52db-c3b7-538c-a859-345b87a9b9b4@linaro.org>","list_archive_url":null,"date":"2017-09-25T23:14:16","subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","submitter":{"id":72104,"url":"http://patchwork.ozlabs.org/api/people/72104/","name":"Richard Henderson","email":"richard.henderson@linaro.org"},"content":"On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n>      /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */\n> -    cs->cpu_index = env->core_id;\n> +    cs->cpu_index = cpu->env.core_id;\n> +#endif\n\nAny reason not to drop core_id entirely in favour of cpu_index?\n(Since cpu_index itself is generic and can't be dropped.)\n\n\nr~","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"hZEfIgJi\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Kfx6s2mz9t3F\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 09:14:48 +1000 (AEST)","from localhost ([::1]:44697 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwcaL-0004yR-St\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 19:14:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42707)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwca0-0004ww-P6\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:25 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <richard.henderson@linaro.org>) id 1dwcZw-0008To-Pc\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:24 -0400","from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:54515)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <richard.henderson@linaro.org>)\n\tid 1dwcZw-0008TZ-IS\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 19:14:20 -0400","by mail-pg0-x22e.google.com with SMTP id c137so4870036pga.11\n\tfor <qemu-devel@nongnu.org>; Mon, 25 Sep 2017 16:14:20 -0700 (PDT)","from bigtime.twiddle.net ([70.35.39.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tj2sm13392786pgn.26.2017.09.25.16.14.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 25 Sep 2017 16:14:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=GNmPHMBtEO4BG6KAOZVv+gFlYD7jS+IEu8cExuFx6VE=;\n\tb=hZEfIgJi5rGRZrQjLszp3aPAjjjwlDVlgsTJA5GK9kLA/N4GRE8Ecz6F+xxFCPn0t8\n\t7APs0v4nPka8vjSTuK3fChPzN3uaL26/aoxKxQIFAR7KXbNMxfqt85p+xIw8TaFVlaXD\n\tvhkqPFzF5JlQl94P9BNNRBQsVaui7Zw7njSrY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=GNmPHMBtEO4BG6KAOZVv+gFlYD7jS+IEu8cExuFx6VE=;\n\tb=GQpXHxdiG4GahACf3iLGKgqlOkrV0Ca8m5GiC4g/uGQJZ3fgXPcFVUGsAHCxQbncIb\n\tbru81EhCITeO6OPTRKb3jmQnFZTU9J33pNrt2MROg7caYPrbBi6aNIPOVq1lQNHHIYL2\n\tZ/RztskerGtFbYihHuZROd5ODz+2/k6RjUEz9/MIjKVzX8r3DDIxXyW1s2M/3VA11pq/\n\tPxXHVzFumgO/kjP9CgHmfpKPkPPxt0ypNcFoJp/Lbi6xcujjlWNbB19UEjGQSGUIfnvD\n\t5zzFvlmIXlGBx651syFRtex+qWQce8baGbnPF2vhUUu7TYc2F5mnlmk97hPFcrPelSi+\n\t4r0A==","X-Gm-Message-State":"AHPjjUjrvn502AEivBCC+59r5IgYQsNnkzvLpFe61MJw4dczpt95DIel\n\t7ZZLmWeSgVFEZBnurNTdyd6wIg==","X-Google-Smtp-Source":"AOwi7QA+KipmdVjv5GYrMlVm6Geg0J74YNCGkBLOZuzcqF1F6PB/GPhnfp/GBymMVgASbB4bBjpJ2w==","X-Received":"by 10.101.93.132 with SMTP id f4mr9337708pgt.408.1506381259680; \n\tMon, 25 Sep 2017 16:14:19 -0700 (PDT)","To":"David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-4-david@redhat.com>","From":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<f5df52db-c3b7-538c-a859-345b87a9b9b4@linaro.org>","Date":"Mon, 25 Sep 2017 16:14:16 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918160012.4317-4-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c05::22e","Subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tcohuck@redhat.com, Alexander Graf <agraf@suse.de>, \n\tborntraeger@de.ibm.com, Igor Mammedov <imammedo@redhat.com>, \n\t=?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775273,"web_url":"http://patchwork.ozlabs.org/comment/1775273/","msgid":"<20170926104903.2a50bc37@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-26T08:49:03","subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 25 Sep 2017 16:14:16 -0700\nRichard Henderson <richard.henderson@linaro.org> wrote:\n\n> On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n> >      /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */\n> > -    cs->cpu_index = env->core_id;\n> > +    cs->cpu_index = cpu->env.core_id;\n> > +#endif  \n> \n> Any reason not to drop core_id entirely in favour of cpu_index?\n> (Since cpu_index itself is generic and can't be dropped.)\nI prefer core_id vs cpu_index as the later is too generic\n(and we were trying to decouple target specific attributes\n/coreid/cpuid/whatnot from cpu_index as much as possible\nso it would be more clear what they mean and if possible\nmake them in-depended of QEMU internal cpu_index which is\nessentially not owned by target).","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1ZQT33MBz9t3B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 18:49:53 +1000 (AEST)","from localhost ([::1]:46225 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwlYt-0002AU-Gc\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 04:49:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47201)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dwlYL-000290-9s\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:49:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <imammedo@redhat.com>) id 1dwlYH-0005FA-Ls\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:49:17 -0400","from mx1.redhat.com ([209.132.183.28]:43616)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <imammedo@redhat.com>) id 1dwlYH-0005Eu-F4\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:49:13 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2CEB32C9707;\n\tTue, 26 Sep 2017 08:49:12 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 21DB9614D0;\n\tTue, 26 Sep 2017 08:49:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2CEB32C9707","Date":"Tue, 26 Sep 2017 10:49:03 +0200","From":"Igor Mammedov <imammedo@redhat.com>","To":"Richard Henderson <richard.henderson@linaro.org>","Message-ID":"<20170926104903.2a50bc37@nial.brq.redhat.com>","In-Reply-To":"<f5df52db-c3b7-538c-a859-345b87a9b9b4@linaro.org>","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-4-david@redhat.com>\n\t<f5df52db-c3b7-538c-a859-345b87a9b9b4@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 26 Sep 2017 08:49:12 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com, David\n\tHildenbrand <david@redhat.com>, cohuck@redhat.com, \n\tqemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>, \n\tborntraeger@de.ibm.com, Alex =?utf-8?q?Benn=C3=A9e?=\n\t<alex.bennee@linaro.org>, \tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1775434,"web_url":"http://patchwork.ozlabs.org/comment/1775434/","msgid":"<b9b87287-b05a-3895-b996-05609808194d@redhat.com>","list_archive_url":null,"date":"2017-09-26T12:40:49","subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 26.09.2017 10:49, Igor Mammedov wrote:\n> On Mon, 25 Sep 2017 16:14:16 -0700\n> Richard Henderson <richard.henderson@linaro.org> wrote:\n> \n>> On 09/18/2017 08:59 AM, David Hildenbrand wrote:\n>>>      /* sync cs->cpu_index and env->core_id. The latter is needed for TCG. */\n>>> -    cs->cpu_index = env->core_id;\n>>> +    cs->cpu_index = cpu->env.core_id;\n>>> +#endif  \n>>\n>> Any reason not to drop core_id entirely in favour of cpu_index?\n>> (Since cpu_index itself is generic and can't be dropped.)\n> I prefer core_id vs cpu_index as the later is too generic\n> (and we were trying to decouple target specific attributes\n> /coreid/cpuid/whatnot from cpu_index as much as possible\n> so it would be more clear what they mean and if possible\n> make them in-depended of QEMU internal cpu_index which is\n> essentially not owned by target).\n> \n\nAs x86 also has this split I also prefer to keep it for now as it is.\n\ncpu_index just has to match our core id, otherwise e.g. migration could\nbreak (cpu_index is used as identifier for cpus in the migration stream).\n\nIf we would drop core_id, we would have to implement a handler for the\nSTAP instruction, as the CPU object is not accessible from translate.c.\n(not a big problem, just another reason to simply leave it as is for\nnow), and also a new property handler, so only a uint16_t can be set\nusing \"core-id\" onto a CPU object.","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1gYh69P2z9sP1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 22:41:25 +1000 (AEST)","from localhost ([::1]:47390 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dwpAw-0003BR-MY\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 08:41:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58670)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwpAZ-0003BC-HR\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:41:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <david@redhat.com>) id 1dwpAV-0002J4-KS\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:40:59 -0400","from mx1.redhat.com ([209.132.183.28]:51698)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <david@redhat.com>) id 1dwpAV-0002Hq-Ea\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 08:40:55 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DC1617E44A;\n\tTue, 26 Sep 2017 12:40:53 +0000 (UTC)","from [10.36.117.152] (ovpn-117-152.ams2.redhat.com [10.36.117.152])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1C47E5C66F;\n\tTue, 26 Sep 2017 12:40:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DC1617E44A","To":"Igor Mammedov <imammedo@redhat.com>,\n\tRichard Henderson <richard.henderson@linaro.org>","References":"<20170918160012.4317-1-david@redhat.com>\n\t<20170918160012.4317-4-david@redhat.com>\n\t<f5df52db-c3b7-538c-a859-345b87a9b9b4@linaro.org>\n\t<20170926104903.2a50bc37@nial.brq.redhat.com>","From":"David Hildenbrand <david@redhat.com>","Organization":"Red Hat GmbH","Message-ID":"<b9b87287-b05a-3895-b996-05609808194d@redhat.com>","Date":"Tue, 26 Sep 2017 14:40:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170926104903.2a50bc37@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 26 Sep 2017 12:40:54 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 03/27] target/s390x: get rid of\n\tnext_core_id","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Matthew Rosato <mjrosato@linux.vnet.ibm.com>, thuth@redhat.com,\n\tcohuck@redhat.com, qemu-devel@nongnu.org, \n\tAlexander Graf <agraf@suse.de>, borntraeger@de.ibm.com, =?utf-8?q?Ale?=\n\t=?utf-8?b?eCBCZW5uw6ll?= <alex.bennee@linaro.org>,\n\tAurelien Jarno <aurelien@aurel32.net>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]