[{"id":1770574,"web_url":"http://patchwork.ozlabs.org/comment/1770574/","msgid":"<20170918232144.GD29615@lunn.ch>","list_archive_url":null,"date":"2017-09-18T23:21:44","subject":"Re: [PATCH 16/16] thunderbolt: Add support for networking over\n\tThunderbolt cable","submitter":{"id":13608,"url":"http://patchwork.ozlabs.org/api/people/13608/","name":"Andrew Lunn","email":"andrew@lunn.ch"},"content":"On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote:\n> From: Amir Levy \n> \n> ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet\n> traffic over a Thunderbolt cable. The protocol consists of configuration\n> phase where each side sends ThunderboltIP login packets (the protocol is\n> determined by UUID in the XDomain packet header) over the configuration\n> channel. Once both sides get positive acknowledgment to their login\n> packet, they configure high-speed DMA path accordingly. This DMA path is\n> then used to transmit and receive networking traffic.\n> \n> This patch creates a virtual ethernet interface the host software can\n> use in the same way as any other networking interface. Once the\n> interface is brought up successfully network packets get tunneled over\n> the Thunderbolt cable to the remote host and back.\n> \n> The connection is terminated by sending a ThunderboltIP logout packet\n> over the configuration channel. We do this when the network interface is\n> brought down by user or the driver is unloaded.\n> \n> Signed-off-by: Amir Levy \n> Signed-off-by: Michael Jamet \n> Signed-off-by: Mika Westerberg \n> Reviewed-by: Yehezkel Bernat \n> ---\n> Documentation/admin-guide/thunderbolt.rst | 24 +\n> drivers/thunderbolt/Kconfig | 12 +\n> drivers/thunderbolt/Makefile | 3 +\n> drivers/thunderbolt/net.c | 1392 +++++++++++++++++++++++++++++\n> 4 files changed, 1431 insertions(+)\n> create mode 100644 drivers/thunderbolt/net.c\n\nHi Mika\n\nCould this be renamed to driver/net/thunderbolt.c?\n\nAt minimum, it needs a MAINTAINER entry pointing to netdev, so patches\nget reviewed by netdev people. However, since the driver seems to be a\nlot more netdev than thunderbolt, placing it in driver/net could be\nbetter.\n\n\tThanks\n\t\tAndrew","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx28q41hrz9s3T\n\tfor ;\n\tTue, 19 Sep 2017 09:22:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751074AbdIRXWG (ORCPT );\n\tMon, 18 Sep 2017 19:22:06 -0400","from vps0.lunn.ch ([185.16.172.187]:46777 \"EHLO vps0.lunn.ch\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750781AbdIRXWF (ORCPT );\n\tMon, 18 Sep 2017 19:22:05 -0400","from andrew by vps0.lunn.ch with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1du5MG-0008FI-6s; Tue, 19 Sep 2017 01:21:44 +0200"],"Date":"Tue, 19 Sep 2017 01:21:44 +0200","From":"Andrew Lunn ","To":"Mika Westerberg ","Cc":"Greg Kroah-Hartman ,\n\t\"David S . Miller\" ,\n\tAndreas Noever ,\n\tMichael Jamet ,\n\tYehezkel Bernat ,\n\tAmir Levy ,\n\tMario.Limonciello@dell.com, Lukas Wunner ,\n\tAndy Shevchenko ,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org","Subject":"Re: [PATCH 16/16] thunderbolt: Add support for networking over\n\tThunderbolt cable","Message-ID":"<20170918232144.GD29615@lunn.ch>","References":"<20170918153049.44185-1-mika.westerberg@linux.intel.com>\n\t<20170918153049.44185-17-mika.westerberg@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918153049.44185-17-mika.westerberg@linux.intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770690,"web_url":"http://patchwork.ozlabs.org/comment/1770690/","msgid":"<20170919071239.GB4630@lahna.fi.intel.com>","list_archive_url":null,"date":"2017-09-19T07:12:39","subject":"Re: [PATCH 16/16] thunderbolt: Add support for networking over\n\tThunderbolt cable","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"content":"On Tue, Sep 19, 2017 at 01:21:44AM +0200, Andrew Lunn wrote:\n> On Mon, Sep 18, 2017 at 06:30:49PM +0300, Mika Westerberg wrote:\n> > From: Amir Levy \n> > \n> > ThunderboltIP is a protocol created by Apple to tunnel IP/ethernet\n> > traffic over a Thunderbolt cable. The protocol consists of configuration\n> > phase where each side sends ThunderboltIP login packets (the protocol is\n> > determined by UUID in the XDomain packet header) over the configuration\n> > channel. Once both sides get positive acknowledgment to their login\n> > packet, they configure high-speed DMA path accordingly. This DMA path is\n> > then used to transmit and receive networking traffic.\n> > \n> > This patch creates a virtual ethernet interface the host software can\n> > use in the same way as any other networking interface. Once the\n> > interface is brought up successfully network packets get tunneled over\n> > the Thunderbolt cable to the remote host and back.\n> > \n> > The connection is terminated by sending a ThunderboltIP logout packet\n> > over the configuration channel. We do this when the network interface is\n> > brought down by user or the driver is unloaded.\n> > \n> > Signed-off-by: Amir Levy \n> > Signed-off-by: Michael Jamet \n> > Signed-off-by: Mika Westerberg \n> > Reviewed-by: Yehezkel Bernat \n> > ---\n> > Documentation/admin-guide/thunderbolt.rst | 24 +\n> > drivers/thunderbolt/Kconfig | 12 +\n> > drivers/thunderbolt/Makefile | 3 +\n> > drivers/thunderbolt/net.c | 1392 +++++++++++++++++++++++++++++\n> > 4 files changed, 1431 insertions(+)\n> > create mode 100644 drivers/thunderbolt/net.c\n> \n> Hi Mika\n> \n> Could this be renamed to driver/net/thunderbolt.c?\n\nI pondered between drivers/thunderbolt/net.c and\ndrivers/net/thunderbolt.c and then decided to go with the former because\nit follows drivers/firewire/net.c and kind of makes it easier for user\nto enabled.\n\nBut no problem moving it into drivers/net if that's what networking\npeople prefer.\n\n> At minimum, it needs a MAINTAINER entry pointing to netdev, so patches\n> get reviewed by netdev people. However, since the driver seems to be a\n> lot more netdev than thunderbolt, placing it in driver/net could be\n> better.\n\nOK.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xxDfQ5d2Wz9sBZ\n\tfor ;\n\tTue, 19 Sep 2017 17:15:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751476AbdISHO5 (ORCPT );\n\tTue, 19 Sep 2017 03:14:57 -0400","from mga05.intel.com ([192.55.52.43]:6620 \"EHLO mga05.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750972AbdISHO4 (ORCPT );\n\tTue, 19 Sep 2017 03:14:56 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga105.fm.intel.com with ESMTP; 19 Sep 2017 00:14:56 -0700","from lahna.fi.intel.com (HELO lahna) ([10.237.72.157])\n\tby FMSMGA003.fm.intel.com with SMTP; 19 Sep 2017 00:14:51 -0700","by lahna (sSMTP sendmail emulation);\n\tTue, 19 Sep 2017 10:12:39 +0300"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,416,1500966000\"; d=\"scan'208\";a=\"901680860\"","Date":"Tue, 19 Sep 2017 10:12:39 +0300","From":"Mika Westerberg ","To":"Andrew Lunn ","Cc":"Greg Kroah-Hartman ,\n\t\"David S . Miller\" ,\n\tAndreas Noever ,\n\tMichael Jamet ,\n\tYehezkel Bernat ,\n\tAmir Levy ,\n\tMario.Limonciello@dell.com, Lukas Wunner ,\n\tAndy Shevchenko ,\n\tlinux-kernel@vger.kernel.org, netdev@vger.kernel.org","Subject":"Re: [PATCH 16/16] thunderbolt: Add support for networking over\n\tThunderbolt cable","Message-ID":"<20170919071239.GB4630@lahna.fi.intel.com>","References":"<20170918153049.44185-1-mika.westerberg@linux.intel.com>\n\t<20170918153049.44185-17-mika.westerberg@linux.intel.com>\n\t<20170918232144.GD29615@lunn.ch>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918232144.GD29615@lunn.ch>","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]