[{"id":1771075,"web_url":"http://patchwork.ozlabs.org/comment/1771075/","msgid":"<20170919142254.GG3030@localhost.localdomain>","list_archive_url":null,"date":"2017-09-19T14:22:54","subject":"Re: [Qemu-devel] [PATCH v4 3/3] x86_iommu: check if machine has PCI\n\tbus","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Mon, Sep 18, 2017 at 04:37:50PM +0200, Mohammed Gamal wrote:\n> Starting qemu with\n> qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\n> leads to a segfault. The code assume PCI bus is present and\n> tries to access the bus structure without checking.\n> \n> Since Intel VT-d and AMDVI should only work with PCI, add a\n> check for PCI bus and return error if not present.\n> \n> Signed-off-by: Mohammed Gamal \n\nReviewed-by: Eduardo Habkost ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxQ926mQPz9s7h\n\tfor ;\n\tWed, 20 Sep 2017 00:23:50 +1000 (AEST)","from localhost ([::1]:43205 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duJRF-0002Q5-1J\n\tfor incoming@patchwork.ozlabs.org; Tue, 19 Sep 2017 10:23:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50522)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duJQV-0002LQ-8G\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:23:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duJQS-0001xf-JD\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:23:03 -0400","from mx1.redhat.com ([209.132.183.28]:43000)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duJQS-0001xF-DJ\n\tfor qemu-devel@nongnu.org; Tue, 19 Sep 2017 10:23:00 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8303C81235\n\tfor ; Tue, 19 Sep 2017 14:22:59 +0000 (UTC)","from localhost (ovpn-116-23.gru2.redhat.com [10.97.116.23])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3D00F60265;\n\tTue, 19 Sep 2017 14:22:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8303C81235","Date":"Tue, 19 Sep 2017 11:22:54 -0300","From":"Eduardo Habkost ","To":"Mohammed Gamal ","Message-ID":"<20170919142254.GG3030@localhost.localdomain>","References":"<1505745470-12208-1-git-send-email-mgamal@redhat.com>\n\t<1505745470-12208-4-git-send-email-mgamal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505745470-12208-4-git-send-email-mgamal@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tTue, 19 Sep 2017 14:22:59 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 3/3] x86_iommu: check if machine has PCI\n\tbus","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org,\n\tpeterx@redhat.com, mst@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]