[{"id":1770544,"web_url":"http://patchwork.ozlabs.org/comment/1770544/","msgid":"<3107b1aa-d708-0c3f-8bb7-be2e631dff1d@redhat.com>","list_archive_url":null,"date":"2017-09-18T22:00:52","subject":"Re: [Qemu-devel] [PATCH v2 4/7] block/nbd-client: drop reply field\n\tfrom NBDClientSession","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/18/2017 08:59 AM, Vladimir Sementsov-Ogievskiy wrote:\n> Drop 'reply' from NBDClientSession. It's used to only deliver request\n> return code to receiving coroutine. Instead introduce per-request ret\n> variable to simplify the scheme and make further refactoring possible.\n> \n> Signed-off-by: Vladimir Sementsov-Ogievskiy \n> ---\n> block/nbd-client.h | 2 +-\n> block/nbd-client.c | 22 +++++++++-------------\n> 2 files changed, 10 insertions(+), 14 deletions(-)\n> \n> diff --git a/block/nbd-client.h b/block/nbd-client.h\n> index 3f97d31013..4bc8fe3993 100644\n> --- a/block/nbd-client.h\n> +++ b/block/nbd-client.h\n> @@ -22,6 +22,7 @@ typedef struct {\n> bool receiving; /* waiting for read_reply_co? */\n> NBDRequest *request;\n> QEMUIOVector *qiov;\n> + int ret;\n> } NBDClientRequest;\n\nI like this idea. However, I note that:\n\n> @@ -211,11 +211,7 @@ static int nbd_co_receive_reply(NBDClientSession *s, NBDRequest *request)\n> if (!s->ioc || s->quit) {\n> ret = -EIO;\n> } else {\n> - assert(s->reply.handle == request->handle);\n> - ret = -s->reply.error;\n> -\n> - /* Tell the read handler to read another header. */\n> - s->reply.handle = 0;\n> + ret = s->requests[i].ret;\n\nyou are removing the assert you added in 2/7, where I questioned whether\nwe needed NBDClientRequest.request in the first place. So there may be\nsome rebase churn, depending on how that conversation pans out.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx0Mb6qH8z9s7G\n\tfor ;\n\tTue, 19 Sep 2017 08:01:29 +1000 (AEST)","from localhost ([::1]:39103 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du46Z-0004HY-1e\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 18:01:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55879)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du46B-0004GC-1A\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 18:01:04 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du46A-0001AL-4b\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 18:01:03 -0400","from mx1.redhat.com ([209.132.183.28]:11968)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1du464-00018q-EM; Mon, 18 Sep 2017 18:00:56 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 53CA981E0E;\n\tMon, 18 Sep 2017 22:00:55 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CFAD65C881;\n\tMon, 18 Sep 2017 22:00:53 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 53CA981E0E","To":"Vladimir Sementsov-Ogievskiy ,\n\tqemu-block@nongnu.org, qemu-devel@nongnu.org","References":"<20170918135935.255591-1-vsementsov@virtuozzo.com>\n\t<20170918135935.255591-5-vsementsov@virtuozzo.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<3107b1aa-d708-0c3f-8bb7-be2e631dff1d@redhat.com>","Date":"Mon, 18 Sep 2017 17:00:52 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918135935.255591-5-vsementsov@virtuozzo.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"FxBHrsVTkBMElAiKQ7xwv1HEk8mw6jJhc\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tMon, 18 Sep 2017 22:00:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 4/7] block/nbd-client: drop reply field\n\tfrom NBDClientSession","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, pbonzini@redhat.com, den@openvz.org, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]