[{"id":1773264,"web_url":"http://patchwork.ozlabs.org/comment/1773264/","msgid":"","list_archive_url":null,"date":"2017-09-22T05:01:58","subject":"Re: [U-Boot] [PATCH 07/14] usb: Read device descriptor after device\n\tis addressed for xHCI","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 18.09.2017 15:40, Bin Meng wrote:\n> For xHCI it is not possible to read a device descriptor before it\n> has been assigned an address. That's why usb_setup_descriptor()\n> was called with 'do_read' being false. But we really need try to\n> read the device descriptor before starting any real communication\n> with the default control endpoint.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> common/usb.c | 11 +++++++++++\n> 1 file changed, 11 insertions(+)\n> \n> diff --git a/common/usb.c b/common/usb.c\n> index 88cee81..8d27bc7 100644\n> --- a/common/usb.c\n> +++ b/common/usb.c\n> @@ -1052,6 +1052,17 @@ static int usb_prepare_device(struct usb_device *dev, int addr, bool do_read,\n> \n> \tmdelay(10);\t/* Let the SET_ADDRESS settle */\n> \n> +\t/*\n> +\t * If we haven't read device descriptor before, read it here\n> +\t * after device is assigned an address. This is only applicable\n> +\t * to xHCI so far.\n> +\t */\n> +\tif (!do_read) {\n> +\t\terr = usb_setup_descriptor(dev, true);\n> +\t\tif (err)\n> +\t\t\treturn err;\n> +\t}\n> +\n> \treturn 0;\n> }\n> \n> \n\nReviewed-by: Stefan Roese \nTested-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz1Yn30VTz9sPt\n\tfor ;\n\tFri, 22 Sep 2017 15:02:21 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 218A6C21E48; Fri, 22 Sep 2017 05:02:08 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 32CB4C21D55;\n\tFri, 22 Sep 2017 05:02:06 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2DAE6C21D09; Fri, 22 Sep 2017 05:02:01 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id 2B635C21F53\n\tfor ; Fri, 22 Sep 2017 05:02:01 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 06C3A45996;\n\tFri, 22 Sep 2017 07:02:01 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de\n\t[80.241.56.116]) (amavisd-new, port 10030)\n\twith ESMTP id whc5inFJWmvG; Fri, 22 Sep 2017 07:01:59 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Marek Vasut ,\n\tU-Boot Mailing List ","References":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>\n\t<1505742050-5697-8-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"","Date":"Fri, 22 Sep 2017 07:01:58 +0200","MIME-Version":"1.0","In-Reply-To":"<1505742050-5697-8-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH 07/14] usb: Read device descriptor after device\n\tis addressed for xHCI","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]