[{"id":1773271,"web_url":"http://patchwork.ozlabs.org/comment/1773271/","msgid":"","list_archive_url":null,"date":"2017-09-22T05:11:31","subject":"Re: [U-Boot] [PATCH 12/14] usb: xhci: Program max burst size for\n\tendpoint","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 18.09.2017 15:40, Bin Meng wrote:\n> The 'Max Burst Size' indicates to the xHC the maximum number of\n> consecutive USB transactions that should be executed per scheduling\n> opportunity. This is a “zero-based” value, where 0 to 15 represents\n> burst sizes of 1 to 16, but at present this is always set to zero.\n> Let's program the required value according to real needs.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> drivers/usb/host/xhci.c | 21 ++++++++++++++++++++-\n> 1 file changed, 20 insertions(+), 1 deletion(-)\n> \n> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c\n> index 8aed428..dfb188d 100644\n> --- a/drivers/usb/host/xhci.c\n> +++ b/drivers/usb/host/xhci.c\n> @@ -395,6 +395,22 @@ static u32 xhci_get_endpoint_mult(struct usb_device *udev,\n> \treturn ss_ep_comp_desc->bmAttributes;\n> }\n> \n> +static u32 xhci_get_endpoint_max_burst(struct usb_device *udev,\n> +\tstruct usb_endpoint_descriptor *endpt_desc,\n> +\tstruct usb_ss_ep_comp_descriptor *ss_ep_comp_desc)\n> +{\n> +\t/* Super speed and Plus have max burst in ep companion desc */\n> +\tif (udev->speed >= USB_SPEED_SUPER)\n> +\t\treturn ss_ep_comp_desc->bMaxBurst;\n> +\n> +\tif (udev->speed == USB_SPEED_HIGH &&\n> +\t (usb_endpoint_xfer_isoc(endpt_desc) ||\n> +\t usb_endpoint_xfer_int(endpt_desc)))\n> +\t\treturn usb_endpoint_maxp_mult(endpt_desc) - 1;\n> +\n> +\treturn 0;\n> +}\n> +\n> /*\n> * Return the maximum endpoint service interval time (ESIT) payload.\n> * Basically, this is the maxpacket size, multiplied by the burst size\n> @@ -493,6 +509,7 @@ static int xhci_set_configuration(struct usb_device *udev)\n> \tu32 max_esit_payload;\n> \tunsigned int interval;\n> \tunsigned int mult;\n> +\tunsigned int max_burst;\n> \tunsigned int avg_trb_len;\n> \n> \tout_ctx = virt_dev->out_ctx;\n> @@ -545,6 +562,8 @@ static int xhci_set_configuration(struct usb_device *udev)\n> \t\tinterval = xhci_get_endpoint_interval(udev, endpt_desc);\n> \t\tmult = xhci_get_endpoint_mult(udev, endpt_desc,\n> \t\t\t\t\t ss_ep_comp_desc);\n> +\t\tmax_burst = xhci_get_endpoint_max_burst(udev, endpt_desc,\n> +\t\t\t\t\t\t\tss_ep_comp_desc);\n> \t\tavg_trb_len = max_esit_payload;\n> \n> \t\tep_index = xhci_get_ep_index(endpt_desc);\n> @@ -570,7 +589,7 @@ static int xhci_set_configuration(struct usb_device *udev)\n> \t\t\t(get_unaligned(&endpt_desc->wMaxPacketSize)));\n> \n> \t\tep_ctx[ep_index]->ep_info2 |=\n> -\t\t\tcpu_to_le32(((0 & MAX_BURST_MASK) << MAX_BURST_SHIFT) |\n> +\t\t\tcpu_to_le32(MAX_BURST(max_burst) |\n> \t\t\t((3 & ERROR_COUNT_MASK) << ERROR_COUNT_SHIFT));\n> \n> \t\ttrb_64 = (uintptr_t)\n> \n\nReviewed-by: Stefan Roese \nTested-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz1ms3z60z9ryr\n\tfor ;\n\tFri, 22 Sep 2017 15:11:57 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 3DCF7C21C26; Fri, 22 Sep 2017 05:11:49 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 05FC1C21C29;\n\tFri, 22 Sep 2017 05:11:46 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid DE61AC21C29; Fri, 22 Sep 2017 05:11:44 +0000 (UTC)","from mx2.mailbox.org (mx2.mailbox.org [80.241.60.215])\n\tby lists.denx.de (Postfix) with ESMTPS id 98BE0C21C26\n\tfor ; Fri, 22 Sep 2017 05:11:44 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx2.mailbox.org (Postfix) with ESMTPS id 9B5494B718;\n\tFri, 22 Sep 2017 07:11:43 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de\n\t[80.241.56.117]) (amavisd-new, port 10030)\n\twith ESMTP id 4QWL2EZDhn1N; Fri, 22 Sep 2017 07:11:32 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Marek Vasut ,\n\tU-Boot Mailing List ","References":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>\n\t<1505742050-5697-13-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"","Date":"Fri, 22 Sep 2017 07:11:31 +0200","MIME-Version":"1.0","In-Reply-To":"<1505742050-5697-13-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH 12/14] usb: xhci: Program max burst size for\n\tendpoint","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]