[{"id":1773261,"web_url":"http://patchwork.ozlabs.org/comment/1773261/","msgid":"<09edd6e7-a2c1-0747-83d1-abf4b98f5dbd@denx.de>","list_archive_url":null,"date":"2017-09-22T04:59:19","subject":"Re: [U-Boot] [PATCH 04/14] usb: Handle audio extension endpoint\n\tdescriptor in usb_parse_config()","submitter":{"id":13,"url":"http://patchwork.ozlabs.org/api/people/13/","name":"Stefan Roese","email":"sr@denx.de"},"content":"On 18.09.2017 15:40, Bin Meng wrote:\n> Normal endpoint descriptor size is 7, but for audio extension it is\n> 9. Handle that correctly when parsing endpoint descriptor.\n> \n> Signed-off-by: Bin Meng \n> ---\n> \n> common/usb.c | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/common/usb.c b/common/usb.c\n> index 0904259..6cb92ef 100644\n> --- a/common/usb.c\n> +++ b/common/usb.c\n> @@ -437,12 +437,13 @@ static int usb_parse_config(struct usb_device *dev,\n> \t\t\t}\n> \t\t\tbreak;\n> \t\tcase USB_DT_ENDPOINT:\n> -\t\t\tif (head->bLength != USB_DT_ENDPOINT_SIZE) {\n> +\t\t\tif (head->bLength != USB_DT_ENDPOINT_SIZE &&\n> +\t\t\t head->bLength != USB_DT_ENDPOINT_AUDIO_SIZE) {\n> \t\t\t\tprintf(\"ERROR: Invalid USB EP length (%d)\\n\",\n> \t\t\t\t\thead->bLength);\n> \t\t\t\tbreak;\n> \t\t\t}\n> -\t\t\tif (index + USB_DT_ENDPOINT_SIZE >\n> +\t\t\tif (index + head->bLength >\n> \t\t\t dev->config.desc.wTotalLength) {\n> \t\t\t\tputs(\"USB EP descriptor overflowed buffer!\\n\");\n> \t\t\t\tbreak;\n> \n\nReviewed-by: Stefan Roese \nTested-by: Stefan Roese \n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz1Vd4NCcz9sPm\n\tfor ;\n\tFri, 22 Sep 2017 14:59:37 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 4092EC21C62; Fri, 22 Sep 2017 04:59:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id E8EEBC21D55;\n\tFri, 22 Sep 2017 04:59:32 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 75CD9C21D95; Fri, 22 Sep 2017 04:59:31 +0000 (UTC)","from mx1.mailbox.org (mx1.mailbox.org [80.241.60.212])\n\tby lists.denx.de (Postfix) with ESMTPS id 3CF1DC21D55\n\tfor ; Fri, 22 Sep 2017 04:59:31 +0000 (UTC)","from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.mailbox.org (Postfix) with ESMTPS id 1CBF345647;\n\tFri, 22 Sep 2017 06:59:31 +0200 (CEST)","from smtp1.mailbox.org ([80.241.60.240])\n\tby spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de\n\t[80.241.56.117]) (amavisd-new, port 10030)\n\twith ESMTP id j7eC77rUCwKD; Fri, 22 Sep 2017 06:59:20 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-Virus-Scanned":"amavisd-new at heinlein-support.de","To":"Bin Meng , Marek Vasut ,\n\tU-Boot Mailing List ","References":"<1505742050-5697-1-git-send-email-bmeng.cn@gmail.com>\n\t<1505742050-5697-5-git-send-email-bmeng.cn@gmail.com>","From":"Stefan Roese ","Message-ID":"<09edd6e7-a2c1-0747-83d1-abf4b98f5dbd@denx.de>","Date":"Fri, 22 Sep 2017 06:59:19 +0200","MIME-Version":"1.0","In-Reply-To":"<1505742050-5697-5-git-send-email-bmeng.cn@gmail.com>","Content-Language":"en-US","Subject":"Re: [U-Boot] [PATCH 04/14] usb: Handle audio extension endpoint\n\tdescriptor in usb_parse_config()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]