[{"id":1770317,"web_url":"http://patchwork.ozlabs.org/comment/1770317/","msgid":"<5dd9e5be-22c3-f2c3-9a55-ac44591600fe@cogentembedded.com>","list_archive_url":null,"date":"2017-09-18T16:54:35","subject":"Re: [PATCH][V2] libata: make const arrays static,\n\treduces object code size","submitter":{"id":22564,"url":"http://patchwork.ozlabs.org/api/people/22564/","name":"Sergei Shtylyov","email":"sergei.shtylyov@cogentembedded.com"},"content":"Hello!\n\nOn 09/18/2017 04:32 PM, Colin King wrote:\n\n> From: Colin Ian King \n> \n> Don't populate const arrays on the stack, instead make them static.\n> Makes the object code smaller by over 260 bytes:\n> \n> Signed-off-by: Colin Ian King \n> ---\n> drivers/ata/libata-scsi.c | 10 +++++-----\n> fs/ocfs2/dlm/dlmrecovery.c | 1 -\n> 2 files changed, 5 insertions(+), 6 deletions(-)\n[...]\n> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c\n> index 74407c6dd592..31a61e8e0152 100644\n> --- a/fs/ocfs2/dlm/dlmrecovery.c\n> +++ b/fs/ocfs2/dlm/dlmrecovery.c\n> @@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm,\n> \t\t(mres->num_locks * sizeof(struct dlm_migratable_lock));\n> \n> \t/* add an all-done flag if we reached the last lock */\n> -\torig_flags = mres->flags;\n\n What's that? :-/\n\n> \tBUG_ON(total_locks > mres_total_locks);\n> \tif (total_locks == mres_total_locks)\n> \t\tmres->flags |= DLM_MRES_ALL_DONE;\n\nMBR, Sergei\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-ide\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ide-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=cogentembedded-com.20150623.gappssmtp.com\n\theader.i=@cogentembedded-com.20150623.gappssmtp.com\n\theader.b=\"Wk+pDuxX\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwsYZ0vhCz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 02:54:42 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932950AbdIRQyk (ORCPT );\n\tMon, 18 Sep 2017 12:54:40 -0400","from mail-lf0-f49.google.com ([209.85.215.49]:49473 \"EHLO\n\tmail-lf0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S932783AbdIRQyj (ORCPT\n\t); Mon, 18 Sep 2017 12:54:39 -0400","by mail-lf0-f49.google.com with SMTP id r17so1194311lff.6\n\tfor ; Mon, 18 Sep 2017 09:54:38 -0700 (PDT)","from wasted.cogentembedded.com ([31.173.81.185])\n\tby smtp.gmail.com with ESMTPSA id\n\tw65sm1934066lje.17.2017.09.18.09.54.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 09:54:36 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cogentembedded-com.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:organization:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=LlrxiODuCyyocJ0tHUeVhGtB4xvdsXfrBCBgObn0/n8=;\n\tb=Wk+pDuxXtujJGNuJcUzfH9TIVQbMCryCd5dRBSrhJrxAFYtHlx5wGC1Tm7h6YZTEst\n\tGNTmVZE+D4YJouVcsZ2G/QEeg7cdDne2XC/82Be3hPSbBws3Um01pq29VdGsz6L81Kvp\n\th+fJ/PhQ5UAtPLxVqfElEBx02x6k/ewUHOEHsyBQO9gkYeD9jIpAn4T1cNHLooosCpIK\n\tkcyrJ17F3XxEiC2sxVXmpTFGJmy1syczANlCiSFeffNKj+GzSZlWd5M4aaabnHtD86Sb\n\tmPoDL7i/HqKu1l3A/n4DrYWEzOoVhuMuFHTsHuOkFcdAzqVHsWDUXI3ZnYfc1WVUBzIo\n\tSMYw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:organization\n\t:message-id:date:user-agent:mime-version:in-reply-to\n\t:content-language:content-transfer-encoding;\n\tbh=LlrxiODuCyyocJ0tHUeVhGtB4xvdsXfrBCBgObn0/n8=;\n\tb=MCzNrbnz9VlxxfAKqKa5CMxY1zERW4FVg2pklaD1DuNHcyFeR5BA+oYSh6oaOpX9TJ\n\tP4CIP+8g/T/PaoF9VOBTljOgnIV/wcgVLxYzSkkfd+jjxeaVg8++KPxuLqN6zyG27M2z\n\tCwBbYi9UdtQv2/GSk4FI/PcA63mdUEGPetRdYTj3bCrU8aC3/ATJbLdEuV22TowS2ejR\n\tax3bqukYSVrh8kyDwBayCjjCuifytv3olRPhbz/I2Fjjc4jHif/ANdSl/M4bjJYYZpFY\n\tqOzFjuqr+nSnMEM2hOUe3sPo7QiHgSxmh/M+EBCr87Hg2IqrvAn9nb/boMBdEbfCPISY\n\tSh0A==","X-Gm-Message-State":"AHPjjUi/SzCueDR7vGLbAA0ZFxUJ8el3zracHwZpYMbMEZfA1z4N2So0\n\tEvdWB70+cO5UqxXV","X-Google-Smtp-Source":"AOwi7QDn4DloujDHjJ7O7+DyX7VL9WCsl5VrIg7LVGhjLIZs2c/Z1EX5b3Dohh1Z+s7y2cQNLw5e7w==","X-Received":"by 10.46.101.208 with SMTP id e77mr7414482ljf.52.1505753677530; \n\tMon, 18 Sep 2017 09:54:37 -0700 (PDT)","Subject":"Re: [PATCH][V2] libata: make const arrays static,\n\treduces object code size","To":"Colin King , Tejun Heo ,\n\tMark Fasheh , Joel Becker ,\n\tAndrew Morton ,\n\tpiaojun , linux-ide@vger.kernel.org,\n\tocfs2-devel@oss.oracle.com","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","References":"<20170918133219.31293-1-colin.king@canonical.com>","From":"Sergei Shtylyov ","Organization":"Cogent Embedded","Message-ID":"<5dd9e5be-22c3-f2c3-9a55-ac44591600fe@cogentembedded.com>","Date":"Mon, 18 Sep 2017 19:54:35 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170918133219.31293-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-MW","Content-Transfer-Encoding":"7bit","Sender":"linux-ide-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ide@vger.kernel.org"}}]