[{"id":1770631,"web_url":"http://patchwork.ozlabs.org/comment/1770631/","msgid":"<20170919032956.GP378890@devbig577.frc2.facebook.com>","list_archive_url":null,"date":"2017-09-19T03:29:56","subject":"Re: [PATCH] libata: make static arrays const, reduces object code\n\tsize","submitter":{"id":352,"url":"http://patchwork.ozlabs.org/api/people/352/","name":"Tejun Heo","email":"tj@kernel.org"},"content":"On Mon, Sep 18, 2017 at 02:31:40PM +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> Don't populate const arrayis on the stack, instead make them static.\n> Makes the object code smaller by over 260 bytes:\n> \n> Signed-off-by: Colin Ian King \n...\n> diff --git a/fs/ocfs2/dlm/dlmrecovery.c b/fs/ocfs2/dlm/dlmrecovery.c\n> index 74407c6dd592..31a61e8e0152 100644\n> --- a/fs/ocfs2/dlm/dlmrecovery.c\n> +++ b/fs/ocfs2/dlm/dlmrecovery.c\n> @@ -1129,7 +1129,6 @@ static int dlm_send_mig_lockres_msg(struct dlm_ctxt *dlm,\n> \t\t(mres->num_locks * sizeof(struct dlm_migratable_lock));\n> \n> \t/* add an all-done flag if we reached the last lock */\n> -\torig_flags = mres->flags;\n> \tBUG_ON(total_locks > mres_total_locks);\n> \tif (total_locks == mres_total_locks)\n> \t\tmres->flags |= DLM_MRES_ALL_DONE;\n\nLooks like patch contamination.\n\nThanks.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-ide-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EwGURbia\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx7fg2W6Xz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 13:30:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751205AbdISDaC (ORCPT );\n\tMon, 18 Sep 2017 23:30:02 -0400","from mail-qt0-f196.google.com ([209.85.216.196]:38202 \"EHLO\n\tmail-qt0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751100AbdISDaA (ORCPT\n\t); Mon, 18 Sep 2017 23:30:00 -0400","by mail-qt0-f196.google.com with SMTP id f24so1570879qte.5;\n\tMon, 18 Sep 2017 20:30:00 -0700 (PDT)","from localhost (dhcp-ec-8-6b-ed-7a-cf.cpe.echoes.net.\n\t[72.28.26.219]) by smtp.gmail.com with ESMTPSA id\n\tx55sm6445156qth.91.2017.09.18.20.29.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 20:29:59 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=sender:date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=zzixqTj1M+chWNZkoByGrp6A3WpGzw3mDtCvHx/vEdU=;\n\tb=EwGURbia9XNtpoZFx0M05UTQlqPi6OgrEw5itFm2ulMpmSk433nPt4SKZ2KR1aTtPa\n\tUAGcS0ETWQawgxQKUZaVn/ySORG6Li/pARXeIGZ8N6Jmx9c2fWfFNXG1k2LD5hZQ5JBf\n\tL5daTnoA3VWt8MZO3kSydY4wwW5jz1blkDwawqCdCDQGSWhmA3DN0SgEZBal55247gIa\n\t5qKUGxOCubylA+50T+/tXcVTYjGwz3uSDliBWgLcnewh/W+jOpjM28Ox9ugUVG3RAoY0\n\tF3HBd2eD07iC5asMxnBwRVfX3SfNUpDGtRDYohkY8bzeKzP2tIDR5gBaaE6kLJ4bzacy\n\tmxbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:date:from:to:cc:subject:message-id\n\t:references:mime-version:content-disposition:in-reply-to:user-agent; \n\tbh=zzixqTj1M+chWNZkoByGrp6A3WpGzw3mDtCvHx/vEdU=;\n\tb=S5dG2g/vEt4TKR/kWIOJ9eReIPSNtm3tPtiMWywI7oIj7Kgo/HeNmn/DCqodzlYQJK\n\t699k0WY/zAyrYPdvB/f9AQMDcgHkxAxIXtWq8s2kS+xau7SMsewc6YVy/fUKvlOVKOF8\n\tEWMVBdnhtEThQSc18DMShnFmIwqr0t1/67xz7/KBDpPPpZ4L2aY3mqixWtnC3Ue+w7zu\n\tzegqdZP+VQVAEgm+ZacIZuCqoAE3mP9TJqPDQ6S8EReGYMCAB7bo/NH26JXSPFebbM1y\n\tcbTQzQEzdsAI3WKOpx+MUVlwNiV7ddjRv3mHOXrFX+jG38OhlS87rNLokQN0es1g0FcO\n\tKyFQ==","X-Gm-Message-State":"AHPjjUhUdLe2lZpkDLfNvx+ZsRf+tKyV6lxg8XZYt6fgyzO5xS8eEOiS\n\tzb67I0xUuPfATmIGchgzWOmnyAxd","X-Google-Smtp-Source":"AOwi7QDGI2Q/TsoWYl819TCapzoRU7WdKLpBbVaSIR9rRJhqJPgNTYEW+ib9MAIaK3I2OriT24M8Jw==","X-Received":"by 10.200.58.67 with SMTP id w61mr8541qte.151.1505791800172;\n\tMon, 18 Sep 2017 20:30:00 -0700 (PDT)","Date":"Mon, 18 Sep 2017 20:29:56 -0700","From":"Tejun Heo ","To":"Colin King ","Cc":"Mark Fasheh , Joel Becker ,\n\tAndrew Morton ,\n\tpiaojun , linux-ide@vger.kernel.org,\n\tocfs2-devel@oss.oracle.com, kernel-janitors@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH] libata: make static arrays const, reduces object code\n\tsize","Message-ID":"<20170919032956.GP378890@devbig577.frc2.facebook.com>","References":"<20170918133140.31220-1-colin.king@canonical.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918133140.31220-1-colin.king@canonical.com>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-ide-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-ide@vger.kernel.org"}}]