[{"id":1770145,"web_url":"http://patchwork.ozlabs.org/comment/1770145/","msgid":"<59BFC699.1060009@iogearbox.net>","list_archive_url":null,"date":"2017-09-18T13:14:01","subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","submitter":{"id":65705,"url":"http://patchwork.ozlabs.org/api/people/65705/","name":"Daniel Borkmann","email":"daniel@iogearbox.net"},"content":"On 09/18/2017 03:03 PM, Tobias Klauser wrote:\n> If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned\n> regardless of the actual error produced by bpf_map_precharge_memlock.\n> Fix it by passing on the error returned by bpf_map_precharge_memlock.\n>\n> Also return -EINVAL instead of -ENOMEM if the page count overflow check\n> fails.\n>\n> This makes dev_map_alloc match the behavior of other bpf maps' alloc\n> functions wrt. return values.\n>\n> Signed-off-by: Tobias Klauser \n\n(This would then need to go via net tree.)\n\nAcked-by: Daniel Borkmann ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwmg620CJz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 23:14:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753210AbdIRNOG (ORCPT );\n\tMon, 18 Sep 2017 09:14:06 -0400","from www62.your-server.de ([213.133.104.62]:39151 \"EHLO\n\twww62.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751609AbdIRNOF (ORCPT\n\t); Mon, 18 Sep 2017 09:14:05 -0400","from [194.230.155.169] (helo=localhost.localdomain)\n\tby www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dtvsB-0004Xa-5E; Mon, 18 Sep 2017 15:14:03 +0200"],"Message-ID":"<59BFC699.1060009@iogearbox.net>","Date":"Mon, 18 Sep 2017 15:14:01 +0200","From":"Daniel Borkmann ","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:31.0) Gecko/20100101 Thunderbird/31.7.0","MIME-Version":"1.0","To":"Tobias Klauser , Alexei Starovoitov ","CC":"John Fastabend , netdev@vger.kernel.org","Subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","References":"<20170918130346.10833-1-tklauser@distanz.ch>","In-Reply-To":"<20170918130346.10833-1-tklauser@distanz.ch>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-Authenticated-Sender":"daniel@iogearbox.net","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23849/Mon Sep 18 10:42:22 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770273,"web_url":"http://patchwork.ozlabs.org/comment/1770273/","msgid":"<20170918155706.dtqxrffmw3ttnztg@ast-mbp.dhcp.thefacebook.com>","list_archive_url":null,"date":"2017-09-18T15:57:10","subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","submitter":{"id":42586,"url":"http://patchwork.ozlabs.org/api/people/42586/","name":"Alexei Starovoitov","email":"alexei.starovoitov@gmail.com"},"content":"On Mon, Sep 18, 2017 at 03:03:46PM +0200, Tobias Klauser wrote:\n> If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned\n> regardless of the actual error produced by bpf_map_precharge_memlock.\n> Fix it by passing on the error returned by bpf_map_precharge_memlock.\n> \n> Also return -EINVAL instead of -ENOMEM if the page count overflow check\n> fails.\n> \n> This makes dev_map_alloc match the behavior of other bpf maps' alloc\n> functions wrt. return values.\n> \n> Signed-off-by: Tobias Klauser \n\ngood catch.\nAcked-by: Alexei Starovoitov ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"L+gy7O7Q\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwrHL0PQCz9s78\n\tfor ;\n\tTue, 19 Sep 2017 01:57:18 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755797AbdIRP5P (ORCPT );\n\tMon, 18 Sep 2017 11:57:15 -0400","from mail-pg0-f45.google.com ([74.125.83.45]:47185 \"EHLO\n\tmail-pg0-f45.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755765AbdIRP5O (ORCPT\n\t); Mon, 18 Sep 2017 11:57:14 -0400","by mail-pg0-f45.google.com with SMTP id d8so355175pgt.4\n\tfor ; Mon, 18 Sep 2017 08:57:14 -0700 (PDT)","from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::7:b62d])\n\tby smtp.gmail.com with ESMTPSA id\n\tv8sm12227147pgs.9.2017.09.18.08.57.11\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 08:57:12 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=/ZaJ/PBaIL9pNQhjLto7GiwUqJ2Dr34yX0ktMHKiRdY=;\n\tb=L+gy7O7Q0A9DfbbV2Nn4uNuTXGHtxkRZAqJCQnkVY+jyjGpTIKi8Ui56VGcgl5ny0p\n\t0+SV40j6Y+vSlSh+p2Uss2Fh7vpIA3mXA5sO6SQy3a4turXtZo4IkPBSXVaTEjp4Ggt1\n\tetcNhEvTDHM1WMK7eWZdztSNdevKSgQek2Z4ApF3BZui1zdYtYqU8Nlo3aH912TR2wma\n\t8qfxRqQPqa2mGHmdnPTL//yWW2U+xrPMtpGSpwZql7zCZ0J4ggylWxOGbLsSElj6/Q7N\n\tOnRPkknm3/dxvdN1sIO5ECD7vZGNZ7Cf1J10Z2J9XTLO8K792eC4fsoQkJmaWM0uS27K\n\tBSpA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=/ZaJ/PBaIL9pNQhjLto7GiwUqJ2Dr34yX0ktMHKiRdY=;\n\tb=D1jehyw5Q9E4Soki4PdKVR3inFyTqL2f7PhHkx+aXh751qCxxUZ6uWHzoBlgGaaaqT\n\tvwHrFFAzK3uwuWDoutQNYr8E5awHx8aq1Dx0PiSJ51Y3ZITOu7j3DmKX9fDrpz3Xxmuy\n\tC6CmxqR94JctAXx65mDeW3wzdkZeu6EGO27NTrygARxpLCVZAcxGANsWS89S4korRKyJ\n\trIlhOAFzliviR1sWelkv9S4MHjeLFfd0c/eQkedonGr+9BCGti3OUm6zsHu7TYaY896h\n\tCpKFvX02PA1CYYAzHjuxk+GXtT3N7jyFbFmOVNN2VsUQLWivOWEO7LjPaJyBVhtmkiGE\n\tpMVA==","X-Gm-Message-State":"AHPjjUiBBFavZTi90yIItcrKsTLE7b2P7Owknrd/YubpC2aEKg5nv97t\n\tUIP49AOZMtcMA61cjok=","X-Google-Smtp-Source":"ADKCNb7wxEtCPOTMnlsuyqkWpbwSDWLFCLTAm05e4urmxlW221FxGbHn4mTee5qK3C+fv0IH8RbrUA==","X-Received":"by 10.98.82.71 with SMTP id g68mr25195951pfb.125.1505750233740; \n\tMon, 18 Sep 2017 08:57:13 -0700 (PDT)","Date":"Mon, 18 Sep 2017 08:57:10 -0700","From":"Alexei Starovoitov ","To":"Tobias Klauser ","Cc":"Alexei Starovoitov ,\n\tDaniel Borkmann ,\n\tJohn Fastabend , netdev@vger.kernel.org","Subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","Message-ID":"<20170918155706.dtqxrffmw3ttnztg@ast-mbp.dhcp.thefacebook.com>","References":"<20170918130346.10833-1-tklauser@distanz.ch>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918130346.10833-1-tklauser@distanz.ch>","User-Agent":"NeoMutt/20170421 (1.8.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770587,"web_url":"http://patchwork.ozlabs.org/comment/1770587/","msgid":"<20170918.165357.480851390980422798.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-18T23:53:57","subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Tobias Klauser \nDate: Mon, 18 Sep 2017 15:03:46 +0200\n\n> If bpf_map_precharge_memlock in dev_map_alloc, -ENOMEM is returned\n> regardless of the actual error produced by bpf_map_precharge_memlock.\n> Fix it by passing on the error returned by bpf_map_precharge_memlock.\n> \n> Also return -EINVAL instead of -ENOMEM if the page count overflow check\n> fails.\n> \n> This makes dev_map_alloc match the behavior of other bpf maps' alloc\n> functions wrt. return values.\n> \n> Signed-off-by: Tobias Klauser \n\nApplied, thank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx2sR3gfpz9s5L\n\tfor ;\n\tTue, 19 Sep 2017 09:54:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751453AbdIRXyB (ORCPT );\n\tMon, 18 Sep 2017 19:54:01 -0400","from shards.monkeyblade.net ([184.105.139.130]:59128 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750828AbdIRXyA (ORCPT\n\t); Mon, 18 Sep 2017 19:54:00 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id C0F2D102A6515;\n\tMon, 18 Sep 2017 16:53:57 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 16:53:57 -0700 (PDT)","Message-Id":"<20170918.165357.480851390980422798.davem@davemloft.net>","To":"tklauser@distanz.ch","Cc":"ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH] bpf: devmap: pass on return value of\n\tbpf_map_precharge_memlock","From":"David Miller ","In-Reply-To":"<20170918130346.10833-1-tklauser@distanz.ch>","References":"<20170918130346.10833-1-tklauser@distanz.ch>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 16:53:58 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]