[{"id":1770201,"web_url":"http://patchwork.ozlabs.org/comment/1770201/","msgid":"<05940475-2563-87fc-bdc5-5acb1bba4932@redhat.com>","list_archive_url":null,"date":"2017-09-18T14:28:12","subject":"Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export\n\ttarget AS from address_space_translate_internal","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote:\n\nSubject line: s/Explicitely/Explicitly/\n\n> This is not so mechanical change in order to move to shared FlatViews\n> so make it a separate patch.\n\nHard to understand; it's unclear whether this is the mechanical addition\nof a parameter before the next patch does shared FlatViews, or whether\nthe next patch is mechanical by virtue of this patch doing the\nnon-mechanical changes. Maybe:\n\nMechanical change to add a parameter to make it easier for the next\npatch to share FlatViews.\n\n> The first argument of\n> address_space_do_translate() will become a FlatView, however since\n> address_space_get_iotlb_entry() still wants AS, hence this change.\n> \n> Signed-off-by: Alexey Kardashevskiy \n> ---\n> exec.c | 11 +++++++----\n> 1 file changed, 7 insertions(+), 4 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwpKB0lxMz9s7F\n\tfor ;\n\tTue, 19 Sep 2017 00:28:46 +1000 (AEST)","from localhost ([::1]:36979 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtx2S-0007uV-6E\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 10:28:44 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51679)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtx23-0007uI-FT\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:28:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtx1z-0000Uo-Hx\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:28:19 -0400","from mx1.redhat.com ([209.132.183.28]:45814)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtx1z-0000Ud-8o\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:28:15 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4339E285C1;\n\tMon, 18 Sep 2017 14:28:14 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id A77626060C;\n\tMon, 18 Sep 2017 14:28:13 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4339E285C1","To":"Alexey Kardashevskiy , qemu-devel@nongnu.org","References":"<20170918101709.30421-1-aik@ozlabs.ru>\n\t<20170918101709.30421-3-aik@ozlabs.ru>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<05940475-2563-87fc-bdc5-5acb1bba4932@redhat.com>","Date":"Mon, 18 Sep 2017 09:28:12 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918101709.30421-3-aik@ozlabs.ru>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"1lraGoX1WxNBbE9FAvdK51mPMBU11Jtvw\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 18 Sep 2017 14:28:14 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export\n\ttarget AS from address_space_translate_internal","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770592,"web_url":"http://patchwork.ozlabs.org/comment/1770592/","msgid":"<410e74f9-76c9-6b6a-3236-d7782a97520b@ozlabs.ru>","list_archive_url":null,"date":"2017-09-19T00:15:34","subject":"Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export\n\ttarget AS from address_space_translate_internal","submitter":{"id":7621,"url":"http://patchwork.ozlabs.org/api/people/7621/","name":"Alexey Kardashevskiy","email":"aik@ozlabs.ru"},"content":"On 19/09/17 00:28, Eric Blake wrote:\n> On 09/18/2017 05:16 AM, Alexey Kardashevskiy wrote:\n> \n> Subject line: s/Explicitely/Explicitly/\n> \n>> This is not so mechanical change in order to move to shared FlatViews\n>> so make it a separate patch.\n> \n> Hard to understand; it's unclear whether this is the mechanical addition\n> of a parameter before the next patch does shared FlatViews, or whether\n> the next patch is mechanical by virtue of this patch doing the\n> non-mechanical changes. Maybe:\n> \n> Mechanical change to add a parameter to make it easier for the next\n> patch to share FlatViews.\n\nI was told in this list that \"mechanical\" is when simple 's/lalala/mememe/'\ndoes the job, when it is bigger than this - then it is \"this should not\ncause any behavioural change\" :) I'll add such note where applicable.\n\ntbh only 1/13, 11/13 and 13/13 do cause a change in behaviour, others do not.\n\n> \n>> The first argument of\n>> address_space_do_translate() will become a FlatView, however since\n>> address_space_get_iotlb_entry() still wants AS, hence this change.\n>>\n>> Signed-off-by: Alexey Kardashevskiy \n>> ---\n>> exec.c | 11 +++++++----\n>> 1 file changed, 7 insertions(+), 4 deletions(-)\n>>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ozlabs-ru.20150623.gappssmtp.com\n\theader.i=@ozlabs-ru.20150623.gappssmtp.com\n\theader.b=\"Vt5IQ76G\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx3QQ23ZZz9s7M\n\tfor ;\n\tTue, 19 Sep 2017 10:19:10 +1000 (AEST)","from localhost ([::1]:39416 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du6Fn-0002AZ-Os\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 20:19:07 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38417)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du6CZ-00009F-89\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 20:15:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du6CV-0006dY-62\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 20:15:47 -0400","from mail-pf0-x243.google.com ([2607:f8b0:400e:c00::243]:38834)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1du6CU-0006cw-W5\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 20:15:43 -0400","by mail-pf0-x243.google.com with SMTP id q76so801681pfq.5\n\tfor ; Mon, 18 Sep 2017 17:15:42 -0700 (PDT)","from [192.168.10.22] (124-171-134-202.dyn.iinet.net.au.\n\t[124.171.134.202]) by smtp.googlemail.com with ESMTPSA id\n\tk82sm645807pfj.66.2017.09.18.17.15.37\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 17:15:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ozlabs-ru.20150623.gappssmtp.com; s=20150623;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to;\n\tbh=vLLs6U4iFzhf5H2pO8ZA+ZFIcq24EfQxMQQMQuIdLW0=;\n\tb=Vt5IQ76GonTLF8og2B0/FFV9qzayS/y63/vhoAK/gPljlIDCt/skFzqOw2Sk2ckrp4\n\trav3gLRXP3Vz73FmuVNrjtH2okB/B3fFIi3hfeFUTznw5yry1i2T7HFlWR6lJwwvpOE5\n\t7KTNeP+MhNxlJM6LEp92tnoSXbazgJBBYxPL44ASPArGbBlg66UmEjjcbkolsR9LowWb\n\t6H8bPaXRX//1/J8s9/pis/s6Is5geDfJHit2+8iunZVjMUtG2ep9XZX0gsRycz1cBc3W\n\tkg1MmyD/eW2gX7w60LRQEicgnBi3YZUbCm3eDa8pVeLheSsBER52tNsXcbHBeounBnwr\n\tOjkQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to;\n\tbh=vLLs6U4iFzhf5H2pO8ZA+ZFIcq24EfQxMQQMQuIdLW0=;\n\tb=lW2m7sK8CSFEEnbOJZvvddXmKAxvgzHSK9TKspjuXn1vY2IE0gmuB4X/hzaOYfcmZu\n\t6ePo5Mn2sH4MFH8nG2KDLe/Oq46B1j5XiyGfqvkt+yUH4ACXVEMjX+Cwne20lzMQXxGm\n\t8LpByxMR6NJoRAOASAKyGQckyeCMu8Z887NjaV3nMMNRJfktzqVJoF0Ez+4pQLU7wsqc\n\tXOek/do+/AMp1xQjJT6miulv39kci3g9II70ap5oaPulchTED11HYvRUld2KDtW2lUMY\n\tHczI2s/RpZLIfp8M8hbrCK6AWKsqR3EEB+nNQ/FYRfModEcOKfHwP7aDxPUBoPRmC43B\n\t/eyQ==","X-Gm-Message-State":"AHPjjUjOlwT41Rnc31RnOGyMK54xZRbc+y5CjfwIl4z8m+UNoECm/HuT\n\tBiz7C9I/m6IGmSiX","X-Google-Smtp-Source":"AOwi7QB0c9H1gvHUFSv+WhQuNu9EPrsd6rmxmzgxStP4kgWTviRfjm/TPyVbEBRObRqUV7WikeIRfQ==","X-Received":"by 10.84.252.130 with SMTP id y2mr302529pll.68.1505780141617;\n\tMon, 18 Sep 2017 17:15:41 -0700 (PDT)","To":"Eric Blake , qemu-devel@nongnu.org","References":"<20170918101709.30421-1-aik@ozlabs.ru>\n\t<20170918101709.30421-3-aik@ozlabs.ru>\n\t<05940475-2563-87fc-bdc5-5acb1bba4932@redhat.com>","From":"Alexey Kardashevskiy ","Message-ID":"<410e74f9-76c9-6b6a-3236-d7782a97520b@ozlabs.ru>","Date":"Tue, 19 Sep 2017 10:15:34 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<05940475-2563-87fc-bdc5-5acb1bba4932@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"w638gPifdl44jlVBRAV2gJo2oRMx2U55c\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::243","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export\n\ttarget AS from address_space_translate_internal","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]