[{"id":1772203,"web_url":"http://patchwork.ozlabs.org/comment/1772203/","msgid":"<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:53:13","subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote:\n> A lot of devices do not need and do not document port or endpoint\n> numbering at all, e.g. in case where there's just a single port and a\n> single endpoint. Whereas this is just common sense, document it to make it\n> explicit.\n> \n> Signed-off-by: Sakari Ailus \n> ---\n> Documentation/devicetree/bindings/media/video-interfaces.txt | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n\nThis is fine, but bindings should still be explicit. Otherwise, I'm \nwondering if it's a single port/endpoint or they just forgot to document \nit. And I shouldn't have to look at the example to infer that.\n\nAcked-by: Rob Herring \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBmh0mV1z9sPm\n\tfor ;\n\tThu, 21 Sep 2017 06:53:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752233AbdITUxR (ORCPT\n\t);\n\tWed, 20 Sep 2017 16:53:17 -0400","from mail-pg0-f65.google.com ([74.125.83.65]:35673 \"EHLO\n\tmail-pg0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752227AbdITUxP (ORCPT\n\t); Wed, 20 Sep 2017 16:53:15 -0400","by mail-pg0-f65.google.com with SMTP id j16so2249629pga.2;\n\tWed, 20 Sep 2017 13:53:14 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\tu73sm8746318pfi.58.2017.09.20.13.53.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:53:13 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=PmzmY6c1uO8ka7cFokwJmenzSQhCJkbkQ5H3A6S/Q54=;\n\tb=Vr8xJUQ6gyJsEFvTIJ9j2PyJ8YkSvpr0oUlEIs+dfNmEzM/JBvfOVvl1b9b5LZc4JT\n\tyj+YGO4c1iM+JA9/iQSdhtGfAjSgGKF8/7bOLcgYcZkSy4N38vgHLNjK9Ydt/43oY3QH\n\tVBsAOxOgQ6+49mYF9g8jqaksGcwiVOJqmvAEvoutonGEKOlApJoVIkxwHEjwLQ7Ymqnv\n\t9DJ9IeeZKbS5wjI5qAOLo+P+pmM4Xs4Bt/1cOLZbeWp0TzpTg42hgM584mhFK/MyYE0U\n\tXGBNI13IY4Wn6TGG9fk58bfHD2Xijw31oo0dMWizP+3eUpdyEUZ0cBGZFwdP9qNScEKm\n\tbUog==","X-Gm-Message-State":"AHPjjUihFQwnj636lFzdYxM5oWvOw7O9GPN3ffx21U9NDj0l/QkdtIT1\n\tdt1E7lxtUpebXEfNN0vFnQ01T5Y=","X-Google-Smtp-Source":"AOwi7QBBnueqdyDhMuvKG5pVOi5ccHs4s6iAzrWcZYvqU/ZIgBnRs/sHWR4U6ThHWjGs54U6q7M6pw==","X-Received":"by 10.84.241.201 with SMTP id t9mr3319139plm.154.1505940794536; \n\tWed, 20 Sep 2017 13:53:14 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:53:13 -0500","From":"Rob Herring ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, devicetree@vger.kernel.org","Subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","Message-ID":"<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>","References":"<1505723105-16238-1-git-send-email-sakari.ailus@linux.intel.com>\n\t<1505723105-16238-2-git-send-email-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<1505723105-16238-2-git-send-email-sakari.ailus@linux.intel.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772610,"web_url":"http://patchwork.ozlabs.org/comment/1772610/","msgid":"<20170921092516.yzjelpxka4firnwx@paasikivi.fi.intel.com>","list_archive_url":null,"date":"2017-09-21T09:25:17","subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","submitter":{"id":65485,"url":"http://patchwork.ozlabs.org/api/people/65485/","name":"Sakari Ailus","email":"sakari.ailus@linux.intel.com"},"content":"Hi Rob,\n\nThanks for the reply.\n\nOn Wed, Sep 20, 2017 at 03:53:13PM -0500, Rob Herring wrote:\n> On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote:\n> > A lot of devices do not need and do not document port or endpoint\n> > numbering at all, e.g. in case where there's just a single port and a\n> > single endpoint. Whereas this is just common sense, document it to make it\n> > explicit.\n> > \n> > Signed-off-by: Sakari Ailus \n> > ---\n> > Documentation/devicetree/bindings/media/video-interfaces.txt | 12 ++++++++++++\n> > 1 file changed, 12 insertions(+)\n> \n> This is fine, but bindings should still be explicit. Otherwise, I'm \n> wondering if it's a single port/endpoint or they just forgot to document \n> it. And I shouldn't have to look at the example to infer that.\n> \n> Acked-by: Rob Herring \n\nThe purpose of the patch was to actually document port and endpoint\nnumbering for devices for which it is not documented, not to suggest that\nthis would be omitted in in binding documentation. The fact is that I\ncouldn't find documentation for endpoint numbering for a single device\nunder Documentation/devicetree/bindings/media/ . Yet I haven't come across\nDT source where other than zero would have been used. And the drivers\n(mostly?) have ignored endpoint numbers so far.\n\nSome bindings have been omitted on the grounds that they're documented in\nvideo-interfaces.txt.\n\nWhat would you think of the following? I'm not sure it'd really belong\nthere, but it'd be a small piece of documentation one can easily refer to.\n\n\n>From e735979005244eb10597fe5333130b93e41d5a38 Mon Sep 17 00:00:00 2001\nFrom: Sakari Ailus \nDate: Mon, 18 Sep 2017 11:15:53 +0300\nSubject: [PATCH 1/1] dt: bindings: media: Document practices for DT bindings,\n ports, endpoints\n\nPort and endpoint numbering has been omitted in DT binding documentation\nfor a large number of devices. Also common properties the device uses have\nbeen missed in binding documentation. Make it explicit that these things\nneed to be documented.\n\nSigned-off-by: Sakari Ailus \n---\n .../devicetree/bindings/media/video-interfaces.txt | 15 +++++++++++++++\n 1 file changed, 15 insertions(+)\n\ndiff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\nindex 852041a..3c5382f 100644\n--- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n+++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n@@ -55,6 +55,21 @@ divided into two separate ITU-R BT.656 8-bit busses. In such case bus-width\n and data-shift properties can be used to assign physical data lines to each\n endpoint node (logical bus).\n \n+Documenting bindings for devices\n+--------------------------------\n+\n+All required and optional bindings the device supports shall be explicitly\n+documented in device DT binding documentation. This also includes port and\n+endpoint numbering for the device.\n+\n+Port and endpoint numbering\n+---------------------------\n+\n+Old binding documentation may have omitted explicitly specifying port and\n+endpoint numbers. This often applies to devices that have a single port and a\n+single endpoint in that port. In this case, the only valid port number for such\n+a device is zero. The same applies for devices for which bindings do not\n+document endpoint numbering: only zero is a valid endpoint.\n \n Required properties\n -------------------","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyWRl65Lpz9t42\n\tfor ;\n\tThu, 21 Sep 2017 19:25:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751387AbdIUJZW (ORCPT\n\t);\n\tThu, 21 Sep 2017 05:25:22 -0400","from mga06.intel.com ([134.134.136.31]:33516 \"EHLO mga06.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750912AbdIUJZV (ORCPT );\n\tThu, 21 Sep 2017 05:25:21 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 21 Sep 2017 02:25:20 -0700","from paasikivi.fi.intel.com ([10.237.72.42])\n\tby FMSMGA003.fm.intel.com with ESMTP; 21 Sep 2017 02:25:19 -0700","by paasikivi.fi.intel.com (Postfix, from userid 1000)\n\tid 2C8FA2079C; Thu, 21 Sep 2017 12:25:17 +0300 (EEST)"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,424,1500966000\"; d=\"scan'208\";a=\"902510890\"","Date":"Thu, 21 Sep 2017 12:25:17 +0300","From":"Sakari Ailus ","To":"Rob Herring ","Cc":"linux-media@vger.kernel.org, devicetree@vger.kernel.org","Subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","Message-ID":"<20170921092516.yzjelpxka4firnwx@paasikivi.fi.intel.com>","References":"<1505723105-16238-1-git-send-email-sakari.ailus@linux.intel.com>\n\t<1505723105-16238-2-git-send-email-sakari.ailus@linux.intel.com>\n\t<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772953,"web_url":"http://patchwork.ozlabs.org/comment/1772953/","msgid":"","list_archive_url":null,"date":"2017-09-21T15:58:34","subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Thu, Sep 21, 2017 at 4:25 AM, Sakari Ailus\n wrote:\n> Hi Rob,\n>\n> Thanks for the reply.\n>\n> On Wed, Sep 20, 2017 at 03:53:13PM -0500, Rob Herring wrote:\n>> On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote:\n>> > A lot of devices do not need and do not document port or endpoint\n>> > numbering at all, e.g. in case where there's just a single port and a\n>> > single endpoint. Whereas this is just common sense, document it to make it\n>> > explicit.\n>> >\n>> > Signed-off-by: Sakari Ailus \n>> > ---\n>> > Documentation/devicetree/bindings/media/video-interfaces.txt | 12 ++++++++++++\n>> > 1 file changed, 12 insertions(+)\n>>\n>> This is fine, but bindings should still be explicit. Otherwise, I'm\n>> wondering if it's a single port/endpoint or they just forgot to document\n>> it. And I shouldn't have to look at the example to infer that.\n>>\n>> Acked-by: Rob Herring \n>\n> The purpose of the patch was to actually document port and endpoint\n> numbering for devices for which it is not documented, not to suggest that\n> this would be omitted in in binding documentation. The fact is that I\n> couldn't find documentation for endpoint numbering for a single device\n> under Documentation/devicetree/bindings/media/ . Yet I haven't come across\n> DT source where other than zero would have been used. And the drivers\n> (mostly?) have ignored endpoint numbers so far.\n\nThat's surprising. I know there are some for display controllers and\nit's a common review comment I give.\n\n>\n> Some bindings have been omitted on the grounds that they're documented in\n> video-interfaces.txt.\n>\n> What would you think of the following? I'm not sure it'd really belong\n> there, but it'd be a small piece of documentation one can easily refer to.\n\nLooks good.\n\n>\n>\n> From e735979005244eb10597fe5333130b93e41d5a38 Mon Sep 17 00:00:00 2001\n> From: Sakari Ailus \n> Date: Mon, 18 Sep 2017 11:15:53 +0300\n> Subject: [PATCH 1/1] dt: bindings: media: Document practices for DT bindings,\n> ports, endpoints\n>\n> Port and endpoint numbering has been omitted in DT binding documentation\n> for a large number of devices. Also common properties the device uses have\n> been missed in binding documentation. Make it explicit that these things\n> need to be documented.\n>\n> Signed-off-by: Sakari Ailus \n> ---\n> .../devicetree/bindings/media/video-interfaces.txt | 15 +++++++++++++++\n> 1 file changed, 15 insertions(+)\n>\n> diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> index 852041a..3c5382f 100644\n> --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> @@ -55,6 +55,21 @@ divided into two separate ITU-R BT.656 8-bit busses. In such case bus-width\n> and data-shift properties can be used to assign physical data lines to each\n> endpoint node (logical bus).\n>\n> +Documenting bindings for devices\n> +--------------------------------\n> +\n> +All required and optional bindings the device supports shall be explicitly\n> +documented in device DT binding documentation. This also includes port and\n> +endpoint numbering for the device.\n> +\n> +Port and endpoint numbering\n> +---------------------------\n> +\n> +Old binding documentation may have omitted explicitly specifying port and\n> +endpoint numbers. This often applies to devices that have a single port and a\n> +single endpoint in that port. In this case, the only valid port number for such\n> +a device is zero. The same applies for devices for which bindings do not\n> +document endpoint numbering: only zero is a valid endpoint.\n>\n> Required properties\n> -------------------\n> --\n> 2.7.4\n>\n> --\n> Sakari Ailus\n> sakari.ailus@linux.intel.com\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyh9t4tzvz9t4B\n\tfor ;\n\tFri, 22 Sep 2017 01:58:58 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751596AbdIUP65 (ORCPT\n\t);\n\tThu, 21 Sep 2017 11:58:57 -0400","from mail.kernel.org ([198.145.29.99]:34146 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750790AbdIUP64 (ORCPT );\n\tThu, 21 Sep 2017 11:58:56 -0400","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id A6AAB22A72;\n\tThu, 21 Sep 2017 15:58:55 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id l25so6361831qtf.13;\n\tThu, 21 Sep 2017 08:58:55 -0700 (PDT)","by 10.12.209.75 with HTTP; Thu, 21 Sep 2017 08:58:34 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org A6AAB22A72","X-Gm-Message-State":"AHPjjUjPen66PcJ+bbhmksQS9LUyj31HFfTP3WvGX37mUzLV88QWotzK\n\timNw8IJGVixslr9UQO4N+RxCWQSbnqU0lyAxmQ==","X-Google-Smtp-Source":"AOwi7QCcYxqnnp6SpARyKjbEFLGF2afUQPekDIdbEgjYBA1fO/WiDBJMuT0TgSOmkdrqePrQpfGSCTl1VP6+IZcniqw=","X-Received":"by 10.200.42.251 with SMTP id c56mr4124255qta.152.1506009534841; \n\tThu, 21 Sep 2017 08:58:54 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170921092516.yzjelpxka4firnwx@paasikivi.fi.intel.com>","References":"<1505723105-16238-1-git-send-email-sakari.ailus@linux.intel.com>\n\t<1505723105-16238-2-git-send-email-sakari.ailus@linux.intel.com>\n\t<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>\n\t<20170921092516.yzjelpxka4firnwx@paasikivi.fi.intel.com>","From":"Rob Herring ","Date":"Thu, 21 Sep 2017 10:58:34 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","To":"Sakari Ailus ","Cc":"\"linux-media@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773326,"web_url":"http://patchwork.ozlabs.org/comment/1773326/","msgid":"<20170922074209.2vk4ph6uvlzdbgqq@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-22T07:42:10","subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"On Thu, Sep 21, 2017 at 10:58:34AM -0500, Rob Herring wrote:\n> On Thu, Sep 21, 2017 at 4:25 AM, Sakari Ailus\n> wrote:\n> > Hi Rob,\n> >\n> > Thanks for the reply.\n> >\n> > On Wed, Sep 20, 2017 at 03:53:13PM -0500, Rob Herring wrote:\n> >> On Mon, Sep 18, 2017 at 11:25:04AM +0300, Sakari Ailus wrote:\n> >> > A lot of devices do not need and do not document port or endpoint\n> >> > numbering at all, e.g. in case where there's just a single port and a\n> >> > single endpoint. Whereas this is just common sense, document it to make it\n> >> > explicit.\n> >> >\n> >> > Signed-off-by: Sakari Ailus \n> >> > ---\n> >> > Documentation/devicetree/bindings/media/video-interfaces.txt | 12 ++++++++++++\n> >> > 1 file changed, 12 insertions(+)\n> >>\n> >> This is fine, but bindings should still be explicit. Otherwise, I'm\n> >> wondering if it's a single port/endpoint or they just forgot to document\n> >> it. And I shouldn't have to look at the example to infer that.\n> >>\n> >> Acked-by: Rob Herring \n> >\n> > The purpose of the patch was to actually document port and endpoint\n> > numbering for devices for which it is not documented, not to suggest that\n> > this would be omitted in in binding documentation. The fact is that I\n> > couldn't find documentation for endpoint numbering for a single device\n> > under Documentation/devicetree/bindings/media/ . Yet I haven't come across\n> > DT source where other than zero would have been used. And the drivers\n> > (mostly?) have ignored endpoint numbers so far.\n> \n> That's surprising. I know there are some for display controllers and\n> it's a common review comment I give.\n\nOn V4L2 side we only have started paying attention recently. See e.g.\n\n\tDocumentation/devicetree/bindings/media/atmel-isc.txt\n\tDocumentation/devicetree/bindings/media/ti,omap3isp.txt\n\tDocumentation/devicetree/bindings/media/qcom,camss.txt\n\n> \n> >\n> > Some bindings have been omitted on the grounds that they're documented in\n> > video-interfaces.txt.\n> >\n> > What would you think of the following? I'm not sure it'd really belong\n> > there, but it'd be a small piece of documentation one can easily refer to.\n> \n> Looks good.\n\nI'll resend the set, replacing the original patch.\n\n> \n> >\n> >\n> > From e735979005244eb10597fe5333130b93e41d5a38 Mon Sep 17 00:00:00 2001\n> > From: Sakari Ailus \n> > Date: Mon, 18 Sep 2017 11:15:53 +0300\n> > Subject: [PATCH 1/1] dt: bindings: media: Document practices for DT bindings,\n> > ports, endpoints\n> >\n> > Port and endpoint numbering has been omitted in DT binding documentation\n> > for a large number of devices. Also common properties the device uses have\n> > been missed in binding documentation. Make it explicit that these things\n> > need to be documented.\n> >\n> > Signed-off-by: Sakari Ailus \n> > ---\n> > .../devicetree/bindings/media/video-interfaces.txt | 15 +++++++++++++++\n> > 1 file changed, 15 insertions(+)\n> >\n> > diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > index 852041a..3c5382f 100644\n> > --- a/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > +++ b/Documentation/devicetree/bindings/media/video-interfaces.txt\n> > @@ -55,6 +55,21 @@ divided into two separate ITU-R BT.656 8-bit busses. In such case bus-width\n> > and data-shift properties can be used to assign physical data lines to each\n> > endpoint node (logical bus).\n> >\n> > +Documenting bindings for devices\n> > +--------------------------------\n> > +\n> > +All required and optional bindings the device supports shall be explicitly\n> > +documented in device DT binding documentation. This also includes port and\n> > +endpoint numbering for the device.\n> > +\n> > +Port and endpoint numbering\n> > +---------------------------\n> > +\n> > +Old binding documentation may have omitted explicitly specifying port and\n> > +endpoint numbers. This often applies to devices that have a single port and a\n> > +single endpoint in that port. In this case, the only valid port number for such\n> > +a device is zero. The same applies for devices for which bindings do not\n> > +document endpoint numbering: only zero is a valid endpoint.\n> >\n> > Required properties\n> > -------------------\n> > --\n> > 2.7.4\n> >\n> > --\n> > Sakari Ailus\n> > sakari.ailus@linux.intel.com","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz56G5xrQz9ryr\n\tfor ;\n\tFri, 22 Sep 2017 17:42:14 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751838AbdIVHmN (ORCPT\n\t);\n\tFri, 22 Sep 2017 03:42:13 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:41202 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751795AbdIVHmM (ORCPT\n\t); Fri, 22 Sep 2017 03:42:12 -0400","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id B0D6F600E0;\n\tFri, 22 Sep 2017 10:42:10 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dvIbC-0005dD-9N; Fri, 22 Sep 2017 10:42:10 +0300"],"Date":"Fri, 22 Sep 2017 10:42:10 +0300","From":"Sakari Ailus ","To":"Rob Herring ","Cc":"Sakari Ailus ,\n\t\"linux-media@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ","Subject":"Re: [PATCH 1/2] dt: bindings: media: Document port and endpoint\n\tnumbering","Message-ID":"<20170922074209.2vk4ph6uvlzdbgqq@valkosipuli.retiisi.org.uk>","References":"<1505723105-16238-1-git-send-email-sakari.ailus@linux.intel.com>\n\t<1505723105-16238-2-git-send-email-sakari.ailus@linux.intel.com>\n\t<20170920142438.wva4a5gz7ikfnlyh@rob-hp-laptop>\n\t<20170921092516.yzjelpxka4firnwx@paasikivi.fi.intel.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]