[{"id":1770000,"web_url":"http://patchwork.ozlabs.org/comment/1770000/","msgid":"<3684ee87-f9ca-85e8-302a-7f681c58fdd5@st.com>","list_archive_url":null,"date":"2017-09-18T09:18:02","subject":"Re: [PATCH][V2] i2c: i2c-stm32f7: make structure stm32f7_setup\n\tstatic const","submitter":{"id":71499,"url":"http://patchwork.ozlabs.org/api/people/71499/","name":"Pierre Yves MORDRET","email":"pierre-yves.mordret@st.com"},"content":"On 09/18/2017 10:15 AM, Colin King wrote:\n> From: Colin Ian King \n> \n> The structure stm32f7_setup is local to the source and does not need\n> to be in global scope, make it static const.\n> \n> Cleans up sparse warning:\n> symbol 'stm32f7_setup' was not declared. Should it be static?\n> \n> Signed-off-by: Colin Ian King \n> ---\n> drivers/i2c/busses/i2c-stm32f7.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c\n> index 47c67b0ca896..3eae4fc96884 100644\n> --- a/drivers/i2c/busses/i2c-stm32f7.c\n> +++ b/drivers/i2c/busses/i2c-stm32f7.c\n> @@ -265,7 +265,7 @@ static struct stm32f7_i2c_spec i2c_specs[] = {\n> \t},\n> };\n> \n> -struct stm32f7_i2c_setup stm32f7_setup = {\n> +static const struct stm32f7_i2c_setup stm32f7_setup = {\n> \t.rise_time = STM32F7_I2C_RISE_TIME_DEFAULT,\n> \t.fall_time = STM32F7_I2C_FALL_TIME_DEFAULT,\n> \t.dnf = STM32F7_I2C_DNF_DEFAULT,\n> \n\nAcked-by: Pierre-Yves MORDRET ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwgRZ6wBzz9s7g\n\tfor ;\n\tMon, 18 Sep 2017 19:18:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754696AbdIRJSk (ORCPT );\n\tMon, 18 Sep 2017 05:18:40 -0400","from mx07-00178001.pphosted.com ([62.209.51.94]:13627 \"EHLO\n\tmx07-00178001.pphosted.com\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754669AbdIRJSi (ORCPT\n\t); Mon, 18 Sep 2017 05:18:38 -0400","from pps.filterd (m0046668.ppops.net [127.0.0.1])\n\tby mx07-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8I9DhGj030120; Mon, 18 Sep 2017 11:18:09 +0200","from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35])\n\tby mx07-00178001.pphosted.com with ESMTP id 2d20x02fjh-1\n\t(version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT);\n\tMon, 18 Sep 2017 11:18:09 +0200","from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9])\n\tby beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B4BBC3A;\n\tMon, 18 Sep 2017 09:18:05 +0000 (GMT)","from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14])\n\tby zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 648D0156A;\n\tMon, 18 Sep 2017 09:18:05 +0000 (GMT)","from [10.201.23.236] (10.75.127.45) by SFHDAG5NODE2.st.com\n\t(10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1178.4;\n\tMon, 18 Sep 2017 11:18:04 +0200"],"Subject":"Re: [PATCH][V2] i2c: i2c-stm32f7: make structure stm32f7_setup\n\tstatic const","To":"Colin King , Wolfram Sang ,\n\tMaxime Coquelin ,\n\tAlexandre Torgue ,\n\t, ","CC":", ","References":"<20170918081539.26512-1-colin.king@canonical.com>","From":"Pierre Yves MORDRET ","Message-ID":"<3684ee87-f9ca-85e8-302a-7f681c58fdd5@st.com>","Date":"Mon, 18 Sep 2017 11:18:02 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918081539.26512-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[10.75.127.45]","X-ClientProxiedBy":"SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG5NODE2.st.com\n\t(10.75.127.14)","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_02:, , signatures=0","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]