[{"id":1770220,"web_url":"http://patchwork.ozlabs.org/comment/1770220/","msgid":"<20170918145059.lxaxbsfqen43exam@localhost>","list_archive_url":null,"date":"2017-09-18T14:50:59","subject":"Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a\n\tfuture transmit time.","submitter":{"id":4009,"url":"http://patchwork.ozlabs.org/api/people/4009/","name":"Richard Cochran","email":"richardcochran@gmail.com"},"content":"On Mon, Sep 18, 2017 at 09:41:16AM +0200, Richard Cochran wrote:\n> diff --git a/arch/powerpc/include/uapi/asm/socket.h b/arch/powerpc/include/uapi/asm/socket.h\n> index 3c590c7c42c0..55718129ab06 100644\n> --- a/arch/powerpc/include/uapi/asm/socket.h\n> +++ b/arch/powerpc/include/uapi/asm/socket.h\n> @@ -17,4 +17,7 @@\n> \n> #include \n> \n> +#define SO_TXTIME\t\t54\n> +#define SCM_TXTIME\t\tSO_TXTIME\n> +\n> #endif\t/* _ASM_POWERPC_SOCKET_H */\n\nThis hunk breaks powerpc builds. Will fix in the next round...\n\nThanks,\nRichard","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"sxr9nVqf\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwpq91pJhz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 00:51:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932136AbdIROvF (ORCPT );\n\tMon, 18 Sep 2017 10:51:05 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:36339 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753118AbdIROvE (ORCPT\n\t); Mon, 18 Sep 2017 10:51:04 -0400","by mail-wr0-f195.google.com with SMTP id g50so502370wra.3;\n\tMon, 18 Sep 2017 07:51:03 -0700 (PDT)","from localhost (213-225-5-51.nat.highway.a1.net. [213.225.5.51])\n\tby smtp.gmail.com with ESMTPSA id\n\t25sm7862957wrv.8.2017.09.18.07.51.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 07:51:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=9K/yGVDUi5bDASkQFLEDP10Va0+bO/K1WGOjrULw1NY=;\n\tb=sxr9nVqf94+U2pnOlq48K+b3CFW/rJs0+OWGUxMW8RX2azrT+NpTQVrbV1cQLXUnsh\n\tsrC6NAg7lhO+OspAGP27UJoNNH1i/2CUozvxDQ+cQcp5aGzihcoK8j+i6DVO+6n0UeRv\n\tL2rwFwMoChNJElrlknWZd53ScwFw4OmJ4od2asY/sTnhA3VORHgmvrgjSysyXicbiYbm\n\t7G+cbzsJHiIuUFOS7n31ZMZuBIDQC4SZK7TTpGilesVjNGnu7X2VKng4XPT9RQwhVPlu\n\t8xDGM2gmZt4xjgTl+baFycILj+HMZukEPEJyXH6G/cHfpvfaGMAug4GbcnqL6H7naSqF\n\taAAw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=9K/yGVDUi5bDASkQFLEDP10Va0+bO/K1WGOjrULw1NY=;\n\tb=hmdBgKbdKeFBJLJSF622KKVBr85F/hOf9EfBU/6Jikhl7gpjhGZOYlnT++8To3GKcI\n\t3N/6LKgN+mHvsivv1UyQ6b5Giplq1GyVQqbVLZHkIhwG82beIsiVVVijwcQ8E+YQHO4C\n\tFbaK3v/VtM0law6mMNjzMcloAtf4E6HDtQYA/5JaxrOeN7ACf8LpmZKMgj+DQm6XYUaI\n\tjqihILHj4Ax30QiyuOF5sRqkqjF3JEkNrcumQV7HTtJczdCS0cn7j+u132XZ5MszqDs+\n\t5UMkENQYpkAnqpY6NgRUldxwo9wKuV3uHVlOKx/j11d8Kv06vqvpto08SxQgH3m65tkO\n\tpmnw==","X-Gm-Message-State":"AHPjjUhSKTDqFhOyeZGC7e9DB5Lynob1LsiCpn8lTUU1bboCBn+Y/B4L\n\t7iYFdTw5Lf7WlP2ueZw=","X-Google-Smtp-Source":"ADKCNb5HJtIoUmMGwB2KWD90gFoRhF2rwwfjzYcXbN8Og6XY5ciQ2xsn2W8+vkYaYOvBRKpi37/heQ==","X-Received":"by 10.223.138.153 with SMTP id y25mr27126589wry.59.1505746262972;\n\tMon, 18 Sep 2017 07:51:02 -0700 (PDT)","Date":"Mon, 18 Sep 2017 16:50:59 +0200","From":"Richard Cochran ","To":"Richard Cochran ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, Andre Guedes ,\n\tAnna-Maria Gleixner ,\n\tDavid Miller , Henrik Austad ,\n\tJesus Sanchez-Palencia ,\n\tJohn Stultz ,\n\tThomas Gleixner ,\n\tVinicius Costa Gomes ","Subject":"Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a\n\tfuture transmit time.","Message-ID":"<20170918145059.lxaxbsfqen43exam@localhost>","References":"\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770246,"web_url":"http://patchwork.ozlabs.org/comment/1770246/","msgid":"<1505747934.29839.21.camel@edumazet-glaptop3.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-18T15:18:54","subject":"Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a\n\tfuture transmit time.","submitter":{"id":2404,"url":"http://patchwork.ozlabs.org/api/people/2404/","name":"Eric Dumazet","email":"eric.dumazet@gmail.com"},"content":"On Mon, 2017-09-18 at 09:41 +0200, Richard Cochran wrote:\n\n> +\tcase SO_TXTIME:\n> +\t\tif (!sock_flag(sk, SOCK_TXTIME))\n> +\t\t\treturn -EINVAL;\n> +\t\tsockc->transmit_time = *(u64 *)CMSG_DATA(cmsg);\n\n1) No guarantee the CMSG is properly aligned on arches that might trap\non unaligned access.\n\n2) No guarantee user provided 8 bytes here.\n\nAlso, what would be the time base here ?\n\n> +\t\tbreak;\n> \t/* SCM_RIGHTS and SCM_CREDENTIALS are semantically in SOL_UNIX. */\n> \tcase SCM_RIGHTS:\n> \tcase SCM_CREDENTIALS:","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bJkOsQNL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwqRL0Nstz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 01:19:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752669AbdIRPS6 (ORCPT );\n\tMon, 18 Sep 2017 11:18:58 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:35199 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752420AbdIRPS4 (ORCPT\n\t); Mon, 18 Sep 2017 11:18:56 -0400","by mail-pg0-f66.google.com with SMTP id j16so404570pga.2;\n\tMon, 18 Sep 2017 08:18:56 -0700 (PDT)","from ?IPv6:2620:15c:2c1:100:3c6c:f4d4:634b:bb8e?\n\t([2620:15c:2c1:100:3c6c:f4d4:634b:bb8e])\n\tby smtp.googlemail.com with ESMTPSA id\n\ts1sm15854387pfk.27.2017.09.18.08.18.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 08:18:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kapAcRSx1bMhz+tzL5Bez0kWOxxKUOUUWz1zQePkslg=;\n\tb=bJkOsQNLkHKBJV4uTXxWPov+8GpMZiUFVQpywFSf7f2/uA9ifmlchihXI56Du6PDtM\n\tx6nQdEq3PxaK8uFo/owMaTsGx80kq6FbUFSu98wmGh9j6N7m7eBdYPnmiwXGrxXyC2VS\n\teZNOR6Iz2zfbAqfQ+LZ0t4M2OlpIYTE8cJfDn0VdNbY5g754HDXxy4VFKXrRH5YCDe8D\n\tgnH2ghPhCdwZ4rLGv1dFqvfvOaBWdh1RpZbOlTKLQ/P/q1mcXbnuioxnv8oqNPeA7v/b\n\trw4F5RNyjDMVXyI7hBCJxwLwGrf6kU7ofEfMaGxRJZgzS5LGCKC3XcGTxX0TG4yyCALJ\n\tcKsw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kapAcRSx1bMhz+tzL5Bez0kWOxxKUOUUWz1zQePkslg=;\n\tb=dGXx5sjFdZ9qyH2T7JtJ71GP7OpCnZiPhaG+blKg+ugdjTxvPS3FwBtuuxIG9UsJ3S\n\tNlwlcNZuRJ+V56T8qBrV2AEAX8HkBjI5VwtW4gA7r1X0mHbsUlORbrc0htApUVMQ9kL3\n\tCjaiTYbczltIoibozwtYcMNGO+6VsfBZXB0/1+162TmoMUGNlgSb7kZchK2z090/PJG4\n\tnUnMG6SkIZDmQ3QPfG/rWw3JOJbEIwUNOWu3kjSBw+X7h40YTcWTo98RO/F1EGYYrYB0\n\txOsr5bZ5K5d1Le7QNTO2Vyk65pxg9NL7iuwUBS3aXABcJ+k9U3PVXK+FsI94hFJ7491W\n\tef4g==","X-Gm-Message-State":"AHPjjUhD/m0SM6O1g3iE1hVNJu2LiMChTh3SnK85N17GL78smi4Z2JsB\n\t2iga/JWFXjT6Ew==","X-Google-Smtp-Source":"AOwi7QCeL9YTUjHl2falIPXZa+1m5kLlTsRyZyz3OJZcwHzxSPzm96s3JKNFeTbEBB7vAoanURxHiA==","X-Received":"by 10.101.67.201 with SMTP id n9mr4317492pgp.453.1505747936271; \n\tMon, 18 Sep 2017 08:18:56 -0700 (PDT)","Message-ID":"<1505747934.29839.21.camel@edumazet-glaptop3.roam.corp.google.com>","Subject":"Re: [PATCH RFC V1 net-next 1/6] net: Add a new socket option for a\n\tfuture transmit time.","From":"Eric Dumazet ","To":"Richard Cochran ","Cc":"netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, Andre Guedes ,\n\tAnna-Maria Gleixner ,\n\tDavid Miller , Henrik Austad ,\n\tJesus Sanchez-Palencia ,\n\tJohn Stultz ,\n\tThomas Gleixner ,\n\tVinicius Costa Gomes ","Date":"Mon, 18 Sep 2017 08:18:54 -0700","In-Reply-To":"","References":"\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","X-Mailer":"Evolution 3.10.4-0ubuntu2 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]