[{"id":1770016,"web_url":"http://patchwork.ozlabs.org/comment/1770016/","msgid":"<20170918093403.GB31063@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-18T09:34:04","subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Mon, Sep 18, 2017 at 07:25:24AM +0200, Kevin Wolf wrote:\n> Python requires parentheses around multiline expression. This fixes the\n> breakage of all Python-based qemu-iotests cases that was introduced in\n> commit dab91d9aa0.\n> \n> Signed-off-by: Kevin Wolf \n> ---\n> \n> Eduardo, I think I'm going to include this patch in a block layer pull\n> request today, just to stop the CI spam I'm getting, so the CC is just\n> FYI.\n> \n> scripts/qemu.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jTZcm1IF\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgnn5zlRz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 19:34:37 +1000 (AEST)","from localhost ([::1]:35421 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtsRn-0001v1-Vi\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 05:34:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56847)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtsRS-0001tf-SG\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:34:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtsRS-0001TX-4i\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:34:14 -0400","from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:46277)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtsRM-0001RW-Db; Mon, 18 Sep 2017 05:34:08 -0400","by mail-wm0-x22c.google.com with SMTP id i189so897548wmf.1;\n\tMon, 18 Sep 2017 02:34:06 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tu1sm6321807wrd.95.2017.09.18.02.34.05\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 02:34:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=sprkKTQZS9iUWze1rgFYwa2YpBdrkeTUGkk85Ul3DP8=;\n\tb=jTZcm1IFeBI69U3Uljbt/XVAZSLmhxNml4Xu8YfI3VnAgP3KgU8yOkSAI7YXqhpnaD\n\tR1zAMmDNDpTpEFENkjlKVwL5qCSzN/igbMiXTkRAU/VkYs2bjOhVdF7oXrUNTFr0MaY5\n\tBx8QrgUzdpdayeSiiVGwYMQKhNOKspN+dOq+EB0qqvtBHYtNx9SNayi4z92TvK0briNE\n\t/JpA35Zp3FQmDdrnyrv7N8vXai23k/G4h5eCNrtYhckselfCWdQ96/LoI3FmqLbfPisw\n\t4RUOx0M6HNrWaL7HCDzmRwwJeRrMxtn+TWbJC1r2Oa78iDigoOjzK1OTy5oIraA55oGo\n\taMqA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=sprkKTQZS9iUWze1rgFYwa2YpBdrkeTUGkk85Ul3DP8=;\n\tb=HQaxEFjWcb7CqFHyRJ0ryN+Wi+J75U4v6dA0dNjLDTqqv9GO+FmXgxANqiuaqFfmZJ\n\tOXp/YE7EoNlZIFCN5sbvhhPFqwfUqE4nOKLMm0PMaiwpmQMudZunxxdL2A/8oDLCKnBI\n\tAx6n/JpBcIi4bql+XT0cTB11Gkpb/LqmVBZUw8E5+phcy5P0xAU4ZZGy8QWWjiQVTuv1\n\t7zQg7fr6XmTipRC8hLQ8E/1hv9XICrrfLHrlfaYKHWa9l8nv9Ng1sTcyjuUdVGpWAXA+\n\t2X38e+i3y1SnmGrFGW3oTMiFSfW7NaLsXjmAbbKSv8t1BTwglZUNLkS5rh+VUJuDB4qX\n\tSRcg==","X-Gm-Message-State":"AHPjjUjUhFbZ1M6hHdbI3BpqDBjk0av36mQW9oUVurFCPjPDhAykVq9A\n\tMCAehwNPaGAo0XV6mg9l/dY=","X-Google-Smtp-Source":"AOwi7QDOBt3P5eLpmIvjxF70lH9WtDtAnxxFix0cwgqVtceR8Af/a35BP0LN/k6RuYE15oJL0AGQIA==","X-Received":"by 10.28.87.143 with SMTP id l137mr7524121wmb.66.1505727246113; \n\tMon, 18 Sep 2017 02:34:06 -0700 (PDT)","Date":"Mon, 18 Sep 2017 10:34:04 +0100","From":"Stefan Hajnoczi ","To":"Kevin Wolf ","Message-ID":"<20170918093403.GB31063@stefanha-x1.localdomain>","References":"<20170918052524.4045-1-kwolf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918052524.4045-1-kwolf@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::22c","Subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,\n\tqemu-block@nongnu.org, qemu-devel@nongnu.org, apahim@redhat.com,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770024,"web_url":"http://patchwork.ozlabs.org/comment/1770024/","msgid":"<87efr4jqfj.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-18T09:40:00","subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Kevin Wolf writes:\n\n> Python requires parentheses around multiline expression. This fixes the\n> breakage of all Python-based qemu-iotests cases that was introduced in\n> commit dab91d9aa0.\n>\n> Signed-off-by: Kevin Wolf \n\nHeh, just sent an identical patch.\n\nReviewed-by: Alex Bennée \nTested-by: Alex Bennée \n\n> ---\n>\n> Eduardo, I think I'm going to include this patch in a block layer pull\n> request today, just to stop the CI spam I'm getting, so the CC is just\n> FYI.\n>\n> scripts/qemu.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index 8c67595ec8..5e02dd8e78 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -193,8 +193,8 @@ class QEMUMachine(object):\n> qemulog = open(self._qemu_log_path, 'wb')\n> try:\n> self._pre_launch()\n> - self._qemu_full_args = self._wrapper + [self._binary] +\n> - self._base_args() + self._args\n> + self._qemu_full_args = (self._wrapper + [self._binary] +\n> + self._base_args() + self._args)\n> self._popen = subprocess.Popen(self._qemu_full_args,\n> stdin=devnull,\n> stdout=qemulog,\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"h9v7MFy8\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgz762RSz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 19:42:43 +1000 (AEST)","from localhost ([::1]:35456 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtsZd-0007RD-Tu\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 05:42:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:58699)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtsX7-0005cP-Sk\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:40:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtsX4-0003li-Rq\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:40:05 -0400","from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:46131)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtsX4-0003lB-Kn\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:40:02 -0400","by mail-wr0-x22b.google.com with SMTP id o42so5691894wrb.3\n\tfor ; Mon, 18 Sep 2017 02:40:02 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\t55sm8112156wrw.60.2017.09.18.02.40.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 02:40:00 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 74EC13E00DB;\n\tMon, 18 Sep 2017 10:40:00 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=Veil2WG5Rh8V0mvIKRUWFfHWwiS8NIvrYEC4cgpu4DQ=;\n\tb=h9v7MFy8CmbLNDpkNw3tlxGvMUR5ss5XX1x+hGxX8ktbBcKsqTHfj/455Y9HmhFClg\n\tbIXUwBmj4nlZyXlzpljplgiqjbCVMFV+e3FVbRgAK7Z6M9QY2RcSsL2Aea8HMfOt1lnL\n\tnHJZYnGb+i/g3LwbTzWaBRqenVYX4bzUfiirs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=Veil2WG5Rh8V0mvIKRUWFfHWwiS8NIvrYEC4cgpu4DQ=;\n\tb=qWeYAKBn+3/EzNnditN+NZM5/2B75CdkGxKHgupfIR6KLyM+XUCz3uWmXcx8HXsQyc\n\tQW4LKOWuphu/vDtcSUGBzipxi9p48AvKQAL6MGQDJfMJ1Y8DB91bfQzBBKq2mt/G4F08\n\tbGcCiIsYom41AFO5dx3D2FpdzJaNy2258MX3l9zC6oLTZkd7R/AGHAF61TrunK09PYH4\n\tduATB+YEqxtz2biJUVgG/1CZgGqC22QmANgNd1UnQ/R+GsGy56mfQbzVKOpui40QZ9IR\n\t68cJHVWBbYDvcj4mKmtNQJEKjcgW0RunCB9j+U2zWXMb5IVwRsgtpD8dhbQouvFQo5Hf\n\tBj1A==","X-Gm-Message-State":"AHPjjUjjZcKlMrNMWxyZj3iXN6g8kUTfwd1s0lZxGZiriUnCifGHvCBG\n\twAnPr+sCDeZjMEKs","X-Google-Smtp-Source":"ADKCNb54OXDfKT5sHAecLQ9pBBoKW3yeI4dPu0bbq2TbQzuCsHbw5h2NyN4zW/IzgHQliFgk1u2Anw==","X-Received":"by 10.223.154.81 with SMTP id z75mr30397678wrb.124.1505727601548;\n\tMon, 18 Sep 2017 02:40:01 -0700 (PDT)","References":"<20170918052524.4045-1-kwolf@redhat.com>","User-agent":"mu4e 0.9.19; emacs 25.3.50.1","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Kevin Wolf ","In-reply-to":"<20170918052524.4045-1-kwolf@redhat.com>","Date":"Mon, 18 Sep 2017 10:40:00 +0100","Message-ID":"<87efr4jqfj.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::22b","Subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ldoktor@redhat.com, famz@redhat.com, ehabkost@redhat.com,\n\tqemu-block@nongnu.org, stefanha@gmail.com, apahim@redhat.com,\n\tqemu-devel@nongnu.org, armbru@redhat.com, crosa@redhat.com,\n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770062,"web_url":"http://patchwork.ozlabs.org/comment/1770062/","msgid":"","list_archive_url":null,"date":"2017-09-18T10:32:21","subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On 18 September 2017 at 06:25, Kevin Wolf wrote:\n> Python requires parentheses around multiline expression. This fixes the\n> breakage of all Python-based qemu-iotests cases that was introduced in\n> commit dab91d9aa0.\n>\n> Signed-off-by: Kevin Wolf \n> ---\n>\n> Eduardo, I think I'm going to include this patch in a block layer pull\n> request today, just to stop the CI spam I'm getting, so the CC is just\n> FYI.\n\nApplied to master as a buildfix; thanks.\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"YBBcxxQE\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwj5f318kz9s78\n\tfor ;\n\tMon, 18 Sep 2017 20:33:26 +1000 (AEST)","from localhost ([::1]:35670 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dttMi-0000dZ-Hh\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 06:33:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48096)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dttM4-0000Xj-6y\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:32:45 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dttM3-0002dS-El\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:32:44 -0400","from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:48104)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dttM3-0002d8-9G\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 06:32:43 -0400","by mail-wm0-x231.google.com with SMTP id 13so1325370wmq.2\n\tfor ; Mon, 18 Sep 2017 03:32:43 -0700 (PDT)","by 10.223.139.215 with HTTP; Mon, 18 Sep 2017 03:32:21 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ZUCJihnJ1eNAaQRG4XfAJOKp8HRMZzaUzJ9EVE8Uju8=;\n\tb=YBBcxxQEsXBNIYA6aWQoLz0vf7xgwBAfWlk/x3Put2lkBn4WSqamhGtOagWDyG9AbW\n\t+OCFzHniGNsOU2NUmNmTH53T0EEFz1eG9jxZaZUHL+Ywb4GXhkwxXwt19gkgWQI2xOnu\n\t7DXjNksnOdmCmWquRqlAkDLLzD84j0fe3F0Jo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZUCJihnJ1eNAaQRG4XfAJOKp8HRMZzaUzJ9EVE8Uju8=;\n\tb=l6QH1t+QAZKctnnOakHY7vAJqGsL/UfTNSIYoYiS6cM7oqFmShIFWV/XCk3EpBzlYz\n\tO7rc6xGgLu4pLRJs26oM+5U2w6++soHsS2m7pfvDAMFq004O8M5HbkRPRH1ms9gv8S81\n\tWxIeb1vE2k9RgwdyRCAyYZwYw+v2hyqlvvstQtiIKTXrBrmhiemoNu9Qr+vQ45qZ/7Ec\n\tVLwaB5q3AEagPqaQ8wBG+nm5bsmbKSDPYqH02CojgDW50X7D68Sl2bYw1zfFxq1PbR1E\n\tWrTQTmIMdojLNhfsL2JvuBkHisPrK7ai+oc9yKUKDRnR5WQuldHVrQi+Z9vgamundJsE\n\tbkpA==","X-Gm-Message-State":"AHPjjUiFLOyu2o7A4HaFoFGh6y/h5zvgoyft/PySF7D0y8LPOplUI/Sm\n\tWffy9ApkHQi9IcoNgDsNsBOFn912qVHduMpr1qq0Yg==","X-Google-Smtp-Source":"AOwi7QD5LxP8Zbw6vjmS4OY1sQjlUhxmuwDlJvS8TtRZzWuGY60pVf8+MqgJA4NWEdWUrqP25f6akwnEYxjl9V3/88A=","X-Received":"by 10.28.52.81 with SMTP id b78mr8531685wma.11.1505730762110;\n\tMon, 18 Sep 2017 03:32:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170918052524.4045-1-kwolf@redhat.com>","References":"<20170918052524.4045-1-kwolf@redhat.com>","From":"Peter Maydell ","Date":"Mon, 18 Sep 2017 11:32:21 +0100","Message-ID":"","To":"Kevin Wolf ","Content-Type":"text/plain; charset=\"UTF-8\"","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::231","Subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Lukas Doktor , Fam Zheng ,\n\tEduardo Habkost ,\n\tQemu-block , \n\tStefan Hajnoczi , Amador Pahim ,\n\tQEMU Developers ,\n\tMarkus Armbruster ,\n\tCleber Rosa , Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770100,"web_url":"http://patchwork.ozlabs.org/comment/1770100/","msgid":"<20170918114959.GH10621@localhost.localdomain>","list_archive_url":null,"date":"2017-09-18T11:49:59","subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"On Mon, Sep 18, 2017 at 07:25:24AM +0200, Kevin Wolf wrote:\n> Python requires parentheses around multiline expression. This fixes the\n> breakage of all Python-based qemu-iotests cases that was introduced in\n> commit dab91d9aa0.\n> \n> Signed-off-by: Kevin Wolf \n> ---\n> \n> Eduardo, I think I'm going to include this patch in a block layer pull\n> request today, just to stop the CI spam I'm getting, so the CC is just\n> FYI.\n\nNo problem, thanks for fixing it. I incorrectly assumed \"make\ncheck\" was covering that code path. Sorry for the mess.\n\n\n> \n> scripts/qemu.py | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/scripts/qemu.py b/scripts/qemu.py\n> index 8c67595ec8..5e02dd8e78 100644\n> --- a/scripts/qemu.py\n> +++ b/scripts/qemu.py\n> @@ -193,8 +193,8 @@ class QEMUMachine(object):\n> qemulog = open(self._qemu_log_path, 'wb')\n> try:\n> self._pre_launch()\n> - self._qemu_full_args = self._wrapper + [self._binary] +\n> - self._base_args() + self._args\n> + self._qemu_full_args = (self._wrapper + [self._binary] +\n> + self._base_args() + self._args)\n> self._popen = subprocess.Popen(self._qemu_full_args,\n> stdin=devnull,\n> stdout=qemulog,\n> -- \n> 2.13.5\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwkpm4LZYz9s78\n\tfor ;\n\tMon, 18 Sep 2017 21:50:40 +1000 (AEST)","from localhost ([::1]:35888 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtuZS-00069O-P2\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 07:50:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44694)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtuZ5-00065h-BL\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 07:50:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtuZ4-0002dk-Fr\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 07:50:15 -0400","from mx1.redhat.com ([209.132.183.28]:35084)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtuYy-0002UB-9N; Mon, 18 Sep 2017 07:50:08 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4397E4E4C6;\n\tMon, 18 Sep 2017 11:50:07 +0000 (UTC)","from localhost (ovpn-116-24.gru2.redhat.com [10.97.116.24])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C1B7160BE2;\n\tMon, 18 Sep 2017 11:50:00 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4397E4E4C6","Date":"Mon, 18 Sep 2017 08:49:59 -0300","From":"Eduardo Habkost ","To":"Kevin Wolf ","Message-ID":"<20170918114959.GH10621@localhost.localdomain>","References":"<20170918052524.4045-1-kwolf@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918052524.4045-1-kwolf@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 18 Sep 2017 11:50:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"ldoktor@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tqemu-devel@nongnu.org, stefanha@gmail.com, apahim@redhat.com,\n\tarmbru@redhat.com, mreitz@redhat.com, crosa@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]