[{"id":1769872,"web_url":"http://patchwork.ozlabs.org/comment/1769872/","msgid":"<1505713040.12632.45.camel@neuling.org>","list_archive_url":null,"date":"2017-09-18T05:37:20","subject":"Re: [Skiboot] [PATCH] PHB4: Default to PCIe GEN3 on POWER9 DD2.00","submitter":{"id":109,"url":"http://patchwork.ozlabs.org/api/people/109/","name":"Michael Neuling","email":"mikey@neuling.org"},"content":"On Mon, 2017-09-18 at 14:21 +1000, Stewart Smith wrote:\n> You can use the NVRAM override for DD2.00 screened parts.\n> \n> Signed-off-by: Stewart Smith \n> ---\n>  hw/phb4.c | 6 ++++++\n>  1 file changed, 6 insertions(+)\n> \n> diff --git a/hw/phb4.c b/hw/phb4.c\n> index fea9125699fe..5371949fd997 100644\n> --- a/hw/phb4.c\n> +++ b/hw/phb4.c\n> @@ -4741,12 +4741,14 @@ static void phb4_create(struct dt_node *np)\n>  \tchar *path;\n>  \tuint32_t irq_base, irq_flags;\n>  \tint i;\n> +\tstruct proc_chip *chip;\n>  \n>  \tassert(p);\n>  \n>  \t/* Populate base stuff */\n>  \tp->index = dt_prop_get_u32(np, \"ibm,phb-index\");\n>  \tp->chip_id = dt_prop_get_u32(np, \"ibm,chip-id\");\n> +\tchip = get_chip(p->chip_id);\n>  \tp->regs = (void *)dt_get_address(np, 0, NULL);\n>  \tp->int_mmio = (void *)dt_get_address(np, 1, NULL);\n>  \tp->phb.dt_node = np;\n> @@ -4833,6 +4835,10 @@ static void phb4_create(struct dt_node *np)\n>  \tp->max_link_speed = 4;\n>  \tif (p->rev == PHB4_REV_NIMBUS_DD10)\n>  \t\tp->max_link_speed = 2;\n> +\tif (p->rev == PHB4_REV_NIMBUS_DD20 && chip->ec_rev == 0) {\n> +\t\tp->max_link_speed = 3;\n> +\t\tPHBINF(p, \"Default max link speed for P9 DD2.00 is GEN3\\n\");\n\nI'd probably drop this print. We already print the speed later.\n\nOther than that.. looks good.\n\nMikey\n\n> +\t}\n>  \tif (dt_has_node_property(np, \"ibm,max-link-speed\", NULL))\n>  \t\tp->max_link_speed = dt_prop_get_u32(np, \"ibm,max-link-\n> speed\");\n>  \tif (pcie_max_link_speed)","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwZX50Wf0z9s78\n\tfor ;\n\tMon, 18 Sep 2017 15:37:25 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwZX46kvrzDrWC\n\tfor ;\n\tMon, 18 Sep 2017 15:37:24 +1000 (AEST)","from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwZX04DN4zDrW0\n\tfor ; Mon, 18 Sep 2017 15:37:20 +1000 (AEST)","from localhost.localdomain (localhost [127.0.0.1])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwZX030HBz9s78\n\tfor ; Mon, 18 Sep 2017 15:37:20 +1000 (AEST)","by localhost.localdomain (Postfix, from userid 1000)\n\tid 534E2EEA9E9; Mon, 18 Sep 2017 15:37:20 +1000 (AEST)"],"Message-ID":"<1505713040.12632.45.camel@neuling.org>","From":"Michael Neuling ","To":"Stewart Smith , skiboot@lists.ozlabs.org","Date":"Mon, 18 Sep 2017 15:37:20 +1000","In-Reply-To":"<20170918042157.19062-1-stewart@linux.vnet.ibm.com>","References":"<20170918042157.19062-1-stewart@linux.vnet.ibm.com>","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Subject":"Re: [Skiboot] [PATCH] PHB4: Default to PCIe GEN3 on POWER9 DD2.00","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}},{"id":1770817,"web_url":"http://patchwork.ozlabs.org/comment/1770817/","msgid":"<87zi9rm25k.fsf@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-19T10:08:23","subject":"Re: [Skiboot] [PATCH] PHB4: Default to PCIe GEN3 on POWER9 DD2.00","submitter":{"id":48041,"url":"http://patchwork.ozlabs.org/api/people/48041/","name":"Stewart Smith","email":"stewart@linux.vnet.ibm.com"},"content":"Stewart Smith writes:\n> You can use the NVRAM override for DD2.00 screened parts.\n>\n> Signed-off-by: Stewart Smith \n\nMerged to master as of eef0e197abbdc0ce8034be94cd7022e498f11c3e","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","skiboot@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","skiboot@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxJcS4Tkgz9ryr\n\tfor ;\n\tTue, 19 Sep 2017 20:13:44 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxJcS3Z4dzDqfg\n\tfor ;\n\tTue, 19 Sep 2017 20:13:44 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxJVV4M2NzDqYP\n\tfor ; Tue, 19 Sep 2017 20:08:34 +1000 (AEST)","from pps.filterd (m0098409.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8JA8UaN125937\n\tfor ; Tue, 19 Sep 2017 06:08:32 -0400","from e16.ny.us.ibm.com (e16.ny.us.ibm.com [129.33.205.206])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d2yyym2bk-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Tue, 19 Sep 2017 06:08:32 -0400","from localhost\n\tby e16.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tTue, 19 Sep 2017 06:08:30 -0400","from b01cxnp22035.gho.pok.ibm.com (9.57.198.25)\n\tby e16.ny.us.ibm.com (146.89.104.203) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tTue, 19 Sep 2017 06:08:28 -0400","from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com\n\t[9.57.199.111])\n\tby b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8JA8SHq47710222\n\tfor ; Tue, 19 Sep 2017 10:08:28 GMT","from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id D3FF8AC03F\n\tfor ; Tue, 19 Sep 2017 06:08:59 -0400 (EDT)","from birb.localdomain (unknown [9.83.0.131])\n\tby b01ledav006.gho.pok.ibm.com (Postfix) with SMTP id 543EEAC03A\n\tfor ; Tue, 19 Sep 2017 06:08:59 -0400 (EDT)","by birb.localdomain (Postfix, from userid 1000)\n\tid 7F4604F0F8F; Tue, 19 Sep 2017 20:08:23 +1000 (AEST)"],"Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=linux.vnet.ibm.com\n\t(client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n\tenvelope-from=stewart@linux.vnet.ibm.com; receiver=)","From":"Stewart Smith ","To":"skiboot@lists.ozlabs.org","In-Reply-To":"<20170918042157.19062-1-stewart@linux.vnet.ibm.com>","References":"<20170918042157.19062-1-stewart@linux.vnet.ibm.com>","Date":"Tue, 19 Sep 2017 20:08:23 +1000","MIME-Version":"1.0","X-TM-AS-GCONF":"00","x-cbid":"17091910-0024-0000-0000-000002D48952","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007761; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000230; SDB=6.00919217; UDB=6.00461819;\n\tIPR=6.00699443; \n\tBA=6.00005597; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017205;\n\tXFM=3.00000015; UTC=2017-09-19 10:08:30","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091910-0025-0000-0000-000045791828","Message-Id":"<87zi9rm25k.fsf@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-19_04:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=3\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709190144","Subject":"Re: [Skiboot] [PATCH] PHB4: Default to PCIe GEN3 on POWER9 DD2.00","X-BeenThere":"skiboot@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Mailing list for skiboot development ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org","Sender":"\"Skiboot\"\n\t"}}]