[{"id":1770095,"web_url":"http://patchwork.ozlabs.org/comment/1770095/","msgid":"<877ewwjkrm.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-18T11:42:21","subject":"Re: [Qemu-devel] [PATCH v8 10/13] Makefile: Add rules to run vm\n\ttests","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Fam Zheng <famz@redhat.com> writes:\n\n> Signed-off-by: Fam Zheng <famz@redhat.com>\n\nReviewed-by: Alex Bennée <alex.bennee@linaro.org>\nTested-by: Alex Bennée <alex.bennee@linaro.org>\n\n> ---\n>  Makefile                  |  2 ++\n>  configure                 |  2 +-\n>  tests/vm/Makefile.include | 42 ++++++++++++++++++++++++++++++++++++++++++\n>  3 files changed, 45 insertions(+), 1 deletion(-)\n>  create mode 100644 tests/vm/Makefile.include\n>\n> diff --git a/Makefile b/Makefile\n> index b53fc69a60..79684ab138 100644\n> --- a/Makefile\n> +++ b/Makefile\n> @@ -812,6 +812,7 @@ endif\n>  -include $(wildcard *.d tests/*.d)\n>\n>  include $(SRC_PATH)/tests/docker/Makefile.include\n> +include $(SRC_PATH)/tests/vm/Makefile.include\n>\n>  .PHONY: help\n>  help:\n> @@ -835,6 +836,7 @@ help:\n>  \t@echo  'Test targets:'\n>  \t@echo  '  check           - Run all tests (check-help for details)'\n>  \t@echo  '  docker          - Help about targets running tests inside Docker containers'\n> +\t@echo  '  vm-test         - Help about targets running tests inside VM'\n>  \t@echo  ''\n>  \t@echo  'Documentation targets:'\n>  \t@echo  '  html info pdf txt'\n> diff --git a/configure b/configure\n> index 94db2d103e..bbf053e3e0 100755\n> --- a/configure\n> +++ b/configure\n> @@ -6505,7 +6505,7 @@ if test \"$ccache_cpp2\" = \"yes\"; then\n>  fi\n>\n>  # build tree in object directory in case the source is not in the current directory\n> -DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests\"\n> +DIRS=\"tests tests/tcg tests/tcg/cris tests/tcg/lm32 tests/libqos tests/qapi-schema tests/tcg/xtensa tests/qemu-iotests tests/vm\"\n>  DIRS=\"$DIRS docs docs/interop fsdev\"\n>  DIRS=\"$DIRS pc-bios/optionrom pc-bios/spapr-rtas pc-bios/s390-ccw\"\n>  DIRS=\"$DIRS roms/seabios roms/vgabios\"\n> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include\n> new file mode 100644\n> index 0000000000..5daa2a3b73\n> --- /dev/null\n> +++ b/tests/vm/Makefile.include\n> @@ -0,0 +1,42 @@\n> +# Makefile for VM tests\n> +\n> +.PHONY: vm-build-all\n> +\n> +IMAGES := ubuntu.i386 freebsd netbsd openbsd\n> +IMAGE_FILES := $(patsubst %, tests/vm/%.img, $(IMAGES))\n> +\n> +.PRECIOUS: $(IMAGE_FILES)\n> +\n> +vm-test:\n> +\t@echo \"vm-test: Test QEMU in preconfigured virtual machines\"\n> +\t@echo\n> +\t@echo \"  vm-build-ubuntu.i386            - Build QEMU in ubuntu i386 VM\"\n> +\t@echo \"  vm-build-freebsd                - Build QEMU in FreeBSD VM\"\n> +\t@echo \"  vm-build-netbsd                 - Build QEMU in NetBSD VM\"\n> +\t@echo \"  vm-build-openbsd                - Build QEMU in OpenBSD VM\"\n> +\n> +vm-build-all: $(addprefix vm-build-, $(IMAGES))\n> +\n> +tests/vm/%.img: $(SRC_PATH)/tests/vm/% \\\n> +\t\t$(SRC_PATH)/tests/vm/basevm.py \\\n> +\t\t$(SRC_PATH)/tests/vm/Makefile.include\n> +\t$(call quiet-command, \\\n> +\t\t$< \\\n> +\t\t$(if $(V)$(DEBUG), --debug) \\\n> +\t\t--image \"$@\" \\\n> +\t\t--force \\\n> +\t\t--build-image $@, \\\n> +\t\t\"  VM-IMAGE $*\")\n> +\n> +\n> +# Build in VM $(IMAGE)\n> +vm-build-%: tests/vm/%.img\n> +\t$(call quiet-command, \\\n> +\t\t$(SRC_PATH)/tests/vm/$* \\\n> +\t\t$(if $(V)$(DEBUG), --debug) \\\n> +\t\t$(if $(DEBUG), --interactive) \\\n> +\t\t$(if $(J),--jobs $(J)) \\\n> +\t\t--image \"$<\" \\\n> +\t\t--build-qemu $(SRC_PATH), \\\n> +\t\t\"  VM-BUILD $*\")\n> +\n\n\n--\nAlex Bennée","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MBPh4mnc\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwkdh6Zf0z9s7G\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 21:42:47 +1000 (AEST)","from localhost ([::1]:35861 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1dtuRp-0002rS-9E\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 07:42:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:42228)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <alex.bennee@linaro.org>) id 1dtuRX-0002r5-6q\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 07:42:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <alex.bennee@linaro.org>) id 1dtuRU-0007q7-4v\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 07:42:27 -0400","from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:44638)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from <alex.bennee@linaro.org>)\n\tid 1dtuRT-0007pq-TP\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 07:42:24 -0400","by mail-wm0-x231.google.com with SMTP id 189so12835966wmh.1\n\tfor <qemu-devel@nongnu.org>; Mon, 18 Sep 2017 04:42:23 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\tn29sm6652791wmi.46.2017.09.18.04.42.21\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 04:42:21 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id 7E0CF3E00DB;\n\tMon, 18 Sep 2017 12:42:21 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=rWSjfFGMMcSSX9CNe8dGJsSFCo1hFhjEvG+DvvYyIpA=;\n\tb=MBPh4mnchCEprWQLbCKa8F2ClRACreMXhu6KYFIcluIH/WswEQh/AGnQ5yiF0lhhhx\n\tzYtgSjbQ4x5y4uFIIkkNuVTQTqhgIwvAl4XJbp7pHkvBhdyPUJMdJZuxXTFb1W2Wv0Bn\n\tDjs+GB3VplT5qVn6nRzY6p3zrPHONH52QbsIw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=rWSjfFGMMcSSX9CNe8dGJsSFCo1hFhjEvG+DvvYyIpA=;\n\tb=cvFJjgPViprjgSgokqyMrce0xc0A3rzdkorPXIt4QOIReL+PXNlMELpe5knimvdV2X\n\t9dPhIQ7VvVI+isZ17LWDAlEDBEuyosx9wrGBnmaD77GkO/jRc+RjRHwppe5p4tfxwgfH\n\tteAxAj/eGDG+lifwXE+DgBPmoE+SU/xQ6QKPvFdyUKOYb3S02ig5D4FZKywzZDGvdkEz\n\tOOMRZaR78uh3zq+zfKn7OU2cq0li2bAR9dDMIbNm7oTsNMcJ0MPo7k8z5LuRfozkrcEE\n\tLi6fRxwvjyfjkHYHvMeiLEMjErI8+zAcFV5WHWGoJ4/AU8AsFZQsx0eNaX88YNsk2qv+\n\tB07w==","X-Gm-Message-State":"AHPjjUiCJ8rWoBBQ24KPkbBMgfnUs3qyqFcOIeUIGnFA4G5r7pq8OLZj\n\tz+1tVjef+TsyTsnd","X-Google-Smtp-Source":"AOwi7QAoPYwWBaZorqo03v37TFyk1j6LdlyWKMuWCCyxr8nq/JFOD0pGGKaVBlRjh+G8OfM0OrszaA==","X-Received":"by 10.28.215.84 with SMTP id o81mr7756249wmg.68.1505734942726;\n\tMon, 18 Sep 2017 04:42:22 -0700 (PDT)","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-11-famz@redhat.com>","User-agent":"mu4e 0.9.19; emacs 25.3.50.1","From":"Alex =?utf-8?q?Benn=C3=A9e?= <alex.bennee@linaro.org>","To":"Fam Zheng <famz@redhat.com>","In-reply-to":"<20170918024402.3265-11-famz@redhat.com>","Date":"Mon, 18 Sep 2017 12:42:21 +0100","Message-ID":"<877ewwjkrm.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::231","Subject":"Re: [Qemu-devel] [PATCH v8 10/13] Makefile: Add rules to run vm\n\ttests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= <f4bug@amsat.org>,\n\tKamil Rytarowski <kamil@netbsd.org>, stefanha@redhat.com, \n\tCleber Rosa <crosa@redhat.com>, pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]