[{"id":1770026,"web_url":"http://patchwork.ozlabs.org/comment/1770026/","msgid":"<87d16ojq9g.fsf@linaro.org>","list_archive_url":null,"date":"2017-09-18T09:43:39","subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/people/39532/","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"content":"Fam Zheng writes:\n\n> Signed-off-by: Fam Zheng \n> ---\n> tests/vm/README | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 85 insertions(+)\n> create mode 100644 tests/vm/README\n>\n> diff --git a/tests/vm/README b/tests/vm/README\n> new file mode 100644\n> index 0000000000..fa30a79ea7\n> --- /dev/null\n> +++ b/tests/vm/README\n> @@ -0,0 +1,85 @@\n> +=== VM test suite to run build in guests ===\n> +\n> +== Intro ==\n> +\n> +This test suite contains scripts that bootstrap various guest images that have\n> +necessary packages to build QEMU. The basic usage is documented in Makefile\n> +help which is displayed with \"make vm-test\".\n> +\n> +== Quick start ==\n> +\n> +Run \"make vm-test\" to list available make targets. Invoke a specific make\n> +command to run build test in an image. For example, \"make vm-build-freebsd\"\n> +will build the source tree in the FreeBSD image. The command can be executed\n> +from either the source tree or the build dir; if the former, ./configure is not\n> +needed. The command will then generate the test image in ./tests/vm/ under the\n> +working directory.\n> +\n> +== QEMU binary ==\n> +\n> +By default, qemu-system-x86_64 is searched in $PATH to run the guest. If there\n> +isn't one, or if it is older than 2.10, the test won't work. In this case,\n> +provide the QEMU binary in env var: QEMU=/path/to/qemu-2.10+.\n> +\n> +== Make jobs ==\n> +\n> +The \"-j$X\" option in the make command line is not propagated into the VM,\n> +specify \"J=$X\" to control the make jobs in the guest.\n> +\n> +== Debugging ==\n> +\n> +Add \"DEBUG=1\" and/or \"V=1\" to the make command to allow interactive debugging\n> +and verbose output. If this is not enough, see the next section.\n> +\n> +== Manual invocation ==\n> +\n> +Each guest script is an executable script with the same command line options.\n> +For example to work with the netbsd guest, use $QEMU_SRC/tests/vm/netbsd:\n> +\n> + $ cd $QEMU_SRC/tests/vm\n> +\n> + # To bootstrap the image\n> + $ ./netbsd --build-image --image /var/tmp/netbsd.img\n> + <...>\n> +\n> + # To run an arbitrary command in guest (the output will not be echoed unless\n> + # --debug is added)\n> + $ ./netbsd --debug --image /var/tmp/netbsd.img uname -a\n> +\n> + # To build QEMU in guest\n> + $ ./netbsd --debug --image /var/tmp/netbsd.img --build-qemu\n> $QEMU_SRC\n\nThis doesn't work:\n\n10:41:38 [alex@zen:~/l/q/q/t/vm] review/fam-vmbuild-v8(+2/-2) ± ./netbsd --debug --image netbsd.img --build-qemu /home/alex/lsrc/qemu/qemu.git/\nDEBUG:root:Creating archive ./vm-test-9yVAeh.tmp/data-9b5f9.tar for src_dir dir: /home/alex/lsrc/qemu/qemu.git/\n./scripts/archive-source.sh: 27: ./scripts/archive-source.sh: cannot create ./vm-test-9yVAeh.tmp/data-9b5f9.tar.list: Directory nonexistent\nFailed to prepare guest environment\nTraceback (most recent call last):\n File \"/home/alex/lsrc/qemu/qemu.git/tests/vm/basevm.py\", line 234, in main\n vm.add_source_dir(args.build_qemu)\n File \"/home/alex/lsrc/qemu/qemu.git/tests/vm/basevm.py\", line 140, in add_source_dir\n stdout=self._stdout, stderr=self._stderr)\n File \"/usr/lib/python2.7/subprocess.py\", line 541, in check_call\n raise CalledProcessError(retcode, cmd)\nCalledProcessError: Command '['./scripts/archive-source.sh', './vm-test-9yVAeh.tmp/data-9b5f9.tar']' returned non-zero exit status 2\n\nEither adjust the call to be from QEMU_SRC or make the call to\narchive-source smarter.\n\n> +\n> + # To get to an interactive shell\n> + $ ./netbsd --interactive --image /var/tmp/netbsd.img sh\n> +\n> +== Adding new guests ==\n> +\n> +Please look at existing guest scripts for how to add new guests.\n> +\n> +Most importantly, create a subclass of BaseVM and implement build_image()\n> +method and define BUILD_SCRIPT, then finally call basevm.main() from the\n> +script's main().\n> +\n> + - Usually in build_image(), a template image is downloaded from a predefined\n> + URL. BaseVM._download_with_cache() takes care of the cache and the\n> + checksum, so consider using it.\n> +\n> + - Once the image is downloaded, users, SSH server and QEMU build deps should\n> + be set up:\n> +\n> + * Root password set to BaseVM.ROOT_PASS\n> + * User BaseVM.GUEST_USER is created, and password set to BaseVM.GUEST_PASS\n> + * SSH service is enabled and started on boot,\n> + $QEMU_SRC/tests/keys/id_rsa.pub is added to ssh's \"authorized_keys\" file\n> + of both root and the normal user\n> + * DHCP client service is enabled and started on boot, so that it can\n> + automatically configure the virtio-net-pci NIC and communicate with QEMU\n> + user net (10.0.2.2)\n> + * Necessary packages are installed to untar the source tarball and build\n> + QEMU\n> +\n> + - Write a proper BUILD_SCRIPT template, which should be a shell script that\n> + untars a raw virtio-blk block device, which is the tarball data blob of the\n> + QEMU source tree, then configure/build it. Running \"make check\" is also\n> + recommended.\n> +\n\n\n--\nAlex Bennée","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"WTT+3aIR\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwh0l1lQjz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 19:44:07 +1000 (AEST)","from localhost ([::1]:35460 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtsaz-0008DQ-4j\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 05:44:05 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60062)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtsaf-0008DA-Op\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:43:47 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtsac-0005be-LW\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:43:45 -0400","from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:44071)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtsac-0005bO-CR\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:43:42 -0400","by mail-wm0-x231.google.com with SMTP id 189so12333334wmh.1\n\tfor ; Mon, 18 Sep 2017 02:43:42 -0700 (PDT)","from zen.linaro.local ([81.128.185.34])\n\tby smtp.gmail.com with ESMTPSA id\n\ta69sm6472594wme.40.2017.09.18.02.43.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 18 Sep 2017 02:43:40 -0700 (PDT)","from zen (localhost [127.0.0.1])\n\tby zen.linaro.local (Postfix) with ESMTPS id F02893E00DB;\n\tMon, 18 Sep 2017 10:43:39 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=references:user-agent:from:to:cc:subject:in-reply-to:date\n\t:message-id:mime-version:content-transfer-encoding;\n\tbh=KkgI3jq5HAa78gI7Wtg9J1TyW7Zs3GO7Q8TsBJ2Uf64=;\n\tb=WTT+3aIRCc+v9qf2NgjRST+2gW9bFT3KGYcQIgQRu5CDlhv0Za+bikykUO6FlHkE7X\n\t3oE5TN6czrgl7Se+sxbdBPZHthdQGtcjk90n7oVNX6bxOD9DSP0nPVw1f7/7AFlL/fql\n\tSz4gOCNoGud6C2BVFFfrmfN9IfkiD5dDMts7A=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:references:user-agent:from:to:cc:subject\n\t:in-reply-to:date:message-id:mime-version:content-transfer-encoding; \n\tbh=KkgI3jq5HAa78gI7Wtg9J1TyW7Zs3GO7Q8TsBJ2Uf64=;\n\tb=gnNWO9Xot9O/PLpzQzM+aV3JDf+amLNT1lFcJiIoDfdN5g8tJ2WSterzHG+mPZ473t\n\tLOP7aOZIoZE6YZv1s7CHWdVV98hD0I3njEsY/BOQ9sV7mQVnfJZ337QHPvE7YP0w/FqI\n\t+1vPmY47xreiINiQraSGFmSD9nywZcf4iHc/SAM+qU6JPuH/9SeKo0cGzbfXUvf7ZDjG\n\tavXsAR3P+L3wCyhmeJf95Mv3RF6a7ttxKU6ICQTLul5RBgVYsw4Ih4TvI4D8T/YQ69BM\n\tfd2E5Fwl6JqPPRMq7m0hXAlnQA8qxNlZhg+oA64OBAc+5OCxM2NPsJz2VktgfBKVcYgN\n\tjgxg==","X-Gm-Message-State":"AHPjjUjsbUbJerWHCRKyNTsktZ/ISW1a6nKolBeZ2Bz+d8Q4WtOfdRzX\n\tOnNbHxdnGVZI1iSI","X-Google-Smtp-Source":"AOwi7QASv1kPsYMEiRAotFEcVi4jzWI8S5nDGa8k9+WywjyxkD9NZhzG81UKdgQs/PAVFNkXqop5Lg==","X-Received":"by 10.28.97.135 with SMTP id v129mr8938796wmb.98.1505727821054; \n\tMon, 18 Sep 2017 02:43:41 -0700 (PDT)","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-13-famz@redhat.com>","User-agent":"mu4e 0.9.19; emacs 25.3.50.1","From":"Alex =?utf-8?q?Benn=C3=A9e?= ","To":"Fam Zheng ","In-reply-to":"<20170918024402.3265-13-famz@redhat.com>","Date":"Mon, 18 Sep 2017 10:43:39 +0100","Message-ID":"<87d16ojq9g.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"8bit","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::231","Subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?utf-8?q?Mathieu-Daud=C3=A9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770106,"web_url":"http://patchwork.ozlabs.org/comment/1770106/","msgid":"<20170918120300.GM15551@lemon.lan>","list_archive_url":null,"date":"2017-09-18T12:03:00","subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Mon, 09/18 10:43, Alex Bennée wrote:\n> \n> Fam Zheng writes:\n> \n> > Signed-off-by: Fam Zheng \n> > ---\n> > tests/vm/README | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> > 1 file changed, 85 insertions(+)\n> > create mode 100644 tests/vm/README\n> >\n> > diff --git a/tests/vm/README b/tests/vm/README\n> > new file mode 100644\n> > index 0000000000..fa30a79ea7\n> > --- /dev/null\n> > +++ b/tests/vm/README\n> > @@ -0,0 +1,85 @@\n> > +=== VM test suite to run build in guests ===\n> > +\n> > +== Intro ==\n> > +\n> > +This test suite contains scripts that bootstrap various guest images that have\n> > +necessary packages to build QEMU. The basic usage is documented in Makefile\n> > +help which is displayed with \"make vm-test\".\n> > +\n> > +== Quick start ==\n> > +\n> > +Run \"make vm-test\" to list available make targets. Invoke a specific make\n> > +command to run build test in an image. For example, \"make vm-build-freebsd\"\n> > +will build the source tree in the FreeBSD image. The command can be executed\n> > +from either the source tree or the build dir; if the former, ./configure is not\n> > +needed. The command will then generate the test image in ./tests/vm/ under the\n> > +working directory.\n> > +\n> > +== QEMU binary ==\n> > +\n> > +By default, qemu-system-x86_64 is searched in $PATH to run the guest. If there\n> > +isn't one, or if it is older than 2.10, the test won't work. In this case,\n> > +provide the QEMU binary in env var: QEMU=/path/to/qemu-2.10+.\n> > +\n> > +== Make jobs ==\n> > +\n> > +The \"-j$X\" option in the make command line is not propagated into the VM,\n> > +specify \"J=$X\" to control the make jobs in the guest.\n> > +\n> > +== Debugging ==\n> > +\n> > +Add \"DEBUG=1\" and/or \"V=1\" to the make command to allow interactive debugging\n> > +and verbose output. If this is not enough, see the next section.\n> > +\n> > +== Manual invocation ==\n> > +\n> > +Each guest script is an executable script with the same command line options.\n> > +For example to work with the netbsd guest, use $QEMU_SRC/tests/vm/netbsd:\n> > +\n> > + $ cd $QEMU_SRC/tests/vm\n> > +\n> > + # To bootstrap the image\n> > + $ ./netbsd --build-image --image /var/tmp/netbsd.img\n> > + <...>\n> > +\n> > + # To run an arbitrary command in guest (the output will not be echoed unless\n> > + # --debug is added)\n> > + $ ./netbsd --debug --image /var/tmp/netbsd.img uname -a\n> > +\n> > + # To build QEMU in guest\n> > + $ ./netbsd --debug --image /var/tmp/netbsd.img --build-qemu\n> > $QEMU_SRC\n> \n> This doesn't work:\n> \n> 10:41:38 [alex@zen:~/l/q/q/t/vm] review/fam-vmbuild-v8(+2/-2) ± ./netbsd --debug --image netbsd.img --build-qemu /home/alex/lsrc/qemu/qemu.git/\n> DEBUG:root:Creating archive ./vm-test-9yVAeh.tmp/data-9b5f9.tar for src_dir dir: /home/alex/lsrc/qemu/qemu.git/\n> ./scripts/archive-source.sh: 27: ./scripts/archive-source.sh: cannot create ./vm-test-9yVAeh.tmp/data-9b5f9.tar.list: Directory nonexistent\n> Failed to prepare guest environment\n> Traceback (most recent call last):\n> File \"/home/alex/lsrc/qemu/qemu.git/tests/vm/basevm.py\", line 234, in main\n> vm.add_source_dir(args.build_qemu)\n> File \"/home/alex/lsrc/qemu/qemu.git/tests/vm/basevm.py\", line 140, in add_source_dir\n> stdout=self._stdout, stderr=self._stderr)\n> File \"/usr/lib/python2.7/subprocess.py\", line 541, in check_call\n> raise CalledProcessError(retcode, cmd)\n> CalledProcessError: Command '['./scripts/archive-source.sh', './vm-test-9yVAeh.tmp/data-9b5f9.tar']' returned non-zero exit status 2\n> \n> Either adjust the call to be from QEMU_SRC or make the call to\n> archive-source smarter.\n\nYup, I failed to verify manual invocations since the revision which introduced\narchive-source.sh.. I would use absolute path for tmpdir everywhere, by\nsquashing in this:\n\ndiff --git a/tests/vm/basevm.py b/tests/vm/basevm.py\nindex 77d07b161d..cbaa061c72 100755\n--- a/tests/vm/basevm.py\n+++ b/tests/vm/basevm.py\n@@ -43,7 +43,9 @@ class BaseVM(object):\n name = \"#base\"\n def __init__(self, debug=False, vcpus=None):\n self._guest = None\n- self._tmpdir = tempfile.mkdtemp(prefix=\"vm-test-\", suffix=\".tmp\", dir=\".\")\n+ self._tmpdir = os.path.realpath(tempfile.mkdtemp(prefix=\"vm-test-\",\n+ suffix=\".tmp\",\n+ dir=\".\"))\n atexit.register(shutil.rmtree, self._tmpdir)\n\n self._ssh_key_file = os.path.join(self._tmpdir, \"id_rsa\")\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwl6G5rcdz9s78\n\tfor ;\n\tMon, 18 Sep 2017 22:04:06 +1000 (AEST)","from localhost ([::1]:36193 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtumS-0002QR-T0\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 08:04:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49345)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtuli-0002MH-AP\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:03:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtulc-0001T3-7Y\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:03:18 -0400","from mx1.redhat.com ([209.132.183.28]:50759)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtulb-0001SW-Vj\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:03:12 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id AD57D883D6;\n\tMon, 18 Sep 2017 12:03:10 +0000 (UTC)","from localhost (ovpn-12-141.pek2.redhat.com [10.72.12.141])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 5B63B60627;\n\tMon, 18 Sep 2017 12:03:02 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com AD57D883D6","Date":"Mon, 18 Sep 2017 20:03:00 +0800","From":"Fam Zheng ","To":"Alex =?iso-8859-1?q?Benn=E9e?= ","Message-ID":"<20170918120300.GM15551@lemon.lan>","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-13-famz@redhat.com>\n\t<87d16ojq9g.fsf@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","In-Reply-To":"<87d16ojq9g.fsf@linaro.org>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tMon, 18 Sep 2017 12:03:10 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770248,"web_url":"http://patchwork.ozlabs.org/comment/1770248/","msgid":"","list_archive_url":null,"date":"2017-09-18T15:20:22","subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/17/2017 09:44 PM, Fam Zheng wrote:\n> Signed-off-by: Fam Zheng \n> ---\n> tests/vm/README | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 85 insertions(+)\n> create mode 100644 tests/vm/README\n\nThe README should ALSO mention that (some) of the guests created in this\nmanner are using a well-known public/private-key pair, and MUST NOT be\nexposed to external interfaces if you are at all concerned about an\nattacker being able to take over the guest VM and exploit any other qemu\nbug that can then take over your host machine.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwqTS3GN4z9s72\n\tfor ;\n\tTue, 19 Sep 2017 01:20:56 +1000 (AEST)","from localhost ([::1]:37213 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtxqv-0003Vf-G8\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 11:20:53 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:46064)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtxqc-0003VW-Fx\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:20:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtxqY-00039o-Cb\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:20:34 -0400","from mx1.redhat.com ([209.132.183.28]:29244)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtxqY-00039e-3a\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:20:30 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 16DDF10DCC;\n\tMon, 18 Sep 2017 15:20:29 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 6212B5C552;\n\tMon, 18 Sep 2017 15:20:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 16DDF10DCC","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-13-famz@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Mon, 18 Sep 2017 10:20:22 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918024402.3265-13-famz@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"p0Qt2M1wh0Hhe0Kj02aMLIR2JFLrvq7oi\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tMon, 18 Sep 2017 15:20:29 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?b?YXVkw6k=?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]