[{"id":1770245,"web_url":"http://patchwork.ozlabs.org/comment/1770245/","msgid":"<234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com>","list_archive_url":null,"date":"2017-09-18T15:17:21","subject":"Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/17/2017 09:43 PM, Fam Zheng wrote:\n> This will be used by setup test user ssh.\n\nShouldn't the commit message have more details about WHY we are checking\nin a private key? The conversation last time included useful gems such as:\n\nSome guests require the key to exist prior to provisioning the guest,\nand reusing a pre-built key avoids consuming entropy every time the\ntestsuite is run. Because the private key is well-known, care must be\ntaken to use the key ONLY in situations that cannot be compromised by\nexternal network clients.\n\n> \n> Signed-off-by: Fam Zheng \n> ---\n> tests/keys/id_rsa | 27 +++++++++++++++++++++++++++\n> tests/keys/id_rsa.pub | 1 +\n> 2 files changed, 28 insertions(+)\n> create mode 100644 tests/keys/id_rsa\n> create mode 100644 tests/keys/id_rsa.pub\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx07.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwqPs6ftDz9s4s\n\tfor ;\n\tTue, 19 Sep 2017 01:17:53 +1000 (AEST)","from localhost ([::1]:37198 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtxo0-0001yH-14\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 11:17:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:45008)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtxnh-0001xf-VL\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:17:35 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtxnd-0001sG-So\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:17:33 -0400","from mx1.redhat.com ([209.132.183.28]:44664)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtxnd-0001rl-Je\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 11:17:29 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B472EC0AC36A;\n\tMon, 18 Sep 2017 15:17:28 +0000 (UTC)","from [10.10.124.97] (ovpn-124-97.rdu2.redhat.com [10.10.124.97])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 8A0111852A;\n\tMon, 18 Sep 2017 15:17:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com B472EC0AC36A","To":"Fam Zheng , qemu-devel@nongnu.org","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-5-famz@redhat.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com>","Date":"Mon, 18 Sep 2017 10:17:21 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170918024402.3265-5-famz@redhat.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"PPjBB7fkQlAVjtXaBC9pJQuTloqbMmV2n\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.31]);\n\tMon, 18 Sep 2017 15:17:28 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?b?YXVkw6k=?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com,\n\t=?utf-8?q?Alex_Benn=C3=A9e?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770612,"web_url":"http://patchwork.ozlabs.org/comment/1770612/","msgid":"<20170919021028.GB11534@lemon.lan>","list_archive_url":null,"date":"2017-09-19T02:10:28","subject":"Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair","submitter":{"id":24872,"url":"http://patchwork.ozlabs.org/api/people/24872/","name":"Fam Zheng","email":"famz@redhat.com"},"content":"On Mon, 09/18 10:17, Eric Blake wrote:\n> On 09/17/2017 09:43 PM, Fam Zheng wrote:\n> > This will be used by setup test user ssh.\n> \n> Shouldn't the commit message have more details about WHY we are checking\n> in a private key? The conversation last time included useful gems such as:\n> \n> Some guests require the key to exist prior to provisioning the guest,\n> and reusing a pre-built key avoids consuming entropy every time the\n> testsuite is run. Because the private key is well-known, care must be\n> taken to use the key ONLY in situations that cannot be compromised by\n> external network clients.\n\nYeah. Not everyone looks at the commit message, I'll add a tests/keys/README to\ndocument that.\n\nFam","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=famz@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx5vj1md0z9s3w\n\tfor ;\n\tTue, 19 Sep 2017 12:11:13 +1000 (AEST)","from localhost ([::1]:39706 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1du80F-0004Dl-Bf\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 22:11:11 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:32905)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1du7zk-0004CB-0p\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 22:10:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1du7ze-0004p6-Gb\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 22:10:39 -0400","from mx1.redhat.com ([209.132.183.28]:45058)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1du7ze-0004ob-9m\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 22:10:34 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4E11C2C9708;\n\tTue, 19 Sep 2017 02:10:33 +0000 (UTC)","from localhost (ovpn-12-98.pek2.redhat.com [10.72.12.98])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 624C55D97A;\n\tTue, 19 Sep 2017 02:10:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4E11C2C9708","Date":"Tue, 19 Sep 2017 10:10:28 +0800","From":"Fam Zheng ","To":"Eric Blake ","Message-ID":"<20170919021028.GB11534@lemon.lan>","References":"<20170918024402.3265-1-famz@redhat.com>\n\t<20170918024402.3265-5-famz@redhat.com>\n\t<234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<234e0e32-0f16-c621-6062-a2ee140efdf6@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tTue, 19 Sep 2017 02:10:33 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 04/13] tests: Add a test key pair","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Peter Maydell , qemu-devel@nongnu.org, Philippe\n\t=?iso-8859-1?q?Mathieu-Daud=E9?= ,\n\tKamil Rytarowski , stefanha@redhat.com, \n\tCleber Rosa , pbonzini@redhat.com, Alex\n\t=?iso-8859-1?q?Benn=E9e?= ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]