[{"id":1769866,"web_url":"http://patchwork.ozlabs.org/comment/1769866/","msgid":"<4e2a4e46-e181-ef30-37aa-927fdfe1b866@gmx.de>","list_archive_url":null,"date":"2017-09-18T04:55:28","subject":"Re: [U-Boot] [PATCH 05/16] efi: Correct header order in efi_memory","submitter":{"id":61270,"url":"http://patchwork.ozlabs.org/api/people/61270/","name":"Heinrich Schuchardt","email":"xypron.glpk@gmx.de"},"content":"On 09/18/2017 12:59 AM, Simon Glass wrote:\n> The headers are not in the correct order. Fix this.\n\nThe commit message should tell that and explain why you are dropping\n#include <libfdt_env.h>\n\n> \n> Signed-off-by: Simon Glass <sjg@chromium.org>\n> ---\n> \n>  lib/efi_loader/efi_memory.c | 5 ++---\n>  1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c\n> index 9e079f1fa3..ad3d277be6 100644\n> --- a/lib/efi_loader/efi_memory.c\n> +++ b/lib/efi_loader/efi_memory.c\n> @@ -8,12 +8,11 @@\n>  \n>  #include <common.h>\n>  #include <efi_loader.h>\n> +#include <inttypes.h>\n>  #include <malloc.h>\n> +#include <watchdog.h>\n>  #include <asm/global_data.h>\n> -#include <libfdt_env.h>\n>  #include <linux/list_sort.h>\n> -#include <inttypes.h>\n> -#include <watchdog.h>\n>  \n>  DECLARE_GLOBAL_DATA_PTR;\n>  \n>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwYc422sFz9ryr\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 14:55:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 07C31C21F21; Mon, 18 Sep 2017 04:55:40 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 1CDBFC21D57;\n\tMon, 18 Sep 2017 04:55:38 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 0FB38C21D57; Mon, 18 Sep 2017 04:55:36 +0000 (UTC)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lists.denx.de (Postfix) with ESMTPS id A3E87C21D19\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 04:55:36 +0000 (UTC)","from [192.168.123.58] ([84.118.154.110]) by mail.gmx.com (mrgmx103\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t0LymjL-1dNAtY2RN9-0163vX; Mon, 18 Sep 2017 06:55:31 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","To":"Simon Glass <sjg@chromium.org>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>","References":"<20170917225927.117917-1-sjg@chromium.org>\n\t<20170917225927.117917-6-sjg@chromium.org>","From":"Heinrich Schuchardt <xypron.glpk@gmx.de>","Message-ID":"<4e2a4e46-e181-ef30-37aa-927fdfe1b866@gmx.de>","Date":"Mon, 18 Sep 2017 06:55:28 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170917225927.117917-6-sjg@chromium.org>","Content-Language":"en-US","X-Provags-ID":"V03:K0:VY5L4dHoc7Qf2HAXnXQrFvTHTRo8ufA1ySua4QAkcdFza7BL80f\n\tO1q3x54EelvohoUvctggtnzZs0v4tiTAmQtKxD7WDrahmMbo/rHsxetgXrpos8z/uDAb0Yo\n\tEeWkcH/4bVVes0Vw1wspt+L+TYi7bD8WcPD/MPZY++unCrauzUj8JzXxtIu4jzQfvHyAqVv\n\tirPhwBmMyU6HuwsXIYJIg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:CXe+6ti+SaU=:nHq6mRCpCckZ6FKo2e58lK\n\t2iIljFyxm/i4mSPzNNL6+3GcdwM/E/cakC209SA8eg/c90SO/k8NyfCFZNk5qyKPY5Gco7Zfl\n\trHcHqZ1mHCE/q5HRfX/j99ob1vdSPOInjq1F2noJQzf5ivIfLxgeKotxBSspWE/pofPShxXaL\n\tYdMjOKLfeubHDHgccksbpiDdylq3+GRTUYGuLRX/dO8thUr4d+nwOB4OerETPV8+1xYn+HNFz\n\tIb7DuD2yg7YGg7Be19edciRSTQgxKSdl4NFUuvJMLSucrk2T5spQB8eLVbOr8sMnuGFacN7XG\n\tPilh2DJ9MFwIm3Zd3xKgNcYyUZoATAXnwRjnUwsbiquA5u+qipfwsivAtkcvwzxfR4di4Fhm9\n\tAZnO8VPn7jkiotLZY+aVZqZmyHvz8d5GFeT1Q/8oUZe6D4ecgFAGsC2KXq6HJyCeTHiFg9OPW\n\tw0AiRKZtdcGaTDXrwZbmk7oEWPYBWdTWvVHe30Q5yFbsLn/x0BW0JbRndTkMZRJYm3tPX0jcl\n\tfTxBlWk36asjLv+Hvj9gZLYkSuDbyTnbT+CEpincDaAZYMg8CVPYCsUKcaB+LK4/U2vZ7Zurs\n\tReHoyPKwnuZYCQDy+SO6UfvYXwSdlqDR/ElJJMfEhrgp9wNGbxEm42RTFMYAjpjyFhUISPf3y\n\tAT87lPtxdWB31DNG70cTsemWGYYi6C6veOZYU2UpRjFh+1NRATe6/m7adjsnMLQM9RKhoVNmN\n\tDOV8uoSKcgXPdQUPcV2hI8n6oEUYk5/BUBAxkVDw5Kz3fvQeQq+gnnmPSe1ISWxUJ/Uaiz9Qx\n\tUmDcxtpncDGYawTBt8sEKx3XAi8dfGSaHVLzLDloTUFPAPGOTU=","Cc":"Heinrich Schuchardt <xypron.glpk@gmx.de>,\n\tAndy Shevchenko <andriy.shevchenko@linux.intel.com>","Subject":"Re: [U-Boot] [PATCH 05/16] efi: Correct header order in efi_memory","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]