[{"id":1770006,"web_url":"http://patchwork.ozlabs.org/comment/1770006/","msgid":"","list_archive_url":null,"date":"2017-09-18T09:26:04","subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"On Sun, Sep 17, 2017 at 11:39 AM, Linus Walleij\n wrote:\n> This adds support for using the \"sda\" and \"scl\" GPIOs in\n> device tree instead of anonymously using index 0 and 1 of\n> the \"gpios\" property.\n>\n> We add a helper function to retrieve the GPIO descriptors\n> and some explicit error handling since the probe may have\n> to be deferred. At least this happened to me when moving\n> to using named \"sda\" and \"scl\" lines (all of a sudden this\n> started to probe before the GPIO driver) so we need to\n> gracefully defer probe when we ge -ENOENT in the error\n\nget\n\n> pointer.\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"aR6qQtpL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwgdB31SCz9s72\n\tfor ;\n\tMon, 18 Sep 2017 19:27:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755046AbdIRJ1I (ORCPT );\n\tMon, 18 Sep 2017 05:27:08 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:38339 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754908AbdIRJ0F (ORCPT\n\t); Mon, 18 Sep 2017 05:26:05 -0400","by mail-pg0-f68.google.com with SMTP id m30so4948272pgn.5\n\tfor ; Mon, 18 Sep 2017 02:26:05 -0700 (PDT)","by 10.100.160.13 with HTTP; Mon, 18 Sep 2017 02:26:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=BkLVJltjxh2pb+aDKiJcZBZbSmUV1Ddmy1n91rmGA9w=;\n\tb=aR6qQtpLp4wM8jgHvoD73uYSt46QKxVNUwQvvao0aFUHtKz/UXH+FUWfKq7s9E7slj\n\tQeyOZB+871QMEI/eGCe0lFUywEMVTRyiKe9tp9zLwPavlDSb2oLAx5AER8+UC7M18z2N\n\t7uKqqdqJv3376HqnL1rjG991wtrVT5qZF80SeSX8VyR9mxyUrVKl3cuO7KJtsPnc+k0/\n\toGv5a6tRPl9oVbCekXHYDtReQBvyhGMGAkIB0bxL9X6gyeXSKvgKRq2PZdCxo195g/4a\n\t5uz7WNgV/TbsCrvHsLd6Rd5HM//ugA4tbps2dWGduMcX1aPHmR4RdyJN7MXq+bNwQPwN\n\tQbDw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=BkLVJltjxh2pb+aDKiJcZBZbSmUV1Ddmy1n91rmGA9w=;\n\tb=LE02RjJAq+mM0z635DlfpbA9uKDDdgKsMkAvH5TbYmfcRR29zAdPE2JevRY/jJf/53\n\tCSH9Tckvm18UkeWTnMzE1urVmHlr+k3/ioWp3jr6SK2qUAN/o0Qpyk13Vzje1OsuHb8y\n\tPIZUr3JItN7hbnhNFnBRo1RFE1UFgYSzkKPCxeXw/8Nj5tvOme+hNkfY293yfesnJ8xk\n\t3yxMUh9am0GCwk3Ioa9yzs3JX3J0Skckae8OcqLkLBKBgLuquuwhFDmqvIy2/RKPBVfI\n\t9mNq9rcL46sUAOb8oUx+waMWNn7P1cCoRzxHuklBrP6Li0XalDRhPX5oGMiKytAIGMb0\n\tl/kQ==","X-Gm-Message-State":"AHPjjUhaRDgrYTBvjrmqyT8r/Mt0bJE8RsXGRm3agINoasl9JZDYr3yl\n\t5cgo18fmo6h77BPbfppJ9MpRx8M3KLt6KHlBC2s=","X-Google-Smtp-Source":"AOwi7QClKLZkNp4foNrFpyQgBNTFlTlUogbu5/Ra6kjX40Cwsq6d7r/pL9kfpoEKtLEsFQhV5K2djol1Z1Kw74GtCdM=","X-Received":"by 10.101.67.137 with SMTP id m9mr12755391pgp.63.1505726764815; \n\tMon, 18 Sep 2017 02:26:04 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170917093906.16325-8-linus.walleij@linaro.org>","References":"<20170917093906.16325-1-linus.walleij@linaro.org>\n\t<20170917093906.16325-8-linus.walleij@linaro.org>","From":"Geert Uytterhoeven ","Date":"Mon, 18 Sep 2017 11:26:04 +0200","X-Google-Sender-Auth":"1usnQCHDrO4-iureelPTJpXwVM0","Message-ID":"","Subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","To":"Linus Walleij ","Cc":"Wolfram Sang , Linux I2C ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tLinux MIPS Mailing List ,\n\t\"adi-buildroot-devel@lists.sourceforge.net\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1770039,"web_url":"http://patchwork.ozlabs.org/comment/1770039/","msgid":"","list_archive_url":null,"date":"2017-09-18T09:58:40","subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","submitter":{"id":703,"url":"http://patchwork.ozlabs.org/api/people/703/","name":"Geert Uytterhoeven","email":"geert@linux-m68k.org"},"content":"Hi Linus,\n\nOn Sun, Sep 17, 2017 at 11:39 AM, Linus Walleij\n wrote:\n> This adds support for using the \"sda\" and \"scl\" GPIOs in\n> device tree instead of anonymously using index 0 and 1 of\n> the \"gpios\" property.\n>\n> We add a helper function to retrieve the GPIO descriptors\n> and some explicit error handling since the probe may have\n> to be deferred. At least this happened to me when moving\n> to using named \"sda\" and \"scl\" lines (all of a sudden this\n> started to probe before the GPIO driver) so we need to\n> gracefully defer probe when we ge -ENOENT in the error\n> pointer.\n>\n> Suggested-by: Geert Uytterhoeven \n> Signed-off-by: Linus Walleij \n> ---\n> This is pretty much a rewrite of Geerts patch on top of\n> my own changes to support descriptors.\n> ---\n> drivers/i2c/busses/i2c-gpio.c | 59 +++++++++++++++++++++++++++++++------------\n> 1 file changed, 43 insertions(+), 16 deletions(-)\n>\n> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c\n> index beb5ce523684..2738b851f470 100644\n> --- a/drivers/i2c/busses/i2c-gpio.c\n> +++ b/drivers/i2c/busses/i2c-gpio.c\n> @@ -82,6 +82,42 @@ static void of_i2c_gpio_get_props(struct device_node *np,\n> of_property_read_bool(np, \"i2c-gpio,scl-output-only\");\n> }\n>\n> +static struct gpio_desc *i2c_gpio_get_desc(struct device *dev,\n> + const char *con_id,\n> + unsigned int index,\n> + enum gpiod_flags gflags)\n> +{\n> + struct gpio_desc *retdesc;\n> + int ret;\n\n[...]\n\n> + if (ret != -EPROBE_DEFER)\n> + dev_err(dev, \"error trying to get descriptor: %ld\\n\", ret);\n\nwarning: format '%ld' expects argument of type 'long int', but\nargument 3 has type 'int' [-Wformat=]\n\n%d (0day busy?)\n\n> +\n> + return retdesc;\n> +}\n\nGr{oetje,eeting}s,\n\n Geert\n\n--\nGeert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org\n\nIn personal conversations with technical people, I call myself a hacker. But\nwhen I'm talking to journalists I just say \"programmer\" or something like that.\n -- Linus Torvalds","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"I7QbbfOR\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwhKd3sB0z9ryv\n\tfor ;\n\tMon, 18 Sep 2017 19:58:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755686AbdIRJ6m (ORCPT );\n\tMon, 18 Sep 2017 05:58:42 -0400","from mail-pg0-f68.google.com ([74.125.83.68]:38503 \"EHLO\n\tmail-pg0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755696AbdIRJ6l (ORCPT\n\t); Mon, 18 Sep 2017 05:58:41 -0400","by mail-pg0-f68.google.com with SMTP id m30so4980477pgn.5\n\tfor ; Mon, 18 Sep 2017 02:58:41 -0700 (PDT)","by 10.100.160.13 with HTTP; Mon, 18 Sep 2017 02:58:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=ei7y6Cd4+ASo/xdHS0DaZsM9MICmfb3lreSB8v1iIEQ=;\n\tb=I7QbbfORXUtJBaR+vaHBiE8vgmgk9jjuIw+mfDwnjLzHkvRkbjx6iCuFp631GRu0FT\n\ttJ0tH3J9WvfjHFt3eI4J5K4dS1FqHvb22FlbCBdxl8zqvLfSXso4vlFpOHtb2CETnCRK\n\tdImZRgWCTWHQWc+Lv6CMNpst2QbpEp8tv64HjfkDkt5la1ch4C/BQu7fWBggClHm+jYk\n\t8HxR3hYYwWjhMvFcEnyFVC397klbHHyUobiX4DwAToObi4pX8NV4HfiSdX8sTtQAs5z0\n\tVuK4q7w8+8iNlfgc6hCIwBD9XWMS9N9Ipf/8jDXOnmH2EoqgFqdU0UUx9IGLCfSzU5jP\n\tC7XA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=ei7y6Cd4+ASo/xdHS0DaZsM9MICmfb3lreSB8v1iIEQ=;\n\tb=FVlhdyDPVvNTZKlauUKm93S5YNWLV6BhZTkw1qgrdBNRBDYBFetIX0Z1VhTkEZs5oQ\n\ttU7hBoBg6XJcLW3TZQ7456/2cLbjFEVwyuYATQvAhAUxZX0pXPw6MUv8q6Nsi9YMO9oB\n\tYxotsXDoTorVVuRm3/TSamlLdC8Dq+e5YKWIc4YUgWGJ8m5xowykQQxiQNLd3u9XeuOR\n\tt1V6ZEpTd833b3COya2IXiW2FIObvCQ4DyW4JcbTvklBB28Pq/1b4mIGHe4HWBucZRTD\n\trNFZXr4NKWVMWspzZlCL7IZYook5GTcYyoSuz1FIIS4qoXnYqCcOZ0Nzow/oUxSd80F5\n\tCPUQ==","X-Gm-Message-State":"AHPjjUgehbJjbph9R2eUBKIuBuJBLYagPmS7IG+Bmh24AdITkFAcwlks\n\tCf8LqX9SAWTibMi/Zn5ITHE5+TjAaTDhzZljTgo=","X-Google-Smtp-Source":"AOwi7QBcyutQ/tmDIyhEYdZZL1vDmdfRYEBxP62a2GCCNhiSXC54KLQ1ItXdrO+1XvUN0EhDIEyLDCvYuMfvHMPhpvk=","X-Received":"by 10.101.67.137 with SMTP id m9mr12827874pgp.63.1505728720584; \n\tMon, 18 Sep 2017 02:58:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170917093906.16325-8-linus.walleij@linaro.org>","References":"<20170917093906.16325-1-linus.walleij@linaro.org>\n\t<20170917093906.16325-8-linus.walleij@linaro.org>","From":"Geert Uytterhoeven ","Date":"Mon, 18 Sep 2017 11:58:40 +0200","X-Google-Sender-Auth":"rn7PFit4cpycn8fWhcNdZzLZzwM","Message-ID":"","Subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","To":"Linus Walleij ","Cc":"Wolfram Sang , Linux I2C ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tLinux MIPS Mailing List ,\n\t\"adi-buildroot-devel@lists.sourceforge.net\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1770433,"web_url":"http://patchwork.ozlabs.org/comment/1770433/","msgid":"","list_archive_url":null,"date":"2017-09-18T19:09:39","subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Mon, Sep 18, 2017 at 11:58 AM, Geert Uytterhoeven\n wrote:\n\n>> + if (ret != -EPROBE_DEFER)\n>> + dev_err(dev, \"error trying to get descriptor: %ld\\n\", ret);\n>\n> warning: format '%ld' expects argument of type 'long int', but\n> argument 3 has type 'int' [-Wformat=]\n>\n> %d (0day busy?)\n\nBah haven't pushed it to the 0day builders yet.\nI'll do that tonight so I can drown in the build errors.\n:-D\n\nFixing it.\n\nYours,\nLinus Walleij","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"FMxLbJst\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwwYP6r9pz9sBd\n\tfor ;\n\tTue, 19 Sep 2017 05:09:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751575AbdIRTJn (ORCPT );\n\tMon, 18 Sep 2017 15:09:43 -0400","from mail-io0-f175.google.com ([209.85.223.175]:53965 \"EHLO\n\tmail-io0-f175.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751561AbdIRTJk (ORCPT\n\t); Mon, 18 Sep 2017 15:09:40 -0400","by mail-io0-f175.google.com with SMTP id q11so4602163ioe.10\n\tfor ; Mon, 18 Sep 2017 12:09:40 -0700 (PDT)","by 10.79.164.78 with HTTP; Mon, 18 Sep 2017 12:09:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=mZij9RtT0OwvSzjyWH0ZMI7sELbw0Dm4WuovXS483Go=;\n\tb=FMxLbJstjzS0nqAmu7dDqJbJSo3KHlNpc4lc5418pWE+F4JumgdmH7m4T6e4uJu17F\n\t2A6c4mHbyMvLdRZN4UqRORzZuJa1G6iiAfVBPmp8H6u9OF1BykgG8tyAw3khBc/EmTSE\n\tS3cZIbU+D4T5lgKfMPVoyVhFyDlvx/FDxdjTU=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=mZij9RtT0OwvSzjyWH0ZMI7sELbw0Dm4WuovXS483Go=;\n\tb=teoaa+XSBuuVjahgZOxE9c2yVG9mFXmWTXGtfY+Sjb4xfgD85GX2w7NZ2K6oF9cgUn\n\tEvbH50PFp2nT5ZS18uukLmrWBPIOo3XRYnUU0UjbkapAdFZrg6svdwYXj4G3eWekMGUp\n\trE2rZ525WFraXW109Yktc6iG7LeMAV54QnY/JpY5iJdLM1Td3vpOGBeJBgNTKBHnpJFM\n\t/5mPa9vFVIHHftdxWTSUPN5LQEY6preJnm3MY9CAxHFlQerlqrxIdU8ab3DarKfU2bZg\n\tMvzeoOX1cGkQnFQle3EBVFG6OgLyCEcTFxHSZFP64zO9Nzp07iciZbkjcgKexAmKKfG0\n\tCfaw==","X-Gm-Message-State":"AHPjjUiEPYERwLB09LXjEXRJz5lRJBT3i8jWAU2Wcffxs1ba62vZinBY\n\tCyCBzqdgPxrGOIUuccJ2tLoH7Atr2hxl5thnj40G3w==","X-Google-Smtp-Source":"AOwi7QACPkDFrauGqTzQkQg4Yyp3Jooi9/x13tVm/ywRvAFaZCF+UJRPvsdgbzgsdYjlBcZyO8Rd/VqwIxAJ7nweqq0=","X-Received":"by 10.107.139.215 with SMTP id\n\tn206mr22532675iod.155.1505761780058; \n\tMon, 18 Sep 2017 12:09:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170917093906.16325-1-linus.walleij@linaro.org>\n\t<20170917093906.16325-8-linus.walleij@linaro.org>\n\t","From":"Linus Walleij ","Date":"Mon, 18 Sep 2017 21:09:39 +0200","Message-ID":"","Subject":"Re: [PATCH 7/7] i2c: gpio: Add support for named gpios in DT","To":"Geert Uytterhoeven ","Cc":"Wolfram Sang , Linux I2C ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tLinux MIPS Mailing List ,\n\t\"adi-buildroot-devel@lists.sourceforge.net\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]