[{"id":1784164,"web_url":"http://patchwork.ozlabs.org/comment/1784164/","msgid":"<20171010233347.5907a289@windsurf.lan>","list_archive_url":null,"date":"2017-10-10T21:33:47","subject":"Re: [Buildroot] [PATCH] support/run-tests: export download dir","submitter":{"id":2230,"url":"http://patchwork.ozlabs.org/api/people/2230/","name":"Thomas Petazzoni","email":"thomas.petazzoni@free-electrons.com"},"content":"Hello,\n\nOn Sun, 17 Sep 2017 11:20:28 +0200, Yann E. MORIN wrote:\n> Currently, the download directory, when specified with the -d option, is\n> only used to store the files downloaded by the testing infra, not those\n> downloaded by Buildroot.\n> \n> So, we end up with this situation:\n> \n> BR2_DL_DIR | -d DIR | test downloads | BR downloads\n> ------------+----------+------------------+--------------\n> unset | unset | [error] | [error]\n> unset | set | in $(DIR) | in $(TOP_DIR)/dl\n> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)\n> set | set | in $(DIR) | in $(BR2_DL_DIR)\n> \n> This is not very consistent.\n> \n> We change the behaviour so that the value of -d always takes precedence,\n> and is used by Buildroot as well, giving this new behaviour:\n> \n> BR2_DL_DIR | -d DIR | test downloads | BR downloads\n> ------------+----------+------------------+--------------\n> unset | unset | [error] | [error]\n> unset | set | in $(DIR) | in $(DIR)\n> set | unset | in $(BR2_DL_DIR) | in $(BR2_DL_DIR)\n> set | set | in $(DIR) | in $(DIR)\n> \n> Signed-off-by: \"Yann E. MORIN\" \n> Cc: Ricardo Martincoski \n> Cc: Thomas Petazzoni \n> ---\n> support/testing/run-tests | 1 +\n> 1 file changed, 1 insertion(+)\n\nIndeed, makes sense. Applied, thanks!\n\nThomas","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","buildroot@lists.busybox.net"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","buildroot@osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=busybox.net\n\t(client-ip=140.211.166.138; helo=whitealder.osuosl.org;\n\tenvelope-from=buildroot-bounces@busybox.net;\n\treceiver=)","Received":["from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBVjn2z0Bz9t6B\n\tfor ;\n\tWed, 11 Oct 2017 08:34:05 +1100 (AEDT)","from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 5F738890D6;\n\tTue, 10 Oct 2017 21:34:03 +0000 (UTC)","from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dA9cy+cxtNOC; Tue, 10 Oct 2017 21:34:02 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 16D8389099;\n\tTue, 10 Oct 2017 21:34:02 +0000 (UTC)","from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id AA0B71C0C51\n\tfor ;\n\tTue, 10 Oct 2017 21:34:00 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 98E262D116\n\tfor ;\n\tTue, 10 Oct 2017 21:34:00 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id NvfuHhyvNeiz for ;\n\tTue, 10 Oct 2017 21:33:59 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby silver.osuosl.org (Postfix) with ESMTP id 6E31623042\n\tfor ; Tue, 10 Oct 2017 21:33:59 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 13527208EC; Tue, 10 Oct 2017 23:33:57 +0200 (CEST)","from windsurf.lan (LFbn-1-15130-153.w86-206.abo.wanadoo.fr\n\t[86.206.236.153])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id DFA92208D3;\n\tTue, 10 Oct 2017 23:33:46 +0200 (CEST)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","Date":"Tue, 10 Oct 2017 23:33:47 +0200","From":"Thomas Petazzoni ","To":"\"Yann E. MORIN\" ","Message-ID":"<20171010233347.5907a289@windsurf.lan>","In-Reply-To":"<20170917092028.5236-1-yann.morin.1998@free.fr>","References":"<20170917092028.5236-1-yann.morin.1998@free.fr>","Organization":"Free Electrons","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Cc":"Ricardo Martincoski ,\n\tbuildroot@buildroot.org","Subject":"Re: [Buildroot] [PATCH] support/run-tests: export download dir","X-BeenThere":"buildroot@busybox.net","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@busybox.net","Sender":"\"buildroot\" "}}]