[{"id":1769819,"web_url":"http://patchwork.ozlabs.org/comment/1769819/","msgid":"","list_archive_url":null,"date":"2017-09-17T23:06:25","subject":"Re: [LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()","submitter":{"id":22753,"url":"http://patchwork.ozlabs.org/api/people/22753/","name":"Stijn Tintel","email":"stijn@linux-ipv6.be"},"content":"On 17-09-17 07:05, Maxim Gorbachyov wrote:\n> Because mktemp() is evil.\n>\nHi, please add a reference when making such claims.\n\nThanks,\nStijn","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"J2IluGyw\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linux-ipv6.be header.i=@linux-ipv6.be\n\theader.b=\"pDnYgPAL\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwPt709hpz9s7B\n\tfor ;\n\tMon, 18 Sep 2017 09:07:22 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtieT-0004gQ-4b; Sun, 17 Sep 2017 23:07:01 +0000","from mail.tintel.eu ([2001:41d0:8:1644:0:ff:fe5c:6a54])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtieO-0004Zd-5W\n\tfor lede-dev@lists.infradead.org; Sun, 17 Sep 2017 23:06:58 +0000","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 94819437CC72;\n\tMon, 18 Sep 2017 01:06:27 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10032)\n\twith ESMTP id 98LxmK3Z4Ybl; Mon, 18 Sep 2017 01:06:27 +0200 (CEST)","from localhost (localhost [IPv6:::1])\n\tby mail.tintel.eu (Postfix) with ESMTP id 175FD43679A9;\n\tMon, 18 Sep 2017 01:06:27 +0200 (CEST)","from mail.tintel.eu ([IPv6:::1])\n\tby localhost (mail.tintel.eu [IPv6:::1]) (amavisd-new, port 10026)\n\twith ESMTP id zfFfAcyYfnYL; Mon, 18 Sep 2017 01:06:27 +0200 (CEST)","from [IPv6:2001:67c:21bc:24::adb] (unknown\n\t[IPv6:2001:67c:21bc:24::adb]) (Authenticated sender: stijn@tintel.eu)\n\tby mail.tintel.eu (Postfix) with ESMTPSA id 46698437CC72;\n\tMon, 18 Sep 2017 01:06:26 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Reply-To:Cc:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Dv1J8jrqfvU8Y7HrNUImnXCOp+394hsV8/1AEEW/qAM=;\n\tb=J2IluGywXtn/ue\n\tHGPHPYeWVEI8fJX4sn6IbNSPBgUU+z5+8zNjJsMaTvvqyKBP4yO4RmpXgNuOjrj14ClcxxqUoEgXE\n\t/2jiw7r9Z1kogmN8eoeoM9pdp/XwXHsncSuHuuHR71CnF57tGYyRZJfM/RReO3UjxUFrBRcaX6+8a\n\tPFLJBALMm424y7n8yM6s6MnwtoPI4VOaWMWoumTlaHSBN9kgUkuboTiGJrUgeZZXe0FzVs4P6KGz0\n\tmneDQdEbIHF6/BRP+soiMNUzjGOP1PaIVdv2PreiyVnm5LN5Op2K9OhgWhrUiGTfVxM2w6rNWusny\n\tcYp58wg2rLJcQMNto4oA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-ipv6.be;\n\ts=502B7754-045F-11E5-BBC5-64595FD46BE8; t=1505689587;\n\tbh=1tTS2KCi4iy+whi4StxNqscDAsiXHPRC51K2Tcidmls=;\n\th=Subject:To:From:Message-ID:Date:MIME-Version:Content-Type:\n\tContent-Transfer-Encoding;\n\tb=pDnYgPAL/CxkgH4KGzgbrMDWFH6zc5xtZDWUlAGYyBRtNOFHyb880C8rKIf/AXCBA\n\tc28a3gKYeUzBPYvU4yE//BcmaPhim6++0BA5X1Ug/iTpl7BeE0edwnHEqUlJIkUyl7\n\txnenGb2ezdqVIdtfKMKAShjJj8+1KbCzXbVXlMl4="],"DKIM-Filter":"OpenDKIM Filter v2.9.2 mail.tintel.eu 175FD43679A9","X-Virus-Scanned":"amavisd-new at mail.tintel.eu","To":"Maxim Gorbachyov ,\n\tlede-dev@lists.infradead.org","References":"<20170917040532.3926-1-maxim.gorbachyov@gmail.com>","From":"Stijn Tintel ","Message-ID":"","Date":"Mon, 18 Sep 2017 02:06:25 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170917040532.3926-1-maxim.gorbachyov@gmail.com>","Content-Language":"en-GB","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170917_160656_532194_C54F26B6 ","X-CRM114-Status":"UNSURE ( 5.59 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.8 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid","Subject":"Re: [LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":1769821,"web_url":"http://patchwork.ozlabs.org/comment/1769821/","msgid":"","list_archive_url":null,"date":"2017-09-17T23:21:23","subject":"Re: [LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()","submitter":{"id":72380,"url":"http://patchwork.ozlabs.org/api/people/72380/","name":"Maxim Gorbachyov","email":"maxim.gorbachyov@gmail.com"},"content":"On Sun, Sep 17, 2017 at 4:06 PM, Stijn Tintel wrote:\n\n>> Because mktemp() is evil.\n> Hi, please add a reference when making such claims.\n\n\"Never use mktemp() ... every use of mktemp() is a security risk\"\nhttps://linux.die.net/man/3/mktemp\n\nI thought it's obvious.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"pDMbkD3E\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"jbPllD9N\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwQBz1QGrz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 09:22:03 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtisr-0000AO-Fs; Sun, 17 Sep 2017 23:21:53 +0000","from mail-it0-x230.google.com ([2607:f8b0:4001:c0b::230])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtisk-0008MN-EM\n\tfor lede-dev@lists.infradead.org; Sun, 17 Sep 2017 23:21:50 +0000","by mail-it0-x230.google.com with SMTP id r131so5005393itc.1\n\tfor ;\n\tSun, 17 Sep 2017 16:21:24 -0700 (PDT)","by 10.2.137.20 with HTTP; Sun, 17 Sep 2017 16:21:23 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Subject:To:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=TA7a8Q6np6qQhzrA+3iKrIgX1I7eyzPsE0oC8jeCjFk=;\n\tb=pDMbkD3E7sTCvT\n\tpu1SRWwP0C0KC5kmI70tZwBZySBG+GVaH2QfMQXAnMUgzR5n9LgVHSqtjCHerqXZVvrRKTAWk+zKw\n\tlifxXyT2XPVfck01+2VCN7WB5n8AgyJO4tG/FBHQzh6tOxCoUXSAo32Lvzyz2CMND2PEUUOZnGZgA\n\tqWf+9LGDhSeBx7QZ5VV4DGBYN4WVc7HrYkFmWofhImCNwGSyA6Xvcg2ow9+4n/fqmelzPvfOP5UTd\n\thzp5s2D0FmHp3DSK7CZQb1TvFF/M4XMgOaWZoWXn96xb8lKQz9zXCQE3BexHfA77p55gI08ZWIb3x\n\t2T/UkCoz2aOScUyEskqA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=x+vZsYrZnIS6Prm8q12uSg1rNHonyOzXfxBiFuUtSio=;\n\tb=jbPllD9NUF2VRND4KTbouYLz+enZ4i8sKoxQ7otfPzImU7DzgaooC1ZJnTAHOmyvcv\n\twVsohzB1wWbQ6KgB13gfrGbfwJY6ItaYyl6x1U27Nz9DbV+Dzs1naQCy6iVoSg9y9PHp\n\tt5laePkEiTdAWLpSt3Qg+DScugzvS9GQksYsmXzqcgm7N+9Mj+zjEiRxp4bPjRaZQhbz\n\tqZMJ7NyprzkxoT6f+LA+4hHYNZm/mXnC5da2pW095KJ/EkvJyIqPnRu08t4VqUDqsXFR\n\tuyEBlh9Zy+4PlYlQLtDptjdbB7eHd29duBv+1fPXmtoAyWfAp6oupjqbRhTKVgkE1lV9\n\tQsdQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=x+vZsYrZnIS6Prm8q12uSg1rNHonyOzXfxBiFuUtSio=;\n\tb=DNPL4bnvrCjwJwFXQFteE+hjiebdTl2MbviwVO4FxQTDwf90C68nxhMnCxHhoWFU0C\n\tiCWGDtDBtsDWgcQjVXr4Aat7BSdDq5MjbyOqr4ldsgVKQsnzE8qDk6E7ygQWOZIrplK/\n\tcjACPg0aBem/asPANAxu192r3xdr35wpkPGBYv9JwO8HMNHqbmGPVfS3OrxWCBM5VdFZ\n\tAUMw+Ot7P1+2hkF4jWWKnOJWmdaTge1ykLrPhW9Il4hZHqkwvSqDfnnlJ9D7OtEJX5f+\n\toQ/s6yx7LohIs3qtFQeQ6WMpkyRCykTRSWxxp03ohi+aQwdnPrCa06NQZJghfaU52gH5\n\tqgmQ==","X-Gm-Message-State":"AHPjjUiq7bPGYgyWffXa0RcEzANN/AslkV7PM2L89MHXux0IDq4p4yKx\n\tlbAfH7qkXWel0EI2rDPzGtkqyKSh/xvPpTu+pF23DKg9","X-Google-Smtp-Source":"AOwi7QC/yvwzGEw25SE+7rW1Z3c2s0A2rmMs5Qn2N4g7aBNpORvjZ2M+yVSWwkVGCOxB12g/i0yMmnvkaYLAnNtrrIg=","X-Received":"by 10.36.50.150 with SMTP id j144mr14112959ita.52.1505690484258; \n\tSun, 17 Sep 2017 16:21:24 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170917040532.3926-1-maxim.gorbachyov@gmail.com>\n\t","From":"Maxim Gorbachyov ","Date":"Sun, 17 Sep 2017 16:21:23 -0700","Message-ID":"","To":"Stijn Tintel ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170917_162146_563782_8E05BA3B ","X-CRM114-Status":"UNSURE ( 5.65 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c0b:0:0:0:230 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (maxim.gorbachyov[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"Re: [LEDE-DEV] [PATCH] uci/file: replace mktemp() with mkstemp()","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"lede-dev@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]