[{"id":1769964,"web_url":"http://patchwork.ozlabs.org/comment/1769964/","msgid":"<20170918081928.eex7njub6atasj6x@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:19:28","subject":"Re: [PATCH v2 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Sun, Sep 17, 2017 at 05:19:54AM +0200, Stefan Brüns wrote:\n> The A64 SoC has the same dma engine as the H3 (sun8i), with a\n> reduced amount of physical channels. To allow future reuse of the\n> compatible, leave the channel count etc. in the config data blank\n> and retrieve it from the devicetree.\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> drivers/dma/sun6i-dma.c | 23 +++++++++++++++++++++++\n> 1 file changed, 23 insertions(+)\n> \n> diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c\n> index b5ecc97a0d5a..118b29bb1eac 100644\n> --- a/drivers/dma/sun6i-dma.c\n> +++ b/drivers/dma/sun6i-dma.c\n> @@ -1127,6 +1127,28 @@ static struct sun6i_dma_config sun8i_h3_dma_cfg = {\n> \t\t\t BIT(DMA_SLAVE_BUSWIDTH_8_BYTES);\n> };\n> \n> +/*\n> + * The A64 binding uses the number of dma channels from the\n> + * device tree node.\n> + */\n> +static struct sun6i_dma_config sun50i_a64_dma_cfg = {\n> +\t.nr_max_channels = 0,\n> +\t.nr_max_requests = 0,\n> +\t.nr_max_vchans = 0,\n\nThose are the default values. I appreciate that you wanted them here\nfor documentation, but the comment above already fills up that role\nfine.\n\nOnce removed,\n\nAcked-by: Maxime Ripard \n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"pOk0/Cbk\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwf854GdSz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 18:20:21 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrHt-0005IA-W1; Mon, 18 Sep 2017 08:20:18 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrHo-00040a-QA for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:20:15 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid A0EE52083C; Mon, 18 Sep 2017 10:19:51 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 8A8B320A58;\n\tMon, 18 Sep 2017 10:19:28 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=fpWoyXoRHvejS5U0rxh81Nt3whDFxeXEbc/4eyhvtEI=;\n\tb=pOk0/Cbk7cw67VUGZ5+PcGF8N\n\tGhJ7vrXf+ireDlnz6DZIQR4IZv0Ew4jpw0HyA1Gm2PHSQeiT98SfqotGh8JCLVd3iVPECk58hYyKl\n\tBWRqhwiKg4GWJRdl3rGLaJv8tceeqFeNOmQFQYfgnapzQbiJ7FnFX6J5u/Ju+hIIWzq9QgXOvofmu\n\tbxn3zN10LXfDe23Te4vXF6e20mpP0T2pmjpUYsOUkBYlFIyKz1WH0MgC+m0jnFfTa2jVUlQTNzTac\n\tf+cfdr9QTmyRSPPrUiU7te5p5aLJ1lPRkSMH3OWMjyMlW/AB7Dq1uRND3JGTII/lUieKMhJFCCUIW\n\t4zM3GnMtg==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:19:28 +0200","From":"Maxime Ripard ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Subject":"Re: [PATCH v2 08/10] dmaengine: sun6i: Add support for Allwinner A64\n\tand compatibles","Message-ID":"<20170918081928.eex7njub6atasj6x@flea.lan>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-9-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","In-Reply-To":"<20170917031956.28010-9-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_012013_043103_CB29D517 ","X-CRM114-Status":"GOOD ( 17.45 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Vinod Koul ,\n\tAndre Przywara , linux-kernel@vger.kernel.org,\n\tCode Kipper , linux-sunxi@googlegroups.com,\n\tRob Herring , dmaengine@vger.kernel.org,\n\tChen-Yu Tsai , linux-arm-kernel@lists.infradead.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============1483678603603799376==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]