[{"id":1769959,"web_url":"http://patchwork.ozlabs.org/comment/1769959/","msgid":"<20170918081134.obpoaiwd7dgzdcak@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:11:34","subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:\n> The A64 is register compatible with the H3, but has a different number\n> of dma channels and request ports.\n> \n> Attach additional properties to the node to allow future reuse of the\n> compatible for controllers with different number of channels/requests.\n> \n> If dma-requests is not specified, the register layout defined maximum\n> of 32 is used.\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> index 98fbe1a5c6dd..6ebc79f95202 100644\n> --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> @@ -27,6 +27,32 @@ Example:\n> \t\t#dma-cells = <1>;\n> \t};\n> \n> +------------------------------------------------------------------------------\n> +For A64 DMA controller:\n> +\n> +Required properties:\n> +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> +- dma-channels: Number of DMA channels supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells\n> +\n> +Optional properties:\n> +- dma-requests: Number of DMA request signals supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n\nYou're error'ing out if dma-requests, so it isn't optional. I guess we\nshould just make it mandatory.\n\nOnce done,\nAcked-by: Maxime Ripard \n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwdzm2hJxz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 18:13:08 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752735AbdIRILi (ORCPT\n\t);\n\tMon, 18 Sep 2017 04:11:38 -0400","from mail.free-electrons.com ([62.4.15.54]:56062 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752125AbdIRILg (ORCPT\n\t); Mon, 18 Sep 2017 04:11:36 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 6085220A2E; Mon, 18 Sep 2017 10:11:34 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 33F0D2081F;\n\tMon, 18 Sep 2017 10:11:34 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:11:34 +0200","From":"Maxime Ripard ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Cc":"linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,\n\tdmaengine@vger.kernel.org, Vinod Koul ,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tChen-Yu Tsai , Rob Herring ,\n\tCode Kipper ,\n\tAndre Przywara ","Subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","Message-ID":"<20170918081134.obpoaiwd7dgzdcak@flea.lan>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"h4xpe5swv5okxfft\"","Content-Disposition":"inline","In-Reply-To":"<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770165,"web_url":"http://patchwork.ozlabs.org/comment/1770165/","msgid":"<13822703.glkPkggzn6@sbruens-linux>","list_archive_url":null,"date":"2017-09-18T13:38:50","subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","submitter":{"id":67055,"url":"http://patchwork.ozlabs.org/api/people/67055/","name":"Stefan Brüns","email":"stefan.bruens@rwth-aachen.de"},"content":"On Montag, 18. September 2017 10:11:34 CEST Maxime Ripard wrote:\n> On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:\n> > The A64 is register compatible with the H3, but has a different number\n> > of dma channels and request ports.\n> > \n> > Attach additional properties to the node to allow future reuse of the\n> > compatible for controllers with different number of channels/requests.\n> > \n> > If dma-requests is not specified, the register layout defined maximum\n> > of 32 is used.\n> > \n> > Signed-off-by: Stefan Brüns \n> > ---\n> > \n> > .../devicetree/bindings/dma/sun6i-dma.txt | 26\n> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index\n> > 98fbe1a5c6dd..6ebc79f95202 100644\n> > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > \n> > @@ -27,6 +27,32 @@ Example:\n> > \t\t#dma-cells = <1>;\n> > \t\n> > \t};\n> > \n> > +-------------------------------------------------------------------------\n> > ----- +For A64 DMA controller:\n> > +\n> > +Required properties:\n> > +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> > +- dma-channels: Number of DMA channels supported by the controller.\n> > +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> > +- all properties above, i.e. reg, interrupts, clocks, resets and\n> > #dma-cells +\n> > +Optional properties:\n> > +- dma-requests: Number of DMA request signals supported by the\n> > controller.\n> > +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> \n> You're error'ing out if dma-requests, so it isn't optional. I guess we\n> should just make it mandatory.\n\nNo, it defaults to DMA_CHAN_MAX_DRQ = 31, see patch 07/10.\n\nKind regards,\n\nStefan\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwnCh03rjz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 23:38:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1754901AbdIRNiy convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 18 Sep 2017 09:38:54 -0400","from mail-out-1.itc.rwth-aachen.de ([134.130.5.46]:37958 \"EHLO\n\tmail-out-1.itc.rwth-aachen.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1754807AbdIRNix (ORCPT\n\t); Mon, 18 Sep 2017 09:38:53 -0400","from rwthex-w2-a.rwth-ad.de ([134.130.26.158])\n\tby mail-in-1.itc.rwth-aachen.de with ESMTP; 18 Sep 2017 15:38:51 +0200","from rwthex-w1-a.rwth-ad.de (2002:8682:1a9c::8682:1a9c) by\n\trwthex-w2-a.rwth-ad.de (2002:8682:1a9e::8682:1a9e) with Microsoft\n\tSMTP Server\n\t(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n\t15.1.1034.26; Mon, 18 Sep 2017 15:38:50 +0200","from rwthex-w1-a.rwth-ad.de ([fe80::fd01:de75:d684:fb97]) by\n\trwthex-w1-a.rwth-ad.de ([fe80::fd01:de75:d684:fb97%21]) with mapi id\n\t15.01.1034.026; Mon, 18 Sep 2017 15:38:50 +0200"],"X-IronPort-AV":"E=Sophos;i=\"5.42,413,1500933600\"; d=\"scan'208\";a=\"13904858\"","From":"=?iso-8859-1?q?Br=FCns=2C_Stefan?= ","To":"Maxime Ripard ","CC":"\"linux-sunxi@googlegroups.com\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"dmaengine@vger.kernel.org\" ,\n\tVinod Koul ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tChen-Yu Tsai , Rob Herring ,\n\tCode Kipper ,\n\tAndre Przywara ","Subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","Thread-Topic":"[PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","Thread-Index":"AQHTMFah16CQC7zw5EGQNSbmYFTjQqK6hLcA","Date":"Mon, 18 Sep 2017 13:38:50 +0000","Message-ID":"<13822703.glkPkggzn6@sbruens-linux>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>\n\t<20170918081134.obpoaiwd7dgzdcak@flea.lan>","In-Reply-To":"<20170918081134.obpoaiwd7dgzdcak@flea.lan>","Accept-Language":"en-US, de-DE","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[78.35.13.203]","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-ID":"<29E16918749D36448517A33892830162@rwth-ad.de>","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772211,"web_url":"http://patchwork.ozlabs.org/comment/1772211/","msgid":"<20170920205300.io3ghr54kzk763kt@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:53:00","subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:\n> The A64 is register compatible with the H3, but has a different number\n> of dma channels and request ports.\n> \n> Attach additional properties to the node to allow future reuse of the\n> compatible for controllers with different number of channels/requests.\n> \n> If dma-requests is not specified, the register layout defined maximum\n> of 32 is used.\n> \n> Signed-off-by: Stefan Brüns \n> ---\n> .../devicetree/bindings/dma/sun6i-dma.txt | 26 ++++++++++++++++++++++\n> 1 file changed, 26 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> index 98fbe1a5c6dd..6ebc79f95202 100644\n> --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> @@ -27,6 +27,32 @@ Example:\n> \t\t#dma-cells = <1>;\n> \t};\n> \n> +------------------------------------------------------------------------------\n> +For A64 DMA controller:\n> +\n> +Required properties:\n> +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> +- dma-channels: Number of DMA channels supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> +- all properties above, i.e. reg, interrupts, clocks, resets and #dma-cells\n> +\n> +Optional properties:\n> +- dma-requests: Number of DMA request signals supported by the controller.\n> +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> +\n> +Example:\n> +\tdma: dma-controller@01c02000 {\n\nDrop the leading 0. Building dtbs with W=2 will tell you this.\n\nWith that,\n\nAcked-by: Rob Herring \n\n> +\t\tcompatible = \"allwinner,sun50i-a64-dma\";\n> +\t\treg = <0x01c02000 0x1000>;\n> +\t\tinterrupts = ;\n> +\t\tclocks = <&ccu CLK_BUS_DMA>;\n> +\t\tdma-channels = <8>;\n> +\t\tdma-requests = <27>;\n> +\t\tresets = <&ccu RST_BUS_DMA>;\n> +\t\t#dma-cells = <1>;\n> +\t};\n> +------------------------------------------------------------------------------\n> +\n> Clients:\n> \n> DMA clients connected to the A31 DMA controller must use the format\n> -- \n> 2.14.1\n> \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBnr0gKxz9s83\n\tfor ;\n\tThu, 21 Sep 2017 06:54:56 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751958AbdITUyx (ORCPT\n\t);\n\tWed, 20 Sep 2017 16:54:53 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:35202 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752169AbdITUxC (ORCPT\n\t); Wed, 20 Sep 2017 16:53:02 -0400","by mail-pf0-f193.google.com with SMTP id i23so1629705pfi.2;\n\tWed, 20 Sep 2017 13:53:02 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\tf9sm9329455pfe.150.2017.09.20.13.53.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:53:01 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=k6ToE6Bz6a9Am4twPuPJtHhB+0pr8lweSCa/wg338Gw=;\n\tb=dRpBKzP6B6iMmqL3lImyHK+4LkXxSYCkzgblOwmt2RCmTglwW1Vma3t6uKdOkC4Nb0\n\t8r/e2oeLnPCnNIq/Qlgw3LYRDDVkV2Jtq6XFQzxpH83kKV82p8uFVEn6iQlGUGeUoZBN\n\t8KFYO4m0srj0EuPHv8RpiFlGgg7VE0hai+xtLq4qm360vf2Zt0G9vZqkwhyiIQbcKegm\n\tL429SfXnFXjy9N6lANlEBjsnQv0lexqIi67uzb2JXkj7gMo5ZEaLtgsxPDhk5SRW7i5J\n\tg5ogJmOjNgT9TLe/8Boxr0M8oMPG/tgXG/0G0aAsOH/yEzTNX18GbaRVqlqnoyMhJOor\n\tSb3Q==","X-Gm-Message-State":"AHPjjUirjckYz0TWm1Kihq9+r7H2J6QCRt6nVr/8hg9PgZHgyB5jIvzh\n\tFRoTOzFH8tERI85leSXiTw==","X-Google-Smtp-Source":"AOwi7QACKgS9DbFFoKBKNKeQh4mL3n3ircURj796PaW2+j2RaUIzUMvYICfVYDIVfDGhd36MHFFQzA==","X-Received":"by 10.98.62.93 with SMTP id l90mr3469413pfa.32.1505940781982;\n\tWed, 20 Sep 2017 13:53:01 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:53:00 -0500","From":"Rob Herring ","To":"Stefan =?iso-8859-1?q?Br=FCns?= ","Cc":"linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,\n\tdmaengine@vger.kernel.org, Vinod Koul ,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Code Kipper ,\n\tAndre Przywara ","Subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","Message-ID":"<20170920205300.io3ghr54kzk763kt@rob-hp-laptop>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1774090,"web_url":"http://patchwork.ozlabs.org/comment/1774090/","msgid":"<1673036.ZUJy1pffid@pebbles.site>","list_archive_url":null,"date":"2017-09-23T23:34:58","subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","submitter":{"id":67055,"url":"http://patchwork.ozlabs.org/api/people/67055/","name":"Stefan Brüns","email":"stefan.bruens@rwth-aachen.de"},"content":"On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote:\n> On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:\n> > The A64 is register compatible with the H3, but has a different number\n> > of dma channels and request ports.\n> > \n> > Attach additional properties to the node to allow future reuse of the\n> > compatible for controllers with different number of channels/requests.\n> > \n> > If dma-requests is not specified, the register layout defined maximum\n> > of 32 is used.\n> > \n> > Signed-off-by: Stefan Brüns \n> > ---\n> > \n> > .../devicetree/bindings/dma/sun6i-dma.txt | 26\n> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)\n> > \n> > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index\n> > 98fbe1a5c6dd..6ebc79f95202 100644\n> > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n> > \n> > @@ -27,6 +27,32 @@ Example:\n> > \t\t#dma-cells = <1>;\n> > \t\n> > \t};\n> > \n> > +-------------------------------------------------------------------------\n> > ----- +For A64 DMA controller:\n> > +\n> > +Required properties:\n> > +- compatible:\t\"allwinner,sun50i-a64-dma\"\n> > +- dma-channels: Number of DMA channels supported by the controller.\n> > +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> > +- all properties above, i.e. reg, interrupts, clocks, resets and\n> > #dma-cells +\n> > +Optional properties:\n> > +- dma-requests: Number of DMA request signals supported by the\n> > controller.\n> > +\t\tRefer to Documentation/devicetree/bindings/dma/dma.txt\n> > +\n> > +Example:\n> > +\tdma: dma-controller@01c02000 {\n> \n> Drop the leading 0. Building dtbs with W=2 will tell you this.\n> \n> With that,\n> \n> Acked-by: Rob Herring \n\nThe leading 0 was copied from the A31 example just a few lines above. Should I \nalso correct that one, or should that go in a separate patch?\n\nKind regards,\n\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y06CD6s9Tz9t43\n\tfor ;\n\tSun, 24 Sep 2017 09:35:04 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751408AbdIWXfD convert rfc822-to-8bit (ORCPT\n\t);\n\tSat, 23 Sep 2017 19:35:03 -0400","from mail-out-1.itc.rwth-aachen.de ([134.130.5.46]:42350 \"EHLO\n\tmail-out-1.itc.rwth-aachen.de\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1750959AbdIWXfC (ORCPT\n\t); Sat, 23 Sep 2017 19:35:02 -0400","from rwthex-w2-a.rwth-ad.de ([134.130.26.158])\n\tby mail-in-1.itc.rwth-aachen.de with ESMTP; 24 Sep 2017 01:35:00 +0200","from pebbles.site (77.181.79.149) by rwthex-w2-a.rwth-ad.de\n\t(2002:8682:1a9e::8682:1a9e) with Microsoft SMTP Server\n\t(version=TLS1_2, \n\tcipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.26;\n\tSun, 24 Sep 2017 01:35:00 +0200"],"X-IronPort-AV":"E=Sophos;i=\"5.42,431,1500933600\"; d=\"scan'208\";a=\"14785323\"","From":"Stefan Bruens ","To":"Rob Herring ","CC":", ,\n\t, Vinod Koul ,\n\t, ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Code Kipper ,\n\tAndre Przywara ","Subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","Date":"Sun, 24 Sep 2017 01:34:58 +0200","Message-ID":"<1673036.ZUJy1pffid@pebbles.site>","In-Reply-To":"<20170920205300.io3ghr54kzk763kt@rob-hp-laptop>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>\n\t<20170920205300.io3ghr54kzk763kt@rob-hp-laptop>","MIME-Version":"1.0","Content-Transfer-Encoding":"8BIT","Content-Type":"text/plain; charset=\"iso-8859-1\"","X-Originating-IP":"[77.181.79.149]","X-ClientProxiedBy":"rwthex-s1-a.rwth-ad.de (2002:8682:1a98::8682:1a98) To\n\trwthex-w2-a.rwth-ad.de (2002:8682:1a9e::8682:1a9e)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1774402,"web_url":"http://patchwork.ozlabs.org/comment/1774402/","msgid":"","list_archive_url":null,"date":"2017-09-25T04:12:26","subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Sep 23, 2017 at 6:34 PM, Stefan Bruens\n wrote:\n> On Mittwoch, 20. September 2017 22:53:00 CEST Rob Herring wrote:\n>> On Sun, Sep 17, 2017 at 05:19:52AM +0200, Stefan Brüns wrote:\n>> > The A64 is register compatible with the H3, but has a different number\n>> > of dma channels and request ports.\n>> >\n>> > Attach additional properties to the node to allow future reuse of the\n>> > compatible for controllers with different number of channels/requests.\n>> >\n>> > If dma-requests is not specified, the register layout defined maximum\n>> > of 32 is used.\n>> >\n>> > Signed-off-by: Stefan Brüns \n>> > ---\n>> >\n>> > .../devicetree/bindings/dma/sun6i-dma.txt | 26\n>> > ++++++++++++++++++++++ 1 file changed, 26 insertions(+)\n>> >\n>> > diff --git a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n>> > b/Documentation/devicetree/bindings/dma/sun6i-dma.txt index\n>> > 98fbe1a5c6dd..6ebc79f95202 100644\n>> > --- a/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n>> > +++ b/Documentation/devicetree/bindings/dma/sun6i-dma.txt\n>> >\n>> > @@ -27,6 +27,32 @@ Example:\n>> > #dma-cells = <1>;\n>> >\n>> > };\n>> >\n>> > +-------------------------------------------------------------------------\n>> > ----- +For A64 DMA controller:\n>> > +\n>> > +Required properties:\n>> > +- compatible: \"allwinner,sun50i-a64-dma\"\n>> > +- dma-channels: Number of DMA channels supported by the controller.\n>> > + Refer to Documentation/devicetree/bindings/dma/dma.txt\n>> > +- all properties above, i.e. reg, interrupts, clocks, resets and\n>> > #dma-cells +\n>> > +Optional properties:\n>> > +- dma-requests: Number of DMA request signals supported by the\n>> > controller.\n>> > + Refer to Documentation/devicetree/bindings/dma/dma.txt\n>> > +\n>> > +Example:\n>> > + dma: dma-controller@01c02000 {\n>>\n>> Drop the leading 0. Building dtbs with W=2 will tell you this.\n>>\n>> With that,\n>>\n>> Acked-by: Rob Herring \n>\n> The leading 0 was copied from the A31 example just a few lines above. Should I\n> also correct that one, or should that go in a separate patch?\n\nA separate patch.\n\nRob\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=robh@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0rKG5HqGz9t30\n\tfor ;\n\tMon, 25 Sep 2017 14:12:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752428AbdIYEMt convert rfc822-to-8bit (ORCPT\n\t);\n\tMon, 25 Sep 2017 00:12:49 -0400","from mail.kernel.org ([198.145.29.99]:55310 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751836AbdIYEMs (ORCPT );\n\tMon, 25 Sep 2017 00:12:48 -0400","from mail-qt0-f175.google.com (mail-qt0-f175.google.com\n\t[209.85.216.175])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 25184218BA;\n\tMon, 25 Sep 2017 04:12:48 +0000 (UTC)","by mail-qt0-f175.google.com with SMTP id 47so5677797qts.10;\n\tSun, 24 Sep 2017 21:12:48 -0700 (PDT)","by 10.12.209.75 with HTTP; Sun, 24 Sep 2017 21:12:26 -0700 (PDT)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 25184218BA","X-Gm-Message-State":"AHPjjUj3fhiJOyDZgKYRz59felILw2W9neuv3rv2JUPFUtwEU/rxdi1j\n\tE2qYUXmctNvj0Kzi3YRvjFX4lDaWB3Hupjocww==","X-Google-Smtp-Source":"AOwi7QD9+KSngKDV/x/1tSsjdDbSbLHMEBxgoHZVvgNEULksMjFb4pTzkjGEZe769j+DbvtoEQGJXSz8M0g8y74bNFI=","X-Received":"by 10.200.42.251 with SMTP id c56mr9616299qta.152.1506312767341; \n\tSun, 24 Sep 2017 21:12:47 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1673036.ZUJy1pffid@pebbles.site>","References":"<20170917031956.28010-1-stefan.bruens@rwth-aachen.de>\n\t<20170917031956.28010-7-stefan.bruens@rwth-aachen.de>\n\t<20170920205300.io3ghr54kzk763kt@rob-hp-laptop>\n\t<1673036.ZUJy1pffid@pebbles.site>","From":"Rob Herring ","Date":"Sun, 24 Sep 2017 23:12:26 -0500","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v2 06/10] arm64: allwinner: a64: Add devicetree binding\n\tfor DMA controller","To":"Stefan Bruens ","Cc":"linux-sunxi ,\n\t\"devicetree@vger.kernel.org\" ,\n\tdmaengine@vger.kernel.org, Vinod Koul ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Code Kipper ,\n\tAndre Przywara ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8BIT","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]