[{"id":1774346,"web_url":"http://patchwork.ozlabs.org/comment/1774346/","msgid":"","list_archive_url":null,"date":"2017-09-25T02:15:39","subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 15 September 2017 at 23:10, Masahiro Yamada\n wrote:\n> U-Boot widely uses error() as a bit noisier variant of printf().\n>\n> This macro causes name conflict with the following line in\n> include/linux/compiler-gcc.h:\n>\n> # define __compiletime_error(message) __attribute__((error(message)))\n>\n> This prevents us from using __compiletime_error(), and makes it\n> difficult to fully sync BUILD_BUG macros with Linux. (Notice\n> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n>\n> Let's convert error() into now treewide-available pr_err().\n>\n> Done with the help of Coccinelle, excluing tools/ directory.\n>\n> The semantic patch I used is as follows:\n>\n> // \n> @@@@\n> -error\n> +pr_err\n> (...)\n> // \n>\n> Signed-off-by: Masahiro Yamada \n> ---\n>\n> Changes in v2: None\n>\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"WVM+rAs/\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"JAG0l1yd\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y0nss3Lg4z9s7M\n\tfor ;\n\tMon, 25 Sep 2017 12:22:25 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 31937C221AC; Mon, 25 Sep 2017 02:19:35 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 73E93C21C35;\n\tMon, 25 Sep 2017 02:19:33 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2EBC3C22190; Mon, 25 Sep 2017 02:16:08 +0000 (UTC)","from mail-qt0-f180.google.com (mail-qt0-f180.google.com\n\t[209.85.216.180])\n\tby lists.denx.de (Postfix) with ESMTPS id 2A0DCC2218A\n\tfor ; Mon, 25 Sep 2017 02:16:01 +0000 (UTC)","by mail-qt0-f180.google.com with SMTP id o13so5550594qtf.1\n\tfor ; Sun, 24 Sep 2017 19:16:01 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 24 Sep 2017 19:15:39 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=xOrl2bsIc/qvZcrc+bKD1KQQIfp4p5vHLUjWhWxWJEM=;\n\tb=WVM+rAs/CEGa2iY9nCRzR8emVCoKqko7HRNPxwvBOExl6IYl/iQSY4YBKHe8NHwqiL\n\tA/8WchUnRtFQv7uzw9nA3o9322CsutqyyGRt2fgR8wYf7zW+dT3WAQAGcnf58sNOpxPO\n\timqeHECOjNHV8c6qVsq6Ob3/fcJtUqf2+VsPI7gNsaZo15Ur8v3uGvN7hjTALGBB6m+C\n\tFdDDJ+agiFUqeVIim0b8rZXQWX5CIG2ZPjAB5sIgCYEjMIPKGAFC59NiO/KqRFwYEKmM\n\tLdxZzBH5BYROnU1B027MAGSa7bc66OLxls0l9cK77znQ7e/O1lXvlztNDeWOmD2SA6aS\n\tzhFQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=xOrl2bsIc/qvZcrc+bKD1KQQIfp4p5vHLUjWhWxWJEM=;\n\tb=JAG0l1ydeET6gz0juE6JXh3Idku+bq8cjfFBwMg2CmwR3HcapF5wnC/sJirlc3V8Xk\n\t+IKviSqXqQDvRhSZ+UYVoNaXYp5g+7pfaiKN/jeGAXi2i8Wovw+YxWw4C1F660XyW6hl\n\tQHgjLVaOlPDF4goszT0PzVLsS9WvSKEP4CcNY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=xOrl2bsIc/qvZcrc+bKD1KQQIfp4p5vHLUjWhWxWJEM=;\n\tb=VEi5arRaC4LN6VifJXLtBDqrEWzs4zhp6YYXjofoWAf9XVCA8oMGNyHpJ1uh5a+R74\n\tapxkXrGQcHu4hPwPC/Aek48YcN2VJaxJLFuZC253cZbw8iR0xy3hGICTJJ5+YTiDaPNX\n\tuZ9H8rbkr+u/Rkf8Zlz/Hmk+gka8D2jhxhjqFzeysRjd7d+aX73t4Nh6B19aIX1vvOTN\n\t0fcMOP6vCfwKtO5a5I5fgRrkfAm6ZnFDMvwREaw5UaR7ICSAhjLMZ7pMS+vmEYP4CXMh\n\tUQc1F4HfTy/JMQMBh9bN8iIfKqsGE/1OXkimvQu49FPEVZlm5c/8gsl05nLerHUi6kfQ\n\tw8PA==","X-Gm-Message-State":"AHPjjUjk4nOJkKhqDDYDE3LtbsIi1brETZmJ3IzFdID2wzmxFn4QlUZ7\n\tJ5fzFXyX/HwgrYe0VwKqx7WVhgdKk12HKcMS3y4W9zwI","X-Google-Smtp-Source":"AOwi7QD3bTTFXV6yPfhZiHDDwwZwUcm0bL0ADS3R68puqAMPMcchjl6ZQf+71z4R+Vx+fxbQbRM1BxdVcxlq5kIucYo=","X-Received":"by 10.200.63.154 with SMTP id d26mr9270247qtk.212.1506305759853; \n\tSun, 24 Sep 2017 19:15:59 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","References":"<1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","From":"Simon Glass ","Date":"Sun, 24 Sep 2017 22:15:39 -0400","X-Google-Sender-Auth":"4Cp_LEMHFm7sYv4pN53XavUUokc","Message-ID":"","To":"Masahiro Yamada ","Cc":"Marek Vasut , Stephen Warren ,\n\tJoe Hershberger ,\n\tRobert Baldyga , Scott Wood ,\n\tU-Boot Mailing List ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1776788,"web_url":"http://patchwork.ozlabs.org/comment/1776788/","msgid":"","list_archive_url":null,"date":"2017-09-28T06:11:05","subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"Hi Tom,\n\n2017-09-16 14:10 GMT+09:00 Masahiro Yamada :\n> U-Boot widely uses error() as a bit noisier variant of printf().\n>\n> This macro causes name conflict with the following line in\n> include/linux/compiler-gcc.h:\n>\n> # define __compiletime_error(message) __attribute__((error(message)))\n>\n> This prevents us from using __compiletime_error(), and makes it\n> difficult to fully sync BUILD_BUG macros with Linux. (Notice\n> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n>\n> Let's convert error() into now treewide-available pr_err().\n>\n> Done with the help of Coccinelle, excluing tools/ directory.\n>\n> The semantic patch I used is as follows:\n>\n> // \n> @@@@\n> -error\n> +pr_err\n> (...)\n> // \n>\n\n\nApparently, this is outdated already.\n\nDo you want me to update this?\nor will you run coccinelle by yourself?","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"eF82d5IY\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2kqc21jKz9t5C\n\tfor ;\n\tThu, 28 Sep 2017 16:12:10 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid A86FBC21D56; Thu, 28 Sep 2017 06:12:04 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id ABB93C21CB1;\n\tThu, 28 Sep 2017 06:12:01 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid D7B22C21CB1; Thu, 28 Sep 2017 06:12:00 +0000 (UTC)","from conssluserg-04.nifty.com (conssluserg-04.nifty.com\n\t[210.131.2.83]) by lists.denx.de (Postfix) with ESMTPS id C9490C21C39\n\tfor ; Thu, 28 Sep 2017 06:11:59 +0000 (UTC)","from mail-yw0-f176.google.com (mail-yw0-f176.google.com\n\t[209.85.161.176]) (authenticated)\n\tby conssluserg-04.nifty.com with ESMTP id v8S6Bk6D021351\n\tfor ; Thu, 28 Sep 2017 15:11:46 +0900","by mail-yw0-f176.google.com with SMTP id i6so307344ywc.9\n\tfor ; Wed, 27 Sep 2017 23:11:46 -0700 (PDT)","by 10.37.170.198 with HTTP; Wed, 27 Sep 2017 23:11:05 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-04.nifty.com v8S6Bk6D021351","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506579107;\n\tbh=Uq4nMbdxYdxvtReYEAWuX2ak7NhSmVsvE0caduxBsKY=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=eF82d5IYXAJuJ026GfDY5e+xHxfd2RA+epZfVK5QTklKafTOp4zfhOB213akgagVy\n\tfjeSx9Uh+8dz30RAf2yiwxlpffVr9JH0XPl8CJ25LHnHCUpDehR+Mw7KcaKyUJTryf\n\tva6rgZUU4bB0LETUx2A1qnPGI/2B9IZIU1JKUY1ss+q5FrHmnEvondjfHeYGDgywMB\n\tUJh2rxbdC+WvQepF66wHh+ykM2XjOWkgk9cx/h0KPvUanROIVP8HaVToaGPGUa4lLR\n\tCte0YjTdhGqxAeYk/zXuzZevTLdb2RX4ggprywxIqI/3JiaF+GlctqFpLWen0lxZ1P\n\tkFOV768wRf0ug==","X-Nifty-SrcIP":"[209.85.161.176]","X-Gm-Message-State":"AHPjjUjq40kiih3ySSGygFQhZ2TVhFez1arpODk+xp3AVHNjWM0dzu+N\n\t0U5076pR8hkQaUHLm7MGKkT/3koBDXh5J5tCldY=","X-Google-Smtp-Source":"AOwi7QCleHXxrGqHNX6NtBoFU/HBID2kVNb7/l4MygdeycwGz1l6uMJ/s6gJ3NYynJdoy9DS93FcnXZzKTBsl100b9A=","X-Received":"by 10.13.248.3 with SMTP id i3mr2590141ywf.337.1506579105624;\n\tWed, 27 Sep 2017 23:11:45 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","References":"<1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","From":"Masahiro Yamada ","Date":"Thu, 28 Sep 2017 15:11:05 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"U-Boot Mailing List , Tom Rini ","Cc":"Marek Vasut , Stephen Warren ,\n\tRobert Baldyga , Scott Wood ,\n\tJoe Hershberger ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777006,"web_url":"http://patchwork.ozlabs.org/comment/1777006/","msgid":"<20170928124307.GJ3112@bill-the-cat>","list_archive_url":null,"date":"2017-09-28T12:43:07","subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote:\n> Hi Tom,\n> \n> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada :\n> > U-Boot widely uses error() as a bit noisier variant of printf().\n> >\n> > This macro causes name conflict with the following line in\n> > include/linux/compiler-gcc.h:\n> >\n> > # define __compiletime_error(message) __attribute__((error(message)))\n> >\n> > This prevents us from using __compiletime_error(), and makes it\n> > difficult to fully sync BUILD_BUG macros with Linux. (Notice\n> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n> >\n> > Let's convert error() into now treewide-available pr_err().\n> >\n> > Done with the help of Coccinelle, excluing tools/ directory.\n> >\n> > The semantic patch I used is as follows:\n> >\n> > // \n> > @@@@\n> > -error\n> > +pr_err\n> > (...)\n> > // \n> \n> \n> Apparently, this is outdated already.\n> \n> Do you want me to update this?\n> or will you run coccinelle by yourself?\n\nWell, that was my first time running coccinelle, and it was rather\npainless. So yes, I'm happy to re-generate any coccinelle generated\npatches so long as the smpl is included in the commit message. Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"f+l5b0m/\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2vVq74TLz9tXj\n\tfor ;\n\tThu, 28 Sep 2017 22:43:15 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B149BC21E16; Thu, 28 Sep 2017 12:43:11 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id BF6B2C21D84;\n\tThu, 28 Sep 2017 12:43:08 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 38C41C21D84; Thu, 28 Sep 2017 12:43:07 +0000 (UTC)","from mail-yw0-f182.google.com (mail-yw0-f182.google.com\n\t[209.85.161.182])\n\tby lists.denx.de (Postfix) with ESMTPS id A72C7C21D09\n\tfor ; Thu, 28 Sep 2017 12:43:06 +0000 (UTC)","by mail-yw0-f182.google.com with SMTP id u205so883448ywa.5\n\tfor ; Thu, 28 Sep 2017 05:43:06 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:706c:f3a8:eab4:3cc8])\n\tby smtp.gmail.com with ESMTPSA id\n\tv124sm518299ywb.68.2017.09.28.05.43.04\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 28 Sep 2017 05:43:04 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=EJu+ZT8Hr1Bs21OSI8dz0xoyvVo4uZdzXAaNmmZdgco=;\n\tb=f+l5b0m/mLqnOyyUe74ye3sWZReXp5Ygna3IuSwE2wwlrgIwWi7f7sZFiKHFqkVTok\n\tFpBrqqVa9zKtf9wMRu2VwEXq0GxhYJmBM3h4Gqoo6f82R/LQ6wE7xKOBi/ViyLstDo3D\n\tahauamZyxQpj1CeavObjPPF8LerM6b4HGbCxs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=EJu+ZT8Hr1Bs21OSI8dz0xoyvVo4uZdzXAaNmmZdgco=;\n\tb=Wuq317+zNyHHcPaHmKEpOIDGDDnP8iOnbXK8cz3wW3ynXsXrZc7a8EjypkdEjfnhBK\n\t22xlnG1HwP8U/lbtj/ksNrqe5BfKUWhHn5WSTYQAUJmhBVRTMF8M50LAB19ttQQQY5Sm\n\tUAhSxSOtt6MLu/+blJnXOB3JWyx3s488VdCHVnJMBR1g7HEUNU3L2dCbaoApAKO0SbU2\n\tThw2p79wdaV0P6qjr/KRcIZU9euVqW7hYzJIW5E/T4CG7qRWYC72kdGYkN7xjhFQCGdf\n\tudHtpui3cbBJEMf00et+3mUPq+fUc8VwfeDII56N5DIDFtSEWcDdMdyOwSi1nf61FhuU\n\tIWjA==","X-Gm-Message-State":"AHPjjUgqaP9cQNgXtqdbUooCBuB8CQRJ8Y7Okjy5Mdz6FAYnslcvYlge\n\t0pZEzklIhW0Ith4Cq5juxg30IQEr9Fo=","X-Google-Smtp-Source":"AOwi7QD8PAf7+XCIGIQLYxhcUh2Y0r0XLIc2zjH2hmrIuI5qnywOBMc11rz2aOHBCBimkgMJV3iZPA==","X-Received":"by 10.129.52.68 with SMTP id b65mr3280452ywa.342.1506602585319; \n\tThu, 28 Sep 2017 05:43:05 -0700 (PDT)","Date":"Thu, 28 Sep 2017 08:43:07 -0400","From":"Tom Rini ","To":"Masahiro Yamada ","Message-ID":"<20170928124307.GJ3112@bill-the-cat>","References":"<1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Marek Vasut , Stephen Warren ,\n\tJoe Hershberger ,\n\tRobert Baldyga , Scott Wood ,\n\tU-Boot Mailing List ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2610764754863856257==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777011,"web_url":"http://patchwork.ozlabs.org/comment/1777011/","msgid":"","list_archive_url":null,"date":"2017-09-28T12:56:29","subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"Hi Tom,\n\n\n2017-09-28 21:43 GMT+09:00 Tom Rini :\n> On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote:\n>> Hi Tom,\n>>\n>> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada :\n>> > U-Boot widely uses error() as a bit noisier variant of printf().\n>> >\n>> > This macro causes name conflict with the following line in\n>> > include/linux/compiler-gcc.h:\n>> >\n>> > # define __compiletime_error(message) __attribute__((error(message)))\n>> >\n>> > This prevents us from using __compiletime_error(), and makes it\n>> > difficult to fully sync BUILD_BUG macros with Linux. (Notice\n>> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n>> >\n>> > Let's convert error() into now treewide-available pr_err().\n>> >\n>> > Done with the help of Coccinelle, excluing tools/ directory.\n>> >\n>> > The semantic patch I used is as follows:\n>> >\n>> > // \n>> > @@@@\n>> > -error\n>> > +pr_err\n>> > (...)\n>> > // \n>>\n>>\n>> Apparently, this is outdated already.\n>>\n>> Do you want me to update this?\n>> or will you run coccinelle by yourself?\n>\n> Well, that was my first time running coccinelle, and it was rather\n> painless. So yes, I'm happy to re-generate any coccinelle generated\n> patches so long as the smpl is included in the commit message. Thanks!\n>\n\n\nOK, I will not resend this series.\nThis one is quite big, and would go to the moderator.\n\n\nOne more request, if you will remember, would you fix my typo in the subject?\n\n\"replace with error() with pr_error()\"\n\nI noticed the first \"with\" was unneeded.\n\n\n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"rK7+e16+\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2vqH5vGPz9t66\n\tfor ;\n\tThu, 28 Sep 2017 22:57:30 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C5D60C21DE7; Thu, 28 Sep 2017 12:57:23 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 99449C21D84;\n\tThu, 28 Sep 2017 12:57:21 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7BB3BC21D84; Thu, 28 Sep 2017 12:57:20 +0000 (UTC)","from conssluserg-05.nifty.com (conssluserg-05.nifty.com\n\t[210.131.2.90]) by lists.denx.de (Postfix) with ESMTPS id 788A5C21D09\n\tfor ; Thu, 28 Sep 2017 12:57:19 +0000 (UTC)","from mail-yw0-f172.google.com (mail-yw0-f172.google.com\n\t[209.85.161.172]) (authenticated)\n\tby conssluserg-05.nifty.com with ESMTP id v8SCvAsD018572\n\tfor ; Thu, 28 Sep 2017 21:57:11 +0900","by mail-yw0-f172.google.com with SMTP id w22so901965ywa.13\n\tfor ; Thu, 28 Sep 2017 05:57:10 -0700 (PDT)","by 10.37.170.198 with HTTP; Thu, 28 Sep 2017 05:56:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=T_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v8SCvAsD018572","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1506603431;\n\tbh=j3ZgcgTVtoN6Y5EaN4FbjFnTlmw9346IFz/jWVRlpbk=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=rK7+e16+TCdaBBSdpU8CJiB48hXVSXpmQLzSPbnwi0jQRmfjXd4YvE4/u8LGOQiES\n\tjLeyfY2wbpMpaJOwEakaBc9b1h6K1HFsZtAuhLUFvH7jQBdIucKjvZ/oB00mt0tXVO\n\ti70UoUgQ/EJ4fe/qWs/jOqaG/BivDBd8UfwOXjCHDjwz5bB03HFKgeB7xesP98Vm8k\n\tJVN7Y+urPc4Y+mBlKMk6r7ZJLpjWFufRXgfyB1KUvTu0Oc2qrx0qW6NLLRsFqsgcKV\n\tfuIkAkk71VoJ9Q48fhTvatT4lyAYKQFFbSKbUXpUFt0OGcczEST7sDhUwbRTVapjNo\n\tgepQyt+PUFlnQ==","X-Nifty-SrcIP":"[209.85.161.172]","X-Gm-Message-State":"AHPjjUgma2lfpkY0SsZncspjOrKhMWOHsMWwoegZViyb3YOkswNjQ1yL\n\tGWZHIa+lavovWCM9iaSemrJr3GbcW+QKI84AOEg=","X-Google-Smtp-Source":"AOwi7QB/UPs4OrH14E8MunFLjJkCIIEEH6TQ+M9VX8Y1ClRyB6h5F5CiA57Ra21/EXfshaZAgxv7MbhgP8v66L9DWII=","X-Received":"by 10.129.93.86 with SMTP id r83mr3295405ywb.182.1506603429731; \n\tThu, 28 Sep 2017 05:57:09 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170928124307.GJ3112@bill-the-cat>","References":"<1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>\n\t\n\t<20170928124307.GJ3112@bill-the-cat>","From":"Masahiro Yamada ","Date":"Thu, 28 Sep 2017 21:56:29 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","To":"Tom Rini ","Cc":"Marek Vasut , Stephen Warren ,\n\tU-Boot Mailing List ,\n\tRobert Baldyga , Scott Wood ,\n\tJoe Hershberger ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1777022,"web_url":"http://patchwork.ozlabs.org/comment/1777022/","msgid":"<20170928131114.GL3112@bill-the-cat>","list_archive_url":null,"date":"2017-09-28T13:11:14","subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Thu, Sep 28, 2017 at 09:56:29PM +0900, Masahiro Yamada wrote:\n> Hi Tom,\n> \n> \n> 2017-09-28 21:43 GMT+09:00 Tom Rini :\n> > On Thu, Sep 28, 2017 at 03:11:05PM +0900, Masahiro Yamada wrote:\n> >> Hi Tom,\n> >>\n> >> 2017-09-16 14:10 GMT+09:00 Masahiro Yamada :\n> >> > U-Boot widely uses error() as a bit noisier variant of printf().\n> >> >\n> >> > This macro causes name conflict with the following line in\n> >> > include/linux/compiler-gcc.h:\n> >> >\n> >> > # define __compiletime_error(message) __attribute__((error(message)))\n> >> >\n> >> > This prevents us from using __compiletime_error(), and makes it\n> >> > difficult to fully sync BUILD_BUG macros with Linux. (Notice\n> >> > Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n> >> >\n> >> > Let's convert error() into now treewide-available pr_err().\n> >> >\n> >> > Done with the help of Coccinelle, excluing tools/ directory.\n> >> >\n> >> > The semantic patch I used is as follows:\n> >> >\n> >> > // \n> >> > @@@@\n> >> > -error\n> >> > +pr_err\n> >> > (...)\n> >> > // \n> >>\n> >>\n> >> Apparently, this is outdated already.\n> >>\n> >> Do you want me to update this?\n> >> or will you run coccinelle by yourself?\n> >\n> > Well, that was my first time running coccinelle, and it was rather\n> > painless. So yes, I'm happy to re-generate any coccinelle generated\n> > patches so long as the smpl is included in the commit message. Thanks!\n> >\n> \n> \n> OK, I will not resend this series.\n> This one is quite big, and would go to the moderator.\n> \n> \n> One more request, if you will remember, would you fix my typo in the subject?\n> \n> \"replace with error() with pr_error()\"\n> \n> I noticed the first \"with\" was unneeded.\n\nOK, will do.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"LU5gPtBw\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2w7G3W9fz9t39\n\tfor ;\n\tThu, 28 Sep 2017 23:11:22 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 34959C21DDF; Thu, 28 Sep 2017 13:11:18 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id A19CEC21D7B;\n\tThu, 28 Sep 2017 13:11:15 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 4EFA3C21D7B; Thu, 28 Sep 2017 13:11:14 +0000 (UTC)","from mail-yw0-f177.google.com (mail-yw0-f177.google.com\n\t[209.85.161.177])\n\tby lists.denx.de (Postfix) with ESMTPS id 0F720C21D09\n\tfor ; Thu, 28 Sep 2017 13:11:13 +0000 (UTC)","by mail-yw0-f177.google.com with SMTP id w22so932488ywa.13\n\tfor ; Thu, 28 Sep 2017 06:11:13 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:706c:f3a8:eab4:3cc8])\n\tby smtp.gmail.com with ESMTPSA id\n\tr13sm550776ywg.2.2017.09.28.06.11.10\n\t(version=TLS1_2 cipher=AES128-SHA bits=128/128);\n\tThu, 28 Sep 2017 06:11:11 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=lO+XEIBP/iY2pKLSowbJ9x+h+3KoAvMd6TeAy1ze+JQ=;\n\tb=LU5gPtBwVtHAP0vmIToOme2X6dGf7hKj+GeG/RSEuJgR7AxIf1ggnhOlN48/NbzYfG\n\tgBWEjWv17FEtODWitbk7vo/d2FEaaY3KHnlrHEgzAnRcGgLJ+aRG5/4aNsKx8zPO8B4V\n\tsXAZqlD8iTbm6lB3huNHXHMwFjc7kBsYn9JRQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=lO+XEIBP/iY2pKLSowbJ9x+h+3KoAvMd6TeAy1ze+JQ=;\n\tb=AYIN/EAgicOQ/ycItKdxJSsQBCwg6aOb07rk8wIW6vYRn7Iyvtd/EBCluI9UHAlTpK\n\tfMoeDTv3FNIZuJbJs43v3FEQWU+Unx9LE2nK6vD3xbkDu4sBu70PVaYd4lQkPrOkbyag\n\t1j7HHzI50oW6kv37R0F/m7Z888L+ol/OY8KmJnYhhpwc3LBUp8PBPYd6roeHhlOAS8S4\n\tVgbF3cL8qTnVAZ+TNayeSA+aPMbySwDF/J9SmOYZcSTDjdSjyKw7JEIU60RB7fQZOmib\n\t4Kh6GB1ixT+wl/uyr4n0YIY21YGfSHi5ur3CjSJ1ZFLDmM7WCeFshs+9nCmwpaaOg9E7\n\t9KKw==","X-Gm-Message-State":"AHPjjUhxAD/yWBa0N0a+f4UFUoy6Ap/qVnTt4b8yD6VnaYlEPug8zb57\n\tEkIAjiuFytWGQifrhtiy4jZesQ==","X-Google-Smtp-Source":"AOwi7QAGvG6ryTAU/6SKMSFOZOaSO0ynrl4sooq2qxGevKTvcsrSjF4xAlQA6L5L15SfHsD52m4H7g==","X-Received":"by 10.37.212.215 with SMTP id m206mr3561881ybf.41.1506604271677; \n\tThu, 28 Sep 2017 06:11:11 -0700 (PDT)","Date":"Thu, 28 Sep 2017 09:11:14 -0400","From":"Tom Rini ","To":"Masahiro Yamada ","Message-ID":"<20170928131114.GL3112@bill-the-cat>","References":"<1505538646-19191-1-git-send-email-yamada.masahiro@socionext.com>\n\t<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>\n\t\n\t<20170928124307.GJ3112@bill-the-cat>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"Mutt/1.5.21 (2010-09-15)","Cc":"Marek Vasut , Stephen Warren ,\n\tU-Boot Mailing List ,\n\tRobert Baldyga , Scott Wood ,\n\tJoe Hershberger ,\n\tTom Warren , Jagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 3/8] treewide: replace with error() with\n\tpr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============0943226784101774930==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1781061,"web_url":"http://patchwork.ozlabs.org/comment/1781061/","msgid":"<20171005215208.GK25966@bill-the-cat>","list_archive_url":null,"date":"2017-10-05T21:52:08","subject":"Re: [U-Boot] [U-Boot, v2,\n\t3/8] treewide: replace with error() with pr_err()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Sat, Sep 16, 2017 at 02:10:41PM +0900, Masahiro Yamada wrote:\n\n> U-Boot widely uses error() as a bit noisier variant of printf().\n> \n> This macro causes name conflict with the following line in\n> include/linux/compiler-gcc.h:\n> \n> # define __compiletime_error(message) __attribute__((error(message)))\n> \n> This prevents us from using __compiletime_error(), and makes it\n> difficult to fully sync BUILD_BUG macros with Linux. (Notice\n> Linux's BUILD_BUG_ON_MSG is implemented by using compiletime_assert().)\n> \n> Let's convert error() into now treewide-available pr_err().\n> \n> Done with the help of Coccinelle, excluing tools/ directory.\n> \n> The semantic patch I used is as follows:\n> \n> // \n> @@@@\n> -error\n> +pr_err\n> (...)\n> // \n> \n> Signed-off-by: Masahiro Yamada \n> Reviewed-by: Simon Glass \n\nApplied to u-boot/master, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=konsulko.com header.i=@konsulko.com\n\theader.b=\"cF4AX0Bw\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y7RRp0Qp5z9t45\n\tfor ;\n\tFri, 6 Oct 2017 08:56:22 +1100 (AEDT)","by lists.denx.de (Postfix, from userid 105)\n\tid C8275C21E28; Thu, 5 Oct 2017 21:53:31 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 352BDC21E08;\n\tThu, 5 Oct 2017 21:52:45 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 236A4C21DD9; Thu, 5 Oct 2017 21:52:15 +0000 (UTC)","from mail-qt0-f181.google.com (mail-qt0-f181.google.com\n\t[209.85.216.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 10200C21C93\n\tfor ; Thu, 5 Oct 2017 21:52:12 +0000 (UTC)","by mail-qt0-f181.google.com with SMTP id z50so23140603qtj.4\n\tfor ; Thu, 05 Oct 2017 14:52:12 -0700 (PDT)","from bill-the-cat ([2606:a000:1401:811b:59d1:8451:efeb:a7b3])\n\tby smtp.gmail.com with ESMTPSA id\n\tg204sm125918ywb.7.2017.10.05.14.52.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 05 Oct 2017 14:52:10 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com;\n\ts=google; \n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=yetm8PrxEFvrsPPqcdtcZ6IfPLfMZrqbLvR+/p95Zfo=;\n\tb=cF4AX0BwrKguiT/FGJdc/Mr9Xxl7edkt27/eRfZJy389q3PDjP6Wgxw6AKkrBNSM+A\n\tJg64ELwAABD5KUpczGCclLCmXuV7PCJforq0aQI5C6QOhXXeOgsgcPoV/yy0qaVw6JCy\n\tpL2vDBNzynSkp80snYPRS8CDx75pz5RomuHm4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=yetm8PrxEFvrsPPqcdtcZ6IfPLfMZrqbLvR+/p95Zfo=;\n\tb=a2TvX18Ta1m+/e1ZvSxTa+JxP0p0hFtrcb1x1m/8RYJR1+dgHj/ct+iyfP1vH/XqRf\n\tQS5tnh0pFVB0QSYpCie8LWjW6DTyYzT2VxtCHeWohMCLa99c8EOnC/gWV1htzK4lJ16O\n\tW8DofkWdB70Ae0X8nJRTnfDcotLob5vroZkggkuV2TWq3ZIWDtZFaMPLSOxfWuKDxHKs\n\twmXEFkHAI5Bb6ciHYupog8iLe6jpGd+QnTlJDq7t/KZbZKPjXwAf6EqtqwbSXJxWF+CX\n\tmqZhxQi8M5TDAgr43aHu0jriaKVh8JoGO7Cuxfhv9f3K6qUFi3N71z/KiZTAXZXAhppn\n\tJ7bQ==","X-Gm-Message-State":"AMCzsaXjMNf8b/74vmhNKh7rEZ1b6yHrDRtLM4aXH6sj/3hWmylHcy7M\n\t8vzrW1YU+/PA1fuPoDz6EpSP+A==","X-Google-Smtp-Source":"AOwi7QCX8I2Nog6hsOAaWbSWXozdnWexjZaZ24WOesqhM/IW/fT2aoNu8Bpj4v5aBFIQJrZFcykN8A==","X-Received":"by 10.37.161.132 with SMTP id a4mr99672ybi.228.1507240330949;\n\tThu, 05 Oct 2017 14:52:10 -0700 (PDT)","Date":"Thu, 5 Oct 2017 17:52:08 -0400","From":"Tom Rini ","To":"Masahiro Yamada ","Message-ID":"<20171005215208.GK25966@bill-the-cat>","References":"<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","MIME-Version":"1.0","In-Reply-To":"<1505538646-19191-4-git-send-email-yamada.masahiro@socionext.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Cc":"Marek Vasut , Stephen Warren ,\n\tJoe Hershberger ,\n\tRobert Baldyga , Scott Wood ,\n\tu-boot@lists.denx.de, Tom Warren ,\n\tJagan Teki ","Subject":"Re: [U-Boot] [U-Boot, v2,\n\t3/8] treewide: replace with error() with pr_err()","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============4919283340785943099==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]