[{"id":1769847,"web_url":"http://patchwork.ozlabs.org/comment/1769847/","msgid":"<CAEUhbmV1RH1k0+=2if0my96i+GuqFDaQH=sCF7N3tj0eLEbwiw@mail.gmail.com>","list_archive_url":null,"date":"2017-09-18T03:45:55","subject":"Re: [U-Boot] [PATCH 07/13] log: Add a console driver","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass <sjg@chromium.org> wrote:\n> It is useful to display log messages on the console. Add a simple driver\n> to handle this.\n>\n> Signed-off-by: Simon Glass <sjg@chromium.org>\n> ---\n>\n>  common/Kconfig       | 20 ++++++++++++++++++++\n>  common/Makefile      |  1 +\n>  common/log_console.c | 23 +++++++++++++++++++++++\n>  3 files changed, 44 insertions(+)\n>  create mode 100644 common/log_console.c\n>\n\nReviewed-by: Bin Meng <bmeng.cn@gmail.com>\n\nBut isn't it possible to get this stuff into the serial-uclass driver?\n\nRegards,\nBin","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"iN9IluC8\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwX3d56Rmz9rxj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 13:46:05 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 741D1C21EFC; Mon, 18 Sep 2017 03:46:01 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 9AD1CC21D80;\n\tMon, 18 Sep 2017 03:45:58 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 86E08C21D80; Mon, 18 Sep 2017 03:45:57 +0000 (UTC)","from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby lists.denx.de (Postfix) with ESMTPS id 60140C21D57\n\tfor <u-boot@lists.denx.de>; Mon, 18 Sep 2017 03:45:56 +0000 (UTC)","by mail-wm0-f66.google.com with SMTP id m127so2113497wmm.0\n\tfor <u-boot@lists.denx.de>; Sun, 17 Sep 2017 20:45:56 -0700 (PDT)","by 10.223.145.3 with HTTP; Sun, 17 Sep 2017 20:45:55 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID\n\tautolearn=unavailable autolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=5S1fmuZ5Eoe3IgnrzY9bWzmvkmUB4/HT7Y2qFR6tgMM=;\n\tb=iN9IluC8FHO+T/CslvWJBeYl6ZzwTi+iPS4QYRsMIloMnQnD46mNkAHNJUDE+yrEUc\n\tdedmqsCp7n9tp11RJi3PA7q6BtG1iWVoaK9v/J6/POAGsm1XVngQOtZmLMsvJEfdPvsy\n\tXUwpEaQDSnbGFYvmn0bgt9yfYpvGQ4TVBn3N5xlD+5lMmkaSEUqMSQn5HajBV9eFWu+B\n\tLpgsGbpHm4cNOGB+NQxpt7l8MSzvqF2vKigfJVCDDIpOJ7qnMqOnx8OT0eSuJlYMUSvP\n\tAiA5n5+aFzhVaC2yltalDTRqjyC22Szap9y5qDRjrz+Nn/MZ6kALXcRf+0ZFcc2th0b4\n\tH5og==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=5S1fmuZ5Eoe3IgnrzY9bWzmvkmUB4/HT7Y2qFR6tgMM=;\n\tb=OUcMQ3zLiR+86eJ3/c4JBOaofy2H++RqRHjvPjPynmACevX7rg61Z4N9nEaQp1VYN+\n\tXQdzLRktmamSsDDuvnoaNnKHXc9oVdrdQ8vkLIkjWPIUqW+FW5ZtKS3lZ28PxKT1iPLL\n\tb4l6Ap9d2yLBdtFN+mClDUrfU50qqH6L6IgOJcpCVtHpGLwCnsGpw+5za/TAzReNxYPw\n\t0BD2YGa0+F+FVw57K7Pc45ZBT7oXubksojJaTph8WZXuVmBGPOsXWaJ69tZsbnOZkr11\n\t0mTwmK1C+YCHYbEKLC9bU5dH0MhvNV9RqR0hvJxR4EW1WTWoKk8ZsJwAWC5OnDiSLh3h\n\tgt4A==","X-Gm-Message-State":"AHPjjUiPrOTSVSFIxu4YRT/6mOJ6vNVV7ycmjdjlPyfSXoL1Hu5qRZ7F\n\tbSf6TgHe8FrXi/kdWWkVsIFm7MVtBq7V64l3aS0=","X-Google-Smtp-Source":"AOwi7QD6Tq76eIapeu9qQPIyZrxh9VyGvJY/KlbLkvHLCPDz4zo7dcFuvkaOfBvWyK8s8QozXt0K9g17fZ2am2YXrtE=","X-Received":"by 10.28.63.145 with SMTP id m139mr8570476wma.5.1505706356138;\n\tSun, 17 Sep 2017 20:45:56 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916212331.170463-8-sjg@chromium.org>","References":"<20170916212331.170463-1-sjg@chromium.org>\n\t<20170916212331.170463-8-sjg@chromium.org>","From":"Bin Meng <bmeng.cn@gmail.com>","Date":"Mon, 18 Sep 2017 11:45:55 +0800","Message-ID":"<CAEUhbmV1RH1k0+=2if0my96i+GuqFDaQH=sCF7N3tj0eLEbwiw@mail.gmail.com>","To":"Simon Glass <sjg@chromium.org>","Cc":"Tom Rini <trini@konsulko.com>, U-Boot Mailing List <u-boot@lists.denx.de>,\n\tAndy Yan <andy.yan@rock-chips.com>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tJagan Teki <jagan@openedev.com>, Franklin <fcooper@ti.com>","Subject":"Re: [U-Boot] [PATCH 07/13] log: Add a console driver","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}},{"id":1775789,"web_url":"http://patchwork.ozlabs.org/comment/1775789/","msgid":"<CAPnjgZ1Gf9zj61cx9u25mrwKLNpvoNDaat_H4+Gt+2bAfJ4_ig@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T19:10:16","subject":"Re: [U-Boot] [PATCH 07/13] log: Add a console driver","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Bin,\n\nOn 17 September 2017 at 23:45, Bin Meng <bmeng.cn@gmail.com> wrote:\n> On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass <sjg@chromium.org> wrote:\n>> It is useful to display log messages on the console. Add a simple driver\n>> to handle this.\n>>\n>> Signed-off-by: Simon Glass <sjg@chromium.org>\n>> ---\n>>\n>>  common/Kconfig       | 20 ++++++++++++++++++++\n>>  common/Makefile      |  1 +\n>>  common/log_console.c | 23 +++++++++++++++++++++++\n>>  3 files changed, 44 insertions(+)\n>>  create mode 100644 common/log_console.c\n>>\n>\n> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>\n>\n> But isn't it possible to get this stuff into the serial-uclass driver?\n\nIt could do but then it would not be the console. The console is\ncontrolled by stdout and might be set to output to an LCD, or perhaps\nboth LCD and serial.\n\nRegards,\nSimon","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"NGXUWQJe\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"nd0J2Dbm\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1rBy5JYdz9t5c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 05:10:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 1018AC21E08; Tue, 26 Sep 2017 19:10:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id CD0D2C21DC4;\n\tTue, 26 Sep 2017 19:10:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 2B552C21DC4; Tue, 26 Sep 2017 19:10:39 +0000 (UTC)","from mail-qk0-f181.google.com (mail-qk0-f181.google.com\n\t[209.85.220.181])\n\tby lists.denx.de (Postfix) with ESMTPS id 95913C21C46\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 19:10:38 +0000 (UTC)","by mail-qk0-f181.google.com with SMTP id j5so11111865qkd.0\n\tfor <u-boot@lists.denx.de>; Tue, 26 Sep 2017 12:10:38 -0700 (PDT)","by 10.200.37.200 with HTTP; Tue, 26 Sep 2017 12:10:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=bfIGxP5Gc4+zp7LT9DqhceEov2XD8Scy9nBIb3H2v+k=;\n\tb=NGXUWQJesOuiy7lrhpoexe2bUhV263pMgO88UtZykTWeGIZz91HhFbq0FAblYKD7nq\n\trKohK2KM3pvRPLMFZycwNjYdVOfUVVgE60IR46At3adnsAzeXlI7cLZp0FU6m1xHuhj3\n\t9R/x2Pdp2DvN44SNsuIS6fSuOYZ653r7CerZ1OyyvlTDC5MbRUpgaZqvrv6TCJDoCzNF\n\tSmWo5wY2tYdZnwNamq295FoKTA1dyVns8iRMrcDKrQ6SK6vjaWJZ29L/4khz7pURvodL\n\t+bLzV3XlfvM+nuGKUgtqlSKsa3OakrAV0SmRrnHp5TXD07LNazWTqZtU0tFhPeyqdwRB\n\tz4XA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=bfIGxP5Gc4+zp7LT9DqhceEov2XD8Scy9nBIb3H2v+k=;\n\tb=nd0J2DbmHg6kiW52t9Xsxjodfck68KRsuQFgPJvNwIfZxE7TH2XrrYvMzNcnZF6OZ5\n\txUo9jLzeqYJ1etlkDRWXi5zT27LBdmJN0bKFNwfGMHvsI3QsfeAe3Mn29hyrVlYqFolu\n\tKFgd/Ct1wDxqSFcyiJkDSnrnB6CxRQppMw80U="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=bfIGxP5Gc4+zp7LT9DqhceEov2XD8Scy9nBIb3H2v+k=;\n\tb=exkjT20yUfIqudYtofvZm8KS0fOssWJvtqWlbOYuxkY8OLr8pOZS9b7/zhODnLrOR7\n\tLRi4fM595JzTjA/+mF4VioMqDwiT0b+xAn0vnGW+uAfQ8hGXSiJ9EiUlHW+n0g2RsLku\n\tD1PbCEIOVF6XPNWAgPUTPtFYh6XhcnjT3UM30eLjZRinjBOouG7ot6dQonBiYcrxgL1W\n\tuxJHLfTF5VnW5TATd/8yz9E2t3/FOsCj+n23u8ZtqxRPhPC/xdAfNaroRk4GmHGReITM\n\tLcFjGd4ktl+Pte4TCMhho+Z/nen8LuYEpvTe3Ma0UAKNKgso5l17OTQd+7ef7sWmB9wY\n\t5cRw==","X-Gm-Message-State":"AHPjjUiCtCxGqDuX5s8P5qzC84aPCRFmw8HAc0mOfDTdKJm0Z12PzMiM\n\tuTcrflNf8yuXaKIPh5KoIau/8n+JjPXVX0R/vOaKKA==","X-Google-Smtp-Source":"AOwi7QCx2PIvoBB1WjAKYWddks0mzrcl15msPoB2NVLb1ZIeridMDnvQzevmKfLPokfLLVvZg6kabChus3eoMVxpEvc=","X-Received":"by 10.55.122.130 with SMTP id\n\tv124mr16868330qkc.209.1506453036983; \n\tTue, 26 Sep 2017 12:10:36 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<CAEUhbmV1RH1k0+=2if0my96i+GuqFDaQH=sCF7N3tj0eLEbwiw@mail.gmail.com>","References":"<20170916212331.170463-1-sjg@chromium.org>\n\t<20170916212331.170463-8-sjg@chromium.org>\n\t<CAEUhbmV1RH1k0+=2if0my96i+GuqFDaQH=sCF7N3tj0eLEbwiw@mail.gmail.com>","From":"Simon Glass <sjg@chromium.org>","Date":"Tue, 26 Sep 2017 13:10:16 -0600","X-Google-Sender-Auth":"e85H-rrqCmSlYUD5mUFX5BOPmxU","Message-ID":"<CAPnjgZ1Gf9zj61cx9u25mrwKLNpvoNDaat_H4+Gt+2bAfJ4_ig@mail.gmail.com>","To":"Bin Meng <bmeng.cn@gmail.com>","Cc":"Tom Rini <trini@konsulko.com>, U-Boot Mailing List <u-boot@lists.denx.de>,\n\tAndy Yan <andy.yan@rock-chips.com>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tJagan Teki <jagan@openedev.com>, Franklin <fcooper@ti.com>","Subject":"Re: [U-Boot] [PATCH 07/13] log: Add a console driver","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"}}]