[{"id":1769698,"web_url":"http://patchwork.ozlabs.org/comment/1769698/","msgid":"","list_archive_url":null,"date":"2017-09-17T12:48:38","subject":"Re: [U-Boot] [PATCH 01/13] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/people/64981/","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"content":"Hi Simon,\n\nOn Sun, Sep 17, 2017 at 5:23 AM, Simon Glass wrote:\n> While sandbox works OK without the special-case code, it does result in\n> console output being stored in the pre-console buffer while sandbox starts\n> up. If there is a crash or a problem then there is no indication of what\n> is going on.\n>\n\nI don't understand where the issue is. I built with current\nsandbox_defconfig w/ or w/o CONFIG_PRE_CONSOLE_BUFFER, both work fine.\n\n> For ease of debugging it seems better to revert this change.\n>\n> This reverts commit 47b98ad0f6779485d0f0c14f337c3eece273eb54.\n>\n> Signed-off-by: Simon Glass \n> ---\n>\n> arch/sandbox/cpu/os.c | 11 +++++++++++\n> include/os.h | 20 ++++++++++++++++++++\n> 2 files changed, 31 insertions(+)\n>\n\nRegards,\nBin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"P0e5oK9X\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw88H0J08z9s81\n\tfor ;\n\tSun, 17 Sep 2017 22:48:46 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 66040C21E10; Sun, 17 Sep 2017 12:48:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8E58CC21CB3;\n\tSun, 17 Sep 2017 12:48:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 7F2EFC21C62; Sun, 17 Sep 2017 12:48:39 +0000 (UTC)","from mail-wr0-f171.google.com (mail-wr0-f171.google.com\n\t[209.85.128.171])\n\tby lists.denx.de (Postfix) with ESMTPS id 37409C21D72\n\tfor ; Sun, 17 Sep 2017 12:48:39 +0000 (UTC)","by mail-wr0-f171.google.com with SMTP id o42so4414343wrb.3\n\tfor ; Sun, 17 Sep 2017 05:48:39 -0700 (PDT)","by 10.223.145.3 with HTTP; Sun, 17 Sep 2017 05:48:38 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=EU5BPlpDBjtSzVXRVKb6Dg4Hm0iZsn/V2+A6loDkyGA=;\n\tb=P0e5oK9XeA9aaMx2cOCHTO8eaOU+34ON0V2ZjgMuJbPwZE2+ta6KCtGFcKIp/O+9x9\n\tM/VLU7So2yRIkEa2UHMiTkRL/11dtThu1jNJYDNGeADbnnERePS3wb7w+AHtnHrDROTl\n\tPMdjbGEfKYOBLjFUhffxNr7reDnPiz3Zvesqkwa1jzskliL9ttSW13shpBZygx1JG+Sv\n\tjra8M9VdnHINg0On0oCsNQ9I+PEyJ2+MxLgRuKdrzOmOQ1kDnQ1hmUhxfiCvvO9lUpPF\n\tPrDOIxsrq64eBskjg+tVwxtdwmPu65tEpMRIXhuYvmqk2I0gvHx3VI9+/DW0I6E69F6f\n\t8klw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=EU5BPlpDBjtSzVXRVKb6Dg4Hm0iZsn/V2+A6loDkyGA=;\n\tb=BpLurnsLxnXkSVUZ8W7c3G286DDgigyVWTWUtkOw0jxwXRiTpP1n5R8YDSKVCc0AZy\n\tW4Am6UsHTCLJPw7cgVl5gQ/Lz4QnZxjGBFBJe6WJM/MCBvNb/TYMkEl0nYXs7oVbXPVc\n\tfWuxQewW6W0mqrR1wsLn8wd95j6ZkF8vQy3D4SfrWNtt7MhSSAssXGgWy+xnUPZ1Lomd\n\tPNvT9WTNW+cSk0bahN2Uluf/WGWevWlPzoayOw8swqMBBUJLilcox10Jpd6MGQAITIAA\n\t0iMNT8oj/LscoBjzbY5PbR38/uPa7qCIRAwfW8MGRywCsp2KLX8hnf0xuS1fRVR0gF70\n\teEvA==","X-Gm-Message-State":"AHPjjUgby+2SR4487xSrIA8cYddLl5jFWAmCwyViFdunAtvY+Scb10p6\n\tgKf60qXp65Eb2d2wHHlhAjsbhBBDzzKgJ6JjjqU=","X-Google-Smtp-Source":"ADKCNb6PPrIcU2EmSVK/zT2YOPAPBpKzwv3RsJHlZ31l4dmsBKUUzVJ9fB8Sf7Fns1XqwJt15nJfcHjiUlvAzZ1D36c=","X-Received":"by 10.223.166.196 with SMTP id\n\tt62mr25027933wrc.251.1505652518877; \n\tSun, 17 Sep 2017 05:48:38 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916212331.170463-2-sjg@chromium.org>","References":"<20170916212331.170463-1-sjg@chromium.org>\n\t<20170916212331.170463-2-sjg@chromium.org>","From":"Bin Meng ","Date":"Sun, 17 Sep 2017 20:48:38 +0800","Message-ID":"","To":"Simon Glass ","Cc":"U-Boot Mailing List , =?utf-8?q?Stefan_Br=C3=BCn?=\n\t=?utf-8?q?s?= ,\n\tTom Rini ","Subject":"Re: [U-Boot] [PATCH 01/13] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769805,"web_url":"http://patchwork.ozlabs.org/comment/1769805/","msgid":"","list_archive_url":null,"date":"2017-09-17T17:55:42","subject":"Re: [U-Boot] [PATCH 01/13] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Bin,\n\nOn 17 September 2017 at 06:48, Bin Meng wrote:\n> Hi Simon,\n>\n> On Sun, Sep 17, 2017 at 5:23 AM, Simon Glass wrote:\n>> While sandbox works OK without the special-case code, it does result in\n>> console output being stored in the pre-console buffer while sandbox starts\n>> up. If there is a crash or a problem then there is no indication of what\n>> is going on.\n>>\n>\n> I don't understand where the issue is. I built with current\n> sandbox_defconfig w/ or w/o CONFIG_PRE_CONSOLE_BUFFER, both work fine.\n>\n\nDid you try adding a crash before console_init_f()? The problem is\nthat any early problems in sandbox are not reported. It just crashes\nwith no output. With these two patches reverted you can see what is\ngoing on.\n\n>> For ease of debugging it seems better to revert this change.\n>>\n>> This reverts commit 47b98ad0f6779485d0f0c14f337c3eece273eb54.\n>>\n>> Signed-off-by: Simon Glass \n>> ---\n>>\n>> arch/sandbox/cpu/os.c | 11 +++++++++++\n>> include/os.h | 20 ++++++++++++++++++++\n>> 2 files changed, 31 insertions(+)\n>>\n\nREgards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"ccwR+yVk\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"EN33DuUa\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwNPF4RRyz9s4q\n\tfor ;\n\tMon, 18 Sep 2017 08:00:49 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 60265C21DDE; Sun, 17 Sep 2017 22:00:48 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id DF0C1C21F0E;\n\tSun, 17 Sep 2017 17:58:02 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 45698C21E65; Sun, 17 Sep 2017 17:58:00 +0000 (UTC)","from mail-qk0-f173.google.com (mail-qk0-f173.google.com\n\t[209.85.220.173])\n\tby lists.denx.de (Postfix) with ESMTPS id 43F21C21C4E\n\tfor ; Sun, 17 Sep 2017 17:56:04 +0000 (UTC)","by mail-qk0-f173.google.com with SMTP id b23so5602485qkg.1\n\tfor ; Sun, 17 Sep 2017 10:56:04 -0700 (PDT)","by 10.200.37.200 with HTTP; Sun, 17 Sep 2017 10:55:42 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=at/zs2r/Vlzu0z6Ih9fsd3nhtG1Ix8UobLxrdzdaAC0=;\n\tb=ccwR+yVkgIbsBrHu7FyNUrZ0NB3CNe+g8AAkZE30oDRczGDCuPQd5sLsuEMnMEt/w5\n\tGjXFbhGtWdIB+LQPjmXd8qGfMVGFetglf50kdDBR2FOMPTRHdUZ5nqcA/WEDwB/Z0wYj\n\texMAdMMMFedzcr2gZ1irgSATDvymeglBvCmZeCYrEprWjS3ZDyN8RJptX9a2xo/MrRNA\n\tsnW1y078KcW2uNIKXRpQl9TL+KSgGlVZlkxEOAGBWz7mf7a+9rSnIynICaZOpGrLSVwm\n\tpYuCyHwpUeOcapH0DgXgeCrtrec4SbohF47pyAOpW8mlzAPWO5FEBEAh3QSNVSdrJ/Tn\n\ttuNQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=at/zs2r/Vlzu0z6Ih9fsd3nhtG1Ix8UobLxrdzdaAC0=;\n\tb=EN33DuUa4t7VrJAHrdT5gEGnNeX+i3FDUe2zMu4lkb550rMWHAWOavEp9oxcPoA7L8\n\tDg7soRTY77YcEDY/SgtKuX8zABQDaA1cWxmYv+xpAvINEYxujdlHexCXCRoA+ZupGVtm\n\t/OJCFQa0AROJHdSK5wJdxHLLR4QDDYOiIlYeU="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=at/zs2r/Vlzu0z6Ih9fsd3nhtG1Ix8UobLxrdzdaAC0=;\n\tb=CuhEzsavjEJpo+Hj6cXxfM9QvXzP0Z6cfnKgq1pki+Fy8H81QxRjb0qY66ShtqEa7M\n\tdzkFARTQfBP0a99US+AoG1bSC9mi7/i4rN3JL0EvJQ2Kkq3qRTiGNSN7WDRDhoTzX2SP\n\tGCFvwHMQBNlanJhjXnPyH1rNXqj2YSF/bWeOVACloz2M4/D9Koibh/EfBLEmIOxoWhWR\n\tSMZLGRycXFboe9K7FhYqV6k6LRn23JYZJsJmWCCu00knWB5n8SRJ14YHqqzgQI7e10PV\n\tycDn25o5PXUuNP3vOWBYWoKDruUGbIJLVlRnvD7W2w2AxUp/Zk0pNiofnfgPQd1vGRog\n\tJPwA==","X-Gm-Message-State":"AHPjjUhfX/3U8xkIKJgMjrk5y/i8RhJwGRSVCxAkHa7Mm33bPElgEVJY\n\tLOdjC2KwVLvNBKYBlCtsRJwkYzO2jBL+PLboJW5TuQ==","X-Google-Smtp-Source":"AOwi7QCgqkpP+v4AGWfGMlbC0cYqfB6b69eyPOzxcT53cAJ3P0A1L/XmGYdwKHU7/AGbpZmWJzTq/FB2IBdPlhZG5Fg=","X-Received":"by 10.55.81.215 with SMTP id f206mr16829864qkb.188.1505670963001;\n\tSun, 17 Sep 2017 10:56:03 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<20170916212331.170463-1-sjg@chromium.org>\n\t<20170916212331.170463-2-sjg@chromium.org>\n\t","From":"Simon Glass ","Date":"Sun, 17 Sep 2017 11:55:42 -0600","X-Google-Sender-Auth":"SFkC7mbs5Z6VRyypL3PH2wm6Lqo","Message-ID":"","To":"Bin Meng ","Cc":"U-Boot Mailing List , =?utf-8?q?Stefan_Br=C3=BCn?=\n\t=?utf-8?q?s?= ,\n\tTom Rini ","Subject":"Re: [U-Boot] [PATCH 01/13] Revert \"sandbox: remove os_putc() and\n\tos_puts()\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]