[{"id":1770391,"web_url":"http://patchwork.ozlabs.org/comment/1770391/","msgid":"","list_archive_url":null,"date":"2017-09-18T18:18:23","subject":"Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init","submitter":{"id":65180,"url":"http://patchwork.ozlabs.org/api/people/65180/","name":"Santosh Shilimkar","email":"santosh.shilimkar@oracle.com"},"content":"On 9/16/2017 1:42 PM, Arnd Bergmann wrote:\n> The probe function calls omap_gpio_show_rev(), which on most\n> compilers is inlined, but on the old gcc-4.6 is not, causing\n> a valid warning about the incorrect __init annotation:\n> \n> WARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev()\n> The function omap_gpio_probe() references\n> the function __init omap_gpio_show_rev().\n> This is often because omap_gpio_probe lacks a __init\n> annotation or the annotation of omap_gpio_show_rev is wrong.\n> \n> This removes the __init.\n> \n> Signed-off-by: Arnd Bergmann \n> ---\nAcked-by: Santosh Shilimkar \n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwvPp5lgyz9s7m\n\tfor ;\n\tTue, 19 Sep 2017 04:18:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756570AbdIRSRv (ORCPT );\n\tMon, 18 Sep 2017 14:17:51 -0400","from userp1040.oracle.com ([156.151.31.81]:36383 \"EHLO\n\tuserp1040.oracle.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752757AbdIRSRu (ORCPT\n\t); Mon, 18 Sep 2017 14:17:50 -0400","from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2)\n\twith ESMTP id v8IIHhZk015839\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 18 Sep 2017 18:17:43 GMT","from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v8IIHgpp013900\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Mon, 18 Sep 2017 18:17:42 GMT","from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tv8IIHfZF030274; Mon, 18 Sep 2017 18:17:41 GMT","from [10.209.243.219] (/10.209.243.219)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 18 Sep 2017 11:17:41 -0700"],"Subject":"Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init","To":"Arnd Bergmann ,\n\tGrygorii Strashko ,\n\tSantosh Shilimkar ,\n\tKevin Hilman ,\n\tLinus Walleij ","Cc":"linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","References":"<20170916204234.725130-1-arnd@arndb.de>","From":"Santosh Shilimkar ","Organization":"Oracle Corporation","Message-ID":"","Date":"Mon, 18 Sep 2017 11:18:23 -0700","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170916204234.725130-1-arnd@arndb.de>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Source-IP":"aserv0021.oracle.com [141.146.126.233]","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}},{"id":1772743,"web_url":"http://patchwork.ozlabs.org/comment/1772743/","msgid":"","list_archive_url":null,"date":"2017-09-21T12:02:39","subject":"Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Sat, Sep 16, 2017 at 10:42 PM, Arnd Bergmann wrote:\n\n> The probe function calls omap_gpio_show_rev(), which on most\n> compilers is inlined, but on the old gcc-4.6 is not, causing\n> a valid warning about the incorrect __init annotation:\n>\n> WARNING: vmlinux.o(.text+0x40f614): Section mismatch in reference from the function omap_gpio_probe() to the function .init.text:omap_gpio_show_rev()\n> The function omap_gpio_probe() references\n> the function __init omap_gpio_show_rev().\n> This is often because omap_gpio_probe lacks a __init\n> annotation or the annotation of omap_gpio_show_rev is wrong.\n>\n> This removes the __init.\n>\n> Signed-off-by: Arnd Bergmann \n\nPatch applied for fixes.\n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-gpio-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"etTMQs3I\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyZxH1Fykz9s5L\n\tfor ;\n\tThu, 21 Sep 2017 22:02:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751550AbdIUMCl (ORCPT );\n\tThu, 21 Sep 2017 08:02:41 -0400","from mail-io0-f180.google.com ([209.85.223.180]:54270 \"EHLO\n\tmail-io0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751581AbdIUMCk (ORCPT\n\t); Thu, 21 Sep 2017 08:02:40 -0400","by mail-io0-f180.google.com with SMTP id q11so10174797ioe.10\n\tfor ;\n\tThu, 21 Sep 2017 05:02:40 -0700 (PDT)","by 10.79.164.78 with HTTP; Thu, 21 Sep 2017 05:02:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=ZsiFMSkSwc3PzTwDnXG03RHia9JXvD+b1QNU7SJU5nA=;\n\tb=etTMQs3IBfen7S8gFOo8N7wfu1QzxhbgFH6HFgKb/usZd/FECGxyZ/AjxYTY3v+vh2\n\tns+RiftQmaw7eu+aDNIY7u13pDKehFjcbal0E53UWn6jooAUuRXpyJZcH2Df+s8oUscW\n\tAkTMglXBQnwNumPbmveBO4vbS6NntCRWQxBME=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=ZsiFMSkSwc3PzTwDnXG03RHia9JXvD+b1QNU7SJU5nA=;\n\tb=HU9Mf3Zir4XXDtOSyqGBqDpm8UIHttAvo87725Dk30an4mxuSGjWhqR3NbTQEYWqBZ\n\tttjQGGMuM06xl4K1ch9b4FzQAhyoZDcWQ6NTIvkK0EiBMvb/eOaOz3Z9QFEFNl5FMeS0\n\thG0zw6nsSQ9ZOBTbSQ/wQPjnRxWE/ExRLfKxXd+6B7PW9Y5Z/oSxZZ/NzmcBITfPNI6R\n\tVvKq68n3pcRKrdDzOIR75gi1CnM2gfdb4Xh2H6wOu+wj9WxF1dTknarpRWdVRgxSXy9R\n\t8qbASDLbN9EL2vWoeK7Zzd12J50An3mJxdzDkT04fZH5v6lxu5JtwKxSslRbf5VC/oDU\n\t3tOw==","X-Gm-Message-State":"AHPjjUiq1CIYed8Kh80gNio1dYFO7ZeDLxdf8RkdClrgmyVDa0SMviP0\n\thbzajMXeaDGfmEg8YUa2tp028/nv5UBFKAx+XgZ0SA==","X-Google-Smtp-Source":"AOwi7QBFmGOkdUXBmBMxBRRL06XwoK7wzNE9H2GO94Qoni/OVmSz6pQ1sfrVxzzlGOROnuIBr9rYxxlZUFR85lFgHzo=","X-Received":"by 10.107.156.15 with SMTP id f15mr2149860ioe.226.1505995360068; \n\tThu, 21 Sep 2017 05:02:40 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916204234.725130-1-arnd@arndb.de>","References":"<20170916204234.725130-1-arnd@arndb.de>","From":"Linus Walleij ","Date":"Thu, 21 Sep 2017 14:02:39 +0200","Message-ID":"","Subject":"Re: [PATCH] gpio: omap: omap_gpio_show_rev is not __init","To":"Arnd Bergmann ","Cc":"Grygorii Strashko ,\n\tSantosh Shilimkar ,\n\tKevin Hilman ,\n\tLinux-OMAP ,\n\t\"linux-gpio@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-gpio-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-gpio@vger.kernel.org"}}]