[{"id":1769796,"web_url":"http://patchwork.ozlabs.org/comment/1769796/","msgid":"<585dc29a-64bf-9fff-e355-fa4ca7896a12@netcologne.de>","list_archive_url":null,"date":"2017-09-17T21:18:43","subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","submitter":{"id":4465,"url":"http://patchwork.ozlabs.org/api/people/4465/","name":"Thomas Koenig","email":"tkoenig@netcologne.de"},"content":"Hi Janus,\n\n> here is a small patch that enables -Wconversion-extra with -Wextra and\n> updates the documentation.\n\nI grepped for warn_conversion_extra and found 14 occurrences in the\ngfortran source tree.\n\nAre we sure we want to enable each of these warnings with -Wextra?\n\nRegards\n\n\tThomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462340-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"L0NFbhzh\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwMTB0P42z9s76\n\tfor ;\n\tMon, 18 Sep 2017 07:19:07 +1000 (AEST)","(qmail 88915 invoked by alias); 17 Sep 2017 21:18:59 -0000","(qmail 88889 invoked by uid 89); 17 Sep 2017 21:18:59 -0000","from cc-smtpout1.netcologne.de (HELO cc-smtpout1.netcologne.de)\n\t(89.1.8.211) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tSun, 17 Sep 2017 21:18:49 +0000","from cc-smtpin3.netcologne.de (cc-smtpin3.netcologne.de\n\t[89.1.8.203])\tby cc-smtpout1.netcologne.de (Postfix) with\n\tESMTP id EA0FF130E1; Sun, 17 Sep 2017 23:18:45 +0200 (CEST)","from localhost (localhost [127.0.0.1])\tby cc-smtpin3.netcologne.de\n\t(Postfix) with ESMTP id E681511D82;\n\tSun, 17 Sep 2017 23:18:45 +0200 (CEST)","from [78.35.137.148] (helo=cc-smtpin3.netcologne.de)\tby localhost\n\twith ESMTP (eXpurgate 4.1.9)\t(envelope-from\n\t)\tid\n\t59bee6b5-02b7-7f0000012729-7f000001ee1c-1\tfor\n\t; Sun, 17 Sep 2017 23:18:45 +0200","from [192.168.178.20] (xdsl-78-35-137-148.netcologne.de\n\t[78.35.137.148])\t(using TLSv1.2 with cipher\n\tECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\t(No client\n\tcertificate requested)\tby cc-smtpin3.netcologne.de (Postfix)\n\twith ESMTPSA; Sun, 17 Sep 2017 23:18:43 +0200 (CEST)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; q=dns; s=\n\tdefault; b=vsckP8SzxksbXkALzo9PTSv7sxZo4ybwevQg2184wBm70kIC+gt8N\n\t3iHzepqr/sxOHCe/lb4dQ3wEvNChPg4+y54YHfsGPvWzcN10kcsHaOYdaAHtD7zT\n\tXITqLF4I+QQS0XTA9Jdb/frWWOx8139X9RBGS+UqoEYYqLD4YaKvx8=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:subject:to:references:from:message-id:date:mime-version\n\t:in-reply-to:content-type:content-transfer-encoding; s=default;\n\tbh=IzoqEx8l8zhK0ND2c8JXt+rAWDo=; b=L0NFbhzh92uY5Ew3et0E0GmKZInl\n\tSpjRwZVKecCyaOta396d3I169LnstSFttMfGfsu6Cq6eu2p099CixmD5uiUR0J5G\n\tMSlxPOIfQdiSqn0XG5qrDcIG474IK7tk85D2YcNPnSYKvDcrcfthaERZygcwOFE5\n\tx/S3xBExwPLOtHE=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-2.8 required=5.0 tests=AWL, BAYES_00,\n\tRCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD,\n\tSPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:362","X-Spam-User":"qpsmtpd, 3 recipients","X-HELO":"cc-smtpout1.netcologne.de","Subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","To":"Janus Weil , gfortran ,\n\tgcc-patches ","References":"","From":"Thomas Koenig ","Message-ID":"<585dc29a-64bf-9fff-e355-fa4ca7896a12@netcologne.de>","Date":"Sun, 17 Sep 2017 23:18:43 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64;\n\trv:52.0) Gecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit"}},{"id":1770014,"web_url":"http://patchwork.ozlabs.org/comment/1770014/","msgid":"","list_archive_url":null,"date":"2017-09-18T09:31:09","subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","submitter":{"id":4401,"url":"http://patchwork.ozlabs.org/api/people/4401/","name":"Janus Weil","email":"janus@gcc.gnu.org"},"content":"Hi Thomas,\n\n>> here is a small patch that enables -Wconversion-extra with -Wextra and\n>> updates the documentation.\n>\n> I grepped for warn_conversion_extra and found 14 occurrences in the\n> gfortran source tree.\n>\n> Are we sure we want to enable each of these warnings with -Wextra?\n\nI'd say: Yes, why not. They're all similar in style, it seems. Which\none are you worried about, in particular?\n\nAFAICS, these warnings will essentially be triggered on compile-time\nconstants, for which the compiler knows that they can be converted\ne.g. from real to integer without change in value. For such constants,\nI guess it is easy (and advisable) to change them.\n\nIf you're writing '2.0' and assign it to an integer, then you probably\njust mean '2'. I'd say the warning is justified for such cases.\n\nCheers,\nJanus","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462367-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"B0KcYtve\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgk82rrrz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 19:31:28 +1000 (AEST)","(qmail 30275 invoked by alias); 18 Sep 2017 09:31:15 -0000","(qmail 29506 invoked by uid 89); 18 Sep 2017 09:31:14 -0000","from mail-yw0-f178.google.com (HELO mail-yw0-f178.google.com)\n\t(209.85.161.178) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 18 Sep 2017 09:31:12 +0000","by mail-yw0-f178.google.com with SMTP id l4so4699835ywa.6;\n\tMon, 18 Sep 2017 02:31:12 -0700 (PDT)","by 10.129.162.148 with HTTP; Mon, 18 Sep 2017 02:31:09 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; q=dns; s=default; b=CrSc6rtjYus7FvU\n\tJkEyn9sSSqqJs+YZRJGxVAczNXs/tj2yPyzRSSGMB77mQEon2k4rKbRaDN0xNDA5\n\tpJce0bWA2LUxNs0KYdgqyLovKHhrZLWCeBrMeNnUE+7bKr6OJSdFsWrnOyy1v2Au\n\tBqN4JARdohkFD1Nq63Qsu7RxFRkA=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:cc:content-type; s=default; bh=BCyetU/pkWQusuixSFlS3\n\tI7Te3k=; b=B0KcYtveA0D5EwhBPj5Sc3UkfuhIYTCrTU64CY4ocugpuxdXrlsZm\n\tHCFkhFOeg59QcZGxjOV5UiIindKPBiNpVuQQ1YEf14SnwIGgm04WieJ9ogh0/5SX\n\tPjOJyPgPsAY371gUZWyeYH9tE+c+CC3kHa1S3xac0dYfbMJaWqSJLc=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.2 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=advisable","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mail-yw0-f178.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=Be/VrNFQGMq+yAnTQLwjeyayQbiKt5tyy/2+eKUaApI=;\n\tb=QYts6nfwLS2zytc0GRaxA2Cr6HKK+1r5QZ4ZC4lqn0b0yF0guovHgbL48szkx1AiwJ\n\tg0pPt1caz+SGiMK6sQUvJMk4Umb29sBsbnjGtUk8g7euIEaSpuHEsv6konm6eHa7rrc6\n\tcMO+9hGvCaQTFCPXwAp2AuNyVfmjogu22iTXzU+uLp0lQVnJK0vS3s5YLb8sR8H/zazO\n\tCn3FJNPPndYFQuuc4er157HOqY/kpY543knugrbtJcqBeCcNaZE7h5RYYcrSf6o0kqw6\n\tddSvK89xa4rwtPd32EIyqk34iG9hDFj0+2fKjhMoMEkPhX67/Mi40FSOfNx0j9a9VrOn\n\tDlAQ==","X-Gm-Message-State":"AHPjjUhXneK2gcxpd5L695ADdjABHJPE6mIoKxsQEMOD9XOXXu5sFiI2\trDgmT7zAFH6oUKLA6e3UINNytiZ1T0RlzW1nmyc=","X-Google-Smtp-Source":"ADKCNb6J88Beir4BflTeyuYxITUIufyayyXPKf7gDXvD/g8KWX+x4wpzHl8efvWZa3z/Fp3fM4Opm5ZRHy4ga0HMSy8=","X-Received":"by 10.129.169.134 with SMTP id\n\tg128mr21075649ywh.57.1505727070565;\n\tMon, 18 Sep 2017 02:31:10 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<585dc29a-64bf-9fff-e355-fa4ca7896a12@netcologne.de>","References":"\n\t<585dc29a-64bf-9fff-e355-fa4ca7896a12@netcologne.de>","From":"Janus Weil ","Date":"Mon, 18 Sep 2017 11:31:09 +0200","Message-ID":"","Subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","To":"Thomas Koenig ","Cc":"gfortran , gcc-patches ","Content-Type":"text/plain; charset=\"UTF-8\""}},{"id":1770020,"web_url":"http://patchwork.ozlabs.org/comment/1770020/","msgid":"","list_archive_url":null,"date":"2017-09-18T09:39:59","subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","submitter":{"id":4401,"url":"http://patchwork.ozlabs.org/api/people/4401/","name":"Janus Weil","email":"janus@gcc.gnu.org"},"content":"> As a sidenote, I made an observation that is not directly related to\n> the patch: The second warning in the test case, on \"i4 = i8\" shows\n> [-Wconversion] when compiled with -Wall, but [-Wconversion-extra] when\n> compiled with -Wextra. Does anyone understand how that inconsistency\n> comes about?\n\nBtw, this is probably due to constructs like:\n\nif ((warn_conversion || warn_conversion_extra) ...\n\nwhich occur in a few places in arith.c. In this sense, the\ndocumentation is apparently not fully correct, claiming that\n-Wconversion-extra does not imply -Wconversion? It probably does not\ndo so for all warnings, but for some of them it does apparently?\n\nMaybe it would be clearer to just make -Wconversion-extra imply\n-Wconversion (and document that), in order to avoid confusion?\n\nCheers,\nJanus","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","mailing list gcc-patches@gcc.gnu.org"],"Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org\n\t(client-ip=209.132.180.131; helo=sourceware.org;\n\tenvelope-from=gcc-patches-return-462369-incoming=patchwork.ozlabs.org@gcc.gnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org\n\theader.b=\"DNPYwL/g\"; dkim-atps=neutral","sourceware.org; auth=none"],"Received":["from sourceware.org (server1.sourceware.org [209.132.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgwJ6HWKz9s7G\n\tfor ;\n\tMon, 18 Sep 2017 19:40:15 +1000 (AEST)","(qmail 89320 invoked by alias); 18 Sep 2017 09:40:04 -0000","(qmail 88517 invoked by uid 89); 18 Sep 2017 09:40:03 -0000","from mail-yw0-f174.google.com (HELO mail-yw0-f174.google.com)\n\t(209.85.161.174) by sourceware.org\n\t(qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP;\n\tMon, 18 Sep 2017 09:40:02 +0000","by mail-yw0-f174.google.com with SMTP id t127so4700880ywg.4;\n\tMon, 18 Sep 2017 02:40:01 -0700 (PDT)","by 10.129.162.148 with HTTP; Mon, 18 Sep 2017 02:39:59 -0700 (PDT)"],"DomainKey-Signature":"a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:content-type; q=dns; s=default; b=qaWGyBI9xgCCZvgHhi\n\tUdt9JwCRyKVbg06tnAwN/TDvagb7yzATlEkfCUGVRRRn6fgmXT7cYLct8dNtVQRY\n\tJvxO5Hcoff1NOmXS3kUhi4GSRTqJruiVDLu+DX2y7WvKGPHGIpmWfcXXB0pnYEx5\n\tTePXKovi8vMRiZuPIInIhP6zE=","DKIM-Signature":"v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id\n\t:list-unsubscribe:list-archive:list-post:list-help:sender\n\t:mime-version:in-reply-to:references:from:date:message-id\n\t:subject:to:content-type; s=default; bh=ZNBk7uk/YHQSkyrdnsyxtBl7\n\tX0Y=; b=DNPYwL/g1bj4APkoDhBd2nOmeyOcTSr+ANmY7CKlQ/8CwAQWtzZO9hnq\n\tUw8aJDG8+8/PSST2/kbtScFZGLVtsRtS8DqNtclcT+ZowlUWWm3ak+L0JKMgznem\n\tL7mINaKt1gqjD9H+y9+bcnLtWtmOAJMCF0hCua5ro6VgNST4PGw=","Mailing-List":"contact gcc-patches-help@gcc.gnu.org; run by ezmlm","Precedence":"bulk","List-Id":"","List-Unsubscribe":"","List-Archive":"","List-Post":"","List-Help":"","Sender":"gcc-patches-owner@gcc.gnu.org","X-Virus-Found":"No","X-Spam-SWARE-Status":"No, score=-1.2 required=5.0 tests=AWL, BAYES_00,\n\tFREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_SORBS_SPAM,\n\tSPF_PASS autolearn=no version=3.3.2 spammy=","X-Spam-User":"qpsmtpd, 2 recipients","X-HELO":"mail-yw0-f174.google.com","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net;\n\ts=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to;\n\tbh=mEmNccoXg8kdQwBlJv73k6F97q7OE8JUqPsp8j45E6g=;\n\tb=d82RBWCQl4elD8G2kSWJDkpD4D+3fssn0NOGBr18Zvsm1lAxpE9CfaGyz94GJKqp7z\n\tH74b/1efRFtWtgewoaGZlk/4glA0TGJ7dZNR4w/TOZ9MWBOEGb2jtDUiwNZIR8r9wEcD\n\twqxYqtRfGBO7MAKm0nvGdV0EkqHgM825nCM6ZKLauKXLQmudcYCxssVMEE9GSqLj2JIP\n\tZfYxpuWp1OlW2L9o+Bz/UB5W82KWP7A67rFEI++e4GlfJy9/Rm/zBHUlygLwPKF01Lfp\n\tKQ916YgVAQiq8YdXWxbgxQ942of5CUnbpixdzhXpq7/NvVCZVPR7thG5fpAeV4S92/Tw\n\tGhBQ==","X-Gm-Message-State":"AHPjjUik3JwqcIaOOteN/UrcDvp2rGDpJ1AHdGvZ5m8CH4VTuDfQSvlZ\thi9v7zxM7u8bqF0CsGzi+223a2mkxEhB5knr6o7p7g==","X-Google-Smtp-Source":"AOwi7QD+Nhp8dBiZ7GQzYXSB8IzntMFonIbmFLhFFCCanE2peSYUIscvlHqzl0aqWj+i1H1EA1UZROTHLwfNP5Cb63w=","X-Received":"by 10.37.210.71 with SMTP id j68mr26295713ybg.358.1505727600331;\n\tMon, 18 Sep 2017 02:40:00 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"","From":"Janus Weil ","Date":"Mon, 18 Sep 2017 11:39:59 +0200","Message-ID":"","Subject":"Re: [Patch,\n\tFortran] PR 82018: -Wextra should imply -Wconversion-extra","To":"gfortran , gcc-patches ,\n\tThomas Koenig ","Content-Type":"text/plain; charset=\"UTF-8\""}}]