[{"id":1769688,"web_url":"http://patchwork.ozlabs.org/comment/1769688/","msgid":"","list_archive_url":null,"date":"2017-09-17T09:47:51","subject":"Re: [PATCHv5 3/5] dt-bindings: document the CEC GPIO bindings","submitter":{"id":7055,"url":"http://patchwork.ozlabs.org/api/people/7055/","name":"Linus Walleij","email":"linus.walleij@linaro.org"},"content":"On Sat, Sep 16, 2017 at 4:28 PM, Hans Verkuil wrote:\n> From: Hans Verkuil \n>\n> Document the bindings for the cec-gpio module for hardware where the\n> CEC line and optionally the HPD line are connected to GPIO lines.\n>\n> Signed-off-by: Hans Verkuil \n\nJust to make things explicit:\n\n> +Required properties:\n> + - compatible: value must be \"cec-gpio\".\n> + - cec-gpios: gpio that the CEC line is connected to.\n\nAdd \"The line should be tagged as open drain.\"\n\n> +Example for the Raspberry Pi 3 where the CEC line is connected to\n> +pin 26 aka BCM7 aka CE1 on the GPIO pin header and the HPD line is\n> +connected to pin 11 aka BCM17:\n> +\n\n#include \n\n> +cec-gpio {\n> + compatible = \"cec-gpio\";\n> + cec-gpio = <&gpio 7 GPIO_OPEN_DRAIN>;\n\ncec-gpios = <&gpio 7 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;\n\n> + hpd-gpio = <&gpio 17 GPIO_ACTIVE_HIGH>;\n\nhpd-gpios = ..\n\nWith these fixups:\nReviewed-by: Linus Walleij \n\nYours,\nLinus Walleij\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"VR/gK9Do\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw47b2WrCz9s7h\n\tfor ;\n\tSun, 17 Sep 2017 19:47:55 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750862AbdIQJrx (ORCPT\n\t);\n\tSun, 17 Sep 2017 05:47:53 -0400","from mail-io0-f177.google.com ([209.85.223.177]:44424 \"EHLO\n\tmail-io0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750803AbdIQJrw (ORCPT\n\t); Sun, 17 Sep 2017 05:47:52 -0400","by mail-io0-f177.google.com with SMTP id v36so13536377ioi.1\n\tfor ;\n\tSun, 17 Sep 2017 02:47:52 -0700 (PDT)","by 10.79.164.78 with HTTP; Sun, 17 Sep 2017 02:47:51 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=V/aegaZnI6kRXWuueBYigQ0RtowEWiy+Iwac9k/3k/U=;\n\tb=VR/gK9DoniVBbgVGcEY6Fjno825eW0++ynD5ivF8IBCcUbHtKwVEwIUs1DKbmAhV0o\n\t67CXZTzm7+dP3QD7xpk87+fuaY3kyDYIJGMWET43Gm7aMCocGteGcGHV0SXtrVlp7xW/\n\tEMg5iaZn/d8iqC0A+oaDHecGBPnIWbGN5//ug=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=V/aegaZnI6kRXWuueBYigQ0RtowEWiy+Iwac9k/3k/U=;\n\tb=llRhzo7hvYhv20PKsiOnvTLtxbK95yAKtLhKF/T+mGRw8IqQ9g5+1vpjeokaNtNsXv\n\ty7hnLhnkiYfoBrXzS6nQjuyDbcBPbxu14UzJnXzDuNeX8pW9tIMUiofwax8oZl7iCNa4\n\tu3d94mplPiTYqKtkUK9DPKzbZpBKefu3DNse6DlINSUo2bcrG4YqUEERfPEIIp/Y/M44\n\twW6ipv3bZHwMiEzaG/yFiGpMQbMt5hz8eNOpHAp0vol9kxRAlQGdUIEoFkNm0F39YB1y\n\tOWFLe8sIRWVb7tuzDdPD/oAAfGOXBebi9JSjFhd42+CZ9eztSDS2+jlD0jKjaYd+litL\n\twC8g==","X-Gm-Message-State":"AHPjjUhZEJnLuMxX4qN6pz/1kBCcIs4CMVEktBODxDVM8w5w12vDCx8z\n\tU5AMHng7GqEDzCTIsP4MMhrgyUmz0D2Wfs/6eKvIPA==","X-Google-Smtp-Source":"AOwi7QATMTcEqhYDUgsvm2IqmT9L247D9SaA4Zf+qCbMXfCY/bFaNAD4TALxKhMUaj1MQghAwPhnpqKee+Nuq+DpVEk=","X-Received":"by 10.107.63.67 with SMTP id m64mr14639021ioa.104.1505641672272; \n\tSun, 17 Sep 2017 02:47:52 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170916142827.5878-4-hverkuil@xs4all.nl>","References":"<20170916142827.5878-1-hverkuil@xs4all.nl>\n\t<20170916142827.5878-4-hverkuil@xs4all.nl>","From":"Linus Walleij ","Date":"Sun, 17 Sep 2017 11:47:51 +0200","Message-ID":"","Subject":"Re: [PATCHv5 3/5] dt-bindings: document the CEC GPIO bindings","To":"Hans Verkuil ","Cc":"\"linux-media@vger.kernel.org\" ,\n\t\"open list:DRM PANEL DRIVERS\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\tRob Herring , Hans Verkuil ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]