[{"id":1769669,"web_url":"http://patchwork.ozlabs.org/comment/1769669/","msgid":"<0fe61e2a-24d1-5412-382f-2777ce219166@mellanox.com>","list_archive_url":null,"date":"2017-09-17T07:03:59","subject":"Re: [PATCH net] net/sched: cls_matchall: fix crash when used with\n\tclassful qdisc","submitter":{"id":69965,"url":"http://patchwork.ozlabs.org/api/people/69965/","name":"Yotam Gigi","email":"yotamg@mellanox.com"},"content":"On 09/16/2017 03:02 PM, Davide Caratti wrote:\n> this script, edited from Linux Advanced Routing and Traffic Control guide\n>\n> tc q a dev en0 root handle 1: htb default a\n> tc c a dev en0 parent 1: classid 1:1 htb rate 6mbit burst 15k\n> tc c a dev en0 parent 1:1 classid 1:a htb rate 5mbit ceil 6mbit burst 15k\n> tc c a dev en0 parent 1:1 classid 1:b htb rate 1mbit ceil 6mbit burst 15k\n> tc f a dev en0 parent 1:0 prio 1 $clsname $clsargs classid 1:b\n> ping $address -c1\n> tc -s c s dev en0\n>\n> classifies traffic to 1:b or 1:a, depending on whether the packet matches\n> or not the pattern $clsargs of filter $clsname. However, when $clsname is\n> 'matchall', a systematic crash can be observed in htb_classify(). HTB and\n> classful qdiscs don't assign initial value to struct tcf_result, but then\n> they expect it to contain valid values after filters have been run. Thus,\n> current 'matchall' ignores the TCA_MATCHALL_CLASSID attribute, configured\n> by user, and makes HTB (and classful qdiscs) dereference random pointers.\n>\n> By assigning head->res to *res in mall_classify(), before the actions are\n> invoked, we fix this crash and enable TCA_MATCHALL_CLASSID functionality,\n> that had no effect on 'matchall' classifier since its first introduction.\n>\n> BugLink: https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.redhat.com%2Fshow_bug.cgi%3Fid%3D1460213&data=02%7C01%7Cyotamg%40mellanox.com%7C399f6ff50cb148cbd0d408d4fcfad4c7%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636411601630363571&sdata=PSkkBrWNXkTxsvXrTmK6Dx9iKZMq61MAKlTcdVcPj8w%3D&reserved=0\n> Reported-by: Jiri Benc \n> Fixes: b87f7936a932 (\"net/sched: introduce Match-all classifier\")\n> Signed-off-by: Davide Caratti \n> ---\n> net/sched/cls_matchall.c | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c\n> index 21cc45caf842..eeac606c95ab 100644\n> --- a/net/sched/cls_matchall.c\n> +++ b/net/sched/cls_matchall.c\n> @@ -32,6 +32,7 @@ static int mall_classify(struct sk_buff *skb, const struct tcf_proto *tp,\n> \tif (tc_skip_sw(head->flags))\n> \t\treturn -1;\n> \n> +\t*res = head->res;\n> \treturn tcf_exts_exec(skb, &head->exts, res);\n> }\n> \n\nAcked-by: Yotam Gigi ","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=Mellanox.com header.i=@Mellanox.com\n\theader.b=\"uKZVsLXA\"; dkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=yotamg@mellanox.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw0Vj0Nytz9ryk\n\tfor ;\n\tSun, 17 Sep 2017 17:04:13 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750835AbdIQHEK (ORCPT );\n\tSun, 17 Sep 2017 03:04:10 -0400","from mail-db5eur01on0085.outbound.protection.outlook.com\n\t([104.47.2.85]:36640\n\t\"EHLO EUR01-DB5-obe.outbound.protection.outlook.com\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1750749AbdIQHEI (ORCPT );\n\tSun, 17 Sep 2017 03:04:08 -0400","from localhost.localdomain (109.66.173.144) by\n\tDB6PR0502MB2967.eurprd05.prod.outlook.com (2603:10a6:4:97::13) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11;\n\tSun, 17 Sep 2017 07:04:03 +0000"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=3caszpNqz2Dlb/FRenkdXRYvBY9P1hu/mqEsxUZZocs=;\n\tb=uKZVsLXAtC/qq/g92YIIbptKiQlJzUZUDegAG+Y7tevujWdaklw9cL0qFC1CA35MaQRmVMLfOz92GJVDAdLPKkWs1UMPex5Y+ZIHJn1YwB1HW+AF/Pww5eH6GkX3UJ7EteqAgxf3oV3IQyzSmQU9MLQ8DfLKWPpuFKaFP5+CPw0=","Subject":"Re: [PATCH net] net/sched: cls_matchall: fix crash when used with\n\tclassful qdisc","To":"Davide Caratti , Jiri Pirko ,\n\tJamal Hadi Salim , Jiri Benc ,\n\t\"David S . Miller\" ","Cc":"netdev@vger.kernel.org","References":"","From":"Yotam Gigi ","Message-ID":"<0fe61e2a-24d1-5412-382f-2777ce219166@mellanox.com>","Date":"Sun, 17 Sep 2017 10:03:59 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Content-Language":"en-US","X-Originating-IP":"[109.66.173.144]","X-ClientProxiedBy":"DB6PR1001CA0032.EURPRD10.PROD.OUTLOOK.COM\n\t(2603:10a6:4:55::18) To DB6PR0502MB2967.eurprd05.prod.outlook.com\n\t(2603:10a6:4:97::13)","X-MS-PublicTrafficType":"Email","X-MS-Office365-Filtering-Correlation-Id":"55d0bec5-d831-4203-f92e-08d4fd9a486e","X-MS-Office365-Filtering-HT":"Tenant","X-Microsoft-Antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB6PR0502MB2967; ","X-Microsoft-Exchange-Diagnostics":["1; DB6PR0502MB2967;\n\t3:4miTQC+qZe7pRun9WbFIuz3Vg+8YHUx8ZEReDN8tglx+CmbmiPtF5M8Kyb9/VAEgrF68jJa+vQP0jooHSH/uXi4RqNOW1OeF6YsyA2DjEFxb+huFGfS/ZhfdZyp2UIR191Om/753bOjdNuRR/L7mmbrSHZA/qbzaiWSM3TmvIDHPBwskQ84VFJlmIReQeK63rknNqqApkyowKHliYulFJBLT4Qpd6l20b+VC9N42+g04UDxFePtp3vU5niFVkctV;\n\t25:GKEx71uYoTNrmQZEQwFeZboenkig+CBM3jSCUUCemhHqyfYEgDIzL9bpP96ij1qA4ISbU+iza/rE0gISxI+JZm2Gx/JtyWfwVqCnrGPhWRECffkfMPh6fEO4meVHGjMbzgHIVfmRo+cpmbInt2MduUFPYSeKcWghmJa1tExQ/yfx13yu6rhyCLUFSLlzMJgeZM3PrYW0TCcrOJQQUJJnS6UBNmY/tQtrr5NFHc8qqs/LJ7puuNXFsmGK/ladi0OKufRG7qLgkantqL4m3bb9XXaPKdW/Al2vSkfjqi/dE2E7G9ACaYPayMRO8p/SvGrCTWykigcnjK/dcOXT4V1CUw==;\n\t31:iOAugL6jTb+NLzn2UPykZMAREyGpcTCdmqecB6QliZrBgpiFRZvCqznWODG7Ws2UUNtYM5iD5NDLTYAbo0Lm1NVE3sUM59lR/CjvQEFH5m+7x32hkA7WP2Rd6O34yaeUxME8Dv7dFBoQHQ9IpQt6plgWYMYvqyAjV/sq5S7ospriF4NMDCkv75MGwu8CTK+RBDU1JIh25PnbLjeesuRCbbsFsRLYEP0TTwJVLTAcA+w=","1; DB6PR0502MB2967;\n\t20:PrKbZtEgohYKToZ/qoaX+SxbldmDHDAQA7B6LN/iWcb8pxRZn+dWd89QjNI6RzhNJdnxAB/3+bk+njlsO3Qkyc45TWvGMCxJjWq2xOzyEaWEWD0t2UwOV/8K3TLUnyCQT8jVQNKd5w8NrDl1AvUDl98AKFCC4ZyVUNsv83dvcaWY0w2MABBtg3si0gwuPzPETFjtraBHg1txFVrPlOKd0slb4Xuz6p5gab+XegMr/pjbO0qIlSNXYW3kG0Tm6x8GzxX7Zk84jPzghMwfh7LBS9lcIQycRHVW8kmJA48A1f34KzBEifIiXsOgq4AzGONuP+fj+3c60h/3FUumFzHu6TeTvv1JfvLyL7f+3Ss1MaBx/HVBIK3Z52Q0A+vqFpX/yUcjOlUDmE2qOyNaC2KuezDNPRmj4axusXyWeplVVViVAoWa8ZEAzhLjvfb0/NwOQrJ8+U8Ic0iwvjYHl1mywyd5v4mBQebSdy3PMsEm86928axpq6277t5+0jbJP/eG;\n\t4:Hh4TCTQFatEfiDSbl65tjrO1JuR137LPVzbFDhSuz3T2YnhlNImy2r1huLhcPV1BUa0QEHu+aYASDQ2TAXYilO7v6slu5nIHZl8GWzMqtpvlTxXRK8Iat4NUWWxaAdKuUJYeyiCwGEeHN/DpQ0mRoIHn+YyvL+cIIEHuLuEPCKmmTdGOsbLaf4fWTUFCFHz4nfhUj49tUiGocF4mssXuLQUdstUXuX6p3ag9HOGITRL3aO2WQGS3xdpQK0xnZnH5TxTujCSIkfhNRCPFda5TNX1qtwJ1QASDCk+pN2FTNBsU65Ofne5UykLnUZpElKOeP0cYlLnIpCSgHP/xSxNoQg==","=?utf-8?q?1=3BDB6PR0502MB2967=3B23=3AAr?=\n\t=?utf-8?q?7YIAD4K+mcMAfIs8Zo+7OG2RetY7ffw3ciyEGVntKPxvmOqjZavcLyNi?=\n\t=?utf-8?q?BKN2xYWhDNmgY+DQEuINR4nt1KdjAOWJSU/zU3CtNSfNoJTruJKusTU8?=\n\t=?utf-8?q?9BuDdVCl+RzjTyCJ0kKJpuSbjLvAPltGa1Sfdte36pHyNRvHF014L2Na?=\n\t=?utf-8?q?xr1pvrufww/QmQYe50fLp0PDW5FDWasi6ysxwuPpCWQnmDIgqWpA/4Td?=\n\t=?utf-8?q?Kam7F48bKkoeRyrm05x4mh73f9pzIR4IbxdSEFCbSo57aRMNgYdTp2z6?=\n\t=?utf-8?q?AwvPuwIRiV+d26jiATXoo7ab0jzy+GJNvgmUPgS7kayPPstUNhi9po91?=\n\t=?utf-8?q?WYV4aYIDc0VoE+4z7El/EMUtGVUifvLqdO0H835j77MHAUJHY/p2dnSp?=\n\t=?utf-8?q?gd1ULB+yh1ITtLCL6l5xfg/sDBnEkijRLd3fDduDv7jL4IpgPEaakPnv?=\n\t=?utf-8?q?qPU+uWyrP05K1SbgLfLE8f7XZ1CmkWjXET5xdyRYNmOrcMNCyNd/hSfU?=\n\t=?utf-8?q?9xySCXqF448yiwFMRXAsIP4p7OQZatT8Xz96UMjq5GviI/L66Nv5mwXG?=\n\t=?utf-8?q?AW9jPhcFV3w1FnbmMZ71fgQcTlbBMyb5G7JrR0D9OiYCP9BTHp5lqL2S?=\n\t=?utf-8?q?l5BopOKpYG9c/WTJrVJB4w1PmELgQpiVKC6kocpVKYb2u/7GRc12gNH3?=\n\t=?utf-8?q?ZLp6FpN1MRTW8MdnRJhWa0PmgropG+sbx0t1KO0NOx0wUaIEL5gSX7Vp?=\n\t=?utf-8?q?EnwKIJublutwTuXWcE0I8rSOLf2ztntHEFzTZd7Yb2yeTHGvzNXELSJG?=\n\t=?utf-8?q?yVUCYtwTzxezAHxrOOJd4cWzlPjct7kaLDmfaedlYWgzmMGR1sBE2urH?=\n\t=?utf-8?q?w9qLtrA0hWrZdYXRp8oKke7ygyyr75LXpiJOi59wM5ldumYhZIjB80SI?=\n\t=?utf-8?q?NKy3iJgRaGZHSAL3w0NpusbdrQXdPN5p9cyFCrv5/NH59FQnRyTNVhEx?=\n\t=?utf-8?q?oC+09SBoxOdQWGdLMKTaWYy9ND3xI5GRPi2utcUx1HfzV60J4MndYdA8?=\n\t=?utf-8?q?iZttwCH6wsk9WlF4V3gQByUV8mkzBkOMpasH0xjxqv+fwki/i8Zc2jbH?=\n\t=?utf-8?q?8T+ztI0J6FpnrYANPAXVDNWR4gr/wHvStTzMDqGxjfL79GGyvNPPlsyd?=\n\t=?utf-8?q?+KhBA3+wxz1oEPYlM57ZklyGPCKSvecyetrogXU0043DxpvYIfcZaSC1?=\n\t=?utf-8?q?dDeZwmFBswUP/hqdCa9/XMsZ3Uc/T28DR2eROiGcqn4NTuVXSCPlw7Xa?=\n\t=?utf-8?q?Ifi7qGDVHjVaviOEGi5lOlK8XTys3TzjaB8ewSyfkJZHIWBsy9hfyg+2?=\n\t=?utf-8?q?YNNUVazSO2CDbGw2lyKwzAYpAQqvj3EPlQno5Ceb7m0VZDkfZJcs1aSi?=\n\t=?utf-8?q?s8xFQKJ8wLejXBEMOO+fDXeyb7sKgdwD/FXoZJA3wjaaTOLERUegmFzc?=\n\t=?utf-8?q?8pBuOO84LP+imX7wk7r49MgvzRxT1OJkSOqcGBEt+E7S6zdqAk+gwAvE?=\n\t=?utf-8?q?t/naio8XdvDpElBoB/909HnMzONMrb6dGn6Q=3D=3D?=","1; DB6PR0502MB2967;\n\t6:LmbwFymDOCBZB1y4H6vSnSQxvcqeAukaZkH0zA93jzPeT7WAtg8gZTDEVYDNjbIehDJTe1ssGH/JFhxq/edARqsnDn2tTnJhOF+kSKAOdH3io+ff/LvalH6VrQ8ueiQYXDlyiM/RgHah6mmeiqooH36P5xrnw44tSBDa7dIJuE0rJ1dDo/Lr+PincV0pl2Aed50/l1JOq8rZWZTTGfaxudogwstq3qeJKqMpRY9dE7me0coEjcqdu2giW5wU7rSw7rsEOzJz8OK+Oj7wf/PDLY6WxguvXLQvbQNf/4fi1hTUw6V4NILmFvozq5rhYelPcWHyUdq6VfUMJhwi8L+Zzg==;\n\t5:L9nVq2S3X94pBh5LZrBNtf/5AZoZ5AYz+P3DPaxkTgp/n0ETs/rPiXXTEnGC+7M2KDL57cZjAlX5nz2nmn40HtNsKj/MOpDAqkLvJYJyFnN6HUuXQG5ABgxij33ldA1VoxJhVDPTrwsZjxJCs1ZXxw==;\n\t24:lQMGvLlWLFCbeUiuM+rq8EGodDURydgs9dwIwy79ICQ5sQFo37INrhOu/jhlEQGoptTc6Tt4SuZd4jPJaZtnvZjm5LtK/6+Mdh2GPBWZOJc=;\n\t7:tSdydejPrC6/+e8mWEznJIEUBnlPkmszixhtp2RL0bUykXOmV4hwNdvBWJ3dJdD73M7KtrBtO16okpIWwfxuS1eL0xYd/XsluIvTypiyyUXqHvrXx1pcn9VE34BTTzKE8CGBkbaCHdIBwCRMb/1TgeTaS2UiHFc07QzJgRb5YpLiiC2WW+kG5TUTsl2BBm6/ekdR79HpzStWr9ExxTsByr6mc9HbKV1iQEY5c9tHSq8="],"X-MS-TrafficTypeDiagnostic":"DB6PR0502MB2967:","X-Exchange-Antispam-Report-Test":"UriScan:(189930954265078)(45079756050767);","X-Microsoft-Antispam-PRVS":"","X-Exchange-Antispam-Report-CFA-Test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB6PR0502MB2967; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB6PR0502MB2967; ","X-Forefront-PRVS":"0433DB2766","X-Forefront-Antispam-Report":"SFV:NSPM;\n\tSFS:(10009020)(4630300001)(7370300001)(6069001)(6009001)(376002)(39860400002)(346002)(24454002)(199003)(189002)(377454003)(31686004)(229853002)(6486002)(4326008)(6666003)(36756003)(64126003)(65826007)(2906002)(189998001)(16526017)(305945005)(6246003)(6306002)(6512007)(53546010)(2950100002)(25786009)(53936002)(7350300001)(7736002)(478600001)(81166006)(50466002)(6506006)(966005)(106356001)(97736004)(105586002)(86362001)(58126008)(316002)(83506001)(45080400002)(575784001)(31696002)(230700001)(5660300001)(65806001)(47776003)(68736007)(23676002)(54356999)(76176999)(50986999)(33646002)(81156014)(3846002)(6116002)(65956001)(66066001)(101416001)(8676002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0502MB2967;\n\tH:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords;\n\tA:1; MX:1; LANG:en; ","Received-SPF":"None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)","SpamDiagnosticOutput":"1:99","SpamDiagnosticMetadata":"NSPM","X-OriginatorOrg":"Mellanox.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Sep 2017 07:04:03.6230\n\t(UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB6PR0502MB2967","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770579,"web_url":"http://patchwork.ozlabs.org/comment/1770579/","msgid":"<20170918.163807.719055481647996620.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-18T23:38:07","subject":"Re: [PATCH net] net/sched: cls_matchall: fix crash when used with\n\tclassful qdisc","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Davide Caratti \nDate: Sat, 16 Sep 2017 14:02:21 +0200\n\n> this script, edited from Linux Advanced Routing and Traffic Control guide\n> \n> tc q a dev en0 root handle 1: htb default a\n> tc c a dev en0 parent 1: classid 1:1 htb rate 6mbit burst 15k\n> tc c a dev en0 parent 1:1 classid 1:a htb rate 5mbit ceil 6mbit burst 15k\n> tc c a dev en0 parent 1:1 classid 1:b htb rate 1mbit ceil 6mbit burst 15k\n> tc f a dev en0 parent 1:0 prio 1 $clsname $clsargs classid 1:b\n> ping $address -c1\n> tc -s c s dev en0\n> \n> classifies traffic to 1:b or 1:a, depending on whether the packet matches\n> or not the pattern $clsargs of filter $clsname. However, when $clsname is\n> 'matchall', a systematic crash can be observed in htb_classify(). HTB and\n> classful qdiscs don't assign initial value to struct tcf_result, but then\n> they expect it to contain valid values after filters have been run. Thus,\n> current 'matchall' ignores the TCA_MATCHALL_CLASSID attribute, configured\n> by user, and makes HTB (and classful qdiscs) dereference random pointers.\n> \n> By assigning head->res to *res in mall_classify(), before the actions are\n> invoked, we fix this crash and enable TCA_MATCHALL_CLASSID functionality,\n> that had no effect on 'matchall' classifier since its first introduction.\n> \n> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1460213\n> Reported-by: Jiri Benc \n> Fixes: b87f7936a932 (\"net/sched: introduce Match-all classifier\")\n> Signed-off-by: Davide Caratti \n\nApplied and queued up for -stable, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx2W74144z9s2G\n\tfor ;\n\tTue, 19 Sep 2017 09:38:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751016AbdIRXiJ (ORCPT );\n\tMon, 18 Sep 2017 19:38:09 -0400","from shards.monkeyblade.net ([184.105.139.130]:58622 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750791AbdIRXiI (ORCPT\n\t); Mon, 18 Sep 2017 19:38:08 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id D26B4102A6507;\n\tMon, 18 Sep 2017 16:38:07 -0700 (PDT)"],"Date":"Mon, 18 Sep 2017 16:38:07 -0700 (PDT)","Message-Id":"<20170918.163807.719055481647996620.davem@davemloft.net>","To":"dcaratti@redhat.com","Cc":"jiri@resnulli.us, jhs@mojatatu.com, jbenc@redhat.com,\n\tnetdev@vger.kernel.org","Subject":"Re: [PATCH net] net/sched: cls_matchall: fix crash when used with\n\tclassful qdisc","From":"David Miller ","In-Reply-To":"","References":"","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Mon, 18 Sep 2017 16:38:08 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]