[{"id":1769633,"web_url":"http://patchwork.ozlabs.org/comment/1769633/","msgid":"<1505590431.16316.9.camel@perches.com>","list_archive_url":null,"date":"2017-09-16T19:33:51","subject":"Re: [PATCH] i2c: i2c-stm32f7: make structure stm32f7_setup static","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Sat, 2017-09-16 at 12:33 +0100, Colin King wrote:\n> From: Colin Ian King \n> \n> The structure stm32f7_setup is local to the source and does not need\n> to be in global scope, so make it static.\n> \n> Cleans up sparse warning:\n> symbol 'stm32f7_setup' was not declared. Should it be static?\n[]\n> diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c\n[]\n> @@ -265,7 +265,7 @@ static struct stm32f7_i2c_spec i2c_specs[] = {\n> \t},\n> };\n> \n> -struct stm32f7_i2c_setup stm32f7_setup = {\n> +static struct stm32f7_i2c_setup stm32f7_setup = {\n\nbetter to use static const\n\n> \t.rise_time = STM32F7_I2C_RISE_TIME_DEFAULT,\n> \t.fall_time = STM32F7_I2C_FALL_TIME_DEFAULT,\n> \t.dnf = STM32F7_I2C_DNF_DEFAULT,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvjPs3S5Jz9t2S\n\tfor ;\n\tSun, 17 Sep 2017 05:44:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751273AbdIPTn5 (ORCPT );\n\tSat, 16 Sep 2017 15:43:57 -0400","from smtprelay0056.hostedemail.com ([216.40.44.56]:36271 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751272AbdIPTn5 (ORCPT\n\t); Sat, 16 Sep 2017 15:43:57 -0400","from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com\n\t[10.5.19.251])\n\tby smtpgrave04.hostedemail.com (Postfix) with ESMTP id 9315B18009FFF\n\tfor ; Sat, 16 Sep 2017 19:33:56 +0000 (UTC)","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay01.hostedemail.com (Postfix) with ESMTP id 63A26100E806B; \n\tSat, 16 Sep 2017 19:33:55 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf08.hostedemail.com (Postfix) with ESMTPA;\n\tSat, 16 Sep 2017 19:33:53 +0000 (UTC)"],"X-Greylist":"delayed 601 seconds by postgrey-1.27 at vger.kernel.org;\n\tSat, 16 Sep 2017 15:43:57 EDT","X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::::,\n\tRULES_HIT:41:334:355:368:369:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3871:3872:4321:5007:6119:7576:10004:10400:10848:11026:11232:11473:11658:11914:12043:12048:12438:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21627:30054:30089:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none","X-HE-Tag":"heat76_3f24a42a44b36","X-Filterd-Recvd-Size":"1734","Message-ID":"<1505590431.16316.9.camel@perches.com>","Subject":"Re: [PATCH] i2c: i2c-stm32f7: make structure stm32f7_setup static","From":"Joe Perches ","To":"Colin King , Wolfram Sang ,\n\tMaxime Coquelin ,\n\tAlexandre Torgue ,\n\tlinux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Cc":"kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org","Date":"Sat, 16 Sep 2017 12:33:51 -0700","In-Reply-To":"<20170916113308.25534-1-colin.king@canonical.com>","References":"<20170916113308.25534-1-colin.king@canonical.com>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]