[{"id":1779485,"web_url":"http://patchwork.ozlabs.org/comment/1779485/","msgid":"<8022002c-956f-28e6-abca-5919157704c1@skidata.com>","list_archive_url":null,"date":"2017-10-04T07:39:12","subject":"Re: [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and\n\tIDs","submitter":{"id":70889,"url":"http://patchwork.ozlabs.org/api/people/70889/","name":"Richard Leitner","email":"richard.leitner@skidata.com"},"content":"Hi Serge,\n\nOn 09/16/2017 12:42 PM, Serge Semin wrote:\n> There are USB2517 and USB2517i hubs, which have almost the same\n> registers space as already supported USB251xbi series. The difference\n> it in DIDs and in few functions. This patch adds the USB2517/i data\n> structures to the driver, so it would have different setting depending\n> on the device discovered on i2c-bus.\n> \n> Signed-off-by: Serge Semin \n> ---\n> Documentation/devicetree/bindings/usb/usb251xb.txt | 3 ++-\n> drivers/usb/misc/usb251xb.c | 21 ++++++++++++++++++++-\n> 2 files changed, 22 insertions(+), 2 deletions(-)\n\n...\n\nPlease also mention support for the USB2517(i) hubs in the Kconfig\nhelptext of the driver @ drivers/usb/misc/Kconfig. Thanks.\n\nApart from that the patch looks good to me.\n\nregards,\nRichard.L\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y6STc2xBxz9sxR\n\tfor ;\n\tWed, 4 Oct 2017 18:39:32 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751297AbdJDHjR (ORCPT\n\t);\n\tWed, 4 Oct 2017 03:39:17 -0400","from mail2.skidata.com ([91.230.2.91]:63650 \"EHLO\n\tmail2.skidata.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751047AbdJDHjR (ORCPT );\n\tWed, 4 Oct 2017 03:39:17 -0400"],"X-IronPort-AV":"E=Sophos;i=\"5.42,476,1500933600\"; d=\"scan'208\";a=\"1013561\"","Subject":"Re: [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and\n\tIDs","To":"Serge Semin ,\n\t, ,\n\t","CC":", ,\n\t, ,\n\tRichard Leitner ","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-2-fancer.lancer@gmail.com>","From":"Richard Leitner ","Message-ID":"<8022002c-956f-28e6-abca-5919157704c1@skidata.com>","Date":"Wed, 4 Oct 2017 09:39:12 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170916104220.3742-2-fancer.lancer@gmail.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[172.16.60.30]","X-ClientProxiedBy":"sdex1srv.skidata.net (172.16.10.92) To\n\tsdex1srv.skidata.net (172.16.10.92)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]