[{"id":1772208,"web_url":"http://patchwork.ozlabs.org/comment/1772208/","msgid":"<20170920133735.k3yzh2m6zb5qzhn2@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-20T20:52:57","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> The driver used to be developed with legacy GPIO API support. It's\n> better to use descriptor-based interface for several reasons. First\n> of all the legacy API doesn't support the ACTIVE_LOW/HIGH flag of dts\n> nodes, which is essential since different hardware may have different\n> GPIOs connectivity including the logical value inversion. Secondly,\n> by requesting the reset GPIO descriptor the driver prevent the other\n> applications from changing its value. And last but not least the\n> legacy GPIO interface should be avoided in the new code due to it\n> obsolescence.\n\nAll this has nothing to do with the binding. Please make the binding \nchange separate and state why it should be optional.\n\n> \n> Signed-off-by: Serge Semin \n> ---\n> Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +-\n> drivers/usb/misc/usb251xb.c | 34 +++++++++-------------\n> 2 files changed, 15 insertions(+), 21 deletions(-)\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyBnd6m4Zz9s83\n\tfor ;\n\tThu, 21 Sep 2017 06:54:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751810AbdITUxH (ORCPT\n\t);\n\tWed, 20 Sep 2017 16:53:07 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:34011 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752159AbdITUw7 (ORCPT\n\t); Wed, 20 Sep 2017 16:52:59 -0400","by mail-pf0-f194.google.com with SMTP id g65so1633590pfe.1;\n\tWed, 20 Sep 2017 13:52:58 -0700 (PDT)","from localhost ([2620:0:1000:fd28:e83d:5428:912b:b325])\n\tby smtp.gmail.com with ESMTPSA id\n\t133sm10278608pfy.2.2017.09.20.13.52.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 13:52:57 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=AdlUN+CX90hRRFPokzQ5eNY31bXwWRuBB/9yClB8IRM=;\n\tb=MBaWVQA8WH2Onx0s2MZXW+j3rzcvxM90LmIYZl8FYWOuvUP1GOKndw/kVdz4nhmwCn\n\tFVjo5BRwQl/bPzFWrYBW6s1OJ7ZnqOTXz1eCUfI2vOeK+9mfVCQG2G35i1q5tu9Z29Xn\n\twhd5C4Hh8rl2dy3w+PHnMi0PRduZHZZNHxiiVHCGlwgJZ0zZtbd/OMI3LYiuda7jg6+O\n\tGmwbzG1N4gyMjeiW88xTBCAo1KeNQAcUHJLn+vw6Z7kRVYNYJj4us7ELwymi0m/z6AEZ\n\tZLt5UvZ1TGb3lX0Pa7LhD+gIoJcUMOYhLFnkhuL+D0IpIJuUAvkEVfKB6nG6H6hkW3/5\n\tHS3A==","X-Gm-Message-State":"AHPjjUhGX2xLTQgIkVxf2cqI1PLrXmxnlDJne4ZqyykeRPTwvBZHC7N1\n\t4S+ZzxeT+ELFPm4gZ51EMw==","X-Google-Smtp-Source":"AOwi7QCOdA2x0exBetEmhxrq+f12btbrVUmp+Q3cwApGPpQn8o7aAQWmIE6WV4x92Mmh8sI6NgepPA==","X-Received":"by 10.99.123.91 with SMTP id k27mr3468133pgn.23.1505940778429;\n\tWed, 20 Sep 2017 13:52:58 -0700 (PDT)","Date":"Wed, 20 Sep 2017 15:52:57 -0500","From":"Rob Herring ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, gregkh@linuxfoundation.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170920133735.k3yzh2m6zb5qzhn2@rob-hp-laptop>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170916104220.3742-10-fancer.lancer@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772264,"web_url":"http://patchwork.ozlabs.org/comment/1772264/","msgid":"<20170920212928.GC3547@mobilestation>","list_archive_url":null,"date":"2017-09-20T21:29:28","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Wed, Sep 20, 2017 at 03:52:57PM -0500, Rob Herring wrote:\n> On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> > The driver used to be developed with legacy GPIO API support. It's\n> > better to use descriptor-based interface for several reasons. First\n> > of all the legacy API doesn't support the ACTIVE_LOW/HIGH flag of dts\n> > nodes, which is essential since different hardware may have different\n> > GPIOs connectivity including the logical value inversion. Secondly,\n> > by requesting the reset GPIO descriptor the driver prevent the other\n> > applications from changing its value. And last but not least the\n> > legacy GPIO interface should be avoided in the new code due to it\n> > obsolescence.\n> \n> All this has nothing to do with the binding. Please make the binding \n> change separate and state why it should be optional.\n> \n\nOk.\n\n> > \n> > Signed-off-by: Serge Semin \n> > ---\n> > Documentation/devicetree/bindings/usb/usb251xb.txt | 2 +-\n> > drivers/usb/misc/usb251xb.c | 34 +++++++++-------------\n> > 2 files changed, 15 insertions(+), 21 deletions(-)\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Kpo0L532\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyCZ81Ff5z9sBd\n\tfor ;\n\tThu, 21 Sep 2017 07:29:51 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751826AbdITV33 (ORCPT\n\t);\n\tWed, 20 Sep 2017 17:29:29 -0400","from mail-lf0-f66.google.com ([209.85.215.66]:33372 \"EHLO\n\tmail-lf0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751739AbdITV31 (ORCPT\n\t); Wed, 20 Sep 2017 17:29:27 -0400","by mail-lf0-f66.google.com with SMTP id y15so2024364lfd.0;\n\tWed, 20 Sep 2017 14:29:26 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id 1sm601702ljp.29.2017.09.20.14.29.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 20 Sep 2017 14:29:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=EkdVSkq3Kn7ODB+F6qpxRyVYyfivsWdGPbBVvt77ieM=;\n\tb=Kpo0L5324OapPgaJdae0FXREJKYBebV6At8iE7vkTIg/bBiHf5zRvKktCAWG7h03X/\n\t795kE98fuvrIY0Svo3IWQ37orXPe2MLRSIBt4SrmILm3txKmd0YqtWF0VpauXii22X3+\n\tbu2ft0XAEy7oWARqMW4d8FfEDmNGgUY4eERr7QVdEVRhdRcvygCszi3fDeE+iWsd5gL2\n\tu9rGU7kKu/5keEiCc9svnlFkHTtoRE3cMwdtctPxjuKLKe8y+cAQ259bfvtbAqUQ0oA0\n\tA9RbAMET+7M7wd387AsAYQeHhkpZ/ikKpfJUwpEpU/25o1G/MXvjniUiBcf9aqQd10h7\n\tOXWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=EkdVSkq3Kn7ODB+F6qpxRyVYyfivsWdGPbBVvt77ieM=;\n\tb=Gg/gp6eojA7gb6h4nE7Ve6Ii15fqV8iSCDe/xDz0nKYlafNtO8tlGvINLzu9lGP9k0\n\tS/nGkUYZ7C3PgkCo0Wfy4Cvnx/ze85yNe4KngFicfFkPccUnZdF39fxp0ZtgaTSVO1ip\n\tvrC6ItO7d14eqySQb6lL3b4Msevh72NwXBJd5rsVENzP2rgNqleJT4MUz0QoP6s/uxmA\n\tlf0BtaV9HDI7JvoLoyanIOtuAL+vfzVEoIJsxjR8P0CWQTJkF6yGOiRuAJMSoyJySwND\n\toWlIx5n7csdyjWsLp/KklEO0rexQGyGIrIn53nvqNUbJHhy0JWgRKBdCg0T8j4C3/mrb\n\tlddg==","X-Gm-Message-State":"AHPjjUiNqYtlRNT/2zpsnH2NF4MYcfEatxtmCsxT98tDNljmfsOre5XA\n\tYV8kyO1QWje3QRnuB+mA1G4=","X-Google-Smtp-Source":"AOwi7QC2EhlXLxQCYTwCKWfF8UeGO0VaTQNtj/QU0mcpCeyknikkzmXxQQMv93uf3Ezx6MvEW3A+Zg==","X-Received":"by 10.46.2.19 with SMTP id 19mr39459ljc.0.1505942965452;\n\tWed, 20 Sep 2017 14:29:25 -0700 (PDT)","Date":"Thu, 21 Sep 2017 00:29:28 +0300","From":"Serge Semin ","To":"Rob Herring ","Cc":"richard.leitner@skidata.com, gregkh@linuxfoundation.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170920212928.GC3547@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>\n\t<20170920133735.k3yzh2m6zb5qzhn2@rob-hp-laptop>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170920133735.k3yzh2m6zb5qzhn2@rob-hp-laptop>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772528,"web_url":"http://patchwork.ozlabs.org/comment/1772528/","msgid":"<20170921082338.GA30669@kroah.com>","list_archive_url":null,"date":"2017-09-21T08:23:38","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\n> index 71994b883..c2dd9742f 100644\n> --- a/drivers/usb/misc/usb251xb.c\n> +++ b/drivers/usb/misc/usb251xb.c\n> @@ -3,6 +3,7 @@\n> * Configuration via SMBus.\n> *\n> * Copyright (c) 2017 SKIDATA AG\n> + * Copyright (c) 2017 T-platforms\n\nAgain, no, please consult with your corporate lawyers why this isn't ok.\n\ngreg k-h\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyV4f0QPsz9t3F\n\tfor ;\n\tThu, 21 Sep 2017 18:23:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751847AbdIUIX3 (ORCPT\n\t);\n\tThu, 21 Sep 2017 04:23:29 -0400","from mail.linuxfoundation.org ([140.211.169.12]:38250 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751832AbdIUIX2 (ORCPT\n\t); Thu, 21 Sep 2017 04:23:28 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 17EEBB1D;\n\tThu, 21 Sep 2017 08:23:27 +0000 (UTC)"],"Date":"Thu, 21 Sep 2017 10:23:38 +0200","From":"Greg KH ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170921082338.GA30669@kroah.com>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170916104220.3742-10-fancer.lancer@gmail.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772884,"web_url":"http://patchwork.ozlabs.org/comment/1772884/","msgid":"<20170921145129.GA25888@mobilestation>","list_archive_url":null,"date":"2017-09-21T14:51:29","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Thu, Sep 21, 2017 at 10:23:38AM +0200, Greg KH wrote:\n> On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\n> > index 71994b883..c2dd9742f 100644\n> > --- a/drivers/usb/misc/usb251xb.c\n> > +++ b/drivers/usb/misc/usb251xb.c\n> > @@ -3,6 +3,7 @@\n> > * Configuration via SMBus.\n> > *\n> > * Copyright (c) 2017 SKIDATA AG\n> > + * Copyright (c) 2017 T-platforms\n> \n> Again, no, please consult with your corporate lawyers why this isn't ok.\n> \n> greg k-h\n\nI still can't see why this isn't right. We submitted the patchset. It is not\nthat big and still it isn't just two lines. As I've seen all over the kernel, It is\na common practice to have multiple copyrights in kernel files. We are not claiming\nthe copyright to the whole file, but to the contribution only. I got a consent to\ncontribute when I was employed by the company. What's wrong with that? Shall I\nsend the patchset from my corporate e-mail then?\n\n-Sergey\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XiWkvrNy\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyfh21JsXz9t3w\n\tfor ;\n\tFri, 22 Sep 2017 00:51:30 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751768AbdIUOv2 (ORCPT\n\t);\n\tThu, 21 Sep 2017 10:51:28 -0400","from mail-lf0-f66.google.com ([209.85.215.66]:38134 \"EHLO\n\tmail-lf0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751763AbdIUOv1 (ORCPT\n\t); Thu, 21 Sep 2017 10:51:27 -0400","by mail-lf0-f66.google.com with SMTP id m199so3126881lfe.5;\n\tThu, 21 Sep 2017 07:51:26 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id\n\tf16sm249216lfe.66.2017.09.21.07.51.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 21 Sep 2017 07:51:24 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=Dh0BvqphDIrA5PBvACapKBjLWywk9UuYKMShC2ypYVE=;\n\tb=XiWkvrNyH3ZdeqoyuP7MvmYTTUHfa2CzBu0u4V0bVm/rxFZ2uFRjp6tm/sU8F+Hy5W\n\tgodL5awB/ZSZM3m4zXZgO2NH4/hr6sazr0yxeRjeJO9YWQ26SaUgOMtWb42T5TxMauAL\n\tRtdQk6HP5WFzkGkuc+ei+S3UBrHxFV8UFY9RsQ4AOAIX4/U7nRanyMTaJuZjeTiSR7Lr\n\t4tRaUAod2rzEU6ZD0QkdnU5xfiKtLM+lmNqiJuFAq5Uk3XA8uwjo9s7UzbGZEmL1bVMR\n\tu9Z4a+pCMN6lD2iOEnw8cVhSrYHVVeXJcsTFziFaIZgDj6g9dOJsGU/7N2u+kvJLkNXo\n\t8Viw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=Dh0BvqphDIrA5PBvACapKBjLWywk9UuYKMShC2ypYVE=;\n\tb=nBZqFEoBMUDCC3T76mAGgpnXAqQltEJHRhIaZFJrvUtdCfOLUK0xtBWJSQGZ/4TvoI\n\tdzQm5iNhFBQx7/UlRDCsrhKwtI2Dm11AUK11s9OzWlqNS8CZRppRlgqAiHmuJUsa4wfq\n\tdufX25aj7CDa7O+N7711i4Jt5iABR5dhLoQi00S2TsJ837AtrNGydFTLQ0QhL2jla4Od\n\tzg9GpOZm2DIlRTUrVXIPpPHAzCsAGHFm1NTszRklnsTWmxgpouEP2T46kJvLLXBwxph0\n\tZuQE9h2u4z3GT2jS4O3ahTMxXJSdUuMfSaZ8NMaohy2jC/2rWmk/Tpu1fl0/z0Q8EDyE\n\tYsAA==","X-Gm-Message-State":"AHPjjUg5ooO/X9cIpg13s3cmC2cVuUfQ2p1SITi6DGUGux8T8sopn9T8\n\tJmSB1BmqG3ZseaA8x5wSDBc=","X-Google-Smtp-Source":"AOwi7QDZ0iwZqD5iFuf2OxN3fGphHHH4GV07hReQ466VfcLx0ta8NSLHMaAQZlBpms4aCgx+Qpn58w==","X-Received":"by 10.25.23.105 with SMTP id n102mr945707lfi.252.1506005485751; \n\tThu, 21 Sep 2017 07:51:25 -0700 (PDT)","Date":"Thu, 21 Sep 2017 17:51:29 +0300","From":"Serge Semin ","To":"Greg KH ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170921145129.GA25888@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>\n\t<20170921082338.GA30669@kroah.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921082338.GA30669@kroah.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1772905,"web_url":"http://patchwork.ozlabs.org/comment/1772905/","msgid":"<20170921150714.GA7791@kroah.com>","list_archive_url":null,"date":"2017-09-21T15:07:14","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Thu, Sep 21, 2017 at 05:51:29PM +0300, Serge Semin wrote:\n> On Thu, Sep 21, 2017 at 10:23:38AM +0200, Greg KH wrote:\n> > On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\n> > > index 71994b883..c2dd9742f 100644\n> > > --- a/drivers/usb/misc/usb251xb.c\n> > > +++ b/drivers/usb/misc/usb251xb.c\n> > > @@ -3,6 +3,7 @@\n> > > * Configuration via SMBus.\n> > > *\n> > > * Copyright (c) 2017 SKIDATA AG\n> > > + * Copyright (c) 2017 T-platforms\n> > \n> > Again, no, please consult with your corporate lawyers why this isn't ok.\n> > \n> > greg k-h\n> \n> I still can't see why this isn't right. We submitted the patchset. It is not\n> that big and still it isn't just two lines. As I've seen all over the kernel, It is\n> a common practice to have multiple copyrights in kernel files. We are not claiming\n> the copyright to the whole file, but to the contribution only. I got a consent to\n> contribute when I was employed by the company. What's wrong with that? Shall I\n> send the patchset from my corporate e-mail then?\n\nWell, yes, I need some way to properly identify that this corporation\ndid do the changes. I said that before, I don't know why you ignored\nthat.\n\nAnd yes, multiple copyrights are just fine, but again, please talk to\nyour corporate lawyer about why these changes don't seem to warrant that\n\"mark\". If they do think that they do warrant that, great, I will be\nglad to discuss that with them, off-list if needed.\n\nFor even more fun, try discussing with your lawyers about why copyright\nmarks like this don't even mean anything anymore, and haven't for 20+\nyears now (can't remember the actual date...) But that's a different\ntopic, and one not really relevant here.\n\nthanks,\n\ngreg k-h\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xyg230BLdz9t3w\n\tfor ;\n\tFri, 22 Sep 2017 01:07:07 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751839AbdIUPHF (ORCPT\n\t);\n\tThu, 21 Sep 2017 11:07:05 -0400","from mail.linuxfoundation.org ([140.211.169.12]:36732 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751739AbdIUPHE (ORCPT\n\t); Thu, 21 Sep 2017 11:07:04 -0400","from localhost (LFbn-1-12253-150.w90-92.abo.wanadoo.fr\n\t[90.92.67.150])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id D0F1187A;\n\tThu, 21 Sep 2017 15:07:03 +0000 (UTC)"],"Date":"Thu, 21 Sep 2017 17:07:14 +0200","From":"Greg KH ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170921150714.GA7791@kroah.com>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>\n\t<20170921082338.GA30669@kroah.com>\n\t<20170921145129.GA25888@mobilestation>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921145129.GA25888@mobilestation>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773694,"web_url":"http://patchwork.ozlabs.org/comment/1773694/","msgid":"<20170922152654.GA10152@mobilestation>","list_archive_url":null,"date":"2017-09-22T15:26:54","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":70038,"url":"http://patchwork.ozlabs.org/api/people/70038/","name":"Serge Semin","email":"fancer.lancer@gmail.com"},"content":"On Thu, Sep 21, 2017 at 05:07:14PM +0200, Greg KH wrote:\n> On Thu, Sep 21, 2017 at 05:51:29PM +0300, Serge Semin wrote:\n> > On Thu, Sep 21, 2017 at 10:23:38AM +0200, Greg KH wrote:\n> > > On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> > > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\n> > > > index 71994b883..c2dd9742f 100644\n> > > > --- a/drivers/usb/misc/usb251xb.c\n> > > > +++ b/drivers/usb/misc/usb251xb.c\n> > > > @@ -3,6 +3,7 @@\n> > > > * Configuration via SMBus.\n> > > > *\n> > > > * Copyright (c) 2017 SKIDATA AG\n> > > > + * Copyright (c) 2017 T-platforms\n> > > \n> > > Again, no, please consult with your corporate lawyers why this isn't ok.\n> > > \n> > > greg k-h\n> > \n> > I still can't see why this isn't right. We submitted the patchset. It is not\n> > that big and still it isn't just two lines. As I've seen all over the kernel, It is\n> > a common practice to have multiple copyrights in kernel files. We are not claiming\n> > the copyright to the whole file, but to the contribution only. I got a consent to\n> > contribute when I was employed by the company. What's wrong with that? Shall I\n> > send the patchset from my corporate e-mail then?\n> \n> Well, yes, I need some way to properly identify that this corporation\n> did do the changes. I said that before, I don't know why you ignored\n> that.\n> \n> And yes, multiple copyrights are just fine, but again, please talk to\n> your corporate lawyer about why these changes don't seem to warrant that\n> \"mark\". If they do think that they do warrant that, great, I will be\n> glad to discuss that with them, off-list if needed.\n> \n> For even more fun, try discussing with your lawyers about why copyright\n> marks like this don't even mean anything anymore, and haven't for 20+\n> years now (can't remember the actual date...) But that's a different\n> topic, and one not really relevant here.\n> \n> thanks,\n> \n> greg k-h\n\nAlright then. We'll remove the Copyright mark and I'll resend the patchset\nfrom my corporate e-mail. Hope it will solve this issue.\nCould you review the rest of the patchset?\n\nRegards,\n-Sergey\n\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"BepOQ1GB\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzHQY3dGRz9t3h\n\tfor ;\n\tSat, 23 Sep 2017 01:27:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752115AbdIVP07 (ORCPT\n\t);\n\tFri, 22 Sep 2017 11:26:59 -0400","from mail-lf0-f67.google.com ([209.85.215.67]:35706 \"EHLO\n\tmail-lf0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752078AbdIVP06 (ORCPT\n\t); Fri, 22 Sep 2017 11:26:58 -0400","by mail-lf0-f67.google.com with SMTP id c8so783899lfe.2;\n\tFri, 22 Sep 2017 08:26:57 -0700 (PDT)","from mobilestation ([95.79.181.62])\n\tby smtp.gmail.com with ESMTPSA id\n\ta16sm14971ljf.28.2017.09.22.08.26.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 22 Sep 2017 08:26:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=SR25cqWd0a9Rj8NXxS4iwJvt+jywu/TTZUXr/hlgNFY=;\n\tb=BepOQ1GBDKc4jnpugxlFspa+uMINRiz6dHwLJYla9Ongdm/r5oFv9TFjehlk+w7nnZ\n\tIND9X5idjNyxukYGBLW6xGKmoIW67IcPBgrK2NTe/zs09uRg2MjGXF+2Nc3+B/iyZSZL\n\t9SjUsLqMmiQaVT4rcR0Ofxma8in/eR9ed37tVxYI+YQD/2PW84LSvlRvLMjwKV5q23ze\n\t54Xj+H9w7V2raD4NHeJ6eRXfEVr50lKlpLQJzf+yWdw662x00O/LvbR2M7NxgPt6p5UL\n\tXj2+G9chnIiNHVLi08BlMOah8kYpnNqQ1BHGspiR+DDv2NxEZmj5OdHjIq5RPufERoVf\n\tjD1w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=SR25cqWd0a9Rj8NXxS4iwJvt+jywu/TTZUXr/hlgNFY=;\n\tb=UfXsO4Ne4SuIypDusl9SIxpTNK8LA7Wc+lGL+rg6ycye113nzhmOvChYvKydomwg/e\n\tVENya4JLgR1M4Tt6fnI+YrOUSMoFZQkTRUCWtfQFAX6gnQ8ABGePboboV7MmRmIHLMGA\n\tvcGLMYASzPap+3trX+H4AcWxyyiYbV/WgAfMnCZ6uexb+nOM7AFthotMhAmAgDJ7HL1O\n\tooi/EcqPZ4dE7NBFmhZS1rAzwOYQldGB396Wxtt7PJlB57+knzruyBp3XKVo5Y0ei+fP\n\tlg+pAbIBnfSpEDYIBKr39rVIXM3fxn0Ujxvat9jX8XEVKwbw0Ke9ClEMnWIyIYfeQXgo\n\tkohg==","X-Gm-Message-State":"AHPjjUhpOe+//GiyfsE8WpVTOIAAF2pfNnF8B11UKI1c6y3hG5rjqgzc\n\tusDs+8Wb04CBoya+B9sJ8II=","X-Google-Smtp-Source":"AOwi7QA7vh1UGf6q18VpvrZ23MVJ+oVCyt8GC9+dRLqXPdQi+b9UTIxhtmpAXEHklrOU5vSrkyuxRQ==","X-Received":"by 10.46.83.17 with SMTP id h17mr2708603ljb.158.1506094016576;\n\tFri, 22 Sep 2017 08:26:56 -0700 (PDT)","Date":"Fri, 22 Sep 2017 18:26:54 +0300","From":"Serge Semin ","To":"Greg KH ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170922152654.GA10152@mobilestation>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>\n\t<20170921082338.GA30669@kroah.com>\n\t<20170921145129.GA25888@mobilestation>\n\t<20170921150714.GA7791@kroah.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170921150714.GA7791@kroah.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773715,"web_url":"http://patchwork.ozlabs.org/comment/1773715/","msgid":"<20170922160520.GA1310@kroah.com>","list_archive_url":null,"date":"2017-09-22T16:05:20","subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","submitter":{"id":11800,"url":"http://patchwork.ozlabs.org/api/people/11800/","name":"Greg Kroah-Hartman","email":"gregkh@linuxfoundation.org"},"content":"On Fri, Sep 22, 2017 at 06:26:54PM +0300, Serge Semin wrote:\n> On Thu, Sep 21, 2017 at 05:07:14PM +0200, Greg KH wrote:\n> > On Thu, Sep 21, 2017 at 05:51:29PM +0300, Serge Semin wrote:\n> > > On Thu, Sep 21, 2017 at 10:23:38AM +0200, Greg KH wrote:\n> > > > On Sat, Sep 16, 2017 at 01:42:20PM +0300, Serge Semin wrote:\n> > > > > diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c\n> > > > > index 71994b883..c2dd9742f 100644\n> > > > > --- a/drivers/usb/misc/usb251xb.c\n> > > > > +++ b/drivers/usb/misc/usb251xb.c\n> > > > > @@ -3,6 +3,7 @@\n> > > > > * Configuration via SMBus.\n> > > > > *\n> > > > > * Copyright (c) 2017 SKIDATA AG\n> > > > > + * Copyright (c) 2017 T-platforms\n> > > > \n> > > > Again, no, please consult with your corporate lawyers why this isn't ok.\n> > > > \n> > > > greg k-h\n> > > \n> > > I still can't see why this isn't right. We submitted the patchset. It is not\n> > > that big and still it isn't just two lines. As I've seen all over the kernel, It is\n> > > a common practice to have multiple copyrights in kernel files. We are not claiming\n> > > the copyright to the whole file, but to the contribution only. I got a consent to\n> > > contribute when I was employed by the company. What's wrong with that? Shall I\n> > > send the patchset from my corporate e-mail then?\n> > \n> > Well, yes, I need some way to properly identify that this corporation\n> > did do the changes. I said that before, I don't know why you ignored\n> > that.\n> > \n> > And yes, multiple copyrights are just fine, but again, please talk to\n> > your corporate lawyer about why these changes don't seem to warrant that\n> > \"mark\". If they do think that they do warrant that, great, I will be\n> > glad to discuss that with them, off-list if needed.\n> > \n> > For even more fun, try discussing with your lawyers about why copyright\n> > marks like this don't even mean anything anymore, and haven't for 20+\n> > years now (can't remember the actual date...) But that's a different\n> > topic, and one not really relevant here.\n> > \n> > thanks,\n> > \n> > greg k-h\n> \n> Alright then. We'll remove the Copyright mark and I'll resend the patchset\n> from my corporate e-mail. Hope it will solve this issue.\n> Could you review the rest of the patchset?\n\nI'll wait for the resend, as Rob already pointed out issues, so it is\nlong-gone from my patchqueue.\n\nthanks,\n\ngreg k-h\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xzJH759QHz9s83\n\tfor ;\n\tSat, 23 Sep 2017 02:05:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752297AbdIVQFO (ORCPT\n\t);\n\tFri, 22 Sep 2017 12:05:14 -0400","from mail.linuxfoundation.org ([140.211.169.12]:51892 \"EHLO\n\tmail.linuxfoundation.org\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751877AbdIVQFM (ORCPT\n\t); Fri, 22 Sep 2017 12:05:12 -0400","from localhost (unknown [37.171.167.242])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPSA id 8D878904;\n\tFri, 22 Sep 2017 16:05:11 +0000 (UTC)"],"Date":"Fri, 22 Sep 2017 18:05:20 +0200","From":"Greg KH ","To":"Serge Semin ","Cc":"richard.leitner@skidata.com, robh+dt@kernel.org,\n\tmark.rutland@arm.com, Sergey.Semin@t-platforms.ru,\n\tlinux-usb@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer\n\tinterface","Message-ID":"<20170922160520.GA1310@kroah.com>","References":"<20170915233113.17855-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-1-fancer.lancer@gmail.com>\n\t<20170916104220.3742-10-fancer.lancer@gmail.com>\n\t<20170921082338.GA30669@kroah.com>\n\t<20170921145129.GA25888@mobilestation>\n\t<20170921150714.GA7791@kroah.com>\n\t<20170922152654.GA10152@mobilestation>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170922152654.GA10152@mobilestation>","User-Agent":"Mutt/1.9.0 (2017-09-02)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]