[{"id":1769580,"web_url":"http://patchwork.ozlabs.org/comment/1769580/","msgid":"<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>","list_archive_url":null,"date":"2017-09-16T09:02:25","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":15842,"url":"http://patchwork.ozlabs.org/api/people/15842/","name":"Ying Xue","email":"ying.xue@windriver.com"},"content":"On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n> Use common library function rather than explicitly coding\n> some variant of it yourself.\n> \n> Signed-off-by: Thomas Meyer \n\nAcked-by: Ying Xue \n\n> ---\n> net/tipc/name_table.c | 30 +++++++++++++++---------------\n> 1 file changed, 15 insertions(+), 15 deletions(-)\n> \n> V2: Coding style\n> \n> diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c\n> index bd0aac87b41a..eeb4d7a13de2 100644\n> --- a/net/tipc/name_table.c\n> +++ b/net/tipc/name_table.c\n> @@ -44,6 +44,7 @@\n> #include \"addr.h\"\n> #include \"node.h\"\n> #include \n> +#include \n> \n> #define TIPC_NAMETBL_SIZE 1024\t\t/* must be a power of 2 */\n> \n> @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n> \treturn nseq;\n> }\n> \n> +static int nameseq_find_subseq_cmp(const void *key, const void *elt)\n> +{\n> +\tstruct sub_seq *sseq = (struct sub_seq *)elt;\n> +\tu32 instance = *(u32 *)key;\n> +\n> +\tif (instance < sseq->lower)\n> +\t\treturn -1;\n> +\telse if (instance > sseq->upper)\n> +\t\treturn 1;\n> +\treturn 0;\n> +}\n> +\n> /**\n> * nameseq_find_subseq - find sub-sequence (if any) matching a name instance\n> *\n> @@ -176,21 +189,8 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n> static struct sub_seq *nameseq_find_subseq(struct name_seq *nseq,\n> \t\t\t\t\t u32 instance)\n> {\n> -\tstruct sub_seq *sseqs = nseq->sseqs;\n> -\tint low = 0;\n> -\tint high = nseq->first_free - 1;\n> -\tint mid;\n> -\n> -\twhile (low <= high) {\n> -\t\tmid = (low + high) / 2;\n> -\t\tif (instance < sseqs[mid].lower)\n> -\t\t\thigh = mid - 1;\n> -\t\telse if (instance > sseqs[mid].upper)\n> -\t\t\tlow = mid + 1;\n> -\t\telse\n> -\t\t\treturn &sseqs[mid];\n> -\t}\n> -\treturn NULL;\n> +\treturn bsearch(&instance, nseq->sseqs, nseq->first_free,\n> +\t\t sizeof(struct sub_seq), nameseq_find_subseq_cmp);\n> }\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvRCw5y3Mz9t2Q\n\tfor ;\n\tSat, 16 Sep 2017 19:04:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751262AbdIPJEM (ORCPT );\n\tSat, 16 Sep 2017 05:04:12 -0400","from mail5.windriver.com ([192.103.53.11]:49736 \"EHLO\n\tmail5.wrs.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751170AbdIPJEK (ORCPT );\n\tSat, 16 Sep 2017 05:04:10 -0400","from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v8G93gBl026177\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=OK);\n\tSat, 16 Sep 2017 02:03:42 -0700","from [128.224.155.110] (128.224.155.110) by ALA-HCA.corp.ad.wrs.com\n\t(147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tSat, 16 Sep 2017 02:03:40 -0700"],"Subject":"Re: [PATCH V2] tipc: Use bsearch library function","To":"Thomas Meyer , ,\n\t, ,\n\t, ","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>","From":"Ying Xue ","Message-ID":"<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>","Date":"Sat, 16 Sep 2017 17:02:25 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170916075036.28676-1-thomas@m3y3r.de>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[128.224.155.110]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769582,"web_url":"http://patchwork.ozlabs.org/comment/1769582/","msgid":"<1505553970.16316.1.camel@perches.com>","list_archive_url":null,"date":"2017-09-16T09:26:10","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n> On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n> > Use common library function rather than explicitly coding\n> > some variant of it yourself.\n> > \n> > Signed-off-by: Thomas Meyer \n> \n> Acked-by: Ying Xue \n\nAre you sure you want to do this?\n\nNote the comment above nameseq_find_subseq\n\n * Very time-critical, so binary searches through sub-sequence array.\n\nWhat impact does this change have on performance?\n\n> > diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c\n> > index bd0aac87b41a..eeb4d7a13de2 100644\n> > --- a/net/tipc/name_table.c\n> > +++ b/net/tipc/name_table.c\n> > @@ -44,6 +44,7 @@\n> > #include \"addr.h\"\n> > #include \"node.h\"\n> > #include \n> > +#include \n> > \n> > #define TIPC_NAMETBL_SIZE 1024\t\t/* must be a power of 2 */\n> > \n> > @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n> > \treturn nseq;\n> > }\n> > \n> > +static int nameseq_find_subseq_cmp(const void *key, const void *elt)\n> > +{\n> > +\tstruct sub_seq *sseq = (struct sub_seq *)elt;\n> > +\tu32 instance = *(u32 *)key;\n> > +\n> > +\tif (instance < sseq->lower)\n> > +\t\treturn -1;\n> > +\telse if (instance > sseq->upper)\n> > +\t\treturn 1;\n> > +\treturn 0;\n> > +}\n> > +\n> > /**\n> > * nameseq_find_subseq - find sub-sequence (if any) matching a name instance\n> > *\n> > @@ -176,21 +189,8 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n> > static struct sub_seq *nameseq_find_subseq(struct name_seq *nseq,\n> > \t\t\t\t\t u32 instance)\n> > {\n> > -\tstruct sub_seq *sseqs = nseq->sseqs;\n> > -\tint low = 0;\n> > -\tint high = nseq->first_free - 1;\n> > -\tint mid;\n> > -\n> > -\twhile (low <= high) {\n> > -\t\tmid = (low + high) / 2;\n> > -\t\tif (instance < sseqs[mid].lower)\n> > -\t\t\thigh = mid - 1;\n> > -\t\telse if (instance > sseqs[mid].upper)\n> > -\t\t\tlow = mid + 1;\n> > -\t\telse\n> > -\t\t\treturn &sseqs[mid];\n> > -\t}\n> > -\treturn NULL;\n> > +\treturn bsearch(&instance, nseq->sseqs, nseq->first_free,\n> > +\t\t sizeof(struct sub_seq), nameseq_find_subseq_cmp);\n> > }\n> > \n> > /**\n> >","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvRjd1msHz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 19:26:45 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751233AbdIPJ0P (ORCPT );\n\tSat, 16 Sep 2017 05:26:15 -0400","from smtprelay0197.hostedemail.com ([216.40.44.197]:45392 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1750909AbdIPJ0O (ORCPT\n\t); Sat, 16 Sep 2017 05:26:14 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay03.hostedemail.com (Postfix) with ESMTP id 32AEF837F243; \n\tSat, 16 Sep 2017 09:26:13 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf04.hostedemail.com (Postfix) with ESMTPA;\n\tSat, 16 Sep 2017 09:26:11 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::,\n\tRULES_HIT:41:355:379:541:599:800:960:966:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3872:3873:4321:4385:4605:5007:7875:8527:10004:10400:10848:10903:11026:11232:11473:11658:11914:12048:12296:12438:12555:12740:12895:13180:13229:13439:13894:14181:14659:14721:21080:21324:21451:21611:21627:30029:30054:30070:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none","X-HE-Tag":"cream64_8d70a65bcfe13","X-Filterd-Recvd-Size":"3208","Message-ID":"<1505553970.16316.1.camel@perches.com>","Subject":"Re: [PATCH V2] tipc: Use bsearch library function","From":"Joe Perches ","To":"Ying Xue , Thomas Meyer ,\n\tjon.maloy@ericsson.com, netdev@vger.kernel.org,\n\ttipc-discussion@lists.sourceforge.net,\n\tlinux-kernel@vger.kernel.org, davem@davemloft.net","Date":"Sat, 16 Sep 2017 02:26:10 -0700","In-Reply-To":"<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"8bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769583,"web_url":"http://patchwork.ozlabs.org/comment/1769583/","msgid":"<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>","list_archive_url":null,"date":"2017-09-16T09:36:33","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":15842,"url":"http://patchwork.ozlabs.org/api/people/15842/","name":"Ying Xue","email":"ying.xue@windriver.com"},"content":"On 09/16/2017 05:26 PM, Joe Perches wrote:\n> On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n>> On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n>>> Use common library function rather than explicitly coding\n>>> some variant of it yourself.\n>>>\n>>> Signed-off-by: Thomas Meyer \n>>\n>> Acked-by: Ying Xue \n> \n> Are you sure you want to do this?\n> \n> Note the comment above nameseq_find_subseq\n> \n> * Very time-critical, so binary searches through sub-sequence array.\n> \n> What impact does this change have on performance?\n\nSorry, I couldn't see any essential difference between this new\nimplementation and the original one except that the former tries to use\nthe library function - bsearch() to replace the original binary search\nalgorithm implemented in TIPC itself. Therefore, I don't think the\nchange will have a big impact on performance.\n\nIf I miss something, please let me know.\n\nThanks,\nYing\n\n> \n>>> diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c\n>>> index bd0aac87b41a..eeb4d7a13de2 100644\n>>> --- a/net/tipc/name_table.c\n>>> +++ b/net/tipc/name_table.c\n>>> @@ -44,6 +44,7 @@\n>>> #include \"addr.h\"\n>>> #include \"node.h\"\n>>> #include \n>>> +#include \n>>> \n>>> #define TIPC_NAMETBL_SIZE 1024\t\t/* must be a power of 2 */\n>>> \n>>> @@ -168,6 +169,18 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n>>> \treturn nseq;\n>>> }\n>>> \n>>> +static int nameseq_find_subseq_cmp(const void *key, const void *elt)\n>>> +{\n>>> +\tstruct sub_seq *sseq = (struct sub_seq *)elt;\n>>> +\tu32 instance = *(u32 *)key;\n>>> +\n>>> +\tif (instance < sseq->lower)\n>>> +\t\treturn -1;\n>>> +\telse if (instance > sseq->upper)\n>>> +\t\treturn 1;\n>>> +\treturn 0;\n>>> +}\n>>> +\n>>> /**\n>>> * nameseq_find_subseq - find sub-sequence (if any) matching a name instance\n>>> *\n>>> @@ -176,21 +189,8 @@ static struct name_seq *tipc_nameseq_create(u32 type, struct hlist_head *seq_hea\n>>> static struct sub_seq *nameseq_find_subseq(struct name_seq *nseq,\n>>> \t\t\t\t\t u32 instance)\n>>> {\n>>> -\tstruct sub_seq *sseqs = nseq->sseqs;\n>>> -\tint low = 0;\n>>> -\tint high = nseq->first_free - 1;\n>>> -\tint mid;\n>>> -\n>>> -\twhile (low <= high) {\n>>> -\t\tmid = (low + high) / 2;\n>>> -\t\tif (instance < sseqs[mid].lower)\n>>> -\t\t\thigh = mid - 1;\n>>> -\t\telse if (instance > sseqs[mid].upper)\n>>> -\t\t\tlow = mid + 1;\n>>> -\t\telse\n>>> -\t\t\treturn &sseqs[mid];\n>>> -\t}\n>>> -\treturn NULL;\n>>> +\treturn bsearch(&instance, nseq->sseqs, nseq->first_free,\n>>> +\t\t sizeof(struct sub_seq), nameseq_find_subseq_cmp);\n>>> }\n>>> \n>>> /**\n>>>\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvRzM1T70z9s03\n\tfor ;\n\tSat, 16 Sep 2017 19:38:39 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751248AbdIPJi1 (ORCPT );\n\tSat, 16 Sep 2017 05:38:27 -0400","from mail5.windriver.com ([192.103.53.11]:50160 \"EHLO\n\tmail5.wrs.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751050AbdIPJi0 (ORCPT );\n\tSat, 16 Sep 2017 05:38:26 -0400","from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v8G9boxS027101\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=OK);\n\tSat, 16 Sep 2017 02:37:50 -0700","from [128.224.155.110] (128.224.155.110) by ALA-HCA.corp.ad.wrs.com\n\t(147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tSat, 16 Sep 2017 02:37:49 -0700"],"Subject":"Re: [PATCH V2] tipc: Use bsearch library function","To":"Joe Perches , Thomas Meyer ,\n\t, ,\n\t,\n\t, ","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>","From":"Ying Xue ","Message-ID":"<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>","Date":"Sat, 16 Sep 2017 17:36:33 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1505553970.16316.1.camel@perches.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[128.224.155.110]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769587,"web_url":"http://patchwork.ozlabs.org/comment/1769587/","msgid":"<1505555908.16316.5.camel@perches.com>","list_archive_url":null,"date":"2017-09-16T09:58:28","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote:\n> On 09/16/2017 05:26 PM, Joe Perches wrote:\n> > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n> > > On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n> > > > Use common library function rather than explicitly coding\n> > > > some variant of it yourself.\n> > > > \n> > > > Signed-off-by: Thomas Meyer \n> > > \n> > > Acked-by: Ying Xue \n> > \n> > Are you sure you want to do this?\n> > \n> > Note the comment above nameseq_find_subseq\n> > \n> > * Very time-critical, so binary searches through sub-sequence array.\n> > \n> > What impact does this change have on performance?\n> \n> Sorry, I couldn't see any essential difference between this new\n> implementation and the original one except that the former tries to use\n> the library function - bsearch() to replace the original binary search\n> algorithm implemented in TIPC itself. Therefore, I don't think the\n> change will have a big impact on performance.\n> \n> If I miss something, please let me know.\n\nComparison via a function pointer in bsearch is slower\nthan direct code without the function call overhead.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvSRC0VBbz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 19:59:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751288AbdIPJ6d (ORCPT );\n\tSat, 16 Sep 2017 05:58:33 -0400","from smtprelay0199.hostedemail.com ([216.40.44.199]:56558 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751050AbdIPJ6b (ORCPT\n\t); Sat, 16 Sep 2017 05:58:31 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay07.hostedemail.com (Postfix) with ESMTP id 0082E181D3417; \n\tSat, 16 Sep 2017 09:58:30 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf12.hostedemail.com (Postfix) with ESMTPA;\n\tSat, 16 Sep 2017 09:58:29 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::,\n\tRULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:7875:8527:8660:10004:10400:10848:10903:11026:11232:11658:11914:12048:12740:12760:12895:13069:13148:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21611:21627:30012:30054:30070:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none","X-HE-Tag":"tray75_84603b669261c","X-Filterd-Recvd-Size":"2240","Message-ID":"<1505555908.16316.5.camel@perches.com>","Subject":"Re: [PATCH V2] tipc: Use bsearch library function","From":"Joe Perches ","To":"Ying Xue , Thomas Meyer ,\n\tjon.maloy@ericsson.com, netdev@vger.kernel.org,\n\ttipc-discussion@lists.sourceforge.net,\n\tlinux-kernel@vger.kernel.org, davem@davemloft.net","Date":"Sat, 16 Sep 2017 02:58:28 -0700","In-Reply-To":"<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769591,"web_url":"http://patchwork.ozlabs.org/comment/1769591/","msgid":"<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>","list_archive_url":null,"date":"2017-09-16T10:10:57","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":15842,"url":"http://patchwork.ozlabs.org/api/people/15842/","name":"Ying Xue","email":"ying.xue@windriver.com"},"content":"On 09/16/2017 05:58 PM, Joe Perches wrote:\n> On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote:\n>> On 09/16/2017 05:26 PM, Joe Perches wrote:\n>>> On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n>>>> On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n>>>>> Use common library function rather than explicitly coding\n>>>>> some variant of it yourself.\n>>>>>\n>>>>> Signed-off-by: Thomas Meyer \n>>>>\n>>>> Acked-by: Ying Xue \n>>>\n>>> Are you sure you want to do this?\n>>>\n>>> Note the comment above nameseq_find_subseq\n>>>\n>>> * Very time-critical, so binary searches through sub-sequence array.\n>>>\n>>> What impact does this change have on performance?\n>>\n>> Sorry, I couldn't see any essential difference between this new\n>> implementation and the original one except that the former tries to use\n>> the library function - bsearch() to replace the original binary search\n>> algorithm implemented in TIPC itself. Therefore, I don't think the\n>> change will have a big impact on performance.\n>>\n>> If I miss something, please let me know.\n> \n> Comparison via a function pointer in bsearch is slower\n> than direct code without the function call overhead.\n> \n\nRight, but probably we can tolerate the slight sacrifice here.\n\n>","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvSlf4gH0z9t2l\n\tfor ;\n\tSat, 16 Sep 2017 20:13:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751218AbdIPKNU (ORCPT );\n\tSat, 16 Sep 2017 06:13:20 -0400","from mail5.windriver.com ([192.103.53.11]:50374 \"EHLO\n\tmail5.wrs.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751161AbdIPKNT (ORCPT );\n\tSat, 16 Sep 2017 06:13:19 -0400","from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com\n\t[147.11.189.40])\n\tby mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id v8GACEQn027662\n\t(version=TLSv1 cipher=AES128-SHA bits=128 verify=OK);\n\tSat, 16 Sep 2017 03:12:14 -0700","from [128.224.155.110] (128.224.155.110) by ALA-HCA.corp.ad.wrs.com\n\t(147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.361.1;\n\tSat, 16 Sep 2017 03:12:13 -0700"],"Subject":"Re: [PATCH V2] tipc: Use bsearch library function","To":"Joe Perches , Thomas Meyer ,\n\t, ,\n\t,\n\t, ","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>","From":"Ying Xue ","Message-ID":"<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>","Date":"Sat, 16 Sep 2017 18:10:57 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<1505555908.16316.5.camel@perches.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Originating-IP":"[128.224.155.110]","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769594,"web_url":"http://patchwork.ozlabs.org/comment/1769594/","msgid":"<1505557061.16316.7.camel@perches.com>","list_archive_url":null,"date":"2017-09-16T10:17:41","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Sat, 2017-09-16 at 18:10 +0800, Ying Xue wrote:\n> On 09/16/2017 05:58 PM, Joe Perches wrote:\n> > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote:\n> > > On 09/16/2017 05:26 PM, Joe Perches wrote:\n> > > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n> > > > > On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n> > > > > > Use common library function rather than explicitly coding\n> > > > > > some variant of it yourself.\n> > > > > > \n> > > > > > Signed-off-by: Thomas Meyer \n> > > > > \n> > > > > Acked-by: Ying Xue \n> > > > \n> > > > Are you sure you want to do this?\n> > > > \n> > > > Note the comment above nameseq_find_subseq\n> > > > \n> > > > * Very time-critical, so binary searches through sub-sequence array.\n> > > > \n> > > > What impact does this change have on performance?\n> > > \n> > > Sorry, I couldn't see any essential difference between this new\n> > > implementation and the original one except that the former tries to use\n> > > the library function - bsearch() to replace the original binary search\n> > > algorithm implemented in TIPC itself. Therefore, I don't think the\n> > > change will have a big impact on performance.\n> > > \n> > > If I miss something, please let me know.\n> > \n> > Comparison via a function pointer in bsearch is slower\n> > than direct code without the function call overhead.\n> > \n> \n> Right, but probably we can tolerate the slight sacrifice here.\n\nWhat part of \"very time critical\" have you verified\nand benchmarked as inconsequential?\n\nPlease post your results.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvSrj0ydLz9s7p\n\tfor ;\n\tSat, 16 Sep 2017 20:17:57 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751290AbdIPKRq (ORCPT );\n\tSat, 16 Sep 2017 06:17:46 -0400","from smtprelay0002.hostedemail.com ([216.40.44.2]:48994 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751182AbdIPKRo (ORCPT\n\t); Sat, 16 Sep 2017 06:17:44 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay01.hostedemail.com (Postfix) with ESMTP id 07BAF100E8009; \n\tSat, 16 Sep 2017 10:17:44 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf02.hostedemail.com (Postfix) with ESMTPA;\n\tSat, 16 Sep 2017 10:17:42 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::,\n\tRULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1381:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3354:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:7875:8527:8660:10004:10400:10848:10903:11026:11232:11658:11914:12048:12740:12760:12895:13069:13148:13230:13311:13357:13439:14096:14097:14181:14659:14721:21080:21451:21611:21627:30012:30054:30070:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none","X-HE-Tag":"slope35_92047e48aa09","X-Filterd-Recvd-Size":"2747","Message-ID":"<1505557061.16316.7.camel@perches.com>","Subject":"Re: [PATCH V2] tipc: Use bsearch library function","From":"Joe Perches ","To":"Ying Xue , Thomas Meyer ,\n\tjon.maloy@ericsson.com, netdev@vger.kernel.org,\n\ttipc-discussion@lists.sourceforge.net,\n\tlinux-kernel@vger.kernel.org, davem@davemloft.net","Date":"Sat, 16 Sep 2017 03:17:41 -0700","In-Reply-To":"<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769603,"web_url":"http://patchwork.ozlabs.org/comment/1769603/","msgid":"","list_archive_url":null,"date":"2017-09-16T13:20:28","subject":"RE: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":3953,"url":"http://patchwork.ozlabs.org/api/people/3953/","name":"Jon Maloy","email":"jon.maloy@ericsson.com"},"content":"> -----Original Message-----\n> From: netdev-owner@vger.kernel.org [mailto:netdev-\n> owner@vger.kernel.org] On Behalf Of Joe Perches\n> Sent: Saturday, September 16, 2017 06:18\n> To: Ying Xue ; Thomas Meyer\n> ; Jon Maloy ;\n> netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-\n> kernel@vger.kernel.org; davem@davemloft.net\n> Subject: Re: [PATCH V2] tipc: Use bsearch library function\n> \n> On Sat, 2017-09-16 at 18:10 +0800, Ying Xue wrote:\n> > On 09/16/2017 05:58 PM, Joe Perches wrote:\n> > > On Sat, 2017-09-16 at 17:36 +0800, Ying Xue wrote:\n> > > > On 09/16/2017 05:26 PM, Joe Perches wrote:\n> > > > > On Sat, 2017-09-16 at 17:02 +0800, Ying Xue wrote:\n> > > > > > On 09/16/2017 03:50 PM, Thomas Meyer wrote:\n> > > > > > > Use common library function rather than explicitly coding\n> > > > > > > some variant of it yourself.\n> > > > > > >\n> > > > > > > Signed-off-by: Thomas Meyer \n> > > > > >\n> > > > > > Acked-by: Ying Xue \n> > > > >\n> > > > > Are you sure you want to do this?\n> > > > >\n> > > > > Note the comment above nameseq_find_subseq\n> > > > >\n> > > > > * Very time-critical, so binary searches through sub-sequence array.\n> > > > >\n> > > > > What impact does this change have on performance?\n> > > >\n> > > > Sorry, I couldn't see any essential difference between this new\n> > > > implementation and the original one except that the former tries\n> > > > to use the library function - bsearch() to replace the original\n> > > > binary search algorithm implemented in TIPC itself. Therefore, I\n> > > > don't think the change will have a big impact on performance.\n> > > >\n> > > > If I miss something, please let me know.\n> > >\n> > > Comparison via a function pointer in bsearch is slower than direct\n> > > code without the function call overhead.\n> > >\n> >\n> > Right, but probably we can tolerate the slight sacrifice here.\n> \n> What part of \"very time critical\" have you verified and benchmarked as\n> inconsequential?\n> \n> Please post your results.\n\nI agree with Joe here. This change does not simplify anything, it does not reduce the amount of code, plus that it introduce an unnecessary outline call in a place where we have every reason to let the compiler do its optimization job properly.\n\n///jon","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"lz9efyvd\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvXvT3lPmz9sPk\n\tfor ;\n\tSat, 16 Sep 2017 23:20:37 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751273AbdIPNUe (ORCPT );\n\tSat, 16 Sep 2017 09:20:34 -0400","from sesbmg23.ericsson.net ([193.180.251.37]:64316 \"EHLO\n\tsesbmg23.ericsson.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751211AbdIPNUd (ORCPT\n\t); Sat, 16 Sep 2017 09:20:33 -0400","from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27])\n\tby sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id\n\tAC.C0.21299.F152DB95; Sat, 16 Sep 2017 15:20:31 +0200 (CEST)","from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145)\n\tby oa.msg.ericsson.com (153.88.183.27) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Sat, 16 Sep 2017 15:20:30 +0200","from DB5PR0701MB1958.eurprd07.prod.outlook.com (10.167.228.136) by\n\tDB5PR0701MB2008.eurprd07.prod.outlook.com (10.167.228.150) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5;\n\tSat, 16 Sep 2017 13:20:28 +0000","from DB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92]) by\n\tDB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92%14]) with mapi id 15.20.0077.007;\n\tSat, 16 Sep 2017 13:20:28 +0000"],"X-AuditID":"c1b4fb25-967ff70000005333-90-59bd251f8e98","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ericsson.onmicrosoft.com; s=selector1-ericsson-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=XpD5hfeXHwKRsjkiCZPcgul8+d8tQyXTIydVOTMBERg=;\n\tb=lz9efyvdZEYAbzjrCCZ1F/J+cMoxBY/VygZDoyDbaKQc/B2Y38koF/o25bxvD8WXXghcU8SP4YjFhKDRLnXtoxG3o3hC0ewiBjHYhcg7NqeVIc/SvN2/n9bzoStgA6TC8XppJtnUlrUxSvMmGvl3lCNzQIPOflgZchltR1dgvyM=","From":"Jon Maloy ","To":"Joe Perches , Ying Xue ,\n\t\"Thomas Meyer\" ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"tipc-discussion@lists.sourceforge.net\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ","Subject":"RE: [PATCH V2] tipc: Use bsearch library function","Thread-Topic":"[PATCH V2] tipc: Use bsearch library function","Thread-Index":"AQHTLsCFggJ6hPSP+EWhjy5rbdPPE6K3N4aAgAAGogCAAALngIAABiAAgAADfYCAAAHhgIAAMg2Q","Date":"Sat, 16 Sep 2017 13:20:28 +0000","Message-ID":"","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>\n\t<1505557061.16316.7.camel@perches.com>","In-Reply-To":"<1505557061.16316.7.camel@perches.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"lz9efyvd\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"x-originating-ip":"[24.225.233.31]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB5PR0701MB2008;\n\t6:bJhF8/Qte663DyQ/JxM5wrcFs8ZILdXqKGef+LuN35WMGCNucrMCenVESXwsx/ng88JTrDsEHf2nPOlCB+g5dvTqvUGzuKBPij8f/CZT5aQAVA/+P7Gjhz5gsqwZmRVT+TgdEW55aOQuaymf4RY/Z7J3/3VA9yCO9DwzO+7uVhkkQkwtW6mU9eExvByMfg2hnJIadyAm1mpkyK/vI/kj1u2NtWY3d3Kqkik9bP28wW88HL1sRa/K9kBmSc0JLiUvWt4rjjXWIgNx+SQR8pSlue1SvTXadt6PEC89CJUVYrVDgPowEoE/VH6diEcoEGgSMOt6Rx8MWmy/M/JrFUZ/oA==;\n\t5:Kt9VVaOBoY1tKXZNd6IWTJwLKqoUtM5snwhl6q6AD5QTSQU9fwcy51i5hxCBGFNmK803aHrJ1mTKDy6HE4W3HGWNfN8JIhJDkvFVYPCcJyuKafG2EuNx4ZO7cpv9HEuarICtBFWspAcV8TRcZjxE3w==;\n\t24:RcTCTKd1s8enAYRqj9A1EVrC9alwQ/jMPewt3yT2q/XvUxc1CInUdM3CyUor8DSeONvJAU3KeC78Y4gBuXaMb1juOX/0NUMwoLYW8HEafzs=;\n\t7:Bc9fac4HM98+vGWr2wXuSYle1Yk1uxZkQVQ8g9RlzhGxUkz7E+JIA41Rn05vU50yqDMeHfSZg+h9YVpz2nkg9tk03w9vOJUfyz1A2LymjZ57URRX16ZLF/SdoRGbtmKw7qVoQYTnEXKfmmdw0/vXKEU7OEYAdUhaLY9XNwCQHntYtklTGyBpAScoBsGUmNMmZ6/pFRVLKecs3mT/qiqmJcKFkCNVrtuGap1mpNgh9cA=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"234a853b-1564-4f30-6d69-08d4fd05b31a","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB5PR0701MB2008; ","x-ms-traffictypediagnostic":"DB5PR0701MB2008:","x-ld-processed":"92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr","x-exchange-antispam-report-test":"UriScan:(37575265505322)(143289334528602)(9452136761055)(788757137089)(42262312472803);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR0701MB2008; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR0701MB2008; ","x-forefront-prvs":"0432A04947","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(377424004)(377454003)(199003)(24454002)(13464003)(189002)(478600001)(53546010)(3660700001)(6116002)(102836003)(3846002)(3280700002)(68736007)(9686003)(229853002)(6436002)(316002)(6506006)(93886005)(14454004)(99286003)(55016002)(81156014)(8676002)(81166006)(5660300001)(189998001)(305945005)(74316002)(7736002)(8936002)(25786009)(2950100002)(7696004)(2906002)(76176999)(54356999)(97736004)(101416001)(105586002)(2900100001)(106356001)(33656002)(66066001)(86362001)(50986999)(53936002)(6246003)(2201001)(5250100002)(2501003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0701MB2008;\n\tH:DB5PR0701MB1958.eurprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; A:1; MX:1; LANG:en; ","received-spf":"None (protection.outlook.com: ericsson.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-originalarrivaltime":"16 Sep 2017 13:20:28.6662\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"92e84ceb-fbfd-47ab-be52-080c6b87953f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR0701MB2008","X-OriginatorOrg":"ericsson.com","X-Brightmail-Tracker":"H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsUyM2K7tK686t5Ig6fv+SzmnG9hsZh9/zGL\n\txeVdc9gsji0Qs7i2YDqjxZbzWQ5sHltW3mTy2L3gM5PHvP+32Dy+rLrG7PF5k1wAaxSXTUpq\n\tTmZZapG+XQJXxoW//5gLnglVTG7naWB8xNfFyMkhIWAi8X7xDqYuRi4OIYEjjBINf+YygiSE\n\tBE4wShz7qAmSYBHoZZY4/OMqVNVcJonv/4+wQTjPGSX+HnwK1sImoCHxcloHI0hCROAek8TU\n\tLZuZQBLCAlYSm/eeYwOxRQSsJXp6DwEVcQDZURIf3gaDhFkEVCX+Lz/OAmLzCiRInNxwiwVi\n\twX5mib2T/4PN4RQwllj5YRpYEaOAmMT3U2vA4swC4hK3nsxngnhIQGLJnvPMELaoxMvH/1hB\n\tdjEKREqcfhoJEVaUOL9hEVSJrMSl+d2MEHYHu8TkqWEQtp7E1olvwc6UEPCVWHOVH+QcCYEn\n\tTBLtN5ugVulILL50BKrXRmJG93SomRUSW56cZIWw8yWWrvjIAtF8nlVi7bXpLBAJGYmDBxax\n\tT2DUnYXkBQhbR2LB7k9sELa2xLKFr5lngcNFUOLkzCcsCxhZVjGKFqcWJ+WmGxnrpRZlJhcX\n\t5+fp5aWWbGIEJp2DW36r7mC8/MbxEKMAB6MSD+82ub2RQqyJZcWVuYcYJTiYlUR4m1WAQrwp\n\tiZVVqUX58UWlOanFhxilOViUxHkd912IEBJITyxJzU5NLUgtgskycXBKNTDyLrNq8hZcGD1j\n\tAkdc+oSzbate7Hqet1PPSX3j1blx0RNvHOmv+Fa1VnhlUdGfr3OOmXEo3mdU0zo1ddLRRZ22\n\tkqcKOGMfTfhy6ugL3uLvNmE/f5nvmva0WntBM1eP8sfOywXprZ96l+U90hZhl33kHLGN7b7W\n\tp4THq60/v4p6pWob7HiVva9BiaU4I9FQi7moOBEAQIToFTYDAAA=","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769718,"web_url":"http://patchwork.ozlabs.org/comment/1769718/","msgid":"<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>","list_archive_url":null,"date":"2017-09-17T15:00:12","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":10277,"url":"http://patchwork.ozlabs.org/api/people/10277/","name":"Thomas Meyer","email":"thomas@m3y3r.de"},"content":"> Am 16.09.2017 um 15:20 schrieb Jon Maloy .\n>> \n>> What part of \"very time critical\" have you verified and benchmarked as\n>> inconsequential?\n>> \n>> Please post your results.\n> \n> I agree with Joe here. This change does not simplify anything, it does not reduce the amount of code, plus that it introduce an unnecessary outline call in a place where we have every reason to let the compiler do its optimization job properly.\n\nHi,\n\nOkay, should I prepare some performance numbers or do we NAK this change?\nWhat about the other binary search implementation in the same file? Should I try to convert it it will it get NAKed for performance reasons too?\n\nWith kind regards\nThomas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwC4K4Gxvz9sBZ\n\tfor ;\n\tMon, 18 Sep 2017 01:00:33 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751585AbdIQPAV (ORCPT );\n\tSun, 17 Sep 2017 11:00:21 -0400","from www17.your-server.de ([213.133.104.17]:35275 \"EHLO\n\twww17.your-server.de\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751561AbdIQPAU (ORCPT\n\t); Sun, 17 Sep 2017 11:00:20 -0400","from [95.222.26.195] (helo=[192.168.0.93])\n\tby www17.your-server.de with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)\n\t(Exim 4.85_2) (envelope-from )\n\tid 1dtb3O-0002L4-It; Sun, 17 Sep 2017 17:00:14 +0200"],"References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>\n\t<1505557061.16316.7.camel@perches.com>\n\t","Mime-Version":"1.0 (1.0)","In-Reply-To":"","Content-Type":"multipart/signed; micalg=sha1;\n\tboundary=Apple-Mail-37EFFCB3-2CB9-4EFD-87B7-6B070A2A7A13;\n\tprotocol=\"application/pkcs7-signature\"","Content-Transfer-Encoding":"7bit","Message-Id":"<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>","Cc":"Joe Perches , Ying Xue ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"tipc-discussion@lists.sourceforge.net\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ","X-Mailer":"iPad Mail (13G36)","From":"Thomas Meyer ","Subject":"Re: [PATCH V2] tipc: Use bsearch library function","Date":"Sun, 17 Sep 2017 17:00:12 +0200","To":"Jon Maloy ","X-Authenticated-Sender":"thomas@m3y3r.de","X-Virus-Scanned":"Clear (ClamAV 0.99.2/23845/Sun Sep 17 14:42:43 2017)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769732,"web_url":"http://patchwork.ozlabs.org/comment/1769732/","msgid":"","list_archive_url":null,"date":"2017-09-17T16:27:56","subject":"RE: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":3953,"url":"http://patchwork.ozlabs.org/api/people/3953/","name":"Jon Maloy","email":"jon.maloy@ericsson.com"},"content":"> -----Original Message-----\n> From: Thomas Meyer [mailto:thomas@m3y3r.de]\n> Sent: Sunday, September 17, 2017 11:00\n> To: Jon Maloy \n> Cc: Joe Perches ; Ying Xue ;\n> netdev@vger.kernel.org; tipc-discussion@lists.sourceforge.net; linux-\n> kernel@vger.kernel.org; davem@davemloft.net\n> Subject: Re: [PATCH V2] tipc: Use bsearch library function\n> \n> \n> > Am 16.09.2017 um 15:20 schrieb Jon Maloy .\n> >>\n> >> What part of \"very time critical\" have you verified and benchmarked as\n> >> inconsequential?\n> >>\n> >> Please post your results.\n> >\n> > I agree with Joe here. This change does not simplify anything, it does\nnot\n> reduce the amount of code, plus that it introduce an unnecessary outline\ncall\n> in a place where we have every reason to let the compiler do its\noptimization\n> job properly.\n> \n> Hi,\n> \n> Okay, should I prepare some performance numbers or do we NAK this\n> change?\n> What about the other binary search implementation in the same file? Should\n> I try to convert it it will it get NAKed for performance reasons too?\n\nThe searches for inserting and removing publications is less time critical,\nso that would be ok with me.\nIf you have any more general interest in improving the code in this file\n(which is needed) it would also be appreciated.\n\nBR\n///jon\n\n\n> \n> With kind regards\n> Thomas","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"M94pjG7S\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwF1c0HRQz9sBZ\n\tfor ;\n\tMon, 18 Sep 2017 02:28:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751497AbdIQQ2E (ORCPT );\n\tSun, 17 Sep 2017 12:28:04 -0400","from sessmg22.ericsson.net ([193.180.251.58]:65334 \"EHLO\n\tsessmg22.ericsson.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751407AbdIQQ2C (ORCPT\n\t); Sun, 17 Sep 2017 12:28:02 -0400","from ESESSHC016.ericsson.se (Unknown_Domain [153.88.183.66])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\t31.29.20899.092AEB95; Sun, 17 Sep 2017 18:28:00 +0200 (CEST)","from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145)\n\tby oa.msg.ericsson.com (153.88.183.66) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Sun, 17 Sep 2017 18:28:00 +0200","from DB5PR0701MB1958.eurprd07.prod.outlook.com (10.167.228.136) by\n\tDB5PR0701MB1943.eurprd07.prod.outlook.com (10.167.228.27) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id\n\t15.20.77.5; Sun, 17 Sep 2017 16:27:58 +0000","from DB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92]) by\n\tDB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92%14]) with mapi id 15.20.0077.008;\n\tSun, 17 Sep 2017 16:27:56 +0000"],"X-AuditID":"c1b4fb3a-617ff700000051a3-37-59bea290e372","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ericsson.onmicrosoft.com; s=selector1-ericsson-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=BItKKd2MKORTBgz1DMLWkKd2HpFNjgWhnl1MJ1ML5ac=;\n\tb=M94pjG7S5lJ2m/xSgTbh2gZyh12n5a6w5fsPP8POO9/SQaiGMyh2u51aXt1963gKjv3VDLQL5zNYMar96pI4BmztZYS/aWvqErzw2DIr1zTSp7diid1gk/r0YFbxwJRIDZBR8cxkDqi16WeLWB4TsK8GFbLudRFiqRsNlzDcpXY=","From":"Jon Maloy ","To":"Thomas Meyer ","CC":"Joe Perches , Ying Xue ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"tipc-discussion@lists.sourceforge.net\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ","Subject":"RE: [PATCH V2] tipc: Use bsearch library function","Thread-Topic":"[PATCH V2] tipc: Use bsearch library function","Thread-Index":"AQHTLsCFggJ6hPSP+EWhjy5rbdPPE6K3N4aAgAAGogCAAALngIAABiAAgAADfYCAAAHhgIAAMg2QgAGvNwCAAA8JwA==","Date":"Sun, 17 Sep 2017 16:27:56 +0000","Message-ID":"","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>\n\t<1505557061.16316.7.camel@perches.com>\n\t\n\t<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>","In-Reply-To":"<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"yes","X-MS-TNEF-Correlator":"","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"M94pjG7S\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"x-originating-ip":"[24.225.233.31]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB5PR0701MB1943;\n\t6:iBGBcNm2kYOChbdBRneOrkkxjKbZ7U1Bco5k1rIgnlQtZke1wOwSdiWYtM3V5I2+cX1SM2oWj1xu4MPAmZR5cRFWfv3GA9Rqe70GXSoRnnNvv7CTHioqjQhGBxNNoyN9Z7mbAc9kV8h7SinIDmHm6FFDjloOOhymJAkTxHOoUjNeMN+L6Y0OhIkpYvft3LS4rjCdp5ZLpphrnGRKDa2IvK094Sx36r+V/n5WcdFEHgUyXXoMVuqA6xxKYD8f3NObnuhoU/dxBSftPbHsIzp26oGxsqnjX7jH4XjUs+MlqhE0Ex13jU0zQDHs+BCGZTYW021NARKUYEmBQyczzGi2gQ==;\n\t5:2rP3xgKETP4shui0yZe6Og6Upq9FnoDp2bANzv6Oq//Jjtnqx4zPJwufh07DkqwfVeD93qQILRPGOG88ZC9tdiLlOTl2WEbw3RidEdnKzAMXuQPxHo2QeUocaUjeR4fxrfwRSt42r4nOS90s74kEVw==;\n\t24:64I9X1wn/T4V0O1ulm7pUpLgFbhBiCckc/YCJrP2mqy/dJaaeDhkFaXzLkCWpSU3Tkzgfw0yy9SzJq+InbKakVIQ6WC8E893V8wFhlaQYXY=;\n\t7:zM+8tUd70PvMVci6/smGmZAptkU9HYCURNMLhDZpQBpL2dGXliHo+zlGQSvZa+hK0JGwbzZZg7GmH48rsqIt9pyx8WATqlpkJ+pUlnnbPIZysGCRyhr51xFpv5BLWwkXa9zaVMi0sMUQS7WSxv2jqxdCZaqpZKsNIc0y0f8Abl+lPRcfZfzNMiRk0WhdX8Il+ze9VinQXgFNGNDMpHaUBFiqi+Sx80sKNpHLuYrCURg=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"311a64d1-e5ce-46ca-e7c5-08d4fde90dea","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(49563074)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB5PR0701MB1943; ","x-ms-traffictypediagnostic":"DB5PR0701MB1943:","x-ld-processed":"92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr","x-exchange-antispam-report-test":"UriScan:(37575265505322)(143289334528602)(9452136761055)(42262312472803);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(102415395)(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123564025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR0701MB1943; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR0701MB1943; ","x-forefront-prvs":"0433DB2766","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(376002)(346002)(13464003)(189002)(199003)(102836003)(229853002)(6116002)(3280700002)(74316002)(3660700001)(7696004)(3846002)(14454004)(25786009)(9686003)(5660300001)(4326008)(99286003)(55016002)(86362001)(478600001)(7736002)(305945005)(5250100002)(6246003)(97736004)(110136004)(93886005)(33656002)(68736007)(53546010)(2900100001)(189998001)(6916009)(53936002)(54906002)(316002)(2950100002)(106356001)(105586002)(66066001)(76176999)(8676002)(81156014)(50986999)(81166006)(54356999)(101416001)(99936001)(8936002)(6506006)(2906002)(6436002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0701MB1943;\n\tH:DB5PR0701MB1958.eurprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: ericsson.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"multipart/signed; micalg=SHA1;\n\tprotocol=\"application/x-pkcs7-signature\";\n\tboundary=\"----=_NextPart_000_0008_01D32FB0.570D5F00\"","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-originalarrivaltime":"17 Sep 2017 16:27:56.6757\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"92e84ceb-fbfd-47ab-be52-080c6b87953f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR0701MB1943","X-OriginatorOrg":"ericsson.com","X-Brightmail-Tracker":"H4sIAAAAAAAAA02Se0hTURzHOffe3V2lwWmZ/bAXDovoYSVFSyUsixbZiwq0f3LkzUe2xe4S\n\t7QGzh6/5qjR1Dh1CZlZkS9OyrI2eM7esiHxUWCu1UAulJCm721nQf5/z+35/3/P7HQ5Hy/sk\n\tQVyyRs/rNOpUBevPVMQ2r1tSXNMWt8zeM19pdp1ilJXvPzLKl7fNrPKRJVD52lKGlI2ulChW\n\t1Xipi1K1WkYpVdVkN6saq39Nq0atc7ZL9vhHJvCpyWm8bumaeP+k3KvcoYnt6SX5ZokBvY3J\n\tQ34c4BXgLhqh8pA/J8cPELjGzTQ5PEFQXWrwKgwuoGHwfAdLFBMFmRVWX08/giyDU+oJY/EC\n\t0ZWDPByAFeAsKGY8TOM7FPQOxHp4Gg6HG3edLPFEQH6B3edPgdrf7yQeZvA8qMuyeusyHA/V\n\tFxq8OXJczkDrj/0e9sORUJfd6/UgHAg/HVcoctcM6HZXU2S5AOjrbGcJT4fBj3/EfE70x0H7\n\tpzhSDgZXQw1NeDa8qDYiz16Ac6RgP9/lywmFpjNDiPAWMJ0zscQ0TMGofVRChMXQP1Tja4iE\n\tcmOZLzUFHNeKpIS10HRvnCbN3RIo7b9OF6Mlpv8GN4kajYsQXPhTiUzeF5gKTyvcjEmcnBYn\n\tybqOiH8uNA+ZacIRUP7LxhIOhhJjn5TwSvj68DuyIK4eTRd4QTiYGBYWyuuS9wmCVhOq4fVW\n\tJH42W+NEeAuy9a+1I8whxRQZNrbFySXqNCHjoB2FiDkfGi4/R0GMRqvhFQEy02lRliWoM47w\n\tOu1e3eFUXrCjmRyjmCGLanseK8eJaj1/gOcP8bp/KsX5BRlQYbxj99n6DSPmlrKyoE1dg1Vv\n\tVu3qmVQ37IqJzzW3hq6oc80Kyzneqb8/fnKu47Fb2hl2bdvNvV90u6MNTZnRIUdDPleduLVz\n\tbP+tgcljq0Oe1Sq22eZoNxZOzoyo2dHEDL+qjRnLW//hmzv34SLjVmdJzsXFzML0Dv16541X\n\tmy3Z9+8oGCFJvXwhrRPUfwG+hNXtdAMAAA==","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1769794,"web_url":"http://patchwork.ozlabs.org/comment/1769794/","msgid":"<1505682926.16316.15.camel@perches.com>","list_archive_url":null,"date":"2017-09-17T21:15:26","subject":"Re: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote:\n> > -----Original Message-----\n> > From: Thomas Meyer [mailto:thomas@m3y3r.de]\n[]\n> > What about the other binary search implementation in the same file? Should\n> > I try to convert it it will it get NAKed for performance reasons too?\n> \n> The searches for inserting and removing publications is less time critical,\n> so that would be ok with me.\n> If you have any more general interest in improving the code in this file\n> (which is needed) it would also be appreciated.\n\nPerhaps using an rbtree would be an improvement.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwMPW3Kx7z9s76\n\tfor ;\n\tMon, 18 Sep 2017 07:15:59 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751926AbdIQVPc (ORCPT );\n\tSun, 17 Sep 2017 17:15:32 -0400","from smtprelay0207.hostedemail.com ([216.40.44.207]:40065 \"EHLO\n\tsmtprelay.hostedemail.com\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S1751352AbdIQVPa (ORCPT\n\t); Sun, 17 Sep 2017 17:15:30 -0400","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay06.hostedemail.com (Postfix) with ESMTP id C1B4118224D9C; \n\tSun, 17 Sep 2017 21:15:29 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf09.hostedemail.com (Postfix) with ESMTPA;\n\tSun, 17 Sep 2017 21:15:28 +0000 (UTC)"],"X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::,\n\tRULES_HIT:41:355:379:541:599:800:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1538:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3315:3352:3622:3865:3867:3868:3870:3871:3872:3873:3874:4321:5007:6119:7576:7903:10004:10400:10848:11232:11658:11914:12740:12760:12895:13069:13095:13311:13357:13439:14181:14659:21080:21220:21433:21451:21627:30012:30054:30063:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5,\n\tNetcheck:none, DomainCache:0, MSF:not bulk, SPF:, MSBL:0,\n\tDNSBL:none, Custom_rules:0:0:0, LFtime:1, LUA_SUMMARY:none","X-HE-Tag":"fly19_871274c9da40d","X-Filterd-Recvd-Size":"2190","Message-ID":"<1505682926.16316.15.camel@perches.com>","Subject":"Re: [PATCH V2] tipc: Use bsearch library function","From":"Joe Perches ","To":"Jon Maloy , Thomas Meyer ","Cc":"Ying Xue ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"tipc-discussion@lists.sourceforge.net\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ","Date":"Sun, 17 Sep 2017 14:15:26 -0700","In-Reply-To":"","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>\n\t<1505557061.16316.7.camel@perches.com>\n\t\n\t<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>\n\t","Content-Type":"text/plain; charset=\"ISO-8859-1\"","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1770601,"web_url":"http://patchwork.ozlabs.org/comment/1770601/","msgid":"","list_archive_url":null,"date":"2017-09-19T01:08:33","subject":"RE: [PATCH V2] tipc: Use bsearch library function","submitter":{"id":3953,"url":"http://patchwork.ozlabs.org/api/people/3953/","name":"Jon Maloy","email":"jon.maloy@ericsson.com"},"content":"> -----Original Message-----\n> From: netdev-owner@vger.kernel.org [mailto:netdev-\n> owner@vger.kernel.org] On Behalf Of Joe Perches\n> Sent: Sunday, September 17, 2017 23:15\n> To: Jon Maloy ; Thomas Meyer\n> \n> Cc: Ying Xue ; netdev@vger.kernel.org; tipc-\n> discussion@lists.sourceforge.net; linux-kernel@vger.kernel.org;\n> davem@davemloft.net\n> Subject: Re: [PATCH V2] tipc: Use bsearch library function\n> \n> On Sun, 2017-09-17 at 16:27 +0000, Jon Maloy wrote:\n> > > -----Original Message-----\n> > > From: Thomas Meyer [mailto:thomas@m3y3r.de]\n> []\n> > > What about the other binary search implementation in the same file?\n> > > Should I try to convert it it will it get NAKed for performance reasons too?\n> >\n> > The searches for inserting and removing publications is less time\n> > critical, so that would be ok with me.\n> > If you have any more general interest in improving the code in this\n> > file (which is needed) it would also be appreciated.\n> \n> Perhaps using an rbtree would be an improvement.\n\nNot a bad idea. It would probably reduce the code amount, possibly at the expense of cache hit rate during the binary lookup.\nIt is worth looking into.\n\n///jon","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"AGyfX2lp\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xx4Wz2ZHqz9s78\n\tfor ;\n\tTue, 19 Sep 2017 11:09:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751810AbdISBIn (ORCPT );\n\tMon, 18 Sep 2017 21:08:43 -0400","from sessmg22.ericsson.net ([193.180.251.58]:55430 \"EHLO\n\tsessmg22.ericsson.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751778AbdISBIi (ORCPT\n\t); Mon, 18 Sep 2017 21:08:38 -0400","from ESESSHC010.ericsson.se (Unknown_Domain [153.88.183.48])\n\tby sessmg22.ericsson.net (Symantec Mail Security) with SMTP id\n\tED.AC.20899.41E60C95; Tue, 19 Sep 2017 03:08:36 +0200 (CEST)","from EUR01-HE1-obe.outbound.protection.outlook.com (153.88.183.145)\n\tby oa.msg.ericsson.com (153.88.183.48) with Microsoft SMTP Server\n\t(TLS) id 14.3.352.0; Tue, 19 Sep 2017 03:08:36 +0200","from DB5PR0701MB1958.eurprd07.prod.outlook.com (10.167.228.136) by\n\tDB5PR0701MB2024.eurprd07.prod.outlook.com (10.167.228.154) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5;\n\tTue, 19 Sep 2017 01:08:34 +0000","from DB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92]) by\n\tDB5PR0701MB1958.eurprd07.prod.outlook.com\n\t([fe80::b149:87e9:30d5:7d92%14]) with mapi id 15.20.0077.009;\n\tTue, 19 Sep 2017 01:08:34 +0000"],"X-AuditID":"c1b4fb3a-9e1d49c0000051a3-ea-59c06e149293","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ericsson.onmicrosoft.com; s=selector1-ericsson-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version;\n\tbh=nZJBRMwL88GDjBBALhJQyzuaZXTWm5maowuPrmVRIZA=;\n\tb=AGyfX2lpKZil8RgaywTIDzT00dfAGic/p5jMieLcLJNAN3cAQZkVU5EYjsCorysabp+Jd6Wu7Af7Z/S7CmYI415++cgyA37KbawofMA5/JAGtZd0CACJzRbYRrFOimvAas0vFIqul1f50WopzN95AIbPOEm943ERAASkp58iqOU=","From":"Jon Maloy ","To":"Joe Perches , Thomas Meyer ","CC":"Ying Xue ,\n\t\"netdev@vger.kernel.org\" ,\n\t\"tipc-discussion@lists.sourceforge.net\" \n\t,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ","Subject":"RE: [PATCH V2] tipc: Use bsearch library function","Thread-Topic":"[PATCH V2] tipc: Use bsearch library function","Thread-Index":"AQHTLsCFggJ6hPSP+EWhjy5rbdPPE6K3N4aAgAAGogCAAALngIAABiAAgAADfYCAAAHhgIAAMg2QgAGvNwCAAA8JwIAAWc4AgAHSd5A=","Date":"Tue, 19 Sep 2017 01:08:33 +0000","Message-ID":"","References":"<20170911.143025.555018840006192902.davem@davemloft.net>\n\t<20170916075036.28676-1-thomas@m3y3r.de>\n\t<16128f5e-66ff-b6ec-c0e1-74ea08c212b0@windriver.com>\n\t<1505553970.16316.1.camel@perches.com>\n\t<64ee51ce-eb7e-ac1c-56a9-9481f6f80b35@windriver.com>\n\t<1505555908.16316.5.camel@perches.com>\n\t<35f41984-22e9-5adc-0e4d-a4ef4204f6d7@windriver.com>\n\t<1505557061.16316.7.camel@perches.com>\n\t\n\t<760F46A5-2C04-4F3F-83C5-5EA331CFA1D6@m3y3r.de>\n\t\n\t<1505682926.16316.15.camel@perches.com>","In-Reply-To":"<1505682926.16316.15.camel@perches.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[212.247.172.218]","x-ms-publictraffictype":"Email","x-microsoft-exchange-diagnostics":"1; DB5PR0701MB2024;\n\t6:X178ABegf9q6J9S4WxjcsX0XbJjd5W5p4Cs5Ua5r9PfOk+gaMUAxa2lB4o7kPUauWE5qyyn9lFgluRngtlx9s9CRfg+hd5DvJC5ixFKhMTG4BreByBGq5i+oT53uNa2zx+N3qfntjAzuz/V3y/vITUDLL9i4bdS20YrHJUAovCDXQm44roU72PzaD4QJnHIhR02nlD68S1gOwCmmwioutUPlG+Dtg225DMllfdzY98lBx48/phpSlz05MpPDHDLXb0sMqa1WPnbEKS+OheZoxPb+6t2sdDngFEU8zjd32ZkEPxzr5ziuEFw8Deeiajz5nixaXFb1QIl3La2sSD4eZA==;\n\t5:SDPuDpZCqgZPGRBDXnIzNKP7XI2pgujmqJrlWgGew5M1BCTZFbh18cByYC6eOmJnGw9kwPxifzOtnQ1ADBG1lXLcXo5zW9dBxr79nDEtuMASoe98Emx4KcII08kjTNoCz+Y9u7mfyDZI7TWG/2iBpQ==;\n\t24:tvxP2ZsN7RdQT0NkZDaa8j0R4HDZoLsJQmUE/bOBQ1ma2zpNegq+PvthjvfpVm4AZAIwwygFu1U2DyTtCFAqP/HeyeF/yHNkNYj69pcaNGc=;\n\t7:AHEslltZNhxaXWnE1PTkudtKRSspihIKDMxQoZ5seqKgW0844xd636PzVBiWsizvD0wTPHeEzJkXT8+z5stufVoOIk0kDotiuWCvVQ8VX+CTKDsy1aHKX7JSr7vmWvsKWeHYESwKwavwZAOyX4V/Hw3vu0D6TIayQsIHSIR8noAM570jv6RvGUKCx+OPsogT41WIODYMzIBs2tYrHIZyoMhUqcWHQtOusv/6NjaZVkk=","x-ms-exchange-antispam-srfa-diagnostics":"SSOS;","x-ms-office365-filtering-correlation-id":"99c08c4d-d013-4559-e3bc-08d4fefaf31f","x-microsoft-antispam":"UriScan:; BCL:0; PCL:0;\n\tRULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);\n\tSRVR:DB5PR0701MB2024; ","x-ms-traffictypediagnostic":"DB5PR0701MB2024:","authentication-results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=ericsson.onmicrosoft.com\n\theader.i=@ericsson.onmicrosoft.com header.b=\"AGyfX2lp\"; \n\tdkim-atps=neutral","spf=none (sender IP is )\n\tsmtp.mailfrom=jon.maloy@ericsson.com; "],"x-ld-processed":"92e84ceb-fbfd-47ab-be52-080c6b87953f,ExtAddr","x-exchange-antispam-report-test":"UriScan:(37575265505322)(143289334528602)(9452136761055)(42262312472803);","x-microsoft-antispam-prvs":"","x-exchange-antispam-report-cfa-test":"BCL:0; PCL:0;\n\tRULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123564025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);\n\tSRVR:DB5PR0701MB2024; BCL:0; PCL:0;\n\tRULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);\n\tSRVR:DB5PR0701MB2024; ","x-forefront-prvs":"04359FAD81","x-forefront-antispam-report":"SFV:NSPM;\n\tSFS:(10009020)(6009001)(39860400002)(346002)(376002)(377424004)(189002)(24454002)(199003)(13464003)(6116002)(3280700002)(2900100001)(5250100002)(229853002)(14454004)(8936002)(305945005)(33656002)(106356001)(97736004)(3660700001)(25786009)(5660300001)(7736002)(189998001)(8676002)(3846002)(102836003)(105586002)(478600001)(66066001)(4326008)(7696004)(110136005)(53546010)(2906002)(9686003)(53936002)(81166006)(6246003)(99286003)(55016002)(54906002)(54356999)(50986999)(76176999)(6436002)(316002)(6506006)(101416001)(81156014)(2950100002)(93886005)(68736007)(74316002)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR0701MB2024;\n\tH:DB5PR0701MB1958.eurprd07.prod.outlook.com; FPR:; SPF:None;\n\tPTR:InfoNoRecords; MX:1; A:1; LANG:en; ","received-spf":"None (protection.outlook.com: ericsson.com does not designate\n\tpermitted sender hosts)","spamdiagnosticoutput":"1:99","spamdiagnosticmetadata":"NSPM","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-MS-Exchange-CrossTenant-originalarrivaltime":"19 Sep 2017 01:08:33.9533\n\t(UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"92e84ceb-fbfd-47ab-be52-080c6b87953f","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DB5PR0701MB2024","X-OriginatorOrg":"ericsson.com","X-Brightmail-Tracker":"H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsUyM2K7ga5I3oFIg/OH1C3mnG9hsZh9/zGL\n\txeVdc9gsji0Qs7i2YDqjxZbzWQ5sHltW3mTy2L3gM5PHvP+32Dy+rLrG7PF5k1wAaxSXTUpq\n\tTmZZapG+XQJXxv+L1QXfOCta7xxmbGDs5ehi5OSQEDCRaN6zkbWLkYtDSOAIo8Tp2x3MEM4J\n\tRom5X78ygjgsAr3MEi2bW1hAWoQE5jJJtO7Xgah6zigxYedqNpAEm4CGxMtpHYwgtoiAo8TW\n\tjy1g3cwCs5kkdjw7AFYkLGAlsXnvOTaIImuJnt5DUA1lEk+XtIHZLAKqEqunQGzjFUiQ2Dr3\n\tKzvEtpesEi/b77KCJDiBLn9ythfMZhQQk/h+ag0TiM0sIC5x68l8JojvBCSW7DnPDGGLSrx8\n\t/I8VwlaWWLH/OFRcVuLS/G6wSyUEOtglmq/uZYFI6ElsnfiWEcL2lTj6YjIrRNETJolN32ax\n\tQyR0JJ5P+wPUwAF0RaTE6aeREGEbiRnd06EWZEmcWt8PVZ4vsW7DVqg551klHn84zD6BUW8W\n\tksMhbB2JBbs/sUHY2hLLFr5mngUODUGJkzOfsCxgZFnFKFqcWlycm25kpJdalJlcXJyfp5eX\n\tWrKJEZh6Dm75bbWD8eBzx0OMAhyMSjy8ymYHIoVYE8uKK3MPMUpwMCuJ8NrHAIV4UxIrq1KL\n\t8uOLSnNSiw8xSnOwKInzOuy7ECEkkJ5YkpqdmlqQWgSTZeLglGpgZHT/b2bAuYr50e0Ww8m3\n\tmbPlbx45FenwOMPrvISpwH2555O4flYz9OcavDkf+/Ke/qbKNVde+qbFGHddPHnbPF9GTqFJ\n\tt3T3rPfXbALTdJ5etbyxYMUNeTWXeX8MK/01H5zxK7RhtarP+zz9653KxoDvEyf6bTJ1L9z1\n\toOLbErEFqez/JB94KrEUZyQaajEXFScCAEoEMVM5AwAA","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]